Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 36: Code-Review+2
I'm still very happy, and I think we should merge it by tomorrow until
Hello Vadim Yanitskiy, Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/11642
to look at the new patch set (#36).
Change subject: Add SGs Interface
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 35:
fine with me, but let's give Neels the final say as he's doing loads of MSC
work at the
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 35: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/11642
To unsubscribe, or
Hello Vadim Yanitskiy, Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/11642
to look at the new patch set (#35).
Change subject: Add SGs Interface
Hello Vadim Yanitskiy, Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/11642
to look at the new patch set (#34).
Change subject: Add SGs Interface
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 33:
(2 comments)
https://gerrit.osmocom.org/#/c/11642/33/src/libmsc/sgs_iface.c
File
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 33:
(1 comment)
https://gerrit.osmocom.org/#/c/11642/33/src/libmsc/sgs_iface.c
File
Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 33: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/11642
To unsubscribe, or
Hello Vadim Yanitskiy, Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/11642
to look at the new patch set (#33).
Change subject: Add SGs Interface
Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 32: Code-Review+1
(8 comments)
In general, looks good. Just a few cosmetic issues and
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/11642
to look at the new patch set (#32).
Change subject: Add SGs Interface
..
Add SGs
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/11642
to look at the new patch set (#31).
Change subject: Add SGs Interface
..
Add SGs
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 30:
(1 comment)
https://gerrit.osmocom.org/#/c/11642/30/src/libmsc/msc_vty.c
File
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 30:
(1 comment)
vty_dump_one_conn() in msc_vty.c:
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 30:
> Also I think we don't have any TTCN3 test that verifies the periodic LU for
> 2G. If
dexter has posted comments on this change. ( https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 30:
(96 comments)
I am now through with the review, I hope nothing slipped through, the scrolling
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/11642
to look at the new patch set (#30).
Change subject: Add SGs Interface
..
Add SGs
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 29:
(2 comments)
https://gerrit.osmocom.org/#/c/11642/29/src/libvlr/vlr_sgs.c
File
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 29:
feedback on some of my initial concerns, which we talked about in person:
TLDR: all of
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 29:
(10 comments)
https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/sgs_iface.c
File
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 29: Code-Review-1
(35 comments)
Haven't managed to read everything yet. so far...
Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 29:
(4 comments)
https://gerrit.osmocom.org/#/c/11642/29/include/osmocom/msc/ran_conn.h
dexter has posted comments on this change. ( https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11642
To unsubscribe, or for help writing
24 matches
Mail list logo
