Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3430
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb7d5594219c0e458ccb561383a59604bc1a4201
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1:
I need to call gsm340_rx_sms_submit() in the last patch of this series, to add
support for status-report in nitb mode.
In such scenario, I have no real msgb object, since the struct gsm_sms object
is allocated from the SMPP SUBMIT_SM esm_class = Delivery Acknoledgement.
If this
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3424
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3502b5b169bc7a73a67fd6ff53d8b6c0dc045c8
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: add .gitreview to support git review plugin
..
add .gitreview to support git review plugin
Change-Id: Ia197da1614a8cbec5f177368ca9e25946059c68a
---
A
Harald Welte has submitted this change and it was merged.
Change subject: sccp: add function to check sccp addresses
..
sccp: add function to check sccp addresses
In order to catch invalid CS7 configurations, It is necessary
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3064
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie62fa0a8e45e1e141edb64b116dad185ad9c7a5f
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: L1SAP: Use RSL_CHAN_OSMO_PDCH across L1SAP
..
L1SAP: Use RSL_CHAN_OSMO_PDCH across L1SAP
So far, L1SAP code is hiding RSL_CHAN_OSMO_PDCH from the bts
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3379
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7cc6a966dfc17d37e22338ecc1f239f908a9f2e
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3380
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I470290c2b544555e53cedd849b1d6a961db7b5a4
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Holger Freyther has submitted this change and it was merged.
Change subject: libosmo-sccp: Attempt to fix link issue on 201705-nightly builds
..
libosmo-sccp: Attempt to fix link issue on 201705-nightly builds
This project
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/3449
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80eea9ac888ab4b13614ff475bebacb94b72b0f2
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3449
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80eea9ac888ab4b13614ff475bebacb94b72b0f2
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch:
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: libmsc: remove 'deferred' parameter in sms_route_mt_sms()
..
libmsc: remove 'deferred' parameter in sms_route_mt_sms()
No need to cache the sms
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: gsm_04_11: get rid of unused parameter in sms_route_mt_sms()
..
gsm_04_11: get rid of unused parameter in sms_route_mt_sms()
This parameter is
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: libmsc: remove duplicate lines in deliver_to_esme()
..
libmsc: remove duplicate lines in deliver_to_esme()
This code is accidentally doing the same
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: libmsc: move gsm340_rx_sms_submit() to sms_route_mt_sms()
..
libmsc: move gsm340_rx_sms_submit() to sms_route_mt_sms()
Move the sms
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: libmsc: remove dead code in sms_route_mt_sms()
..
libmsc: remove dead code in sms_route_mt_sms()
The following branch:
if (!rc &&
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3433
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b0abaa7e06ffe1bd2242c70813d8b70e9fa954f
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3423
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I474584425d23fb379a9d71b33e29ac0e24f01e61
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1:
I think particularly if all functions are 'static' and within one file, any
reasonably optimizing compiler should remove unused function arguments, so this
is a bit of a pseudo-discussion here.
We do have several places in the code where we pass along some objects either
to make
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/3439
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia197da1614a8cbec5f177368ca9e25946059c68a
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Patch Set 1:
> (1 comment)
>
> @hwelte, is there also material copyrighted by you in libasn1c?
yes, specifically asn1helpers.[ch]
--
To view, visit https://gerrit.osmocom.org/3440
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: tests: osmo-pcap: Allow different l2 pkts
..
tests: osmo-pcap: Allow different l2 pkts
Before this patch, ETH was assumed and other types were not
Harald Welte has submitted this change and it was merged.
Change subject: tests: osmo-pcap: Fix per packet timer
..
tests: osmo-pcap: Fix per packet timer
Before this commit, the gap time between 2 packets {n-1, n} was being
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/3443/2/src/pcu_vty.h
File src/pcu_vty.h:
Line 7: #define PCU_SOCK_DEFAULT "/tmp/pcu_bts"
this should probably be part of pcuif_proto.h
--
To view, visit https://gerrit.osmocom.org/3443
To unsubscribe, visit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3063
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I715865c1edd1fc2ec9b024671d91eb72559cbdea
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3441
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1da23c45a4ac496fe765e0d78c52dae3e7808b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: lc15bts-mgr.service: Prepare dirs and sysctls for the process
..
lc15bts-mgr.service: Prepare dirs and sysctls for the process
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3412
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a0a10ca9498318c48c81fa94faceb2ad4ac1de6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3401
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib19331f9c6476ac01bf729790dfd63c56de86a89
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3402
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I72f68bc980e6421a65f7d33712a587da340698e5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3393
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaa833febe45b82166d3901f10cc5466a7591c19
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: VIRT-BTS: Support for GPRS
..
VIRT-BTS: Support for GPRS
Change-Id: Id851578c53255866537a16a0be6c3e9268e6ccbc
---
M src/osmo-bts-virtual/bts_model.c
M
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3372
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd18dafb235933c9e6aa9d98ddd8fac1522cc9ac
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3376
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3378
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fb2856acbbf4c53e7d53200a37bc8f79e763bcf
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3377
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e029c436a50fa8c2823ea39c5d123ee701becfa
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2:
The problem is that you're breaking API + ABI. The symbol stll exists, and
code compiled against the old version of the symbol will crash in a non-obvious
way.
So I would prefer any solution that avoids this. Simply renaming the function
would solve it, as then an old program
Patch Set 1:
If I push the "submit" button here, gerrit (on a black screen) fails with:
Code Review - Error
Cannot merge 6f615241665a8c47500855e2d608cab4467e6443
Missing dependency
--
To view, visit https://gerrit.osmocom.org/3428
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/3428/1/openbsc/src/libmsc/smpp_openbsc.c
File openbsc/src/libmsc/smpp_openbsc.c:
Line 607: #define SMPP34_DELIVERY_RECEIPT_REQ 0x1
> OK, I didn't know about this policy.
it's not a strict policy, just a "FYI". Feel free
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3437
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib70e534840308ed315f7add440351e649de3f907
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3437/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:
Line 280: /* As defined by GSM 03.40, Section 9.2.2.3. */
> (in comments we usually say "3GPP TS 03.40")
actually, we normally say "GSM TS xx.yy" or "3GPP TS
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3432
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78e93bc4034679e238c8642ccf6a0e844b1d6d8b
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3431
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e477407531fdd4d906e53c9b5a48a79a239966f
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3426
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5f864f9bb963baff95969e306b1b7cff00c1e3
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3425
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68087a850399e22951d2407e4d8a09c671a775c9
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Harald Welte has abandoned this change.
Change subject: IPv6 support
..
Abandoned
code is for > 7 year old version and of little use today. Author is not able to
provide current version of patch. Meanwhile, we're working on
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3375
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I467f75794c5ac9df75c001245b18bbdfcfaadd88
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3373
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63b7f8ce403169a9dbdbdb031db16693de2196d6
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3449
libosmo-sccp: Attempt to fix link issue on 201705-nightly builds
This project will build some static libraries needed for testing
and also for downstream users. Do not disable the static build on
newer Poky versions.
arm-poky-linux-gnueabi-libtool:
Patch Set 1: Code-Review+2
> I need to call gsm340_rx_sms_submit() in the last patch of this
> series, to add support for status-report in nitb mode.
Ok, then please state this briefly in the commit log, i.e. tha the code will be
called in a context without msgb. This gives important context.
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: libmsc: do not leak pending SMPP command object on error path
..
libmsc: do not leak pending SMPP command object on error path
Make sure the SMPP
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3443
to look at the new patch set (#3).
Add pcu-socket vty config
osmo-bts already supports configuring a different path for the bts<->pcu
socket by using the 'pcu-socket'
Patch Set 1:
> If I push the "submit" button here, gerrit (on a black screen)
> fails with:
>
> Code Review - Error
> Cannot merge 6f615241665a8c47500855e2d608cab4467e6443
> Missing dependency
I think that happens when you try to merge a commit in a branch with parent
commits already
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2691
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5012419495a656912b7b71e4f76ce102c6b63a
Gerrit-PatchSet: 3
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3357
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic70889cdb6be95f06d0c2df710524b4128b5f72b
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: timer vty: also print the default value in cmd doc
..
timer vty: also print the default value in cmd doc
Rationale: allows seeing all timer defaults at
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: vty for timers: remove obsolete range check
..
cosmetic: vty for timers: remove obsolete range check
The VTY parsing already ensures the
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3339
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e837e8bedfad7ac4fd50048ecb016ddb37c2397
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3340
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8259234e5c62e058dde56d531071440bbab11462
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3338
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cffa5b01cd5c589f1e42998e32135f1da8c960b
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 2:
ping? Alexander, can I motivat you to extend the test case to cover multiple
BTSs and their numbers, as requested a month ago? Should be super trivial,
AFAICT.
--
To view, visit https://gerrit.osmocom.org/3185
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3157
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04584103018675a2f35cfb565473bfd81a208d7c
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3156
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ec3ab8de100f0bc75044f55ac769d1083d52806
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2859
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14074207f8bbc18b3ebd60875bb99a0a3a4b399d
Gerrit-PatchSet: 7
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Set osmo-bts pcu-socket config to point to run dir
..
Set osmo-bts pcu-socket config to point to run dir
Otherwise osmo-bts stores the socket file
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3038
to look at the new patch set (#2).
l1sap/osmo-bts-sysmo: Improve logging
Change-Id: I339db0e5f3fd5e44bac974f2447afc80388802af
---
M src/common/l1sap.c
1 file changed, 23 insertions(+),
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3434
to look at the new patch set (#2).
libmsc: add support for SMPP delivery receipts
If the mobile phone requests a status report via SMS, send a DELIVER_SM
with esm_class = Delivery
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3437
to look at the new patch set (#3).
libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03.40 status report
This patch adds
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3435
to look at the new patch set (#3).
libmsc: update database to accomodate SMS status-report fields
SMPP DELIVER_SM messages with esm_class = Delivery
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3436
to look at the new patch set (#3).
utils: smpp_mirror: bounce Delivery Receipts as Delivery Acknowledgments
Simple patch to test the new status-report support code, remove previous
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3438
to look at the new patch set (#3).
libmsc: support GSM 03.40 status report for nitb
This patch adds support for GSM 03.40 in nitb mode.
MS GSM 03.40 SMSC
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3429
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac05252253f8933a3875b4904599b7a225191a4b
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 3:
Have you considered using ALTER TABLE? Can it work here?
--
To view, visit https://gerrit.osmocom.org/3435
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7276d356d805a83ebeec72b02c8563b7135ea0b6
Gerrit-PatchSet: 3
Patch Set 4: Code-Review+1
Maxim has added the 'Related: OS#1848' label in the previous
patch set. I think it makes sense to keep it.
--
To view, visit https://gerrit.osmocom.org/3045
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 3: Verified+1
--
To view, visit https://gerrit.osmocom.org/3429
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac05252253f8933a3875b4904599b7a225191a4b
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3437
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib70e534840308ed315f7add440351e649de3f907
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 2:
Hi Harald, thank you for a reminder. I'll try to find some time to extend the
patch.
--
To view, visit https://gerrit.osmocom.org/3185
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 4:
Now using 0x to mark invalid PC, this commit spread out into three:
adding the invalid value, ensuring set primary_pc, and then adjusting
osmo_sccp_user to use the same invalidity marking.
--
To view, visit https://gerrit.osmocom.org/3355
To unsubscribe, visit
Harald Welte has submitted this change and it was merged.
Change subject: GSMTAP: Don't log fill frames via GSMTAP
..
GSMTAP: Don't log fill frames via GSMTAP
There's very little point in sending fill frames (such as empty
Harald Welte has submitted this change and it was merged.
Change subject: vty_interface.c: use RPLMN from settings if preset
..
vty_interface.c: use RPLMN from settings if preset
Previously, when testcard was attached via VTY
Harald Welte has submitted this change and it was merged.
Change subject: vty: add 'default' keyword to timer config
..
vty: add 'default' keyword to timer config
Change-Id: I4e837e8bedfad7ac4fd50048ecb016ddb37c2397
---
M
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3150
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia176245647c19fa1551fb6f5c8225b2529f73cbf
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3155
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f009c52118db95b38a077e08eecda844e7f8d1
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Hello Vadim Yanitskiy, Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3044
to look at the new patch set (#4).
TRX: Remove global variables, move SETBSIC/SETTSC handling into phy_link
Whether or not we are talking to an OpenBTS
Hello Vadim Yanitskiy, Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3045
to look at the new patch set (#4).
TRX: Remove bogus extern global variable declarations
Those global variable declarations for non-existing variables were
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3399
to look at the new patch set (#2).
Fix gsm_pchan2chan_nr() to use RSL_CHAN_OSMO_PDCH
When converting from GSM_PCHAN_PDCH, we should generate
a RSL channel number IE with the osmocom
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3436
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I877e228d8e174430f700631edbf9955972da7892
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/3434/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:
Line 637: rc = sms_route_mt_sms(conn, sms_report);
> if mem is up, the program will likely not do *anything* useful anymore. Ins
It is our
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3400
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c79e42c5e08b28fe8182555302a5505fbbaa313
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3045
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b5f934fc3bd00b0467d90029d3053b16594186
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Hello Vadim Yanitskiy, Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3045
to look at the new patch set (#5).
TRX: Remove bogus extern global variable declarations
Those global variable declarations for non-existing variables were
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3045
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b5f934fc3bd00b0467d90029d3053b16594186
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 3:
> Can it work here?
I don't believe so, SQLITE3 ALTER TABLE is limited to adding new columns to the
end of the table. Probably why it's done like this in previous db version
upgrades.
https://www.sqlite.org/lang_altertable.html
--
To view, visit https://gerrit.osmocom.org/3435
Review at https://gerrit.osmocom.org/3451
consistency: use OSMO_SS7_PC_INVALID for osmo_sccp_user
A previous patch added ss7_instance primary_pc validity checks by means of
OSMO_SS7_PC_INVALID. To be consistent, also adjust sccp_user accordingly.
(see I7f0f0c89b7335d9da24161bfac8234be214ca00c)
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3355
to look at the new patch set (#4).
ensure valid primary_pc in osmo_ss7_instance
Initialize osmo_ss7_instance.cfg.primary_pc = OSMO_SS7_PC_INVALID.
Adjust all code paths using
Review at https://gerrit.osmocom.org/3450
add OSMO_SS7_PC_INVALID, add osmo_ss7_pc_is_valid()
Introduce OSMO_SS7_PC_INVALID to mark an unset point code.
Add static osmo_ss7_pc_is_valid() (name matches schema of
osmo_ss7_pc_is_local()).
In osmo_ss7_pointcode_print(), return "(no PC)" if
Patch Set 1: Code-Review-1
lynxis, let's enhance the copyright notice as in above comments
--
To view, visit https://gerrit.osmocom.org/3440
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I135d975b84027d51cb1dc534e04dd314bbd20289
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3435
to look at the new patch set (#4).
libmsc: update database to accomodate SMS status-report fields
SMPP DELIVER_SM messages with esm_class = Delivery
1 - 100 of 181 matches
Mail list logo
