Change in osmo-msc[master]: Fix trans_has_conn() doxygen description

2019-01-14 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12555 ) Change subject: Fix trans_has_conn() doxygen description .. Fix trans_has_conn() doxygen description Change-Id:

Change in osmo-hlr[master]: Optionally store IMEI in subscriber table

2019-01-14 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12526 to look at the new patch set (#3). Change subject: Optionally store IMEI in subscriber table .. Optionally store

Change in osmo-hlr[master]: Add IMEI column to subscriber table

2019-01-14 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12525 to look at the new patch set (#3). Change subject: Add IMEI column to subscriber table .. Add IMEI column to

Change in osmo-hlr[master]: Optionally store IMEI in subscriber table

2019-01-14 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12526 to look at the new patch set (#4). Change subject: Optionally store IMEI in subscriber table .. Optionally store

Change in osmo-hlr[master]: VTY: integrate IMEI

2019-01-14 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12527 to look at the new patch set (#4). Change subject: VTY: integrate IMEI .. VTY: integrate IMEI Display the IMEI in

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-14 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: This change is ready for review. -- To view, visit

Change in osmo-msc[master]: Fix trans_has_conn() doxygen description

2019-01-14 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12555 Change subject: Fix trans_has_conn() doxygen description .. Fix trans_has_conn() doxygen description Change-Id:

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-14 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12556 Change subject: Add tests for transaction routines .. Add tests for transaction routines Change-Id: I78dfb7cd35073a305cf668beda7d9d58d5a5a713 --- M

Change in osmo-msc[master]: Fix optional libmsc linking with libsmpp

2019-01-14 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12557 Change subject: Fix optional libmsc linking with libsmpp .. Fix optional libmsc linking with libsmpp Link internal libmsc against libsmpp as

Change in osmo-hlr[master]: VTY: integrate IMEI

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12527 ) Change subject: VTY: integrate IMEI .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12527 To unsubscribe, or

Change in osmo-msc[master]: Fix trans_has_conn() doxygen description

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12555 ) Change subject: Fix trans_has_conn() doxygen description .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12555

Change in osmo-msc[master]: transaction: drop unused ti_flag

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12519 ) Change subject: transaction: drop unused ti_flag .. Patch Set 1: the TI flags purpose is defined in the 3GPP specifications. Vadim has

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12556 To

Change in libosmocore[master]: gsm23003: add osmo_imei_str_valid()

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12524 ) Change subject: gsm23003: add osmo_imei_str_valid() .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12524 To

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

2019-01-14 Thread osmith
Hello Stefan Sperling, Vadim Yanitskiy, Pau Espin Pedrol, Max, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12478 to look at the new patch set (#10). Change subject: VLR: send CHECK-IMEI to EIR/HLR

Jenkins build is back to normal : master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #812

2019-01-14 Thread jenkins
See

Change in osmo-msc[master]: Log MI type on request failure

2019-01-14 Thread Max
Max has abandoned this change. ( https://gerrit.osmocom.org/12365 ) Change subject: Log MI type on request failure .. Abandoned -- To view, visit https://gerrit.osmocom.org/12365 To unsubscribe, or for help writing mail

Change in libosmocore[master]: gsm23003: add osmo_imei_str_valid()

2019-01-14 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/12524 ) Change subject: gsm23003: add osmo_imei_str_valid() .. gsm23003: add osmo_imei_str_valid() Verify 14 digit and 15 digit IMEI strings.

Jenkins build is back to normal : master-asn1c » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #370

2019-01-14 Thread jenkins
See

Change in osmo-hlr[master]: Optionally store IMEI in subscriber table

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12526 ) Change subject: Optionally store IMEI in subscriber table .. Patch Set 4: Code-Review-1 (3 comments)

Change in osmo-hlr[master]: Add IMEI column to subscriber table

2019-01-14 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12525 to look at the new patch set (#2). Change subject: Add IMEI column to subscriber table .. Add IMEI column to

Change in osmo-hlr[master]: Add IMEI column to subscriber table

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12525 ) Change subject: Add IMEI column to subscriber table .. Patch Set 3: Code-Review-1 (5 comments)

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12478 ) Change subject: VLR: send CHECK-IMEI to EIR/HLR .. Patch Set 10: Code-Review+1 (2 comments) just cosmetics...

Change in osmo-msc[master]: Store subscriber's cell identity in ran_conn

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11746 ) Change subject: Store subscriber's cell identity in ran_conn .. Patch Set 6: (1 comment) Meta: AFAIK we already store the entire CGI in

Change in osmo-msc[master]: Add SGs Interface

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface .. Patch Set 29: (2 comments) https://gerrit.osmocom.org/#/c/11642/29/src/libvlr/vlr_sgs.c File

Change in osmocom-bb[master]: trx_toolkit/transceiver.py: add init logging message

2019-01-14 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12548 to look at the new patch set (#3). Change subject: trx_toolkit/transceiver.py: add init logging message

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Vadim Yanitskiy
Hello Max, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12547 to look at the new patch set (#3). Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message

Change in osmocom-bb[master]: trx_toolkit/fake_trx.py: move init code to __init__()

2019-01-14 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12545 to look at the new patch set (#3). Change subject: trx_toolkit/fake_trx.py: move init code to __init__()

Change in osmocom-bb[master]: trx_toolkit/fake_trx.py: enrich TRX logging messages

2019-01-14 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12546 to look at the new patch set (#3). Change subject: trx_toolkit/fake_trx.py: enrich TRX logging messages

Change in osmocom-bb[master]: trx_toolkit/transceiver.py: add optional transceiver name

2019-01-14 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12549 to look at the new patch set (#2). Change subject: trx_toolkit/transceiver.py: add optional transceiver name

Change in libosmocore[master]: ipa_ccm_idtag_parse*: Fix reported length value

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10216 ) Change subject: ipa_ccm_idtag_parse*: Fix reported length value .. Patch Set 3: Code-Review+1 first time I come across this patch!

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12547 ) Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message .. Patch Set 2: Code-Review-1 (1 comment)

Change in libosmocore[master]: comments: update/fix three 3GPP spec references

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12559 Change subject: comments: update/fix three 3GPP spec references .. comments: update/fix three 3GPP spec references Change-Id:

Change in libosmocore[master]: change GSM48_CMSERV_* to enum type, add names

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12521 ) Change subject: change GSM48_CMSERV_* to enum type, add names .. change GSM48_CMSERV_* to enum type, add names Prepare handling

Change in libosmocore[master]: LCLS: add GCR comparison helper

2019-01-14 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12493 ) Change subject: LCLS: add GCR comparison helper .. Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/12493

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12547 ) Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message .. Patch Set 3: > it might avoid confusion if we don't call it CTRL

Change in osmo-bsc[master]: LCLS: use Status for HO-COMPLETE message

2019-01-14 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12379 to look at the new patch set (#2). Change subject: LCLS: use Status for HO-COMPLETE message .. LCLS:

Change in osmo-msc[master]: add BSC/MSC neighbor VTY commands for inter-MSC HO

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12446 ) Change subject: add BSC/MSC neighbor VTY commands for inter-MSC HO .. Patch Set 2: Code-Review-1 (13 comments) meta: Thanks for preparing

Change in osmo-msc[master]: Fix optional libmsc linking with libsmpp

2019-01-14 Thread Max
Max has abandoned this change. ( https://gerrit.osmocom.org/12557 ) Change subject: Fix optional libmsc linking with libsmpp .. Abandoned -- To view, visit https://gerrit.osmocom.org/12557 To unsubscribe, or for help writing

Change in libosmocore[master]: LCLS: expand enc/dec tests

2019-01-14 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12558 Change subject: LCLS: expand enc/dec tests .. LCLS: expand enc/dec tests Change-Id: I8ed87f26216104d34c7bd11c1527b203843760a2 --- M

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12547 ) Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message .. Patch Set 2: > it might avoid confusion if we don't call it CTRL in Osmocom...

Change in osmocom-bb[master]: layer23/sap_interface.c: reimplement (BT)SAP interface

2019-01-14 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12441 ) Change subject: layer23/sap_interface.c: reimplement (BT)SAP interface .. Patch Set 8: (4 comments)

Change in osmocom-bb[master]: layer23/sap_interface.c: reimplement (BT)SAP interface

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12441 ) Change subject: layer23/sap_interface.c: reimplement (BT)SAP interface .. Patch Set 8: (4 comments)

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12556 To

Change in libosmocore[master]: LCLS: add GCR comparison helper

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12493 ) Change subject: LCLS: add GCR comparison helper .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12493 To

Change in libosmocore[master]: comments: update/fix three 3GPP spec references

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12559 ) Change subject: comments: update/fix three 3GPP spec references .. comments: update/fix three 3GPP spec references Change-Id:

Change in libosmocore[master]: LCLS: add GCR comparison helper

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12493 ) Change subject: LCLS: add GCR comparison helper .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12493/2//COMMIT_MSG Commit

Change in libosmocore[master]: LCLS: expand enc/dec tests

2019-01-14 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12558 ) Change subject: LCLS: expand enc/dec tests .. LCLS: expand enc/dec tests Change-Id: I8ed87f26216104d34c7bd11c1527b203843760a2 --- M

Change in libosmocore[master]: LCLS: add GCR comparison helper

2019-01-14 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12493 ) Change subject: LCLS: add GCR comparison helper .. LCLS: add GCR comparison helper Change-Id: I9e3b5560a058b976638d03cb819415d237ae9984 ---

Change in libosmocore[master]: LCLS: add GCR comparison helper

2019-01-14 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12493 ) Change subject: LCLS: add GCR comparison helper .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12493/2//COMMIT_MSG Commit Message:

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2019-01-14 Thread Neels Hofmeyr
Hello Max, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11504 to look at the new patch set (#7). Change subject: gsm0808: add BSSMAP Cell Identifier matching API

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12547 ) Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message .. Patch Set 3: Code-Review+2 As (I hope) all warnings were

Change in osmocom-bb[master]: trx_toolkit/transceiver.py: add init logging message

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12548 ) Change subject: trx_toolkit/transceiver.py: add init logging message .. trx_toolkit/transceiver.py: add init logging message

Change in osmocom-bb[master]: trx_toolkit/fake_trx.py: move init code to __init__()

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12545 ) Change subject: trx_toolkit/fake_trx.py: move init code to __init__() .. trx_toolkit/fake_trx.py: move init code to __init__()

Change in osmocom-bb[master]: trx_toolkit: use 'TRXC' and 'TRXD' in logging messages

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12560 ) Change subject: trx_toolkit: use 'TRXC' and 'TRXD' in logging messages .. trx_toolkit: use 'TRXC' and 'TRXD' in logging messages

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12547 ) Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message .. Patch Set 3: > Patch Set 2: Code-Review-1 Please see

Change in osmocom-bb[master]: trx_toolkit/README: update fake_trx.py description

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12561 Change subject: trx_toolkit/README: update fake_trx.py description .. trx_toolkit/README: update fake_trx.py description Since

Change in osmocom-bb[master]: trx_toolkit: use 'TRXC' and 'TRXD' in logging messages

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12560 Change subject: trx_toolkit: use 'TRXC' and 'TRXD' in logging messages .. trx_toolkit: use 'TRXC' and 'TRXD' in logging messages One can

Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: use logging options of fake_trx.py

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12551 ) Change subject: ttcn3-bts-test/jenkins.sh: use logging options of fake_trx.py .. Patch Set 1: Verified+1 -- To view, visit

Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: use logging options of fake_trx.py

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12551 ) Change subject: ttcn3-bts-test/jenkins.sh: use logging options of fake_trx.py .. ttcn3-bts-test/jenkins.sh: use logging options

Change in docker-playground[master]: .../osmo-bsc.cfg: drop deprecated dyn_ts_allow_tch_f

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12552 ) Change subject: .../osmo-bsc.cfg: drop deprecated dyn_ts_allow_tch_f .. .../osmo-bsc.cfg: drop deprecated dyn_ts_allow_tch_f

Change in docker-playground[master]: .../osmo-bsc.cfg: drop deprecated dyn_ts_allow_tch_f

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12552 ) Change subject: .../osmo-bsc.cfg: drop deprecated dyn_ts_allow_tch_f .. Patch Set 1: Verified+1 -- To view, visit

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2019-01-14 Thread Neels Hofmeyr
Hello Max, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11504 to look at the new patch set (#5). Change subject: gsm0808: add BSSMAP Cell Identifier matching API

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11504 ) Change subject: gsm0808: add BSSMAP Cell Identifier matching API .. Patch Set 7: pfsh, jenkins' gcc complains that a const struct isn't

Change in osmo-msc[master]: Add tests for transaction routines

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: Code-Review-1 (13 comments)

Change in osmocom-bb[master]: layer23/sap_interface.c: reimplement (BT)SAP interface

2019-01-14 Thread Vadim Yanitskiy
Hello Kévin Redon, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12441 to look at the new patch set (#9). Change subject: layer23/sap_interface.c: reimplement (BT)SAP interface

Change in osmocom-bb[master]: trx_toolkit/fake_trx.py: move init code to __init__()

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12545 ) Change subject: trx_toolkit/fake_trx.py: move init code to __init__() .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: layer23/sap_interface.c: reimplement (BT)SAP interface

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12441 ) Change subject: layer23/sap_interface.c: reimplement (BT)SAP interface .. Patch Set 9: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trx_toolkit: use 'TRXC' and 'TRXD' in logging messages

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12560 ) Change subject: trx_toolkit: use 'TRXC' and 'TRXD' in logging messages .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trx_toolkit/README: update fake_trx.py description

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12561 ) Change subject: trx_toolkit/README: update fake_trx.py description .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trx_toolkit/transceiver.py: add optional transceiver name

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12549 ) Change subject: trx_toolkit/transceiver.py: add optional transceiver name .. trx_toolkit/transceiver.py: add optional transceiver

Change in osmocom-bb[master]: trx_toolkit/fake_trx.py: enrich TRX logging messages

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12546 ) Change subject: trx_toolkit/fake_trx.py: enrich TRX logging messages .. trx_toolkit/fake_trx.py: enrich TRX logging messages

Change in osmocom-bb[master]: trx_toolkit/{ctrl, data}_if.py: add init log message

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12547 ) Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message .. trx_toolkit/{ctrl,data}_if.py: add init log message

Change in osmocom-bb[master]: trx_toolkit/README: update fake_trx.py description

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12561 ) Change subject: trx_toolkit/README: update fake_trx.py description .. trx_toolkit/README: update fake_trx.py description Since

Change in libosmocore[master]: LCLS: expand enc/dec tests

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12558 ) Change subject: LCLS: expand enc/dec tests .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12558 To

Change in libosmocore[master]: comments: update/fix three 3GPP spec references

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12559 ) Change subject: comments: update/fix three 3GPP spec references .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: LCLS: add GCR comparison helper

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12493 ) Change subject: LCLS: add GCR comparison helper .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12493 To

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2019-01-14 Thread Neels Hofmeyr
Hello Max, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11504 to look at the new patch set (#6). Change subject: gsm0808: add BSSMAP Cell Identifier matching API

Change in libosmocore[master]: LCLS: add GCR comparison helper

2019-01-14 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12493 ) Change subject: LCLS: add GCR comparison helper .. Patch Set 3: (1 comment) In fact, it's already used in this patch in the test.

Change in libosmocore[master]: LCLS: add GCR comparison helper

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12493 ) Change subject: LCLS: add GCR comparison helper .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12493/2//COMMIT_MSG Commit

Change in libosmocore[master]: gsm29118: fix coverity issues

2019-01-14 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12550 Change subject: gsm29118: fix coverity issues .. gsm29118: fix coverity issues The function msgb_sgsap_name_put() assignes the return code of

Change in osmo-bsc[master]: paging: fix nullpointer deref

2019-01-14 Thread dexter
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12482 to look at the new patch set (#2). Change subject: paging: fix nullpointer deref .. paging: fix

Change in osmo-ttcn3-hacks[master]: MSC_Test: Test what happens when Paging for SMS is unanswered

2019-01-14 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/11897 ) Change subject: MSC_Test: Test what happens when Paging for SMS is unanswered .. MSC_Test: Test what happens when Paging for SMS is

Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: use logging options of fake_trx.py

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12551 Change subject: ttcn3-bts-test/jenkins.sh: use logging options of fake_trx.py .. ttcn3-bts-test/jenkins.sh: use logging options of

Change in docker-playground[master]: .../osmo-bsc.cfg: drop deprecated dyn_ts_allow_tch_f

2019-01-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12552 Change subject: .../osmo-bsc.cfg: drop deprecated dyn_ts_allow_tch_f .. .../osmo-bsc.cfg: drop deprecated dyn_ts_allow_tch_f Since

Build failed in Jenkins: master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #811

2019-01-14 Thread jenkins
See -- [...truncated 107.03 KB...] Searching INPUT for files to process... Reading and parsing

Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: use logging options of fake_trx.py

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12551 ) Change subject: ttcn3-bts-test/jenkins.sh: use logging options of fake_trx.py .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: add osmo-asf4-dfu master and gerrit jobs

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12544 ) Change subject: add osmo-asf4-dfu master and gerrit jobs .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: paging: fix nullpointer deref

2019-01-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12482 ) Change subject: paging: fix nullpointer deref .. paging: fix nullpointer deref In theroy the function T_def_get_entry() may return

Change in osmo-bsc[master]: paging: fix nullpointer deref

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12482 ) Change subject: paging: fix nullpointer deref .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12482 To

Change in libosmocore[master]: gsm29118: fix coverity issues

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12550 ) Change subject: gsm29118: fix coverity issues .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12550 To

Change in osmo-ci[master]: add osmo-asf4-dfu master and gerrit jobs

2019-01-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12544 ) Change subject: add osmo-asf4-dfu master and gerrit jobs .. add osmo-asf4-dfu master and gerrit jobs Change-Id:

Change in docker-playground[master]: .../osmo-bsc.cfg: drop deprecated dyn_ts_allow_tch_f

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12552 ) Change subject: .../osmo-bsc.cfg: drop deprecated dyn_ts_allow_tch_f .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-asf4-dfu[master]: Add .gitignore file

2019-01-14 Thread Max
Max has abandoned this change. ( https://gerrit.osmocom.org/12517 ) Change subject: Add .gitignore file .. Abandoned -- To view, visit https://gerrit.osmocom.org/12517 To unsubscribe, or for help writing mail filters, visit

Change in osmo-asf4-dfu[master]: ignore output files

2019-01-14 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12495 ) Change subject: ignore output files .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12495 To unsubscribe, or for help

Change in libosmocore[master]: gsm23003: add osmo_imei_str_valid()

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12524 ) Change subject: gsm23003: add osmo_imei_str_valid() .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/12524/3/src/gsm/gsm23003.c

Change in osmo-bsc[master]: Print BTS number on GPRS options error

2019-01-14 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12553 ) Change subject: Print BTS number on GPRS options error .. Print BTS number on GPRS options error Change-Id:

Change in osmo-msc[master]: transaction: drop unused ti_flag

2019-01-14 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12519 ) Change subject: transaction: drop unused ti_flag .. Patch Set 1: (1 comment) > Patch Set 1: Code-Review-2 Could you please clarify why it's better

Change in osmocom-bb[master]: trx_toolkit/fake_trx.py: enrich TRX logging messages

2019-01-14 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12546 ) Change subject: trx_toolkit/fake_trx.py: enrich TRX logging messages .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmocore[master]: gsm23003: add osmo_imei_str_valid()

2019-01-14 Thread osmith
Hello Vadim Yanitskiy, Pau Espin Pedrol, Max, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12524 to look at the new patch set (#4). Change subject: gsm23003: add osmo_imei_str_valid()

  1   2   >