Change in osmo-gsm-tester[master]: srsenb.conf.tmpl: reduce RRC inactivity timer to 5s

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18625 ) Change subject: srsenb.conf.tmpl: reduce RRC inactivity timer to 5s .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: srsenb_sib.conf.tmpl: increase default T311 value to 10s

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18624 ) Change subject: srsenb_sib.conf.tmpl: increase default T311 value to 10s .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: handover.py: fix typo in test

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18626 ) Change subject: handover.py: fix typo in test .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: srsenb_sib.conf_tmpl: fix whitespaces

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18623 ) Change subject: srsenb_sib.conf_tmpl: fix whitespaces .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: epc: add run function to EPC

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18536 ) Change subject: epc: add run function to EPC .. Patch Set 3: (1 comment)

Change in osmo-gsm-tester[master]: epc: add run function to EPC

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18536 ) Change subject: epc: add run function to EPC .. Patch Set 3: Code-Review+2 -- To view, visit

Change in openbsc[master]: fix typo in osmo_bts_variant_names: s/omso/osmo/

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/18627 ) Change subject: fix typo in osmo_bts_variant_names: s/omso/osmo/ .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: ms_srs: refactor UE state getter functions

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535 ) Change subject: ms_srs: refactor UE state getter functions .. Patch Set 3: (1 comment)

Change in osmo-gsm-tester[master]: ms_srs: add PRACH, reestablishment and paging counter

2020-06-02 Thread srs_andre
srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18538 ) Change subject: ms_srs: add PRACH, reestablishment and paging counter .. Patch Set 3: (1 comment)

Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling

2020-06-02 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18372 ) Change subject: osmo-mgw: refactor endpoint and trunk handling .. Patch Set 7: Code-Review-1 (21 comments) Nice, a lot of excellent

Change in libosmocore[master]: bts_features: fix: properly check the result of bitvec_get_bit_pos()

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18619 ) Change subject: bts_features: fix: properly check the result of bitvec_get_bit_pos() .. Patch Set 2: (1 comment)

Change in libosmocore[master]: bts_features: fix: properly check the result of bitvec_get_bit_pos()

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18619 ) Change subject: bts_features: fix: properly check the result of bitvec_get_bit_pos() .. Patch Set 2: (1 comment)

Change in osmo-pcu[master]: bts: refactor handling and parsing of RACH.ind

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18386 ) Change subject: bts: refactor handling and parsing of RACH.ind .. Patch Set 6: Code-Review+2 -- To view, visit

Change in docker-playground[master]: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18629 ) Change subject: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: bts_features: fix: properly check the result of bitvec_get_bit_pos()

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18619 ) Change subject: bts_features: fix: properly check the result of bitvec_get_bit_pos() .. Patch Set 2: Code-Review+1 (1 comment)

Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18372 ) Change subject: osmo-mgw: refactor endpoint and trunk handling .. Patch Set 7: (1 comment)

Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18372 ) Change subject: osmo-mgw: refactor endpoint and trunk handling .. Patch Set 7: Code-Review+1 -- To view, visit

Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 ) Change subject: Do not mix public and private BTS features, use libosmocore's API .. Patch Set 5: Code-Review+1 (1 comment)

Change in libosmo-netif[master]: amr: fix off-by-one in osmo_amr_bwe_to_oa()

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18451 ) Change subject: amr: fix off-by-one in osmo_amr_bwe_to_oa() .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-gsm-manuals[master]: trx_if.adoc: Document cmd NOMTXPOWER

2020-06-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18630 ) Change subject: trx_if.adoc: Document cmd NOMTXPOWER .. trx_if.adoc: Document cmd NOMTXPOWER TRXC message is implemented

Change in osmo-gsm-manuals[master]: trx_if.adoc: Document cmd NOMTXPOWER

2020-06-02 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18630 ) Change subject: trx_if.adoc: Document cmd NOMTXPOWER .. Patch Set 1: Code-Review+2 nom nom -- To view, visit

Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007

2020-06-02 Thread gui...@gmail.com
gui...@gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 5: > Patch Set 5: > > (1 comment)

Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 6: Verified+1 Setting it on your

Change in libosmocore[master]: gsm23236: add TMSI and NRI utility functions for MSC pooling

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: gsm23236: add TMSI and NRI utility functions for MSC pooling .. Patch Set 2: (1 comment)

Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 6: Should be fixed now. Please let

Change in libosmocore[master]: gsm23236: add TMSI and NRI utility functions for MSC pooling

2020-06-02 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: gsm23236: add TMSI and NRI utility functions for MSC pooling .. Patch Set 2: (1 comment) This change is ready for

Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 5: > yes, I was running it with

Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007

2020-06-02 Thread gui...@gmail.com
gui...@gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 6: > Patch Set 6: > > Should be

Change in osmo-bts[master]: osmo-bts-omldummy: print a brief usage statement if argc < 3

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18631 ) Change subject: osmo-bts-omldummy: print a brief usage statement if argc < 3 .. osmo-bts-omldummy: print a brief usage

Change in osmo-bts[master]: osmo-bts-omldummy: make number of transceivers configurable

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18632 ) Change subject: osmo-bts-omldummy: make number of transceivers configurable .. osmo-bts-omldummy: make number of

Change in osmo-bts[master]: bts-trx: Implement power ramping during BTS bring up

2020-06-02 Thread pespin
Hello tnt, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18488 to look at the new patch set (#5). Change subject: bts-trx: Implement power ramping during BTS bring up

Change in osmo-bts[master]: bts-trx: Introduce helper func l1if_trx_set_nominal_power

2020-06-02 Thread pespin
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18588 to look at the new patch set (#3). Change subject: bts-trx: Introduce helper func l1if_trx_set_nominal_power

Change in osmo-bts[master]: bts-trx: vty: Add 'nominal-tx-power' cmd

2020-06-02 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18579 to look at the new patch set (#3). Change subject: bts-trx: vty: Add 'nominal-tx-power' cmd .. bts-trx:

Change in osmo-gsm-manuals[master]: trx_if: Clarify {SET; ADJ}POWER TRXC commands

2020-06-02 Thread pespin
Hello tnt, neels, Jenkins Builder, Hoernchen, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556 to look at the new patch set (#3). Change subject: trx_if: Clarify {SET;ADJ}POWER TRXC commands

Change in osmo-pcu[master]: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18387 ) Change subject: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request .. Patch Set 7: Code-Review+2 -- To view,

Change in docker-playground[master]: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/18629 ) Change subject: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest .. ttcn3-msc-test: fix osmo-msc.cfg:

Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

2020-06-02 Thread Vadim Yanitskiy
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18591 to look at the new patch set (#5). Change subject: Do not mix public and private BTS features, use libosmocore's API

Change in osmo-gsm-manuals[master]: trx_if: Clarify {SET; ADJ}POWER TRXC commands

2020-06-02 Thread pespin
Hello tnt, neels, Jenkins Builder, Hoernchen, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556 to look at the new patch set (#2). Change subject: trx_if: Clarify {SET;ADJ}POWER TRXC commands

Change in osmo-gsm-manuals[master]: trx_if: Clarify {SET; ADJ}POWER TRXC commands

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556 ) Change subject: trx_if: Clarify {SET;ADJ}POWER TRXC commands .. Patch Set 3: > Patch Set 3: Code-Review+1 > > haven't

Change in libosmocore[master]: bts_features: fix: properly check the result of bitvec_get_bit_pos()

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18619 ) Change subject: bts_features: fix: properly check the result of bitvec_get_bit_pos() .. Patch Set 2: (1 comment)

Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

2020-06-02 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 ) Change subject: Do not mix public and private BTS features, use libosmocore's API .. Patch Set 6: Code-Review+1 (5 comments) only

Change in osmo-mgw[master]: mgcp_vty: fix indentation in VTY config write

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18593 ) Change subject: mgcp_vty: fix indentation in VTY config write .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion

2020-06-02 Thread dexter
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18450 to look at the new patch set (#2). Change subject: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion

Change in openbsc[master]: fix typo in osmo_bts_variant_names: s/omso/osmo/

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change. ( https://gerrit.osmocom.org/c/openbsc/+/18627 ) Change subject: fix typo in osmo_bts_variant_names: s/omso/osmo/ .. fix typo in osmo_bts_variant_names: s/omso/osmo/ Change-Id:

Change in osmo-bts[master]: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from os...

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18589 ) Change subject: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from osmo-trx .. Patch Set 2: > Patch Set 2: > > The

Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 ) Change subject: Do not mix public and private BTS features, use libosmocore's API .. Patch Set 5: (1 comment)

Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18450 ) Change subject: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion

2020-06-02 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18450 ) Change subject: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion .. MGCP_Test: fix test vector in

Change in libosmo-netif[master]: amr: fix off-by-one in osmo_amr_bwe_to_oa()

2020-06-02 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18451 ) Change subject: amr: fix off-by-one in osmo_amr_bwe_to_oa() .. amr: fix off-by-one in osmo_amr_bwe_to_oa() The for loop in

Change in osmo-bsc[master]: Split GSM_BTS_TYPE_OSMOBTS to individual BTS types

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18616 ) Change subject: Split GSM_BTS_TYPE_OSMOBTS to individual BTS types .. Patch Set 1: Code-Review-1 Agree with laforge: * Fine moving

Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

2020-06-02 Thread Vadim Yanitskiy
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18591 to look at the new patch set (#6). Change subject: Do not mix public and private BTS features, use libosmocore's API

Change in osmo-gsm-manuals[master]: trx_if: Clarify {SET; ADJ}POWER TRXC commands

2020-06-02 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556 ) Change subject: trx_if: Clarify {SET;ADJ}POWER TRXC commands .. Patch Set 3: Code-Review+1 haven't checked about whether the

Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007

2020-06-02 Thread gui...@gmail.com
gui...@gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 5: (1 comment) > Patch Set 5:

Change in osmo-msc[master]: add full SDP codec information to the MNCC socket

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15953 ) Change subject: add full SDP codec information to the MNCC socket .. Patch Set 6: (7 comments)

Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 ) Change subject: Do not mix public and private BTS features, use libosmocore's API .. Patch Set 3: (3 comments) Please add

Change in libosmo-netif[master]: src/stream: Work around more Linux kernel ABI breakage

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18628 ) Change subject: src/stream: Work around more Linux kernel ABI breakage .. Patch Set 1: (5 comments)

Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 ) Change subject: Do not mix public and private BTS features, use libosmocore's API .. Patch Set 3: (3 comments)

Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 ) Change subject: Do not mix public and private BTS features, use libosmocore's API .. Patch Set 4: This change is ready for

Change in docker-playground[master]: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18629 ) Change subject: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest .. ttcn3-msc-test: fix osmo-msc.cfg: make it work

Change in docker-playground[master]: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18629 ) Change subject: ttcn3-msc-test: fix osmo-msc.cfg: make it work with latest .. Patch Set 1: Verified+1 Code-Review+2

Change in osmo-mgw[master]: mgcp_vty: fix indentation

2020-06-02 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18594 ) Change subject: mgcp_vty: fix indentation .. mgcp_vty: fix indentation Some DEFUN macros are not correctly indented Change-Id:

Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Patch Set 5: (1 comment)

Change in osmo-bts[master]: osmo-bts-omldummy: print a brief usage statement if argc < 3

2020-06-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18631 ) Change subject: osmo-bts-omldummy: print a brief usage statement if argc < 3 .. osmo-bts-omldummy: print a brief usage statement if argc < 3

Change in osmo-bts[master]: osmo-bts-omldummy: make number of transceivers configurable

2020-06-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18632 ) Change subject: osmo-bts-omldummy: make number of transceivers configurable .. osmo-bts-omldummy: make number of transceivers configurable

Change in osmo-bts[master]: osmo-bts-omldummy: make number of transceivers configurable

2020-06-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18632 ) Change subject: osmo-bts-omldummy: make number of transceivers configurable .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: bts-trx: Introduce helper func l1if_trx_set_nominal_power

2020-06-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18588 ) Change subject: bts-trx: Introduce helper func l1if_trx_set_nominal_power .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: bts-trx: vty: Add 'nominal-tx-power' cmd

2020-06-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18579 ) Change subject: bts-trx: vty: Add 'nominal-tx-power' cmd .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-bts[master]: bts-trx: Implement power ramping during BTS bring up

2020-06-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18488 ) Change subject: bts-trx: Implement power ramping during BTS bring up .. Patch Set 5: Code-Review+1 -- To view, visit

Change in libosmo-netif[master]: src/stream: Work around more Linux kernel ABI breakage

2020-06-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18628 ) Change subject: src/stream: Work around more Linux kernel ABI breakage .. Patch Set 1: (1 comment)

Change in osmo-bts[master]: osmo-bts-omldummy: print a brief usage statement if argc < 3

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18631 ) Change subject: osmo-bts-omldummy: print a brief usage statement if argc < 3 .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bts[master]: osmo-bts-omldummy: make number of transceivers configurable

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18632 ) Change subject: osmo-bts-omldummy: make number of transceivers configurable .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 ) Change subject: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect .. BTS_Tests: fix f_init_rsl():

Change in libosmocore[master]: tlv.h: add msgb_tvl_put() to add a TvLV without the value part

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18634 ) Change subject: tlv.h: add msgb_tvl_put() to add a TvLV without the value part .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bts[master]: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from os...

2020-06-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18589 ) Change subject: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from osmo-trx .. Patch Set 3: > Patch Set 2: > As

Change in libosmocore[master]: gsm23236: add TMSI and NRI utility functions for MSC pooling

2020-06-02 Thread neels
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18506 to look at the new patch set (#3). Change subject: gsm23236: add TMSI and NRI utility functions for MSC pooling

Change in libosmocore[master]: tlv.h: add msgb_tvl_put() to add a TvLV without the value part

2020-06-02 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18634 ) Change subject: tlv.h: add msgb_tvl_put() to add a TvLV without the value part .. tlv.h: add msgb_tvl_put() to add a TvLV without

Change in libosmocore[master]: tlv.h: add msgb_tvl_put() to add a TvLV without the value part

2020-06-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18634 ) Change subject: tlv.h: add msgb_tvl_put() to add a TvLV without the value part .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect

2020-06-02 Thread pespin
pespin has uploaded a new patch set (#2) to the change originally created by Vadim Yanitskiy. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 ) Change subject: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect

Change in libosmocore[master]: gsm23236: add TMSI and NRI utility functions for MSC pooling

2020-06-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: gsm23236: add TMSI and NRI utility functions for MSC pooling .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect

2020-06-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 ) Change subject: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect .. Patch Set 2: Code-Review+1 -- To

Change in osmo-bts[master]: Do not mix public and private BTS features, use libosmocore's API

2020-06-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18591 ) Change subject: Do not mix public and private BTS features, use libosmocore's API .. Patch Set 6: Code-Review+1 -- To view, visit

Change in osmo-bts[master]: osmo-bts-omldummy: print a brief usage statement if argc < 3

2020-06-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18631 ) Change subject: osmo-bts-omldummy: print a brief usage statement if argc < 3 .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from os...

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18589 ) Change subject: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from osmo-trx .. Patch Set 3: > Patch Set 3: > > >

Change in osmo-gsm-tester[master]: enb_srs: add extra head room for max rate with 6 PRB in MIMO mode

2020-06-02 Thread srs_andre
srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18636 ) Change subject: enb_srs: add extra head room for max rate with 6 PRB in MIMO mode .. enb_srs: add extra head room for max

Change in osmo-gsm-tester[master]: ms_srs: refactor UE state getter functions

2020-06-02 Thread srs_andre
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535 to look at the new patch set (#4). Change subject: ms_srs: refactor UE state getter functions

Change in libosmo-netif[master]: src/stream: Work around more Linux kernel ABI breakage

2020-06-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18628 ) Change subject: src/stream: Work around more Linux kernel ABI breakage .. src/stream: Work around more Linux kernel ABI breakage Back in

Change in libosmo-netif[master]: src/stream: Work around more Linux kernel ABI breakage

2020-06-02 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18628 ) Change subject: src/stream: Work around more Linux kernel ABI breakage .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 ) Change subject: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect .. Patch Set 3: Code-Review+1 (1 comment)

Change in osmo-gsm-tester[master]: enb_srs: add extra head room for max rate with 6 PRB in MIMO mode

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18636 ) Change subject: enb_srs: add extra head room for max rate with 6 PRB in MIMO mode .. Patch Set 1: Code-Review+2 Don't you

Change in osmo-gsm-manuals[master]: trx_if: Clarify {SET; ADJ}POWER TRXC commands

2020-06-02 Thread Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556 ) Change subject: trx_if: Clarify {SET;ADJ}POWER TRXC commands .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: vlr_subscr_rx_id_resp(): dont assert on received MI type

2020-06-02 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/18635 ) Change subject: vlr_subscr_rx_id_resp(): dont assert on received MI type .. vlr_subscr_rx_id_resp(): dont assert on received MI type

Change in libosmo-netif[master]: src/stream: Work around more Linux kernel ABI breakage

2020-06-02 Thread laforge
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/18628 to look at the new patch set (#2). Change subject: src/stream: Work around more Linux kernel ABI breakage

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 ) Change subject: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect .. Patch Set 3: This change is

Change in osmo-gsm-tester[master]: enb: use 11.52e6 as base_srate for 25 PRB

2020-06-02 Thread srs_andre
srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18637 ) Change subject: enb: use 11.52e6 as base_srate for 25 PRB .. enb: use 11.52e6 as base_srate for 25 PRB With 25 PRB we've

Change in osmo-gsm-tester[master]: 4g_suite: add MT and MO test cases

2020-06-02 Thread srs_andre
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539 to look at the new patch set (#4). Change subject: 4g_suite: add MT and MO test cases ..

Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: cosmetic: improve logging messages

2020-06-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18638 ) Change subject: library/RSL_Emulation: cosmetic: improve logging messages .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: manual: link to new common cs7-config.adoc, remove some dup of that

2020-06-02 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17580 ) Change subject: manual: link to new common cs7-config.adoc, remove some dup of that .. Patch Set 2: ping -- To view, visit

Change in osmo-msc[master]: manual: Multiple Instances: tweak MNCC, add missing SGs doc

2020-06-02 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18493 ) Change subject: manual: Multiple Instances: tweak MNCC, add missing SGs doc .. manual: Multiple Instances: tweak MNCC, add missing SGs doc

Change in osmo-msc[master]: manual: Multiple Instances: tweak MNCC, add missing SGs doc

2020-06-02 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18493 ) Change subject: manual: Multiple Instances: tweak MNCC, add missing SGs doc .. Patch Set 1: Code-Review+2 relative triviality +2 --

Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: cosmetic: improve logging messages

2020-06-02 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18638 ) Change subject: library/RSL_Emulation: cosmetic: improve logging messages .. library/RSL_Emulation: cosmetic:

  1   2   >