Re: [Gimp-developer] ACO and CSS palette importing (patch attached)

2007-08-08 Thread Sven Neumann
Hi, On Tue, 2007-08-07 at 18:36 +0200, Michael Natterer wrote: Please fix these warnings and attach the updated patch to bugzilla. This way it won't get lost. The patch can unfortunately not be included in 2.4 because we are too close to a release, and we don't depend on a glib version

Re: [Gimp-developer] ACO and CSS palette importing (patch attached)

2007-08-07 Thread Michael Natterer
[resending, apparently the firts try didn't make it...] Thanks, that patch looks generally fine, also coding style wise, however: gimppalette-load.c: In function ‘gimp_palette_load_aco’: gimppalette-load.c:440: warning: unused variable ‘color_bytes’ gimppalette-load.c:598:28: warning: unknown

Re: [Gimp-developer] ACO and CSS palette importing (patch attached)

2007-08-05 Thread Sven Neumann
Hi, On Sat, 2007-08-04 at 19:45 +0100, Nicola Archibald wrote: Attached is a patch, against svn, which adds ACO importing, and CSS color extraction, for the palette system. The ACO code only reads the version 1 section at the moment, I plan on finishing the version 2 support to extract

[Gimp-developer] ACO and CSS palette importing (patch attached)

2007-08-04 Thread Nicola Archibald
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi All, Attached is a patch, against svn, which adds ACO importing, and CSS color extraction, for the palette system. The ACO code only reads the version 1 section at the moment, I plan on finishing the version 2 support to extract color names a