Re: [Gimp-developer] compose - decompose nitpicking

2004-07-23 Thread William Skaggs
Sven Neumann wrote: Huh? At the moment compose doesn't know anything about decompose. Why shouldn't it work on layers not produced by decompose? Well, I'm a bit behind the times on this one. I haven't used compose much for the past 3-4 months, and as I recall this issue was there then, but

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-23 Thread Sven Neumann
Hi, William Skaggs [EMAIL PROTECTED] writes: The issue that *is* there now is that compose shows a bunch of pixbuf-related libgimp-critical error messages whenever I try to run it, but of course that's a different thing. The new code in gimppixbuf.c made a wrong assumption. Good that I had

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-22 Thread Markus Triska
On Wednesday 21 July 2004 09:42 am, Sven Neumann wrote: Sure, the plug-in is far from perfect. There's some code in compose.c that tries to guess some useful default values for the layers it preselects. This code could certainly be improved. I am not sure though if it makes sense to attempt

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-22 Thread Markus Triska
On Wednesday 21 July 2004 09:20 pm, you wrote: For a start, I'm attaching a patch that makes compose use the layers in reverse order (if the image has more than MIN_COMPOSE_LAYERS = 3 layers, otherwise use old behavior). No attempt is currently made to guess the mode. Sorry, should read

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-22 Thread William Skaggs
Here is what I would do, and it wouldn't be very hard to code up: 1) Make decompose attach a parasite called decompose-info to each layer it produces, specifying the type of decomposition and listing the source layer and the layers that are created. 2) Split compose into two PDB

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-22 Thread Nathan Carl Summers
On 21 Jul 2004, Sven Neumann wrote: Dave Neary [EMAIL PROTECTED] writes: I think it would be even more useful to set the compose mode to the last used decompose mode, rather than the last used compose mode (if you get my meaning). Well, this is doable but it would require closer

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-22 Thread Sven Neumann
Hi, William Skaggs [EMAIL PROTECTED] writes: A) Compose would allow you to use any set of equal-sized grayscale layers to assemble into an RGB layer. (One of the annoyances of compose now is that it only works on layers that were produced using decompose.) Huh? At the

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-21 Thread Sven Neumann
Hi, Joseph Heled [EMAIL PROTECTED] writes: Perhaps this is nitpicking, but would like your comments. (gimp 2.0.3) After decomposing an image to HSV (in layers mode), Filters/Colors/Compose brings up the following dialog: (*) RGB Red - image-HSV.jpg-3/value-8

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-21 Thread Dave Neary
Joseph Heled wrote: Perhaps this is nitpicking, but would like your comments. (gimp 2.0.3) After decomposing an image to HSV (in layers mode), Filters/Colors/Compose brings up the following dialog: (*) RGB Red - image-HSV.jpg-3/value-8 Green - image-HSV.jpg-3/value-8

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-21 Thread Sven Neumann
Hi, Dave Neary [EMAIL PROTECTED] writes: 2. Even assuming I have to check HSV manually, why not give the first 3 layers (when they exist) as the default? (for that to work, the order of the dialog has to match the order of created layers. right now it is the reverse) That sounds

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-21 Thread Dave Neary
Hi, Sven Neumann wrote: It's probably more useful to remember the last used mode (which is what the plug-in does already). I think it would be even more useful to set the compose mode to the last used decompose mode, rather than the last used compose mode (if you get my meaning). As I said,

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-21 Thread Sven Neumann
Hi, Sven Neumann [EMAIL PROTECTED] writes: IIRC there's already some code that attempts to select the layers called hue, value, saturation if you select HSV mode. It doesn't seem to work very well though. We would happily accept a patch that improves this. I had a look at the plug-in source

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-21 Thread Sven Neumann
Hi, Dave Neary [EMAIL PROTECTED] writes: It's probably more useful to remember the last used mode (which is what the plug-in does already). I think it would be even more useful to set the compose mode to the last used decompose mode, rather than the last used compose mode (if you get my

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-21 Thread Dave Neary
Hi, Sven Neumann wrote: Well, this is doable but it would require closer interaction between the two plug-ins. compose could read the last-used-parameters set by decompose. A prerequisite for this would be to let the two plug-ins share a common header. Or merge the two plug-ins into one... Cheers,

Re: [Gimp-developer] compose - decompose nitpicking

2004-07-21 Thread Sven Neumann
Hi, Dave Neary [EMAIL PROTECTED] writes: Well, this is doable but it would require closer interaction between the two plug-ins. compose could read the last-used-parameters set by decompose. A prerequisite for this would be to let the two plug-ins share a common header. Or merge the

[Gimp-developer] compose - decompose nitpicking

2004-07-20 Thread Joseph Heled
Perhaps this is nitpicking, but would like your comments. (gimp 2.0.3) After decomposing an image to HSV (in layers mode), Filters/Colors/Compose brings up the following dialog: (*) RGB Red - image-HSV.jpg-3/value-8 Green - image-HSV.jpg-3/value-8 Blue -