[Gimp-developer] Blur tool darkens image?

2007-04-24 Thread Jasper Schalken
This is what I thought was a bug (I posted herehttp://bugzilla.gnome.org/show_bug.cgi?id=432978) but Sven Neumann says I should discuss it on here first. Basically I've found that blurring an image with the blur tool in 2.3.15 darkens it as well as blurs, but only if there is a darker colour invol

Re: [Gimp-developer] Blur tool darkens image?

2007-04-24 Thread Jasper Schalken
On 25/04/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > On Tue, 24 Apr 2007 20:57:43 +0200, Sven Neumann <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > On Wed, 2007-04-25 at 02:41 +1000, Jasper Schalken wrote: > >> This is what I thought was a bug

Re: [Gimp-developer] Blur tool darkens image?

2007-04-24 Thread Jasper Schalken
> Your video shows the blur tool being used on large areas of black color > and small areas of white color. The average of this is a dark gray. Now > when you continue to blur, you are mixing a dark gray with black. If you > go further, you end up with all black. Well yes that's valid for the one

Re: [Gimp-developer] Blur tool darkens image?

2007-04-24 Thread Jasper Schalken
> Why do you say that? Does it still favour dark colours if the image is > predominantly white? Yes it does. Blurring a white spot on a black image erases the white spot. Blurring a black spot on a white image makes the black spot bigger. I have just tested 2.2 and it also suffers from this. Phot

Re: [Gimp-developer] Blur tool darkens image?

2007-04-26 Thread Jasper Schalken
ced the rounding errors in our blur plug-ins today. The > > results are a lot more stable now, even after multiple iterations. > > > > > > Sven > > > > Excellent work! I just reran my test case (which was centred on the b/w > boundry in the middle

Re: [Gimp-developer] Blur tool darkens image?

2007-04-27 Thread Jasper Schalken
from SVN? On 27/04/07, Sven Neumann <[EMAIL PROTECTED]> wrote: > Hi, > > On Fri, 2007-04-27 at 15:59 +1000, Jasper Schalken wrote: > > So this is fixed in cvs? For the tool, plugins, or both? > > We aren't using CVS any longer (for a few months now). If you want to &

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread Jasper Schalken
Yep, you fixed it good! However, some artefacts appear when blurring near the edge of the image. It seems to blur/spread even further: http://schalken.wubbles.net/gimpblurnearedge.ogg On 28/04/07, Sven Neumann <[EMAIL PROTECTED]> wrote: > Hi, > > On Fri, 2007-04-27 at 22:0

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread Jasper Schalken
> I presume you are saying that there is some difference with the new > version. No this was present in the previous version, however trivial in comparison to the darkening bug. > Perhaps a more explicit description would be helpful if a couple > of sentences could save us downloading a movie. It

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread Jasper Schalken
ur at all. Only blur with pixels that do exist. But someone should have a look at the code before I take my assumptions/theories too far. I will have another look and see if I can understand what it is doing. On 28/04/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > On Sat, 28 Apr 200

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread Jasper Schalken
> You could have a look at the matrix convolution filter code. (Be warned > there are some minor bugs concerning edge effects IIRC) but it will serve > as an introduction to the different ways of treating edge data. Is that "void convolve_region(...) {...}" in /gimp/trunk/app/paint-funcs/paint-fun

Re: [Gimp-developer] Blur tool darkens image?

2007-04-28 Thread Jasper Schalken
The bug report: http://bugzilla.gnome.org/show_bug.cgi?id=434279 On 29/04/07, Jasper Schalken <[EMAIL PROTECTED]> wrote: > > You could have a look at the matrix convolution filter code. (Be warned > > there are some minor bugs concerning edge effects IIRC) but it will serve >