Re: [Gimp-developer] Image Info Dialog
Hi, Dave Neary <[EMAIL PROTECTED]> writes: > > is it easy to change the info plugin to show also in the Image Menu? > > No, not really... the menu entries are all defined in > app/gui/image-menu.c and for consistency there are files containing > the callbacks (the functions called when you select a menu item) for > each submenu in -commands.[ch] (so, for example, the info > window calback is in view-commands.c). That's not accurate any longer. With current CVS the menu entry in question is defined in menus/image-menu.xml and it is trivially changed even by non-hackers. There is also a plan for adding an "Image Attributes" or "Image Properties" dialog and extending the already existing "Layer Attributes" (and similar) dialogs. A prerequisite for this is to make all this stuff object properties. This is a nice task for a volunteer who wants to get into GIMP core hacking. Let me know if you are interested... Sven ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Image Info Dialog
Or..press ctrl+shift + i - it is faster than hovering and guessing . On Wednesday 28 April 2004 18:42, Alan Horkan wrote: > On Tue, 27 Apr 2004, Carol Spears wrote: > Perhaps additional information in the status bar messages showing the > selection dimensions and offsets would work? (Shown as a standard > transient message, I am definately not advocating permanently grabbing a > chunk of the statusbar.) I think, I hope something non-intrusive and > relatively trivial could be done to make things a little bit easier, > ideas? Should I file a request for enhancement? There is an enhancement request for showing the selection dimensions in Bugzilla - search for it to add your comments/requests there. As for the otehr image info, I suggest usiong the shortcut (defaults to ctrl+shift+i) to get it fast. > > - Alan > ___ > Gimp-developer mailing list > [EMAIL PROTECTED] > http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Image Info Dialog
On Tue, 27 Apr 2004, Carol Spears wrote: > > > Carol Spears wrote: > > > > since day one with the gimp, everytime i want to get the info dialog i > > > > first search the Image Menu. my reasoning is "Image -->Info". i am > > > > really not thinking of viewing anything, more like knowing > > > > I always though of 'File, Properties' (or 'File, Get Info' because there > > is lots of kinds of file metadata, not specifcally related to the image > > drawable. > > > i can see the logic of "File -->Info" i just never thought that way > myself. > > i always want "Image Info", and the truth is, this dialog is so limited > that it is still quicker to get the scale tool and pop up the scale > dialog to get the width and height information which is usually what i > am looking for. > > crap, i am working so much on web pages with my wysmythingie (mozilla) > that it is actually (truthfully) quicker to right click on the image and > load that into the web browser for the height and width information. I've gotten into the habit of hovering over the bottom right corner and rounding up to figure out the image size. I'm thinking if we are both finding it a little bit awkward to quickly know the image dimensions then it is unlikely that we are the only ones and that it would be something worth improving. Perhaps additional information in the status bar messages showing the selection dimensions and offsets would work? (Shown as a standard transient message, I am definately not advocating permanently grabbing a chunk of the statusbar.) I think, I hope something non-intrusive and relatively trivial could be done to make things a little bit easier, ideas? Should I file a request for enhancement? - Alan ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Image Info Dialog
Hi, Carol Spears wrote: > another one that i stop and think about is the Layers -->Transparency > -->Add Alpha Channel. while it is true that it only works on one layer > at a time, it is also true that there is only one layer for it to work > on. you could have it run from Image Menu or from the Layers Dialog or > from the Layers Menu and have it add transparency to the only layer (the > background layer) that doesnt have it. I tend to agree with you on this. Are there any good arguments for having this in the Layer menu? Cheers, Dave. -- David Neary, Lyon, France E-Mail: [EMAIL PROTECTED] ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Image Info Dialog
On Tue, Apr 27, 2004 at 09:33:31PM +0100, Alan Horkan wrote: > > On Tue, 27 Apr 2004, Dave Neary wrote: > > > Date: Tue, 27 Apr 2004 11:42:33 +0200 > > From: Dave Neary <[EMAIL PROTECTED]> > > To: Carol Spears <[EMAIL PROTECTED]> > > Cc: GIMPDev <[EMAIL PROTECTED]> > > Subject: Re: [Gimp-developer] Image Info Dialog > > > > > > Hi, > > > > Carol Spears wrote: > > > since day one with the gimp, everytime i want to get the info dialog i > > > first search the Image Menu. my reasoning is "Image -->Info". i am > > > really not thinking of viewing anything, more like knowing > > I always though of 'File, Properties' (or 'File, Get Info' because there > is lots of kinds of file metadata, not specifcally related to the image > drawable. > i can see the logic of "File -->Info" i just never thought that way myself. i always want "Image Info", and the truth is, this dialog is so limited that it is still quicker to get the scale tool and pop up the scale dialog to get the width and height information which is usually what i am looking for. crap, i am working so much on web pages with my wysmythingie (mozilla) that it is actually (truthfully) quicker to right click on the image and load that into the web browser for the height and width information. okay, enough ranting. View -->Info makes a certain amount of sense -- but if it were a real dialog, it would be considered rude. at least in my area of the globe. > > Out of interest, are there other menu items that people would like to see > > elsewhere? This is not very difficult to do, but there has not (yet) been a > another one that i stop and think about is the Layers -->Transparency -->Add Alpha Channel. while it is true that it only works on one layer at a time, it is also true that there is only one layer for it to work on. you could have it run from Image Menu or from the Layers Dialog or from the Layers Menu and have it add transparency to the only layer (the background layer) that doesnt have it. it would make more sense to me to keep it in Layers -->Transparency if there were a way to remove it. and there is not a real easy way to make that bottom layer non-alpha again is there. almost everything else has a way to "undo" it, how come this is different? > I very much want menus in other places. > I filed this bug less than two weeks ago and it was rejected. > http://bugzilla.gnome.org/show_bug.cgi?id=140439 > > I'm convinced that there will always be people who want menus in different > places and that runtime customizable menus will eventually be needed. > (It doesn't seem possible to have menus that will be comfortable for > longterm Gimp, Adobe Photoshop, Corel Painter or Macromedia Fireworks > users). > I have for the most part only used TheGIMP and i am having problems with the logic of the one forever (Image -->Info). > If the improvements to Script-Fu allow scripts to exactly place menu items > (this seemed to be part of the plan) and assign shortcuts (but this wasn't > mentioned) I will at least be able to use scripts to put some features > exactly where I would like them to be. (It doesn't seem to be posible to > use Script-Fu to add seperators either, I just get a menu item labelled > ---). > Well, I would have never even thought that you could perhaps easily move the menu entries around until i started to work with the scripts. with the script and plug-in registry, you can make new menu entries and submenus -- it is cool, actually. the first time one of my scripts showed up in this insanely nested menu entry i was proud. then i fixed it. then, as you install other scripts, you an actually see little "Order" wars going on. once gimp-perl is installed this menu called "Render" will show up in Xtns and in gimp-1.2 it was quicker to have people check the menus than to get them to verify that perl was indeed installed. some of the new menus that show up make sense from different points of view. also, there are somedays when i need to know if i am working with python or working with perl. but there are other days that i need to actually use the gimp to work on images and dont care what the freaking language the plug-in was written it. who cares? but then on the other hand, i would want the menus to be how i see them. i had a long talk about my cross stitch plug-in and where it should fall with one of the seasoned old guys. his suggestion was Filters -->Render and i thought Filters -->Map. i was right. > > proposition on where to put menu entries. > > ... so many things I'd like to mover around I wont even start to list > them. > heck, i would rather read about that than baby porn. ikes. carol ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Image Info Dialog
On Tue, 27 Apr 2004, Dave Neary wrote: > Date: Tue, 27 Apr 2004 11:42:33 +0200 > From: Dave Neary <[EMAIL PROTECTED]> > To: Carol Spears <[EMAIL PROTECTED]> > Cc: GIMPDev <[EMAIL PROTECTED]> > Subject: Re: [Gimp-developer] Image Info Dialog > > > Hi, > > Carol Spears wrote: > > since day one with the gimp, everytime i want to get the info dialog i > > first search the Image Menu. my reasoning is "Image -->Info". i am > > really not thinking of viewing anything, more like knowing I always though of 'File, Properties' (or 'File, Get Info' because there is lots of kinds of file metadata, not specifcally related to the image drawable. > This is a reasonable suggestion. > > Out of interest, are there other menu items that people would like to see > elsewhere? This is not very difficult to do, but there has not (yet) been a I very much want menus in other places. I filed this bug less than two weeks ago and it was rejected. http://bugzilla.gnome.org/show_bug.cgi?id=140439 I'm convinced that there will always be people who want menus in different places and that runtime customizable menus will eventually be needed. (It doesn't seem possible to have menus that will be comfortable for longterm Gimp, Adobe Photoshop, Corel Painter or Macromedia Fireworks users). If the improvements to Script-Fu allow scripts to exactly place menu items (this seemed to be part of the plan) and assign shortcuts (but this wasn't mentioned) I will at least be able to use scripts to put some features exactly where I would like them to be. (It doesn't seem to be posible to use Script-Fu to add seperators either, I just get a menu item labelled ---). > proposition on where to put menu entries. ... so many things I'd like to mover around I wont even start to list them. - Alan ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Image Info Dialog
Hi, Carol Spears wrote: > is it impossible to have it show up in both menu locations? No, not at all. You register the same callback twice for two different menu locations. Cheers, Dave. -- David Neary, Lyon, France E-Mail: [EMAIL PROTECTED] ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Image Info Dialog
On Tue, Apr 27, 2004 at 11:42:33AM +0200, Dave Neary wrote: > > No, not really... the menu entries are all defined in app/gui/image-menu.c > and for consistency there are files containing the callbacks (the functions > called when you select a menu item) for each submenu in name>-commands.[ch] (so, for example, the info window calback is in > view-commands.c). > is it impossible to have it show up in both menu locations? carol ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Image Info Dialog
Hi, Dave Neary wrote: the menu entries are all defined in app/gui/image-menu.c In 2.1, there is a file menu/image-menu.xml which defines the menu structure, which makes it even easier to change menu locations than before. Here's a quick, untested patch against the 2.0 branch that changes the placement of that menu. I should have at least *compiled* with the patch, I missed a line and this patch has a syntax error - updated patch applied. Cheers, Dave. -- Dave Neary [EMAIL PROTECTED] ? menu_change.patch Index: app/gui/image-commands.c === RCS file: /cvs/gnome/gimp/app/gui/Attic/image-commands.c,v retrieving revision 1.51 diff -u -r1.51 image-commands.c --- app/gui/image-commands.c31 Jan 2004 20:23:52 - 1.51 +++ app/gui/image-commands.c27 Apr 2004 12:19:59 - @@ -339,6 +339,34 @@ } +void +image_info_window_cmd_callback (GtkWidget *widget, +gpointer data) +{ + GimpDisplay *gdisp; + GimpDisplayShell *shell; + return_if_no_display (gdisp, data); + + shell = GIMP_DISPLAY_SHELL (gdisp->shell); + + if (GIMP_GUI_CONFIG (gdisp->gimage->gimp->config)->info_window_per_display) +{ + if (! shell->info_dialog) + shell->info_dialog = info_window_create (gdisp); + + /* To update the fields of the info window for the first time. * + * It's no use updating it in info_window_create() because the * + * pointer of the info window is not present in the shell yet. */ + info_window_update (gdisp); + + info_dialog_present (shell->info_dialog); +} + else +{ + info_window_follow_auto (gdisp->gimage->gimp); +} +} + // /* The layer merge dialog */ // Index: app/gui/image-commands.h === RCS file: /cvs/gnome/gimp/app/gui/Attic/image-commands.h,v retrieving revision 1.8 diff -u -r1.8 image-commands.h --- app/gui/image-commands.h8 Nov 2003 15:29:47 - 1.8 +++ app/gui/image-commands.h27 Apr 2004 12:19:59 - @@ -54,5 +54,7 @@ void image_configure_grid_cmd_callback(GtkWidget *widget, gpointer data); +void image_info_window_cmd_callback (GtkWidget *widget, + gpointer data); #endif /* __IMAGE_COMMANDS_H__ */ Index: app/gui/image-menu.c === RCS file: /cvs/gnome/gimp/app/gui/image-menu.c,v retrieving revision 1.103 diff -u -r1.103 image-menu.c --- app/gui/image-menu.c20 Mar 2004 16:14:48 - 1.103 +++ app/gui/image-menu.c27 Apr 2004 12:19:59 - @@ -431,11 +431,6 @@ MENU_SEPARATOR ("/View/---"), - { { N_("/View/_Info Window"), "I", - view_info_window_cmd_callback, 0, - "", GIMP_STOCK_INFO }, -NULL, -GIMP_HELP_INFO_DIALOG, NULL }, { { N_("/View/Na_vigation Window"), "N", view_navigation_window_cmd_callback, 0, "", GIMP_STOCK_NAVIGATION }, @@ -612,6 +607,12 @@ "", GIMP_STOCK_GRID }, NULL, GIMP_HELP_IMAGE_GRID, NULL }, + + { { N_("/Image/_Info Window"), "I", + image_info_window_cmd_callback, 0, + "", GIMP_STOCK_INFO }, +NULL, +GIMP_HELP_INFO_DIALOG, NULL }, /* /Layer */ Index: app/gui/view-commands.c === RCS file: /cvs/gnome/gimp/app/gui/Attic/view-commands.c,v retrieving revision 1.42 diff -u -r1.42 view-commands.c --- app/gui/view-commands.c 31 Jan 2004 20:23:53 - 1.42 +++ app/gui/view-commands.c 27 Apr 2004 12:20:03 - @@ -159,34 +159,6 @@ } void -view_info_window_cmd_callback (GtkWidget *widget, - gpointer data) -{ - GimpDisplay *gdisp; - GimpDisplayShell *shell; - return_if_no_display (gdisp, data); - - shell = GIMP_DISPLAY_SHELL (gdisp->shell); - - if (GIMP_GUI_CONFIG (gdisp->gimage->gimp->config)->info_window_per_display) -{ - if (! shell->info_dialog) - shell->info_dialog = info_window_create (gdisp); - - /* To update the fields of the info window for the first time. * - * It's no use updating it in info_window_create() because the * - * pointer of the info window is not present in the shell yet. */ - info_window_update (gdisp); - - info_dialog_present (shell->info_dialog); -} - else -{ - info_window_follow_auto (gdisp->gimage->gimp); -} -} - -void view_navigation_window_cmd_callback (GtkWidget *widget, gpointer data) { Index: app/gui/view-commands.h === RCS file: /cvs/gnome/gimp/app/gui/Attic/view-commands.h,v retrieving revision 1.13 diff -u -r1.13 view-commands.h --- app/gui/view-commands.h 29 Jan 2004 22:22:22 -
Re: [Gimp-developer] Image Info Dialog
Hi, Carol Spears wrote: since day one with the gimp, everytime i want to get the info dialog i first search the Image Menu. my reasoning is "Image -->Info". i am really not thinking of viewing anything, more like knowing This is a reasonable suggestion. Out of interest, are there other menu items that people would like to see elsewhere? This is not very difficult to do, but there has not (yet) been a proposition on where to put menu entries. is it easy to change the info plugin to show also in the Image Menu? No, not really... the menu entries are all defined in app/gui/image-menu.c and for consistency there are files containing the callbacks (the functions called when you select a menu item) for each submenu in -commands.[ch] (so, for example, the info window calback is in view-commands.c). Here's a quick, untested patch against the 2.0 branch that changes the placement of that menu. This has probably changed in HEAD since mitch's work converting menus to be GtkAction based. Cheers, Dave. -- Dave Neary [EMAIL PROTECTED] ? menu_change.patch Index: app/gui/image-commands.c === RCS file: /cvs/gnome/gimp/app/gui/Attic/image-commands.c,v retrieving revision 1.51 diff -u -r1.51 image-commands.c --- app/gui/image-commands.c31 Jan 2004 20:23:52 - 1.51 +++ app/gui/image-commands.c27 Apr 2004 09:35:40 - @@ -339,6 +339,34 @@ } +void +image_info_window_cmd_callback (GtkWidget *widget, +gpointer data) +{ + GimpDisplay *gdisp; + GimpDisplayShell *shell; + return_if_no_display (gdisp, data); + + shell = GIMP_DISPLAY_SHELL (gdisp->shell); + + if (GIMP_GUI_CONFIG (gdisp->gimage->gimp->config)->info_window_per_display) +{ + if (! shell->info_dialog) + shell->info_dialog = info_window_create (gdisp); + + /* To update the fields of the info window for the first time. * + * It's no use updating it in info_window_create() because the * + * pointer of the info window is not present in the shell yet. */ + info_window_update (gdisp); + + info_dialog_present (shell->info_dialog); +} + else +{ + info_window_follow_auto (gdisp->gimage->gimp); +} +} + // /* The layer merge dialog */ // Index: app/gui/image-commands.h === RCS file: /cvs/gnome/gimp/app/gui/Attic/image-commands.h,v retrieving revision 1.8 diff -u -r1.8 image-commands.h --- app/gui/image-commands.h8 Nov 2003 15:29:47 - 1.8 +++ app/gui/image-commands.h27 Apr 2004 09:35:40 - @@ -54,5 +54,7 @@ void image_configure_grid_cmd_callback(GtkWidget *widget, gpointer data); +void image_info_window_cmd_callback (GtkWidget *widget, + gpointer data); #endif /* __IMAGE_COMMANDS_H__ */ Index: app/gui/image-menu.c === RCS file: /cvs/gnome/gimp/app/gui/image-menu.c,v retrieving revision 1.103 diff -u -r1.103 image-menu.c --- app/gui/image-menu.c20 Mar 2004 16:14:48 - 1.103 +++ app/gui/image-menu.c27 Apr 2004 09:35:40 - @@ -431,10 +431,6 @@ MENU_SEPARATOR ("/View/---"), - { { N_("/View/_Info Window"), "I", - view_info_window_cmd_callback, 0, - "", GIMP_STOCK_INFO }, -NULL, GIMP_HELP_INFO_DIALOG, NULL }, { { N_("/View/Na_vigation Window"), "N", view_navigation_window_cmd_callback, 0, @@ -612,6 +608,11 @@ "", GIMP_STOCK_GRID }, NULL, GIMP_HELP_IMAGE_GRID, NULL }, + + { { N_("/Image/_Info Window"), "I", + image_info_window_cmd_callback, 0, + "", GIMP_STOCK_INFO }, +NULL, /* /Layer */ Index: app/gui/view-commands.c === RCS file: /cvs/gnome/gimp/app/gui/Attic/view-commands.c,v retrieving revision 1.42 diff -u -r1.42 view-commands.c --- app/gui/view-commands.c 31 Jan 2004 20:23:53 - 1.42 +++ app/gui/view-commands.c 27 Apr 2004 09:35:40 - @@ -159,34 +159,6 @@ } void -view_info_window_cmd_callback (GtkWidget *widget, - gpointer data) -{ - GimpDisplay *gdisp; - GimpDisplayShell *shell; - return_if_no_display (gdisp, data); - - shell = GIMP_DISPLAY_SHELL (gdisp->shell); - - if (GIMP_GUI_CONFIG (gdisp->gimage->gimp->config)->info_window_per_display) -{ - if (! shell->info_dialog) - shell->info_dialog = info_window_create (gdisp); - - /* To update the fields of the info window for the first time. * - * It's no use updating it in info_window_create() because the * - * pointer of the info window is not present in the shell yet. */ - info_window_update (gdisp); - - info_dialog_present (shell->info_dia