---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5077/#review7756
---
Overall, looks great. Can you address the questions/comments and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5077/#review7772
---
Ship it!
+1, thanks Sebastian! I'm assuming it also passes 'mvn
[
https://issues.apache.org/jira/browse/GIRAPH-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271245#comment-13271245
]
Avery Ching commented on GIRAPH-37:
---
Thanks Claudio.
Here are more results with a scaled
[
https://issues.apache.org/jira/browse/GIRAPH-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching resolved GIRAPH-37.
---
Resolution: Fixed
Hudson is successful, closing.
Implement Netty-backed IPC
Avery Ching created GIRAPH-189:
--
Summary: Synchronization on Map values should be in a thread safe
object
Key: GIRAPH-189
URL: https://issues.apache.org/jira/browse/GIRAPH-189
Project: Giraph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5077/#review7745
---
Hey, Sebastian, overall looks good. If no one else gets to it, I'll
Avery Ching created GIRAPH-190:
--
Summary: Create GiraphConf extends Configuration
Key: GIRAPH-190
URL: https://issues.apache.org/jira/browse/GIRAPH-190
Project: Giraph
Issue Type: Improvement
+1, sounds good to me. I also would like to have a rotating PMC chair.
Avery
On 5/4/12 10:26 AM, Jakob Homan wrote:
Both suggestions sound reasonable to me. +1 on the current resolution.
On Fri, May 4, 2012 at 10:23 AM, Owen O'Malleyomal...@apache.org wrote:
On Fri, May 4, 2012 at 10:09
[
https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13265155#comment-13265155
]
Avery Ching commented on GIRAPH-153:
I'll take a look, sorry for the delay
[
https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13265205#comment-13265205
]
Avery Ching commented on GIRAPH-153:
Is this a fresh checkout? We shouldn't have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4801/
---
(Updated 2012-04-30 23:54:55.758151)
Review request for giraph.
Changes
*
- Avery
On 2012-04-30 23:54:55, Avery Ching wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4801/
---
(Updated 2012-04
[
https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261906#comment-13261906
]
Avery Ching commented on GIRAPH-185:
I agree that a benchmark should be done, although
On 2012-04-24 20:53:33, Avery Ching wrote:
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java,
lines 776-777
https://reviews.apache.org/r/4852/diff/1/?file=104059#file104059line776
Bo, I'm a little leery about
On 2012-04-24 20:53:33, Avery Ching wrote:
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java,
lines 776-777
https://reviews.apache.org/r/4852/diff/1/?file=104059#file104059line776
Bo, I'm a little leery about
[
https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259412#comment-13259412
]
Avery Ching commented on GIRAPH-185:
Thanks for looking at this Bo. I have a couple
[
https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259841#comment-13259841
]
Avery Ching commented on GIRAPH-185:
Since we only allocate one ConcurrentHashMap per
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4801/
---
Review request for giraph.
Summary
---
Brian's patch for GIRAPH-153.
lines
http://svn.apache.org/repos/asf/incubator/giraph/trunk/pom.xml
https://reviews.apache.org/r/4801/#comment15592
Would be great to get Apache Rat working with giraph-formats-contrib so
that we don't forget any licenses here.
- Avery
On 2012-04-19 07:27:14, Avery Ching wrote
[
https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257343#comment-13257343
]
Avery Ching commented on GIRAPH-153:
Okay, so it's still tonight (even though it is 12
[
https://issues.apache.org/jira/browse/GIRAPH-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256246#comment-13256246
]
Avery Ching commented on GIRAPH-180:
This is a good idea. The only question I would
[
https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256767#comment-13256767
]
Avery Ching commented on GIRAPH-153:
I think hosting the submodule on github would
[
https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256856#comment-13256856
]
Avery Ching commented on GIRAPH-153:
I'll take a look at this patch tonight Brian
[
https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching reassigned GIRAPH-185:
--
Assignee: Bo Wang
Improve concurrency of putMsg / putMsgList
[
https://issues.apache.org/jira/browse/GIRAPH-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching reassigned GIRAPH-186:
--
Assignee: Bo Wang
Go for it Bo!
Improve concurrency of putVertexList
[
https://issues.apache.org/jira/browse/GIRAPH-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254890#comment-13254890
]
Avery Ching commented on GIRAPH-181:
+1, committed.
Add Hadoop 1.0
[
https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254152#comment-13254152
]
Avery Ching commented on GIRAPH-184:
Thanks!
Upgrade to junit4
[
https://issues.apache.org/jira/browse/GIRAPH-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253488#comment-13253488
]
Avery Ching commented on GIRAPH-183:
+1. This is great stuff Claudio
[
https://issues.apache.org/jira/browse/GIRAPH-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253655#comment-13253655
]
Avery Ching commented on GIRAPH-183:
Are the problems related to GIRAPH-168
Sounds good to me.
Avery
On 4/12/12 11:06 AM, Jakob Homan wrote:
+1. It's time to fly the nest.
On Wed, Apr 11, 2012 at 11:05 PM, Mattmann, Chris A (388J)
chris.a.mattm...@jpl.nasa.gov wrote:
[moving to giraph-dev@ and dropping general@incubator]
Hey Owen,
On Apr 11, 2012, at 9:44 PM,
[
https://issues.apache.org/jira/browse/GIRAPH-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250476#comment-13250476
]
Avery Ching commented on GIRAPH-168:
Eugene, I committed your patch, which passed 'mvn
[
https://issues.apache.org/jira/browse/GIRAPH-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250874#comment-13250874
]
Avery Ching commented on GIRAPH-168:
I can modify Hudson to do execute the commands
[
https://issues.apache.org/jira/browse/GIRAPH-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250947#comment-13250947
]
Avery Ching commented on GIRAPH-168:
I would ignore the facebook one for now (we can
[
https://issues.apache.org/jira/browse/GIRAPH-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251180#comment-13251180
]
Avery Ching commented on GIRAPH-182:
Agreed, would you like to work on it Pradeep
[
https://issues.apache.org/jira/browse/GIRAPH-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching reassigned GIRAPH-182:
--
Assignee: Pradeep Gollakota
Great!
Provide SequenceFileVertexOutputFormat
[
https://issues.apache.org/jira/browse/GIRAPH-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249702#comment-13249702
]
Avery Ching commented on GIRAPH-168:
Nice that you got it working with all
[
https://issues.apache.org/jira/browse/GIRAPH-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250224#comment-13250224
]
Avery Ching commented on GIRAPH-168:
+1. Given this is a somewhat large change, I'll
[
https://issues.apache.org/jira/browse/GIRAPH-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248175#comment-13248175
]
Avery Ching commented on GIRAPH-171:
+1 Argh, it is inconsistent with the counter
Dan, you're definitely right that this has been mentioned a few times.
The multigraph issue is one part of it, but a helper VertexInputFormat
(and maybe VertexOutputFormat) would certainly still help as you
mention. Can you please open a JIRA (and help if you have time)?
Avery
On 4/5/12
Here is a related JIRA https://issues.apache.org/jira/browse/GIRAPH-155
Avery
On 4/5/12 9:45 AM, Paolo Castagna wrote:
Hi Dan,
I have not an answer to your questions/observations yet.
However, I suspect N-Triples | N-Quads might not be the best option for
something like Giraph. Something more
[
https://issues.apache.org/jira/browse/GIRAPH-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246561#comment-13246561
]
Avery Ching commented on GIRAPH-77:
---
Paolo, would you be interested in working
I don't use Whirr...I haven't heard it mentioned on this forum yet. Anyone?
Avery
On 4/4/12 9:30 PM, Paolo Castagna wrote:
Hi,
seen this?
WHIRR-530 - Add Giraph as a service
https://issues.apache.org/jira/browse/WHIRR-530
This could be quite useful for users who want to give Giraph a
[
https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245480#comment-13245480
]
Avery Ching commented on GIRAPH-153:
From what you've described, sounds good to me
[
https://issues.apache.org/jira/browse/GIRAPH-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245484#comment-13245484
]
Avery Ching commented on GIRAPH-141:
Yes, I also think this is an important feature
[
https://issues.apache.org/jira/browse/GIRAPH-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245488#comment-13245488
]
Avery Ching commented on GIRAPH-169:
This is a simple case. I'll try and see if I can
Thanks Jakob.
Avery
On 4/2/12 4:31 PM, Jakob Homan wrote:
I'll do it tonight.
On Mon, Apr 2, 2012 at 4:14 PM, Owen O'Malleyomal...@apache.org wrote:
All,
We need a status report for the last quarter by Wednesday. Anyone
want to take the first shot at it?
-- Owen
Looks good to me as well.
Avery
On 4/2/12 10:17 PM, Owen O'Malley wrote:
That looks great, Jakob. I've put that into the wiki for now until we
have further edits.
-- Owen
[
https://issues.apache.org/jira/browse/GIRAPH-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240234#comment-13240234
]
Avery Ching commented on GIRAPH-169:
Looks like the worker log got cut off? Also
Dionysis,
I'm a little confused. The below message seems to explain the problem with
Input path does not exist: hdfs://localhost:9000/x
Am I missing something?
Avery
On 3/27/12 4:04 AM, Dionysis Logothetis wrote:
Hi all,
I was running one of the example apps and I accidentally
[
https://issues.apache.org/jira/browse/GIRAPH-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching resolved GIRAPH-144.
Resolution: Fixed
Hudson says success. Rebasing this one was a bit harder than usual
[
https://issues.apache.org/jira/browse/GIRAPH-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240112#comment-13240112
]
Avery Ching commented on GIRAPH-169:
How many task trackers do you have?
Are you
[
https://issues.apache.org/jira/browse/GIRAPH-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240161#comment-13240161
]
Avery Ching commented on GIRAPH-169:
Do you have the logs of the workers? I'd like
[
https://issues.apache.org/jira/browse/GIRAPH-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237909#comment-13237909
]
Avery Ching commented on GIRAPH-159:
+1. I left out your GiraphRunner changes since
[
https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237951#comment-13237951
]
Avery Ching commented on GIRAPH-153:
34 MB is huge. Can we do something like make
[
https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237468#comment-13237468
]
Avery Ching commented on GIRAPH-153:
Brian, could you make it a single patch for us
[
https://issues.apache.org/jira/browse/GIRAPH-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237597#comment-13237597
]
Avery Ching commented on GIRAPH-144:
Ping, anyone? I'd like to close this out, one
[
https://issues.apache.org/jira/browse/GIRAPH-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236414#comment-13236414
]
Avery Ching commented on GIRAPH-167:
+1, Commited, thanks for fixing
[
https://issues.apache.org/jira/browse/GIRAPH-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234139#comment-13234139
]
Avery Ching commented on GIRAPH-161:
+1. There are 5 checkstyle violations from
[
https://issues.apache.org/jira/browse/GIRAPH-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234164#comment-13234164
]
Avery Ching commented on GIRAPH-162:
Looks good. +1. I'm committing
I agree with this approach, although munge is kinda hacky. It is easy
though. =)
Avery
On 3/20/12 5:52 PM, Eugene Koontz wrote:
Hi Giraphers,
I think it might be good to look at how we can add support for new
hadoop versions. Currently we have hadoop_facebook
[
https://issues.apache.org/jira/browse/GIRAPH-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234177#comment-13234177
]
Avery Ching commented on GIRAPH-159:
Brian, can you show me how to recreate this issue
[
https://issues.apache.org/jira/browse/GIRAPH-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234843#comment-13234843
]
Avery Ching commented on GIRAPH-164:
+1, thanks guys. Committing
[
https://issues.apache.org/jira/browse/GIRAPH-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232012#comment-13232012
]
Avery Ching commented on GIRAPH-154:
Nice work Zhiwei (+1), I verified it as well
[
https://issues.apache.org/jira/browse/GIRAPH-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232014#comment-13232014
]
Avery Ching commented on GIRAPH-156:
+1, looks good. It would be great if you could
[
https://issues.apache.org/jira/browse/GIRAPH-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching resolved GIRAPH-154.
Resolution: Fixed
Passed hudson, thanks again Zhiwei.
Worker ports
we could even copy a little more from there :)
Best,
Sebastian
[1] https://cwiki.apache.org/MAHOUT/how-to-contribute.html
On 14.03.2012 17:39, Avery Ching wrote:
Yes, that is thanks to Sebastian. We should probably make that another
confluence page though based on his notes. Anyone want to do
[
https://issues.apache.org/jira/browse/GIRAPH-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230942#comment-13230942
]
Avery Ching commented on GIRAPH-156:
I think this makes sense. Go
This would be great Eugene. So far, I don't know of any other JIRA to
do this, so go for it! Thanks for doing this.
Avery
On 3/15/12 3:39 PM, Eugene Koontz wrote:
Greetings fellow Giraphers,
I'm working on compiling Giraph with support for MRv2 (available
with Hadoop's 0.23 branch and
Hi Giraphers,
We have a submission for the 2012 Hadoop summit and part of deciding
whether it gets accepted is based on community voting. It would be
great to get more folks interested and involved in what is going on with
Giraph so please vote! Here's the link:
[
https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229042#comment-13229042
]
Avery Ching commented on GIRAPH-153:
Brian, this is an awesome contribution and a lot
Hi guys,
I just added a How to contribute page.
https://cwiki.apache.org/confluence/display/GIRAPH/How+to+Contribute
Please fix it if you have anything to add or I forgot something.
Thanks!
Avery
Yes, that is thanks to Sebastian. We should probably make that another
confluence page though based on his notes. Anyone want to do it? =)
Avery
On 3/14/12 7:43 AM, Benjamin Heitmann wrote:
On 14 Mar 2012, at 07:08, Avery Ching wrote:
I just added a How to contribute page.
https
[
https://issues.apache.org/jira/browse/GIRAPH-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224096#comment-13224096
]
Avery Ching commented on GIRAPH-144:
@Jakob, any more thoughts
Hi Timmy,
I don't know much about force directed layout, but it certainly sounds
like a very interesting application for Giraph. Keep us posted on your
progress and let us know how we can help.
Avery
On 3/6/12 8:34 AM, Claudio Martella wrote:
Hi,
I'm not definitely familiar with the
[
https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13217096#comment-13217096
]
Avery Ching commented on GIRAPH-85:
---
I just looked at your patch in Eclipse and see
[
https://issues.apache.org/jira/browse/GIRAPH-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216365#comment-13216365
]
Avery Ching commented on GIRAPH-87:
---
+1
Thanks Eli, I committed on your behalf
[
https://issues.apache.org/jira/browse/GIRAPH-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching resolved GIRAPH-132.
Resolution: Not A Problem
Thanks Eli, this was resolved in the massive checkstyle fix (GIRAPH-40
[
https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216047#comment-13216047
]
Avery Ching commented on GIRAPH-85:
---
please make sure it passes 'mvn verify' as well
[
https://issues.apache.org/jira/browse/GIRAPH-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching resolved GIRAPH-150.
Resolution: Fixed
Thanks Sebastian! Closing after hudson's approval
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209727#comment-13209727
]
Avery Ching commented on GIRAPH-40:
---
Can another committer please look at this as per
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209801#comment-13209801
]
Avery Ching commented on GIRAPH-40:
---
Thanks so much for the reviews Jakob and Sebastian
[
https://issues.apache.org/jira/browse/GIRAPH-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching updated GIRAPH-150:
---
Attachment: GIRAPH-150.patch
Use the job.getConfiguration() instead of getConf() or else the vertex
[
https://issues.apache.org/jira/browse/GIRAPH-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210025#comment-13210025
]
Avery Ching commented on GIRAPH-150:
By the way, here was the full stack trace
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching updated GIRAPH-40:
--
Attachment: GIRAPH-40.3.patch
Good suggestion, Jakob. I have addressed Jakob's comments by changing
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching updated GIRAPH-40:
--
Attachment: GIRAPH-40.patch
As promised, here is the full patch. Due to its massive size, I am
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207188#comment-13207188
]
Avery Ching commented on GIRAPH-40:
---
So for the first example, we need to follow
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207203#comment-13207203
]
Avery Ching commented on GIRAPH-40:
---
I'm not a checkstyle expert, but I don't think so. I
[
https://issues.apache.org/jira/browse/GIRAPH-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207211#comment-13207211
]
Avery Ching commented on GIRAPH-148:
+1.
giraph-site.xml needs
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206291#comment-13206291
]
Avery Ching commented on GIRAPH-40:
---
Thank you for the feedback Claudio. I'll continue
[
https://issues.apache.org/jira/browse/GIRAPH-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205598#comment-13205598
]
Avery Ching commented on GIRAPH-139:
+1
Looks good to me.
Change
Add Blueprints Tinkerpop support
Key: GIRAPH-147
URL: https://issues.apache.org/jira/browse/GIRAPH-147
Project: Giraph
Issue Type: New Feature
Reporter: Avery Ching
Priority: Minor
[
https://issues.apache.org/jira/browse/GIRAPH-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205947#comment-13205947
]
Avery Ching commented on GIRAPH-148:
Jakob, this header is formatted slightly
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205976#comment-13205976
]
Avery Ching commented on GIRAPH-40:
---
Here are some examples of one problem: Checkstyle
[
https://issues.apache.org/jira/browse/GIRAPH-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205992#comment-13205992
]
Avery Ching commented on GIRAPH-148:
It will with checkstyle (see GIRAPH-40). We
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3823/
---
Review request for giraph.
Summary
---
GiraphJob uses composition with Job
[
https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205047#comment-13205047
]
Avery Ching commented on GIRAPH-142:
Looks fine, could we just add a check somewhere
[
https://issues.apache.org/jira/browse/GIRAPH-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203900#comment-13203900
]
Avery Ching commented on GIRAPH-139:
I agree the main() and run() code should
[
https://issues.apache.org/jira/browse/GIRAPH-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203967#comment-13203967
]
Avery Ching commented on GIRAPH-139:
sounds good to me.
Change
[
https://issues.apache.org/jira/browse/GIRAPH-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204213#comment-13204213
]
Avery Ching commented on GIRAPH-144:
I'm working on this, should have a fix by tonight
[
https://issues.apache.org/jira/browse/GIRAPH-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Avery Ching reassigned GIRAPH-144:
--
Assignee: Avery Ching
GiraphJob should not extend Job (users should not be able to call
1 - 100 of 319 matches
Mail list logo
