[jira] [Commented] (GIRAPH-43) GiraphJob: Counter Limit is not set

[ https://issues.apache.org/jira/browse/GIRAPH-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118635#comment-13118635 ] Jakob Homan commented on GIRAPH-43: --- Thinking about this some more, 120 is a pretty low

[jira] [Commented] (GIRAPH-49) Create automated multi-build test

[ https://issues.apache.org/jira/browse/GIRAPH-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123307#comment-13123307 ] Jakob Homan commented on GIRAPH-49: --- If we can't get to it, I'm not sure it belongs in

[jira] [Commented] (GIRAPH-52) There should be a scheme to limit the counter

[ https://issues.apache.org/jira/browse/GIRAPH-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127235#comment-13127235 ] Jakob Homan commented on GIRAPH-52: --- If you'd like to come up with a way around the

[jira] [Commented] (GIRAPH-52) There should be a scheme to limit the counter

[ https://issues.apache.org/jira/browse/GIRAPH-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127239#comment-13127239 ] Jakob Homan commented on GIRAPH-52: --- above, last as in final, not previous.

[jira] [Commented] (GIRAPH-56) Create a CSV TextOutputFormat

[ https://issues.apache.org/jira/browse/GIRAPH-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13135553#comment-13135553 ] Jakob Homan commented on GIRAPH-56: --- I'm thinking along the lines of Arun's comment, as

[jira] [Commented] (GIRAPH-13) Port Giraph to YARN

[ https://issues.apache.org/jira/browse/GIRAPH-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13135554#comment-13135554 ] Jakob Homan commented on GIRAPH-13: --- This is coming along, but there are a lot of pre-req

[jira] [Commented] (GIRAPH-66) Add presentations section to website

[ https://issues.apache.org/jira/browse/GIRAPH-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136505#comment-13136505 ] Jakob Homan commented on GIRAPH-66: --- No problem. Do you want to upload the HW to

[jira] [Commented] (GIRAPH-66) Add presentations section to website

[ https://issues.apache.org/jira/browse/GIRAPH-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136548#comment-13136548 ] Jakob Homan commented on GIRAPH-66: --- bq. Seems like a confluence wiki would be a better

[jira] [Commented] (GIRAPH-66) Add presentations section to website

[ https://issues.apache.org/jira/browse/GIRAPH-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136588#comment-13136588 ] Jakob Homan commented on GIRAPH-66: --- bq. We don't need to make a release to make the site

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142573#comment-13142573 ] Jakob Homan commented on GIRAPH-36: --- Great work, Jake. One thing I notice while reading

[jira] [Commented] (GIRAPH-64) Create VertexRunner to make it easier to run users' computations

[ https://issues.apache.org/jira/browse/GIRAPH-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142608#comment-13142608 ] Jakob Homan commented on GIRAPH-64: --- Not that I know of. I'm allergic to rb, but I've

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142615#comment-13142615 ] Jakob Homan commented on GIRAPH-36: --- bq. Can GIRAPH-47 be a start for what you have in

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

[ https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145133#comment-13145133 ] Jakob Homan commented on GIRAPH-47: --- This looks good but I have some comments when not

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

[ https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146340#comment-13146340 ] Jakob Homan commented on GIRAPH-47: --- Avery, can attach the final diff that you committed

[jira] [Commented] (GIRAPH-63) Typo in PageRankBenchmark

[ https://issues.apache.org/jira/browse/GIRAPH-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13148592#comment-13148592 ] Jakob Homan commented on GIRAPH-63: --- Ah, thanks. Actually, for some reason, JIRA hides

[jira] [Commented] (GIRAPH-63) Typo in PageRankBenchmark

[ https://issues.apache.org/jira/browse/GIRAPH-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13148598#comment-13148598 ] Jakob Homan commented on GIRAPH-63: --- Perfect, thanks! +1 on the patch. Will commit

[jira] [Commented] (GIRAPH-75) Create sections on how to get involved and how to generate patches on website

[ https://issues.apache.org/jira/browse/GIRAPH-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149431#comment-13149431 ] Jakob Homan commented on GIRAPH-75: --- bq. How about making a separate page for these

[jira] [Commented] (GIRAPH-51) Provide unit testing tool for Giraph algorithms

[ https://issues.apache.org/jira/browse/GIRAPH-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149805#comment-13149805 ] Jakob Homan commented on GIRAPH-51: --- Looks great. A few comments: * It may make sense to

[jira] [Commented] (GIRAPH-11) Improve the graph distribution of Giraph

[ https://issues.apache.org/jira/browse/GIRAPH-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150095#comment-13150095 ] Jakob Homan commented on GIRAPH-11: --- I think this is ready to go. Avery, just out of

[jira] [Commented] (GIRAPH-11) Improve the graph distribution of Giraph

[ https://issues.apache.org/jira/browse/GIRAPH-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150099#comment-13150099 ] Jakob Homan commented on GIRAPH-11: --- +1 Improve the graph distribution

[jira] [Commented] (GIRAPH-87) Simplify boolean expression in BspService::checkpointFrequencyMet

[ https://issues.apache.org/jira/browse/GIRAPH-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150679#comment-13150679 ] Jakob Homan commented on GIRAPH-87: --- correct. This optimization would be to keep the

[jira] [Commented] (GIRAPH-85) Simplify return expression in RPCCommunications::getRPCProxy

[ https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150683#comment-13150683 ] Jakob Homan commented on GIRAPH-85: --- For this newbie issue the idea is just to simplify

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150732#comment-13150732 ] Jakob Homan commented on GIRAPH-45: --- Yeah, this would involve changing the save all the

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150755#comment-13150755 ] Jakob Homan commented on GIRAPH-45: --- @Jake I'm suggesting that messages should only be

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150757#comment-13150757 ] Jakob Homan commented on GIRAPH-45: --- bq. I'm not sure whether sending messages in a

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150847#comment-13150847 ] Jakob Homan commented on GIRAPH-45: --- yes, it does. I'm trying to learn from the mistakes

[jira] [Commented] (GIRAPH-88) Message count not updated properly after GIRAPH-11

[ https://issues.apache.org/jira/browse/GIRAPH-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150858#comment-13150858 ] Jakob Homan commented on GIRAPH-88: --- +1 Message count not updated

[jira] [Commented] (GIRAPH-91) Large-memory improvements (Memory reduced vertex implementation, fast failure, added settings)

[ https://issues.apache.org/jira/browse/GIRAPH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151600#comment-13151600 ] Jakob Homan commented on GIRAPH-91: --- can you attach the patch to the jira, for non-rb

[jira] [Commented] (GIRAPH-93) Hive input / output format

[ https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151805#comment-13151805 ] Jakob Homan commented on GIRAPH-93: --- Do you mean RCFile specifically? Hive can handle

[jira] [Commented] (GIRAPH-76) Refactor worker logic from GraphMapper

[ https://issues.apache.org/jira/browse/GIRAPH-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151860#comment-13151860 ] Jakob Homan commented on GIRAPH-76: --- I've not. Please go for it.

[jira] [Commented] (GIRAPH-86) Simplify boolean expressions in ZooKeeperExt::createExt

[ https://issues.apache.org/jira/browse/GIRAPH-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152328#comment-13152328 ] Jakob Homan commented on GIRAPH-86: --- +1. I've committed this. Not sure why you ended up

[jira] [Commented] (GIRAPH-77) Coordinator should expose a web interface with progress, vertex region assignments, etc.

[ https://issues.apache.org/jira/browse/GIRAPH-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152348#comment-13152348 ] Jakob Homan commented on GIRAPH-77: --- I've got a bit of code, but enough to block

[jira] [Commented] (GIRAPH-83) Is Vertex correct yet?

[ https://issues.apache.org/jira/browse/GIRAPH-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152356#comment-13152356 ] Jakob Homan commented on GIRAPH-83: --- bq. I think it should probably actually be called

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152360#comment-13152360 ] Jakob Homan commented on GIRAPH-45: --- On a side note, is it worth considering messages to

[jira] [Commented] (GIRAPH-83) Is Vertex correct yet?

[ https://issues.apache.org/jira/browse/GIRAPH-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152383#comment-13152383 ] Jakob Homan commented on GIRAPH-83: --- I'm saying we should be responsible for maintaining

[jira] [Commented] (GIRAPH-77) Coordinator should expose a web interface with progress, vertex region assignments, etc.

[ https://issues.apache.org/jira/browse/GIRAPH-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152386#comment-13152386 ] Jakob Homan commented on GIRAPH-77: --- s/enough/not enough/g. oy.

[jira] [Commented] (GIRAPH-98) Add Claudio Martella to site

[ https://issues.apache.org/jira/browse/GIRAPH-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152967#comment-13152967 ] Jakob Homan commented on GIRAPH-98: --- Cool. Actually, we don't need to do the instructions

[jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader

[ https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153951#comment-13153951 ] Jakob Homan commented on GIRAPH-84: --- The patch *must* be attached to the JIRA. We need

[jira] [Commented] (GIRAPH-99) Make AdjacencyListVertexReader and its constructor public

[ https://issues.apache.org/jira/browse/GIRAPH-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155234#comment-13155234 ] Jakob Homan commented on GIRAPH-99: --- +1. Looks good. Make

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158734#comment-13158734 ] Jakob Homan commented on GIRAPH-45: --- It's certainly an intriguing idea to go with

[jira] [Commented] (GIRAPH-51) Provide unit testing tool for Giraph algorithms

[ https://issues.apache.org/jira/browse/GIRAPH-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158743#comment-13158743 ] Jakob Homan commented on GIRAPH-51: --- +1. Provide unit testing tool for

[jira] [Commented] (GIRAPH-100) Data input sampling and testing improvements

[ https://issues.apache.org/jira/browse/GIRAPH-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161213#comment-13161213 ] Jakob Homan commented on GIRAPH-100: Please avoid formatting changes as part of code

[jira] [Commented] (GIRAPH-100) Data input sampling and testing improvements

[ https://issues.apache.org/jira/browse/GIRAPH-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161236#comment-13161236 ] Jakob Homan commented on GIRAPH-100: bq. Which exceptions are you referring to?

[jira] [Commented] (GIRAPH-100) Data input sampling and testing improvements

[ https://issues.apache.org/jira/browse/GIRAPH-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161264#comment-13161264 ] Jakob Homan commented on GIRAPH-100: bq. In the future, I'll file separate issues for

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170605#comment-13170605 ] Jakob Homan commented on GIRAPH-57: --- Can we post the final patch, along with the I give

[jira] [Commented] (GIRAPH-111) Refactor I/O to be independent of Map/Reduce

[ https://issues.apache.org/jira/browse/GIRAPH-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173537#comment-13173537 ] Jakob Homan commented on GIRAPH-111: bq. I'm not clear on why this is necessary. I

[jira] [Commented] (GIRAPH-110) Add guide to setup the enviroment for running the unit tests in a pseudo-distributed hadoop instance

[ https://issues.apache.org/jira/browse/GIRAPH-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173631#comment-13173631 ] Jakob Homan commented on GIRAPH-110: Sorry to be late on this one, but I'd been

[jira] [Commented] (GIRAPH-113) Change cast to Vertex used in prepareSuperstep() to BasicVertex

[ https://issues.apache.org/jira/browse/GIRAPH-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173921#comment-13173921 ] Jakob Homan commented on GIRAPH-113: +1 (grumbling about GIRAPH-83)

[jira] [Commented] (GIRAPH-119) VertexCombiner should work on IterableM instead of ListM

[ https://issues.apache.org/jira/browse/GIRAPH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181522#comment-13181522 ] Jakob Homan commented on GIRAPH-119: +1. The change log isn't usually modified as

[jira] [Commented] (GIRAPH-122) Roll version back to 0.1

[ https://issues.apache.org/jira/browse/GIRAPH-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182721#comment-13182721 ] Jakob Homan commented on GIRAPH-122: yep, looks like I could. Roll

[jira] [Commented] (GIRAPH-123) the wiki is not publicly accessible

[ https://issues.apache.org/jira/browse/GIRAPH-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184167#comment-13184167 ] Jakob Homan commented on GIRAPH-123: I've opened INFRA-4318 to have this fixed. I'll

[jira] [Commented] (GIRAPH-126) Use Collections.emptyList() in BasicRPCCommunications.java

[ https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188608#comment-13188608 ] Jakob Homan commented on GIRAPH-126: yeah, good catch: {noformat}scala list3.add(42)

[jira] [Commented] (GIRAPH-126) Use Collections.emptyList() in BasicRPCCommunications.java

[ https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188666#comment-13188666 ] Jakob Homan commented on GIRAPH-126: bq. I think we are moving to guava. Much nicer in

[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars

[ https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13192430#comment-13192430 ] Jakob Homan commented on GIRAPH-129: In contrast to {{mvn javadoc:jar}} and {{mvn

[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars

[ https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13193282#comment-13193282 ] Jakob Homan commented on GIRAPH-129: ok, sounds good. +1 on the patch. I'll commit

[jira] [Commented] (GIRAPH-129) enable creation of javadoc and sources jars

[ https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13193308#comment-13193308 ] Jakob Homan commented on GIRAPH-129: bq. (P.S.: Shouldn't the version of giraph be

[jira] [Commented] (GIRAPH-131) enable creation of test-jars to simplify testing in downstream projects

[ https://issues.apache.org/jira/browse/GIRAPH-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195258#comment-13195258 ] Jakob Homan commented on GIRAPH-131: +1. Tested patch and verified all the tests and

[jira] [Commented] (GIRAPH-128) RPC port from BasicRPCCommunications should be only a starting port, and retried

[ https://issues.apache.org/jira/browse/GIRAPH-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195347#comment-13195347 ] Jakob Homan commented on GIRAPH-128: Any reason the question about mocks/extending the

[jira] [Commented] (GIRAPH-128) RPC port from BasicRPCCommunications should be only a starting port, and retried

[ https://issues.apache.org/jira/browse/GIRAPH-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195382#comment-13195382 ] Jakob Homan commented on GIRAPH-128: Great, thanks. +1. RPC port

[jira] [Commented] (GIRAPH-136) Erorr message for bin/giraph could be improved

[ https://issues.apache.org/jira/browse/GIRAPH-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199482#comment-13199482 ] Jakob Homan commented on GIRAPH-136: @Avery - how does this one look?

[jira] [Commented] (GIRAPH-139) Change PageRankBenchmark to be accessible via bin/giraph

[ https://issues.apache.org/jira/browse/GIRAPH-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203958#comment-13203958 ] Jakob Homan commented on GIRAPH-139: How about I add back in the main and run as

[jira] [Commented] (GIRAPH-146) Maven is running the tests twice during builds

[ https://issues.apache.org/jira/browse/GIRAPH-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205131#comment-13205131 ] Jakob Homan commented on GIRAPH-146: From a run of {{mvn site:site}}. Other targets

[jira] [Commented] (GIRAPH-146) Maven is running the tests twice during builds

[ https://issues.apache.org/jira/browse/GIRAPH-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205137#comment-13205137 ] Jakob Homan commented on GIRAPH-146: This might be a hiccup on my side. The double

[jira] [Commented] (GIRAPH-148) giraph-site.xml needs Apache header

[ https://issues.apache.org/jira/browse/GIRAPH-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205986#comment-13205986 ] Jakob Homan commented on GIRAPH-148: This is copied from hdfs-site.xml (because I'm a

[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of Giraph code conventions

[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207185#comment-13207185 ] Jakob Homan commented on GIRAPH-40: --- bq. The below examples are what Checkstyle wants to

[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of Giraph code conventions

[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207195#comment-13207195 ] Jakob Homan commented on GIRAPH-40: --- bq. So for the first example, we need to follow that

[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of Giraph code conventions

[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207205#comment-13207205 ] Jakob Homan commented on GIRAPH-40: --- OK. If we can fix it later, it'll be less traumatic

[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of Giraph code conventions

[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208731#comment-13208731 ] Jakob Homan commented on GIRAPH-40: --- ok, looks good to me. +1. However, since no one

[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of Giraph code conventions

[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208750#comment-13208750 ] Jakob Homan commented on GIRAPH-40: --- Actually, I have a concern: Compiles will now fail

[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of Giraph code conventions

[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208786#comment-13208786 ] Jakob Homan commented on GIRAPH-40: --- Thanks. +1 on latest patch, while still hoping to

[jira] [Commented] (GIRAPH-147) Add Blueprints Tinkerpop support

[ https://issues.apache.org/jira/browse/GIRAPH-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208902#comment-13208902 ] Jakob Homan commented on GIRAPH-147: I'd be reluctant to add the blueprints support at

[jira] [Commented] (GIRAPH-87) Simplify boolean expression in BspService::checkpointFrequencyMet

[ https://issues.apache.org/jira/browse/GIRAPH-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13215955#comment-13215955 ] Jakob Homan commented on GIRAPH-87: --- Looks good except it fails checkstyle:

[jira] [Commented] (GIRAPH-85) Simplify return expression in RPCCommunications::getRPCProxy

[ https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237139#comment-13237139 ] Jakob Homan commented on GIRAPH-85: --- Let's go ahead and the suppresswarnings. Eli, can

[jira] [Commented] (GIRAPH-153) HBase/Accumulo Input and Output formats

[ https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237959#comment-13237959 ] Jakob Homan commented on GIRAPH-153: bq. I'm concerned with how fat the jar becomes

[jira] [Commented] (GIRAPH-153) HBase/Accumulo Input and Output formats

[ https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244972#comment-13244972 ] Jakob Homan commented on GIRAPH-153: bq. I have a subproject 'giraph-formats-contrib'

[jira] [Commented] (GIRAPH-168) Simplify munge directive usage with new munge flag HADOOP_SECURE (rather than HADOOP_FACEBOOK) and remove usage of HADOOP

[ https://issues.apache.org/jira/browse/GIRAPH-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246478#comment-13246478 ] Jakob Homan commented on GIRAPH-168: My understanding was that the RPC changes FB had

[jira] [Commented] (GIRAPH-153) HBase/Accumulo Input and Output formats

[ https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246489#comment-13246489 ] Jakob Homan commented on GIRAPH-153: Sounds good to me as well. I'm fine with devs

[jira] [Commented] (GIRAPH-168) Simplify munge directive usage with new munge flag HADOOP_SECURE (rather than HADOOP_FACEBOOK) and remove usage of HADOOP

[ https://issues.apache.org/jira/browse/GIRAPH-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246496#comment-13246496 ] Jakob Homan commented on GIRAPH-168: bq. except for the PB-based stuf Where PB =

[jira] [Commented] (GIRAPH-77) Coordinator should expose a web interface with progress, vertex region assignments, etc.

[ https://issues.apache.org/jira/browse/GIRAPH-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246594#comment-13246594 ] Jakob Homan commented on GIRAPH-77: --- bq. Do you or Jakob have a favorite stack to do

[jira] [Commented] (GIRAPH-77) Coordinator should expose a web interface with progress, vertex region assignments, etc.

[ https://issues.apache.org/jira/browse/GIRAPH-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247019#comment-13247019 ] Jakob Homan commented on GIRAPH-77: --- The code I've got is a bunch of messing with

[jira] [Commented] (GIRAPH-85) Simplify return expression in RPCCommunications::getRPCProxy

[ https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249339#comment-13249339 ] Jakob Homan commented on GIRAPH-85: --- bq. I would like to throw the idea out there that

[jira] [Commented] (GIRAPH-85) Simplify return expression in RPCCommunications::getRPCProxy

[ https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1324#comment-1324 ] Jakob Homan commented on GIRAPH-85: --- +1. I've committed this. Thanks, Eli!

[jira] [Commented] (GIRAPH-182) Provide SequenceFileVertexOutputFormat as an available OutputFormat

[ https://issues.apache.org/jira/browse/GIRAPH-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251884#comment-13251884 ] Jakob Homan commented on GIRAPH-182: Hey Pradeep. Thanks for the contribution. Review:

[jira] [Commented] (GIRAPH-184) Upgrade to junit4

[ https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256115#comment-13256115 ] Jakob Homan commented on GIRAPH-184: We can dramatically shrink this patch with static

[jira] [Commented] (GIRAPH-180) Publish SNAPSHOTs and released artifacts in the Maven repository

[ https://issues.apache.org/jira/browse/GIRAPH-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256660#comment-13256660 ] Jakob Homan commented on GIRAPH-180: bq. The only question I would have though is

[jira] [Commented] (GIRAPH-153) HBase/Accumulo Input and Output formats

[ https://issues.apache.org/jira/browse/GIRAPH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256836#comment-13256836 ] Jakob Homan commented on GIRAPH-153: bq. Per Keith Turner's comments in HAMA-153 would

[jira] [Commented] (GIRAPH-184) Upgrade to junit4

[ https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256874#comment-13256874 ] Jakob Homan commented on GIRAPH-184: +1. There are a couple other changes in terms of