On 25.06.13 21:23, Johannes Sixt wrote:
> Am 25.06.2013 00:10, schrieb Junio C Hamano:
>> Mark Levedahl writes:
>>
>>> On 06/22/2013 03:38 PM, Ramsay Jones wrote:
Also, apart from running the git test-suite, I have the Win32
l/stat functions disabled on all of my repos. In particular, I
lled UTF-8, rephrase the heading
Signed-off-by: Torsten Bögershausen
---
I wasn't fast enough to catch it on pu:
fg/submodule-non-ascii-path
t/t7400-submodule-basic.sh | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule
Use the SANITY prerequisite when testing if a temp file can
be created in a read only directory.
Skip the test under CYGWIN, or skip it under Unix/Linux when
it is run as root.
Signed-off-by: Torsten Bögershausen
---
t/t0070-fundamental.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Use the SANITY prerequisite when testing if a temp file can
be created in a read only directory.
Skip the test under CYGWIN, or skip it under Unix/Linux when
it is run as root.
Signed-off-by: Torsten Bögershausen
---
t/t0070-fundamental.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion
dows using NTFS.
This TC has been disabled for MINGW, and needs to be disabled for CYGWIN.
Use the precondition CANNOTWRITE which is probing the file system and
works for MINGW, CYGWIN and even for Linux using VFAT.
Signed-off-by: Torsten Bögershausen
---
t/t0070-fundamental.sh | 19
The new 4015 does not pass under Mac OS:
a) The seq command, does not exits (we can use printf)
b) One sed expression is not understood, sed exporst needed ;-)
git diff
diff --git a/t/t4015-diff-whitespace.sh b/t/t4015-diff-whitespace.sh
index b3c4fcc..f00d20b 100755
--- a/t/t4015-diff-whites
On 2013-05-28 19.04, Junio C Hamano wrote:
>
> Can you tell me what the conclusion on the discussion on your two
> other patches on 'pu'?
>
> * rj/mingw-cygwin (2013-05-08) 2 commits
> - cygwin: Remove the CYGWIN_V15_WIN32API build variable
> - mingw: rename WIN32 cpp macro to GIT_WINDOWS_NATIV
On 2013-05-21 00.52, Junio C Hamano wrote:
> Thanks, will replace da/darwin with this round.
(May be late response, not sure if this is the right email thread.
I eventually managed to compile under 10.6, what we have on pu)
One minor nit, or 2:
imap-send.c: In function ‘cram’:
imap-send.c:913: war
On 2013-05-15 09.11, David Aguilar wrote:
> Mac OS X 10.8 Mountain Lion prints warnings when building git:
>
> warning: 'SHA1_Init' is deprecated
> (declared at /usr/include/openssl/sha.h:121)
>
> Silence the warnings by using the CommonCrytpo SHA-1
> functions for SHA1_Init(), SHA1_U
On 2013-05-09 19.18, Ramsay Jones wrote:
> Torsten Bögershausen wrote:
>> On 2013-05-04 01.14, Junio C Hamano wrote:
>>>
>>> Cygwin portability; both were reviewed by Jonathan, and the tip one
>>> seems to want a bit further explanation. Needs positive report
On 2013-05-13 18.30, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> On 2013-05-13 00.50, Junio C Hamano wrote:
>>> Signed-off-by: Junio C Hamano
>>> ---
>>> t/t5551-http-fetch.sh | 8 ++--
>>> 1 file changed, 6 insertions(+),
On 2013-05-13 00.50, Junio C Hamano wrote:
> Signed-off-by: Junio C Hamano
> ---
> t/t5551-http-fetch.sh | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Thanks, works like a charm, tested on Mac OS.
/torsten
--
To unsubscribe from this list: send the line "unsubscribe git" in
On 11.05.13 22:09, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> I did,
>> the interesting thing is that the test passes with and without your patch.
>> (After enabling GIT_TEST_LONG and GIT_TEST_HTTPD in both cases)
>
> Strange. Do you see differenc
On 05/11/2013 03:25 PM, Torsten Bögershausen wrote:
Sorry, I forgot to mention that there is another test case that fails
in test-bzr.sh (Both Linux and MacOS):
Cloning into 'gitrepo'...
--- ../expected 2013-05-11 20:07:17.678360248 +
+++ actual 2013-05-11 20:07:21.51031
On 11.05.13 21:45, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Thanks. Is there another one in t/t5551-http-fetch.sh that checks
>> the tags?
>
> I think your sed will see the same breakage for the one in 5551 (my
> sed is unfortunately GNU and ".\+" does not break it). Could you
> tes
Using sed -e '/[0-9]\+//' to find "one ore more" digits
is not portable.
Use the Basic Regular Expression '/[0-9][0-9]*//' instead
Signed-off-by: Torsten Bögershausen
---
contrib/remote-helpers/test-bzr.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
On 2013-05-08 02.30, Mark Levedahl wrote:
> On 05/07/2013 10:27 AM, Torsten Bögershausen wrote:
>> On 2013-05-04 01.14, Junio C Hamano wrote:
>>>
>>> Cygwin portability; both were reviewed by Jonathan, and the tip one
>>> seems to want a bit further
On 2013-05-04 01.14, Junio C Hamano wrote:
>
> Cygwin portability; both were reviewed by Jonathan, and the tip one
> seems to want a bit further explanation. Needs positive report
> from Cygwin 1.7 users who have been on 1.7 to make sure it does not
> regress for them.
I was trying to verify
On 2013-04-28 08.02, Torsten Bögershausen wrote:
> On 2013-04-27 20.42, Ramsay Jones wrote:
>>
>> On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should
>> it be static?" warning. The MinGW and MSVC builds do not see the
>> declaration
On 2013-04-27 20.42, Ramsay Jones wrote:
>
> On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should
> it be static?" warning. The MinGW and MSVC builds do not see the
> declaration of this function, within git-compat-util.h, due to it's
> placement within an preprocessor conditional.
On 2013-04-25 22.46, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> Spilt lines like export X=Y into 2 lines:
>> X=Y
>> export X
>
> That can be read from the patch text.
>
> If you are going to spend three lines, please describe why it has to
The shell syntax "export X=Y A=B" is not understood by all shells.
Split the non portable line into separate lines like this:
A=B
X=Y
export A X
Signed-off-by: Torsten Bögershausen
---
t/t7409-submodule-detached-worktree.sh | 14 ++
1 file changed, 10 insertions(+), 4
The shell syntax "export X=Y" is not understood by all shells.
Split the non portable line into separate lines like this:
X=Y
export X
Signed-off-by: Torsten Bögershausen
---
t/t9020-remote-svn.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t9020-remote-
The shell syntax "export X=Y" is not understood by all shells.
Split the non portable line into separate lines like this:
X=Y
export X
Signed-off-by: Torsten Bögershausen
---
t/t9501-gitweb-standalone-http-status.sh | 15 ++-
1 file changed, 10 insertions(+), 5 deletion
The shell syntax "export X=Y A=B" is not understood by all shells.
Split the non portable line into separate lines like this:
A=B
X=Y
export A X
Signed-off-by: Torsten Bögershausen
---
contrib/remote-helpers/test-hg-bidi.sh | 11 ++-
1 file changed, 6 insertions(+), 5 deletion
The shell syntax "export X=Y" is not understood by all shells.
Split the non portable line into separate lines like this:
X=Y
export X
Signed-off-by: Torsten Bögershausen
---
contrib/remote-helpers/test-hg-hg-git.sh | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
di
Spilt lines like export X=Y into 2 lines:
X=Y
export X
Signed-off-by: Torsten Bögershausen
---
t/t9501-gitweb-standalone-http-status.sh | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/t/t9501-gitweb-standalone-http-status.sh
b/t/t9501-gitweb-standalone-http
The prerequisite checker for DATE_PARSER should use
"$PERL_PATH" instead of perl
Signed-off-by: Torsten Bögershausen
---
t/t9501-gitweb-standalone-http-status.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t9501-gitweb-standalone-http-status.sh
b/t/t9
The make test-lint could check for lines like
export X=Y
This is bash syntax and should be written in 2 lines:
X=Y
export X
Signed-off-by: Torsten Bögershausen
---
t/check-non-portable-shell.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/check-non-portable-shell.pl
t/check-non-portable-sh.pl checks for bash only syntax like test $a == $b
This is wrong when bash is used.
Switch to bash mode and skip this test
Signed-off-by: Torsten Bögershausen
---
t/check-non-portable-shell.pl | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/t
ned-off-by: Torsten Bögershausen
---
t/check-non-portable-shell.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
index ff87611..58f8e2c 100755
--- a/t/check-non-portable-shell.pl
+++ b/t/check-non-portable-shell.pl
@@ -16,6 +1
parameter starting with a hyphen
and recommend the usage of printf instead
Signed-off-by: Torsten Bögershausen
---
t/check-non-portable-shell.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
index 8b5a71d
On 25.04.13 12:09, Michael J Gruber wrote:
> fc407f9 (Add new simplified git-remote-testgit, 2012-11-28) introduced a
> test which was meant to skip the test unless the test shell is bash.
> Unfortunately, it tests for the availability of bash only. But users can
> opt to use a different shell (usi
check for installed modules.
While at it, split exportX=Y into 2 lines
Signed-off-by: Torsten Bögershausen
---
contrib/remote-helpers/test-hg-bidi.sh | 14 +-
contrib/remote-helpers/test-hg-hg-git.sh | 12 +++-
contrib/remote-helpers/test-hg.sh| 2 +-
3 files ch
013 at 12:06 AM, Torsten Bögershausen wrote:
> On 30.03.13 10:35, Nguyễn Thái Ngọc Duy wrote:
> [...]
> The short version of a review:
> Would it make sense to leave reencode_string() as it is,
> and add a new function reencode_string_len()
Hmm.. yeah.
/Torsten
--
To unsubscri
points from unicode which can not be decomposed.
In other words, the precompsed form use the same bytes as decomposed.
Signed-off-by: Torsten Bögershausen
---
contrib/remote-helpers/test-bzr.sh | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --
ers/test-XX.sh" and
"/contrib/remote-helpers/test-YY.sh"
are both converted into
"/contrib/remote", and reported as duplicate.
Improve the regexp:
- strip the leading path and look only at the basename
- only look at files which have t- (where N stand for a digit
On 03.04.13 16:28, Jeff King wrote:
> On Wed, Apr 03, 2013 at 07:54:02AM +0200, Torsten Bögershausen wrote:
>
>> Running make inside contrib/remote-helpers fails in "test-lint-duplicates"
>>
>> This was because the regexp checking for duplicate numbers strips ev
On 08.04.13 19:27, Felipe Contreras wrote:
> From: Christophe Simonis
>
> Initial patch by Timotheus Pokorra.
>
> [fc: added tests]
>
> Signed-off-by: Felipe Contreras
> ---
> contrib/remote-helpers/git-remote-bzr | 15 +--
> contrib/remote-helpers/test-bzr.sh| 32
Use a literal TAB followed by SPACE like this [ ] instead,
which is more portable than [:space:]
Signed-off-by: Torsten Bögershausen
---
contrib/remote-helpers/test-hg.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/remote-helpers/test-hg.sh
b/contrib/remote-helpers/
ot a basic regular expression:
use egrep instead of grep.
Signed-off-by: Torsten Bögershausen
---
contrib/remote-helpers/test-hg.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/remote-helpers/test-hg.sh
b/contrib/remote-helpers/test-hg.sh
index 5f81dfa..7bb81f2 100755
On 06.04.13 19:58, Felipe Contreras wrote:
> On Sat, Apr 6, 2013 at 11:45 AM, Torsten Bögershausen wrote:
>> On 06.04.13 19:29, Felipe Contreras wrote:
>>> On Sat, Apr 6, 2013 at 11:03 AM, Torsten Bögershausen wrote:
>
>>>> --- a/contrib/remote-helpers/tes
On 06.04.13 19:29, Felipe Contreras wrote:
> On Sat, Apr 6, 2013 at 11:03 AM, Torsten Bögershausen wrote:
>> On 04.04.13 17:36, Felipe Contreras wrote:
>>> Hi,
>>>
>>> A reroll, now we do some checks, just avoid test-lint-duplicates, and fix
>>> th
On 06.04.13 19:03, Torsten Bögershausen wrote:
> On 04.04.13 17:36, Felipe Contreras wrote:
>> Hi,
>>
>> A reroll, now we do some checks, just avoid test-lint-duplicates, and fix the
>> outsanding shell portability issue. The rest is the same.
>>
>> Felip
On 04.04.13 17:36, Felipe Contreras wrote:
> Hi,
>
> A reroll, now we do some checks, just avoid test-lint-duplicates, and fix the
> outsanding shell portability issue. The rest is the same.
>
> Felipe Contreras (4):
> remote-bzr: avoid echo -n
> remote-helpers: fix the run of all tests
> r
rs/test-bzr.sh" and
"/contrib/remote-helpers/test-hg-bidi.sh"
are both converted into
"/contrib/remote", and reported as duplicate.
Improve the regexp:
Remove everything after t- (where X stand for a digit)
Signed-off-by: Torsten Bögershausen
---
t/Makefile
On 02.04.13 19:36, Jeff King wrote:
> On Tue, Apr 02, 2013 at 06:53:28PM +0200, Torsten Bögershausen wrote:
>
>>> I think the check for duplicate-numbers is the only one that does not
>>> make sense.
>> []
>> Not sure about that, I send a suggestion of a pa
st-bzr.sh,
t5820-test-hg-bidi.sh,
t5821-test-hg-hg-git.sh,
t5830-test-hg.sh
Feed the numbers used in contrib/remote-helpers into t/Makefile
and check that numbering is unique across both directories
Signed-off-by: Torsten Bögershausen
---
contrib/remote-helpers/Makefile
On 02.04.13 01:40, Jeff King wrote:
> On Mon, Apr 01, 2013 at 11:46:00PM +0200, Antoine Pelisse wrote:
>
>> On Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras
>> wrote:
>>> +export TEST_LINT :=
>>
>> I think "test-lint-executable" still makes sense here.
>
> Also test-lint-shell-syntax, which fin
On 30.03.13 10:35, Nguyễn Thái Ngọc Duy wrote:
[...]
The short version of a review:
Would it make sense to leave reencode_string() as it is,
and add a new function reencode_string_len()
+char *reencode_string_len(const char *in, int insz,
+ const char *out_encoding, const char
efs
.git/refs/heads
.git/refs/tags
Signed-off-by: Torsten Bögershausen
---
path.c | 42 +++---
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git a/path.c b/path.c
index 427312e..33fa880 100644
--- a/path.c
+++ b/path.c
@@ -396,22 +396,14 @@ const c
path.c
Signed-off-by: Torsten Bögershausen
---
cache.h | 3 +--
path.c | 27 +++
2 files changed, 8 insertions(+), 22 deletions(-)
diff --git a/cache.h b/cache.h
index c12957b..e1e8ce8 100644
--- a/cache.h
+++ b/cache.h
@@ -719,8 +719,7 @@ enum sharedrepo
On 29.03.13 22:20, Junio C Hamano wrote:
[snip]
> The last two points can become a separate "preparation" step. The
> result would be easier to read.
>
> Your updated adjust_shared_perm() does not begin with:
>
> if (!shared_repository)
> return 0;
>
> as the original, but i
On 29.03.13 11:03, Duy Nguyen wrote:
> On Fri, Mar 29, 2013 at 3:45 PM, Duy Nguyen wrote:
>> On Fri, Mar 29, 2013 at 4:48 AM, Jeff King wrote:
>>> - return fnmatch_icase(pattern, name, FNM_PATHNAME) == 0;
>>> + return fnmatch_icase_mem(pattern, patternlen,
>>> +
ert adjust_shared_perm() from a macro into a function prototype
Signed-off-by: Torsten Bögershausen
---
cache.h | 3 +--
path.c | 71 +++--
2 files changed, 39 insertions(+), 35 deletions(-)
diff --git a/cache.h b/cache.h
index 59e5b53..65a9db7 100
nized with the "read only" attribute of a file:
$ chmod 444 x
$ attrib x
AR C:\temp\pt\x
cygwin 1.7 would show
A C:\temp\pt\x
Signed-off-by: Torsten Bögershausen
---
compat/cygwin.c | 13 +
compat/cygwin.h | 5 +
git-compat-util.h | 1 +
pa
On 24.03.13 03:49, Eric Sunshine wrote:
> On Sat, Mar 23, 2013 at 8:40 AM, Torsten Bögershausen wrote:
>> Subject: [PATCH] Make core.sharedRepository work under cygwin 1.7
[..]
>
> s/failes/fails/
>
Thanks for review,
I will send a new patch in a minute.
It is actually 2 pat
On 24.03.13 10:32, Jeff King wrote:
> On Sat, Mar 23, 2013 at 09:00:05PM -0700, Junio C Hamano wrote:
>
>> On Thu, Mar 21, 2013 at 4:13 AM, Jeff King wrote:
>>>
>>> According to 47ec794, this initialization is meant to
>>> squelch an erroneous uninitialized variable warning from gcc
>>> 4.0.1. T
On 21.03.13 21:47, Jonathan Nieder wrote:
> Jeff King wrote:
>
>> And 4.3 was old enough for me to say "I do not care if you can run with
>> -Wall -Werror or not", let alone 4.2.
>
> Changes like this can only reveal bugs (in git or optimizers) that
> were hidden before, without regressing actual
On 19.03.13 22:03, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> Use a compile switch IGNORECYGWINFSTRICKS to disable the usage
>> of cygwin_lstat_fn() only in path.c
>
> The analysis of the problem and the basic idea to disable the
> fast-but-lying fstric
On 21.03.13 14:00, Leo Koppelkamm wrote:
> Torsten Bögershausen added a patch for this a while ago.
> It seems it only works for files, not for folders with unicode in it.
>
> Eg. on ubuntu box:
> git init
> mkdir hä
> touch hä/file
> git add hä
> git commit
>
> L
On Friday 08 February 2013 07:08:14 Torsten Bögershausen wrote:
> On 07.02.13 20:35, Junio C Hamano wrote:
> > Ramsay Jones writes:
> >
> >> Torsten Bögershausen wrote:
> >>> t0070 and t1301 fail when running the test suite under cygwin.
> >>&g
On 15.03.13 22:59, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> Thanks, that looks good to me:
>>
>> # It took 2.58 seconds to enumerate untracked files.
>> # Consider the -u option for a possible speed-up?
>>
>> But:
>> If I foll
On 15.03.13 21:06, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> > Thanks, I like that much better than mine
>> > (and expere is probably a word not yet invented)
> OK, then how about redoing Duy's patch like this on top?
>
> I've mov
On 03/15/2013 05:53 PM, Junio C Hamano wrote:
Torsten Bögershausen writes:
[PATCH] git status: Document that git status -uno is faster
In some repostories users expere that "git status" command takes long time.
expere??? Certainly you did not mean "expect". "o
untracked file may take some time, and docuemnt
the option -uno better.
Signed-off-by: Torsten Bögershausen
---
Documentation/git-status.txt | 7 +++
1 file changed, 7 insertions(+)
diff --git a/Documentation/git-status.txt b/Documentation/git-status.txt
index 0412c40..fd36bbd 100644
wrong in cygwin_lstat_fn():
The read-only attribute of a file is used to calculate
the permissions, resulting in either rw-r--r-- or r--r--r--
Use a compile switch IGNORECYGWINFSTRICKS to disable the usage
of cygwin_lstat_fn() only in path.c
Signed-off-by: Torsten Bögershausen
---
compat/cygwin.h
On 13.03.13 13:59, Nguyễn Thái Ngọc Duy wrote:
> This patch attempts to advertise -uno to the users who tolerate slow
> "git status" on large repositories (or slow machines/disks). The 2
> seconds limit is quite arbitrary but is probably long enough to start
> using -uno.
>
> Signed-off-by: Nguyễn
On 08.03.13 09:15, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>>> Doesn't this make one wonder why a separate bit and implementation
>>> is necessary to say "I am not interested in untracked files" when
>>> "-uno" option is al
On 08.03.13 01:04, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> diff --git a/builtin/commit.c b/builtin/commit.c
>> index d6dd3df..6a5ba11 100644
>> --- a/builtin/commit.c
>> +++ b/builtin/commit.c
>> @@ -1158,6 +1158,8 @@ int cmd_status(int
d-only
git status may be run faster if
- we only check if files are changed which are already known to git.
- we don't check if there are untracked files.
"git status --changed-only" (or the short form "git status -c")
will only check for changed files which are already kno
On 04.03.13 19:15, Robert Irelan wrote:
> Hello all:
>
> This is my first time posting to this mailing list, but it appears to
> me, through a Google search, that this is where you go to report what
> might be bugs. I'm not sure if this is a bug or not, but it is
> mysterious to me.
>
> My git re
o a function prototype
Signed-off-by: Torsten Bögershausen
---
cache.h | 3 +--
path.c | 75 +++--
2 files changed, 41 insertions(+), 37 deletions(-)
While investigating why cygwin 1.7 failes in t1301, and cygwin 1.5 passes,
I came acros
On 26.02.13 05:08, Mark Levedahl wrote:
> On 02/25/2013 01:44 AM, Junio C Hamano wrote:
>> I was in "find leftover bits" mode today and found this thread hanging. Has
>> anything come out of this thread, or there is nothing to improve in this
>> area?
>
> The patch passed my simple tests (build
On 25.02.13 16:19, Jeff King wrote:
> On Mon, Feb 25, 2013 at 09:37:50AM +0100, Johannes Sixt wrote:
>
>> From: Johannes Sixt
>>
>> iconv on Windows does not know the encoding name "utf8", and does not
>> re-encode log messages when this name is given. Request "UTF-8" encoding.
>>
>> Signed-off-b
-- >8 --
[PATCH] iconv_open(): Use UTF-8 if UTF8 failes
When iconv_open() failes with EINVAL, it may be that "UTF-8"
is spelled wrong by mistake.
For example, "UTF8" is used instead of "UTF-8".
Some iconv implementations tolerate "UTF8" or "utf8&
On 11.02.13 17:36, Erik Faye-Lund wrote:
> On Mon, Feb 11, 2013 at 5:28 PM, Torsten Bögershausen wrote:
>> On 11.02.13 14:34, Erik Faye-Lund wrote:
>>> Even though parse-options doesn't support UTF-8 switches (which
>>> makes sense; non-ascii switches would b
On 11.02.13 14:34, Erik Faye-Lund wrote:
> Even though parse-options doesn't support UTF-8 switches (which
> makes sense; non-ascii switches would be difficult to enter on
> some keyboard layouts), it can be useful to report incorrectly
> entered UTF-8 switches to make the output somewhat less ugly
On 08.02.13 08:20, Jiang Xin wrote:
> 2013/2/8 Torsten Bögershausen :
>> On 08.02.13 03:10, Jiang Xin wrote:
>>> + /* If no error occurs, returns columns really required with
>>> utf8_strwidth. */
>>> + if (0 <= columns)
>>&g
(Sorry for confusing: I should have written:)
Please see below for specifications on fputs()
Linux:
RETURN VALUE
fputc(), putc() and putchar() return the character written as an unsigned char
cast to an int or EOF on error.
puts() and fputs() return a nonnegative number on success, or EOF on err
On 07.02.13 20:35, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Torsten Bögershausen wrote:
>>> t0070 and t1301 fail when running the test suite under cygwin.
>>> Skip the failing tests by unsetting POSIXPERM.
>> t1301 does not fail for me. (WIN XP (SP
On 08.02.13 03:10, Jiang Xin wrote:
> Since command usages can be translated, they may not align well especially
> when they are translated to CJK. A wrapper utf8_fprintf can help to return
> the correct columns required.
>
> Signed-off-by: Jiang Xin
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
>
Am 2013-02-06 10:34, schrieb Erik Faye-Lund:
On Sun, Jan 27, 2013 at 3:57 PM, Torsten Bögershausen wrote:
t0070 and t1301 fail when running the test suite under cygwin.
Skip the failing tests by unsetting POSIXPERM.
But is this the real reason? I thought Cygwin implemented POSIX permissions
On 27.01.13 18:34, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> Back to the which:
>> ...
>> and running "make test" gives the following, at least in my system:
>> ...
> I think everybody involved in this discussion already knows that;
&
t0070 and t1301 fail when running the test suite under cygwin.
Skip the failing tests by unsetting POSIXPERM.
Signed-off-by: Torsten Bögershausen
---
t/test-lib.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 1a6c4ab..94b097e 100644
--- a/t/test-lib.sh
and 1 non whitespace
"echo -n" must be followed by 1..n whitespace and 1 non whitespace
"which": catch lines like "if which foo"
Signed-off-by: Torsten Bögershausen
---
t/check-non-portable-shell.pl | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff -
On 27.01.13 10:31, Jonathan Nieder wrote:
> Hi,
>
> Torsten Bögershausen wrote:
>> On 15.01.13 21:38, Junio C Hamano wrote:
>>> Torsten Bögershausen writes:
>
>>>> What do we think about something like this for fishing for which:
> [...]
>>&g
and 1 non whitespace
"echo -n" must be followed by 1..n whitespace and 1 non whitespace
"which": catch lines like "if which foo"
Signed-off-by: Torsten Bögershausen
---
t/check-non-portable-shell.pl | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff -
On 26.01.13 22:43, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> Do we really need "which" to detect if frotz is installed?
> I think we all know the answer to that question is no, but why is
> that a relevant question in the context of this discussi
On 26.01.13 02:03, Jonathan Nieder wrote:
> Throughout git, it is assumed that the WIN32 preprocessor symbol is
> defined on native Windows setups (mingw and msvc) and not on Cygwin.
> On Cygwin, most of the time git can pretend this is just another Unix
> machine, and Windows-specific magic is gen
On 15.01.13 21:38, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> What do we think about something like this for fishing for which:
>>
>> --- a/t/test-lib.sh
>> +++ b/t/test-lib.sh
>> @@ -644,6 +644,10 @@ yes () {
>>
o
t5810-test-bzr.sh,
t5820-test-hg-bidi.sh,
t5821-test-hg-hg-git.sh,
t5830-test-hg.sh
Feed the numbers used in contrib/remote-helpers into t/Makefile
and check that the numbering is unique across both directories
Signed-off-by: Torsten Bögershausen
---
contrib/remote-helpers/Makefile
o
t5810-test-bzr.sh,
t5820-test-hg-bidi.sh,
t5821-test-hg-hg-git.sh,
t5830-test-hg.sh
Feed the numbers used in contrib/remote-helpers into t/Makefile
and check that the numbering is unique across both directories
Signed-off-by: Torsten Bögershausen
---
contrib/remote-helpers/Makefile
On 22.01.13 20:41, Jeff King wrote:
> On Tue, Jan 22, 2013 at 12:49:31AM -0500, John Szakmeister wrote:
>
>> I tried running make in contrib/remote-helpers and it died with:
>>
>> :: make
>> make -e -C ../../t test
>> rm -f -r test-results
>> duplicate test numbers: /Users/jszakmei
+core.checkstat::
+ Determines which stat fields to match between the index
+ and work tree. The user can set this to 'default' or
+ 'minimal'. Default (or explicitly 'default'), is to check
+ all fields, including the sub-second part of mtime and ctime.
+
Setting 'minimal'
Use one TAB for indentation and remove empty lines
Signed-off-by: Torsten Bögershausen
---
t/t0050-filesystem.sh | 48 +++-
1 file changed, 15 insertions(+), 33 deletions(-)
diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh
index a6fa3c5
The test case "add (with different case)" indicates a
known breakage when run on a case insensitive file system.
The test is invalid for case sensitive file system, it will always fail.
Check the precondition CASE_INSENSITIVE_FS before running it.
Signed-off-by: Torsten Bö
: Torsten Bögershausen
---
Changes since v1: Improved commit message
t/t0050-filesystem.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh
index 78816d9..ccd685d 100755
--- a/t/t0050-filesystem.sh
+++ b/t/t0050-filesystem.sh
@@ -77,7
Sorry for completely messing up the sensitvie/insensiteve
Please discard my patch from pu, I'll send v2.
Sorry for the confusion
/Torsten
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ke
On 20.01.13 12:06, Jonathan Nieder wrote:
> Torsten Bögershausen wrote:
>
>> I wonder, if if we can go one step further:
>>
>> Replace
>> #ifdef WIN32 /* Both MinGW and MSVC */
> [...]
>> with
>> #if defined(_MSC_VER)
>
> I thought Git for
1101 - 1200 of 1315 matches
Mail list logo
