Re: [PATCH 2/2] dir: remove PATH_MAX limitation

2014-07-13 Thread Junio C Hamano
Duy Nguyen writes: >> [01/20] dir.c: coding style fix >> [02/20] dir.h: move struct exclude declaration to top level >> [03/20] prep_exclude: remove the artificial PATH_MAX limit >> >> ...perhaps with s/if (!dir->basebuf.alloc)/if (!dir->basebuf.buf)/ >> >> @Duy any reason for not signing off tha

Re: [PATCH 2/2] dir: remove PATH_MAX limitation

2014-07-11 Thread Duy Nguyen
On Sat, Jul 12, 2014 at 6:43 AM, Karsten Blees wrote: > Am 12.07.2014 00:29, schrieb Junio C Hamano: >> Karsten Blees writes: >> >>> Anyways, I'd like to kindly withdraw this patch in favor of Duy's version. >>> >>> http://article.gmane.org/gmane.comp.version-control.git/248310 >> >> Thanks; I've

Re: [PATCH 2/2] dir: remove PATH_MAX limitation

2014-07-11 Thread Karsten Blees
Am 12.07.2014 00:29, schrieb Junio C Hamano: > Karsten Blees writes: > >> Anyways, I'd like to kindly withdraw this patch in favor of Duy's version. >> >> http://article.gmane.org/gmane.comp.version-control.git/248310 > > Thanks; I've already reverted it from 'next'. > > Is Duy's patch still vi

Re: [PATCH 2/2] dir: remove PATH_MAX limitation

2014-07-11 Thread Junio C Hamano
Karsten Blees writes: > Anyways, I'd like to kindly withdraw this patch in favor of Duy's version. > > http://article.gmane.org/gmane.comp.version-control.git/248310 Thanks; I've already reverted it from 'next'. Is Duy's patch still viable? -- To unsubscribe from this list: send the line "unsub

Re: [PATCH 2/2] dir: remove PATH_MAX limitation

2014-07-11 Thread Karsten Blees
Am 09.07.2014 18:33, schrieb Junio C Hamano: > Karsten Blees writes: > >> 'git status' segfaults if a directory is longer than PATH_MAX, because >> processing .gitignore files in prep_exclude() writes past the end of a >> PATH_MAX-bounded buffer. >> >> Remove the limitation by using strbuf instea

Re: [PATCH 2/2] dir: remove PATH_MAX limitation

2014-07-11 Thread Karsten Blees
Am 05.07.2014 12:48, schrieb Duy Nguyen: > On Sat, Jul 5, 2014 at 5:42 AM, Karsten Blees wrote: >> 'git status' segfaults if a directory is longer than PATH_MAX, because >> processing .gitignore files in prep_exclude() writes past the end of a >> PATH_MAX-bounded buffer. >> >> Remove the limitatio

Re: [PATCH 2/2] dir: remove PATH_MAX limitation

2014-07-09 Thread Junio C Hamano
Karsten Blees writes: > 'git status' segfaults if a directory is longer than PATH_MAX, because > processing .gitignore files in prep_exclude() writes past the end of a > PATH_MAX-bounded buffer. > > Remove the limitation by using strbuf instead. > > Note: this fix just 'abuses' strbuf as string a

Re: [PATCH 2/2] dir: remove PATH_MAX limitation

2014-07-08 Thread Jeff King
On Sat, Jul 05, 2014 at 12:42:29AM +0200, Karsten Blees wrote: > Note: this fix just 'abuses' strbuf as string allocator, len is always 0. > prep_exclude() can probably be simplified using more strbuf APIs. Hrm. It looks like you grow it and add some data, but really don't want the length to expa

Re: [PATCH 2/2] dir: remove PATH_MAX limitation

2014-07-05 Thread Duy Nguyen
On Sat, Jul 5, 2014 at 5:42 AM, Karsten Blees wrote: > 'git status' segfaults if a directory is longer than PATH_MAX, because > processing .gitignore files in prep_exclude() writes past the end of a > PATH_MAX-bounded buffer. > > Remove the limitation by using strbuf instead. > > Note: this fix ju

[PATCH 2/2] dir: remove PATH_MAX limitation

2014-07-04 Thread Karsten Blees
'git status' segfaults if a directory is longer than PATH_MAX, because processing .gitignore files in prep_exclude() writes past the end of a PATH_MAX-bounded buffer. Remove the limitation by using strbuf instead. Note: this fix just 'abuses' strbuf as string allocator, len is always 0. prep_excl