Re: A local shared clone is now much slower

2013-07-08 Thread Jeff King
On Mon, Jul 08, 2013 at 01:03:55PM +1000, Stephen Rothwell wrote: So commit 0433ad128c59 (clone: run check_everything_connected) (which turned up with v1.8.3) added a large traversal to clone which (as the comment said) makes a clone much slower. It is especially noticeable on git clone -s

Re: A local shared clone is now much slower

2013-07-08 Thread Duy Nguyen
On Mon, Jul 8, 2013 at 2:30 PM, Jeff King p...@peff.net wrote: Subject: [PATCH] clone: drop connectivity check for local clones Commit 0433ad1 (clone: run check_everything_connected, 2013-03-25) added the same connectivity check to clone that we use for fetching. The intent was to provide

Re: A local shared clone is now much slower

2013-07-08 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Mon, Jul 08, 2013 at 01:03:55PM +1000, Stephen Rothwell wrote: So commit 0433ad128c59 (clone: run check_everything_connected) (which turned up with v1.8.3) added a large traversal to clone which (as the comment said) makes a clone much slower. It is

Re: A local shared clone is now much slower

2013-07-08 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Mon, Jul 8, 2013 at 2:30 PM, Jeff King p...@peff.net wrote: Subject: [PATCH] clone: drop connectivity check for local clones Commit 0433ad1 (clone: run check_everything_connected, 2013-03-25) added the same connectivity check to clone that we use for

Re: A local shared clone is now much slower

2013-07-08 Thread Jeff King
On Mon, Jul 08, 2013 at 08:00:09AM -0700, Junio C Hamano wrote: I think this deserves to be backported to 'maint' track for 1.8.3.x. Here is an attempt to do so. Agreed. As it makes certain local-clone workflows really painful, I think my original can be considered a performance regression

A local shared clone is now much slower

2013-07-07 Thread Stephen Rothwell
Hi guys, So commit 0433ad128c59 (clone: run check_everything_connected) (which turned up with v1.8.3) added a large traversal to clone which (as the comment said) makes a clone much slower. It is especially noticeable on git clone -s -l -n which I use every day and used to be almost instant. Is

Re: A local shared clone is now much slower

2013-07-07 Thread Duy Nguyen
On Mon, Jul 8, 2013 at 10:03 AM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi guys, So commit 0433ad128c59 (clone: run check_everything_connected) (which turned up with v1.8.3) added a large traversal to clone which (as the comment said) makes a clone much slower. It is especially

Re: A local shared clone is now much slower

2013-07-07 Thread Stephen Rothwell
Hi Duy, On Mon, 8 Jul 2013 10:20:22 +0700 Duy Nguyen pclo...@gmail.com wrote: On Mon, Jul 8, 2013 at 10:03 AM, Stephen Rothwell s...@canb.auug.org.au wrote: So commit 0433ad128c59 (clone: run check_everything_connected) (which turned up with v1.8.3) added a large traversal to clone