Am 08.08.19 um 04:35 schrieb Carlo Arenas:
> On Wed, Aug 7, 2019 at 6:03 AM René Scharfe wrote:
>>
>> Am 07.08.19 um 11:49 schrieb Carlo Arenas:
>>> was hoping will perform better but it seems that testing can be done
>>> only in windows
>>
>> nedmalloc works on other platforms as well.
>
> I mean
On Wed, Aug 07, 2019 at 11:56:14PM -0700, Jonathan Nieder wrote:
> But a dash bug[*] causes it to instead expand to
>
> /3456789...
>
> The stream of symbols that makes up this function is hard for humans
> to follow, too. The complexity mostly comes from the repeated use of
> the express
On Tue, Aug 06, 2019 at 12:11:53PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > git commit -m 'buggy commit'
> > echo fix >>file.c
> > git commit --amend ;# oops, should have been "-a"
> > git push
> >
> > But perhaps that gets to the heart of the matter. Could we perhaps be
>
On Tue, Aug 06, 2019 at 08:14:59PM +0200, SZEDER Gábor wrote:
> On Tue, Aug 06, 2019 at 01:38:17PM -0400, Jeff King wrote:
> > Nothing about "--" is changed by my series; it will still stop option
> > interpretation in rev-list and in other commands. But as before,
> > rev-list (and other Git comm
On Wed, Aug 07, 2019 at 04:17:49AM +, brian m. carlson wrote:
> > I think if we at least choose the left-most "--" as the official
> > end-of-options then they can't inject an option (they can only inject a
> > rev as a path). I guess that's the same as with --end-of-options. But it
> > someho
On Tue, Aug 06, 2019 at 07:19:11PM +, Robin H. Johnson wrote:
> I started trying to make a stab at implementing this, but the code
> wasn't standing out for it. Hopefully somebody else has poked at it
> before:
>
> I'd like to have a --quiet option for git-bundle, such that only errors
> are
On Tue, Aug 06, 2019 at 02:16:25PM -0700, Elijah Newren wrote:
> > > + test_i18ngrep ! CONFLICT out &&
> > > + test_i18ngrep ! BUG: err &&
> >
> > The BUG is gone. But should it not use i18ngrep? BUG() isn't localized.
>
> Technically, yes, you're right. However, this line
On 2019-08-08 at 06:56:14, Jonathan Nieder wrote:
> t1410.3 ("corrupt and checks") fails when run using dash versions
> before 0.5.8, with a cryptic message:
>
> mv: cannot stat '.git/objects//e84adb2704cbd49549e52169b4043871e13432':
> No such file or directory
>
> The function generating
Hi Rohit
On 06/08/2019 18:36, Rohit Ashiwal wrote:
rebase am already has this flag to "lie" about the committer date
by changing it to the author date. Let's add the same for
interactive machinery.
Signed-off-by: Rohit Ashiwal
---
Documentation/git-rebase.txt| 8 +++-
builtin/r
Hi Rohit
On 06/08/2019 18:36, Rohit Ashiwal wrote:
The purpose of amend_author was to free() the malloc()'d string
obtained from get_author(). But the name does not actually convey
this purpose. Rename it to something meaningful.
The name was intended to covey that it was only used when amendi
On 2019-08-08 at 09:37:33, Jeff King wrote:
> On Wed, Aug 07, 2019 at 11:56:14PM -0700, Jonathan Nieder wrote:
> -- >8 --
> Subject: [PATCH] t: reword comments for "local" test
>
> Commit 01d3a526ad (t: check whether the shell supports the "local"
> keyword, 2017-10-26) added a test to gat
Hi Rohit
On 06/08/2019 18:36, Rohit Ashiwal wrote:
The previous commit introduced --ignore-date flag to interactive
rebase, but the name is actually very vague in context of rebase -i
since there are two dates we can work with. Add an alias to convey
the precise purpose.
That's an excellent id
On 06/08/2019 18:36, Rohit Ashiwal wrote:
rebase am already has this flag to "lie" about the author date
by changing it to the committer (current) date. Let's add the same
for interactive machinery.
Signed-off-by: Rohit Ashiwal
---
Documentation/git-rebase.txt| 6 ++--
builti
On Thu, Aug 8, 2019 at 12:07 AM René Scharfe wrote:
>
> Am 08.08.19 um 04:35 schrieb Carlo Arenas:
> > On Wed, Aug 7, 2019 at 6:03 AM René Scharfe wrote:
> >>
> >> Am 07.08.19 um 11:49 schrieb Carlo Arenas:
> >>> was hoping will perform better but it seems that testing can be done
> >>> only in w
On Thu, 8 Aug 2019 at 06:09, Phil Hord wrote:
> I have a repo with 24,000 tags, most of which are not useful to any
> developers. Having this many refs slows down many operations that
> would otherwise be very fast. Removing these tags when they've been
> accidentally fetched again takes about 30
We try to delete the non-existing tag "anothertag", but for the
verifications, we check that the tag "myhead" doesn't exist. "myhead"
isn't used in this test except for this checking. Comparing to the test
two tests earlier, it looks like a copy-paste mistake.
Perhaps it's overkill to check that `
On Thu, Aug 08, 2019 at 11:35:38AM +, brian m. carlson wrote:
> On 2019-08-08 at 09:37:33, Jeff King wrote:
> > On Wed, Aug 07, 2019 at 11:56:14PM -0700, Jonathan Nieder wrote:
> > -- >8 --
> > Subject: [PATCH] t: reword comments for "local" test
> >
> > Commit 01d3a526ad (t: check whe
On Wed, 7 Aug 2019 at 20:57, Josh Steadmon wrote:
>
> This series adds a new pre-merge-commit hook, similar in usage to
> pre-commit. It also improves hook testing in t7503, by verifying that
> the correct hooks are run or bypassed as expected.
>
> The original series was done by Michael J Gruber
Hi Carlo,
On Tue, 6 Aug 2019, Carlo Marcelo Arenas Belón wrote:
> 63e7e9d8b6 ("git-grep: Learn PCRE", 2011-05-09) didn't include a way
> to override the system alocator, and so it is incompatible with
> USE_NED_ALLOCATOR as reported by Dscho[1] (in similar code from PCRE2)
>
> Make the minimum ch
Hi Carlo,
On Tue, 6 Aug 2019, Carlo Marcelo Arenas Belón wrote:
> Most of the code stolen from[1] to easy on comparison and including
> the deficiency of setting the global context even for patterns that
> won't need it.
>
> Ideally, the call from grep_init could be moved to a place where it
> co
From: Jeff Hostetler
Truncate/elide very long "filename:linenumber" field.
Truncate region and data "category" field if necessary.
Adjust overall column widths.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_perf.c | 39 +--
1 file changed, 29 insertions(+
V2 of this patch series cleans up some whitespace and column alignment
issues in the trace2 perf and normal formats. It also removes some dead
code.
Jeff Hostetler (7):
trace2: cleanup column alignment in perf target format
trace2: trim whitespace in region messages in perf target format
tra
From: Jeff Hostetler
Create version of sq_quote_argv_pretty() that does not
insert a leading space before argv[0].
Signed-off-by: Jeff Hostetler
---
quote.c | 11 +++
quote.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/quote.c b/quote.c
index 7f2aa6faa4..7cad8798ac 100644
-
From: Jeff Hostetler
Avoid creating unnecessary trailing whitespace in normal
target format error messages when the message is omitted.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_normal.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/trace2/tr2_tgt_normal.c b
From: Jeff Hostetler
Make use of new sq_quote_argv_pretty_ltrim() to normalize
how we handle leading whitespace in perf format messages.
Signed-off-by: Jeff Hostetler
---
t/t0211-trace2-perf.sh | 4 ++--
trace2/tr2_tgt_perf.c | 31 ---
2 files changed, 22 insertio
From: Jeff Hostetler
Make use of new sq_quote_argv_pretty_ltrim() to normalize
how we handle leading whitespace in normal format messages.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_normal.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/trace2
From: Jeff Hostetler
Avoid unecessary trailing whitespace in "region_enter" and "region_leave"
messages in perf target format.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_perf.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/trace2/tr2_tgt_perf.c b/tra
From: Jeff Hostetler
Remove an unnecessary "if" block in maybe_add_string_va().
Commit "ad006fe419e trace2: NULL is not allowed for va_list"
changed "if (fmt && *fmt && ap)" to just "if (fmt && *fmt)"
because it isn't safe to treat 'ap' as a pointer. This made
the "if" block following it unnece
On Tue, Aug 6, 2019 at 4:16 AM Christian Couder
wrote:
>
> Hi Matheus,
>
> On Tue, Aug 6, 2019 at 4:54 AM Matheus Tavares Bernardino
> wrote:
> >
> > Here's my report from last week:
> > https://matheustavares.gitlab.io/posts/week-11-wip-grep-protecting-textconv-and-submodules
>
> Thank you for a
Am 08.08.19 um 14:38 schrieb Carlo Arenas:
> On Thu, Aug 8, 2019 at 12:07 AM René Scharfe wrote:
>>
>> Am 08.08.19 um 04:35 schrieb Carlo Arenas:
>>> On Wed, Aug 7, 2019 at 6:03 AM René Scharfe wrote:
Am 07.08.19 um 11:49 schrieb Carlo Arenas:
> was hoping will perform better but it
On Thu, Aug 8, 2019 at 6:57 AM Johannes Schindelin
wrote:
> On Tue, 6 Aug 2019, Carlo Marcelo Arenas Belón wrote:
> > Suggested-by: Johannes Schindelin
>
> Actually not so much suggested by me, as your patch still causes
> crashes (mine didn't):
the "equivalent" version in v4[1], that is still n
On Thu, Aug 8, 2019 at 6:55 AM Johannes Schindelin
wrote:
> On Tue, 6 Aug 2019, Carlo Marcelo Arenas Belón wrote:
>
> > 63e7e9d8b6 ("git-grep: Learn PCRE", 2011-05-09) didn't include a way
> > to override the system allocator, and so it is incompatible with
> > USE_NED_ALLOCATOR as reported by Ds
Phillip Wood writes:
> ...
> I think it would be better to handle committer_date_is_author_date in
> a single place in this function, not have two implementations one of
> ...
> git has a high level api for manipulation author/committer information
> in ident.c, it would be best to use that. In a
Hi Rohit
On 06/08/2019 18:36, Rohit Ashiwal wrote:
There are two backends available for rebasing, viz, the am and the
interactive. Naturally, there shall be some features that are
implemented in one but not in the other. One such flag is
--ignore-whitespace which indicates merge mechanism to tre
Hi,
I'd like to report a problem with path validation for Windows, and propose a
fix.
Function `verify_path` first calls `has_dos_drive_prefix` in order to prevent
absolute drive paths like "C:\xxx". The logic for that is implemented as
follows:
#define has_dos_drive_prefix(path) \
(i
On Thu, Aug 8, 2019 at 12:45 PM Christopher Ertl
wrote:
> So I'm proposing to remove the check for the drive letter being alpha in
> `has_dos_drive_prefix` macro:
>
> #define has_dos_drive_prefix(path) \
> ( (path)[1] == ':' ? 2 : 0)
Nit: This isn't safe and will access memory beyond end
On 08/08/2019 12:42, Phillip Wood wrote:
On 06/08/2019 18:36, Rohit Ashiwal wrote:
rebase am already has this flag to "lie" about the author date
by changing it to the committer (current) date. Let's add the same
for interactive machinery.
Signed-off-by: Rohit Ashiwal
---
>> [...[
static c
Thanks, Eric, you're absolutely right; good spot!
Christopher Ertl | MSRC Vulnerabilities & Mitigations | Microsoft Limited
Microsoft Limited (company number 01624297) is a company registered in England
and Wales whose registered office is at Microsoft Campus, Thames Valley Park,
Reading. RG6 1
Daniel Koning writes:
> The git-blame(1) man page says that the .. range specifier can be used
> to exclude changes "older than" a certain revision.
Thanks for spoting a loose-and-colloquial use of "older than" in the
doc. As you suspect, the document wanted the phrase to be understood
as "reac
Jeff King writes:
> On Wed, Aug 07, 2019 at 11:56:14PM -0700, Jonathan Nieder wrote:
>
>> But a dash bug[*] causes it to instead expand to
>>
>> /3456789...
>>
>> The stream of symbols that makes up this function is hard for humans
>> to follow, too. The complexity mostly comes from the r
"Jeff Hostetler via GitGitGadget" writes:
> From: Jeff Hostetler
>
> Create version of sq_quote_argv_pretty() that does not
> insert a leading space before argv[0].
>
> Signed-off-by: Jeff Hostetler
> ---
> quote.c | 11 +++
> quote.h | 1 +
> 2 files changed, 12 insertions(+)
I am O
On Wed, Aug 7, 2019 at 9:11 PM Phil Hord wrote:
>
> From: Phil Hord
>
> 'git tag -d' accepts one or more tag refs to delete, but each deletion
> is done by calling `delete_ref` on each argv. This is painfully slow
> when removing from packed refs. Use delete_refs instead so all the
> removals can
On Tue, Aug 06, 2019 at 02:58:38PM -0700, Junio C Hamano wrote:
>
> * md/list-objects-filter-combo (2019-06-28) 10 commits
> - list-objects-filter-options: make parser void
> - list-objects-filter-options: clean up use of ALLOC_GROW
> - list-objects-filter-options: allow mult. --filter
> - str
Sorry for the late reply...
On Tue, Jul 30, 2019 at 3:49 PM Derrick Stolee via GitGitGadget
wrote:
>
> --- a/Documentation/config/merge.txt
> +++ b/Documentation/config/merge.txt
> @@ -54,7 +54,8 @@ merge.directoryRenames::
> moved into the new directory. If set to "conflict", a conflict
On 8/8/2019 2:34 PM, Elijah Newren wrote:
> Sorry for the late reply...
>
> On Tue, Jul 30, 2019 at 3:49 PM Derrick Stolee via GitGitGadget
> wrote:
>>
>> --- a/Documentation/config/merge.txt
>> +++ b/Documentation/config/merge.txt
>> @@ -54,7 +54,8 @@ merge.directoryRenames::
>> moved in
Elijah Newren writes:
>> --- a/Documentation/config/merge.txt
>> +++ b/Documentation/config/merge.txt
>> @@ -54,7 +54,8 @@ merge.directoryRenames::
>> moved into the new directory. If set to "conflict", a conflict
>> will be reported for such paths. If merge.renames is false,
>>
Matthew DeVore writes:
> On Tue, Aug 06, 2019 at 02:58:38PM -0700, Junio C Hamano wrote:
>>
>> * md/list-objects-filter-combo (2019-06-28) 10 commits
>> - list-objects-filter-options: make parser void
>> - list-objects-filter-options: clean up use of ALLOC_GROW
>> - list-objects-filter-option
On 8/8/2019 2:05 PM, Junio C Hamano wrote:
"Jeff Hostetler via GitGitGadget" writes:
From: Jeff Hostetler
Create version of sq_quote_argv_pretty() that does not
insert a leading space before argv[0].
Signed-off-by: Jeff Hostetler
---
quote.c | 11 +++
quote.h | 1 +
2 files
On 8/8/2019 2:59 PM, Junio C Hamano wrote:
> Elijah Newren writes:
>
>>> --- a/Documentation/config/merge.txt
>>> +++ b/Documentation/config/merge.txt
>>> @@ -54,7 +54,8 @@ merge.directoryRenames::
>>> moved into the new directory. If set to "conflict", a conflict
>>> will be rep
Hi Emily,
On Tue, 6 Aug 2019, Emily Shaffer wrote:
> On Thu, Jul 25, 2019 at 11:25:02AM +0200, Johannes Schindelin wrote:
> >
> > On Mon, 1 Jul 2019, Emily Shaffer wrote:
> >
> > > Since v2, mostly reworded comments, plus fixed the issues mentioned in
> > > the tutorial itself. Thanks Eric for th
On Thu, Aug 8, 2019 at 12:00 PM Junio C Hamano wrote:
>
> Elijah Newren writes:
>
> >> --- a/Documentation/config/merge.txt
> >> +++ b/Documentation/config/merge.txt
> >> @@ -54,7 +54,8 @@ merge.directoryRenames::
> >> moved into the new directory. If set to "conflict", a conflict
> >>
Phil Hord writes:
> From: Phil Hord
>
> 'git tag -d' accepts one or more tag refs to delete, but each deletion
> is done by calling `delete_ref` on each argv. This is painfully slow
> when removing from packed refs. Use delete_refs instead so all the
> removals can be done inside a single transa
Hi Peff,
ACK on the three patches, and I think your outline is valid (post
v2.23.0, possibly an Outreachy project?).
Thanks,
Dscho
P.S.: Sorry for top-posting, but I felt that I did not even respond to
anything you said, concretely, so...
On Tue, 6 Aug 2019, Jeff King wrote:
> On Tue, Aug 06,
Jeff Hostetler writes:
>> That is, "if we are appending to an existing string, have SP to
>> separate the first element from that existing string; treat the
>> remaining elements the same way (if the buffer is empty, there is no
>> point adding SP at the beginning)".
>
> I don't think that would
Elijah Newren writes:
> However, Stollee's commit message started with "The
> 'feature.experimental' setting includes config options that are not
> committed to become defaults".
>
> If these are settings that are "intended" but not "committed" to
> become defaults, then yes, you're absolutely ri
Hi Gábor,
On Mon, 5 Aug 2019, SZEDER Gábor wrote:
> Include the test script number, test number, and the test name at the
> start of the verbose output of each test, to help navigating the
> tests' logs.
>
> Changes since v1:
>
> - Include not only the test name, but the test script number and
Hi René,
On Thu, 8 Aug 2019, René Scharfe wrote:
> Importing the latest version of nedmalloc might make sense in general.
> The last commit in git://github.com/ned14/nedmalloc.git was done five
> years ago; is it finished? A diffstat with -b looks like this:
>
> malloc.c.h | 1193 +
Hi Carlo,
On Tue, 6 Aug 2019, Carlo Marcelo Arenas Belón wrote:
> Eitherway, since I am unable to replicate the original bug or take
> performance numbers in a representative environment without Windows
> this is only published as an RFC, eventhough it has been tested and
> considered mostly comp
On Thu, Aug 8, 2019 at 12:12 PM Derrick Stolee wrote:
>
> On 8/8/2019 2:59 PM, Junio C Hamano wrote:
> > Elijah Newren writes:
> >
> >>> --- a/Documentation/config/merge.txt
> >>> +++ b/Documentation/config/merge.txt
> >>> @@ -54,7 +54,8 @@ merge.directoryRenames::
> >>> moved into the ne
On 8/8/2019 4:07 PM, Junio C Hamano wrote:
> Elijah Newren writes:
>
>> However, Stollee's commit message started with "The
>> 'feature.experimental' setting includes config options that are not
>> committed to become defaults".
>>
>> If these are settings that are "intended" but not "committed"
On 8/8/2019 4:31 PM, Elijah Newren wrote:
> On Thu, Aug 8, 2019 at 12:12 PM Derrick Stolee wrote:
>>
>> On 8/8/2019 2:59 PM, Junio C Hamano wrote:
>>> Elijah Newren writes:
>>>
> --- a/Documentation/config/merge.txt
> +++ b/Documentation/config/merge.txt
> @@ -54,7 +54,8 @@ merge.dire
On Wed, Aug 07, 2019 at 01:08:22PM +, Yagnatinsky, Mark wrote:
> I hope this is the right mailing list, hope someone will redirect me if not...
Yes, you are at the right place, wellcome to the Git community.
> The git documentation (git help config) for core.autocrlf doesn't mention
> that f
fwiw,
jimc@frodo:~/prj-1/capnproto.git$ git branch -l
* master
I find the splat in the response unhelpful
when wrapped in shell for loop, the splat expands into everything in
current directory
jimc@frodo:~/prj-1/capnproto.git$ for b in `git branch -l`; do echo $b; done
appveyor.yml
c++
CMakeList
> Yes, do I read this as "I will send a patch" ?
Probably not, but you can read it as "I will cook up better wording and reply
to this thread"
--
This message, and any attachments, is for the intended recipient(s) only, may
cont
On Thu, Aug 8, 2019 at 2:08 PM wrote:
>
> fwiw,
>
> jimc@frodo:~/prj-1/capnproto.git$ git branch -l
> * master
>
> I find the splat in the response unhelpful
> when wrapped in shell for loop, the splat expands into everything in
> current directory
>
> jimc@frodo:~/prj-1/capnproto.git$ for b in `g
On Thu, Aug 8, 2019 at 2:20 PM Bryan Turner wrote:
>
> On Thu, Aug 8, 2019 at 2:08 PM wrote:
> >
> > fwiw,
> >
> > jimc@frodo:~/prj-1/capnproto.git$ git branch -l
> > * master
> >
> > I find the splat in the response unhelpful
> > when wrapped in shell for loop, the splat expands into everything
On Thu, Aug 08, 2019 at 03:08:06PM -0600, jim.cro...@gmail.com wrote:
> fwiw,
>
> jimc@frodo:~/prj-1/capnproto.git$ git branch -l
> * master
>
> I find the splat in the response unhelpful
> when wrapped in shell for loop, the splat expands into everything in
> current directory
>
> jimc@frodo:~/
Emily Shaffer writes:
> More generally, I think you should take a look at `git help git` and
> check out the difference between "porcelain" and "plumbing" commands.
> The former, of which `git branch` is one, are intended for interactive
> use and not really meant for scripting or piping. You can
Johannes Schindelin writes:
> On Mon, 5 Aug 2019, SZEDER Gábor wrote:
>
>> Include the test script number, test number, and the test name at the
>> start of the verbose output of each test, to help navigating the
>> tests' logs.
>> ...
>
> Looks good to me!
Thanks, both.
On Fri, Jul 26, 2019 at 11:43 AM Mark Rushakoff wrote:
>
> I am building some CI tooling, and I am working with a large-ish repository,
> so
> I am trying to start with a shallow clone of the repository and deepen it on
> demand. I am finding it very difficult to correctly switch between fetch
>
Mark Rushakoff writes:
> I have a shallow clone of a repository. Then sometime later, I obtain a bundle
> containing full history.
>
> I thought I could use git fetch --unshallow /path/to/repo.bundle
> mybranch:mybranch, but I've found that git does not support shallow fetches
> from a bundle and
Am 08.08.19 um 21:04 schrieb Jeff Hostetler:
> On 8/8/2019 2:05 PM, Junio C Hamano wrote:
>> Having made the primary purpose of the helper clearer leads me to
>> wonder if "do not add SP before the first element, i.e. argv[0]", is
>> really what we want. If we always clear the *dst strbuf before
>
Okay, my attempt at better wording for the docs is not going well, because it
turns I that I still don't understand the behavior here!
I thought that "input" means that CRLF will become LF on "git add" but that
seems to be true only sometimes.
For instance, consider the following 11-line shell sc
On Thu, Aug 8, 2019 at 11:15 AM Elijah Newren wrote:
>
> On Wed, Aug 7, 2019 at 9:11 PM Phil Hord wrote:
> >
> > From: Phil Hord
> >
> > 'git tag -d' accepts one or more tag refs to delete, but each deletion
> > is done by calling `delete_ref` on each argv. This is painfully slow
> > when removi
On Thu, Aug 8, 2019 at 12:39 PM Junio C Hamano wrote:
>
> Phil Hord writes:
>
> > From: Phil Hord
> >
> > 'git tag -d' accepts one or more tag refs to delete, but each deletion
> > is done by calling `delete_ref` on each argv. This is painfully slow
> > when removing from packed refs. Use delete
Hi Junio,
On Thu, Jul 25, 2019 at 05:19:23PM -0700, Junio C Hamano wrote:
> Here are the topics that have been cooking. Commits prefixed with
> '-' are only in 'pu' (proposed updates) while commits prefixed with
> '+' are in 'next'. The ones marked with '.' do not appear in any of
> the integrat
On 2019-08-08 at 16:44:52, Christopher Ertl wrote:
> So I'm proposing to remove the check for the drive letter being alpha in
> `has_dos_drive_prefix` macro:
>
> #define has_dos_drive_prefix(path) \
> ( (path)[1] == ':' ? 2 : 0)
Is the drive character required to be ASCII? If it can be non
Hello,
On August 8, 2019 8:13:15 PM EDT, Taylor Blau wrote:
>Hi Junio,
>
>On Thu, Jul 25, 2019 at 05:19:23PM -0700, Junio C Hamano wrote:
>> Here are the topics that have been cooking. Commits prefixed with
>> '-' are only in 'pu' (proposed updates) while commits prefixed with
>> '+' are in 'nex
Hi Ariadne,
Thank you for replying. I'm replying myself to the quoted hunks below,
and I very much appreciate your input. I would like to note that I
myself did not come up with these concerns alone, they were merely
suggested to me by a coworker, and I found them concerning.
I am not myself tran
This series is a candidate reroll for cb/pcre2-chartables-leakfix, that
hopefully addresses the root cause of the problem reported by Dscho in
Windows, where the PCRE2 library wasn't aware of the custom allocator and
was returning a pointer created with the system malloc but passing it to
NED's fre
94da9193a6 (grep: add support for PCRE v2, 2017-06-01) didn't include
a way to override the system allocator, and so it is incompatible with
USE_NED_ALLOCATOR. The problem was made visible when an attempt to
avoid a leak in a data structure that is created by the library was
passed to NED's free f
63e7e9d8b6 ("git-grep: Learn PCRE", 2011-05-09) didn't include a way
to override the system alocator, and so it is incompatible with
USE_NED_ALLOCATOR as reported by Dscho[1] (in similar code from PCRE2)
Make the minimum change possible to ensure this combination is supported
by extending grep_ini
94da9193a6 ("grep: add support for PCRE v2", 2017-06-01) introduced
a small memory leak visible with valgrind in t7813.
Complete the creation of a PCRE2 specific variable that was missing from
the original change and free the generated table just like it is done
for PCRE1.
Signed-off-by: Carlo Ma
Hello,
On Thu, Aug 8, 2019 at 9:07 PM Taylor Blau wrote:
>
> Hi Ariadne,
>
> Thank you for replying. I'm replying myself to the quoted hunks below,
> and I very much appreciate your input. I would like to note that I
> myself did not come up with these concerns alone, they were merely
> suggested
On Thu, Aug 08, 2019 at 04:43:16PM -0700, Phil Hord wrote:
> > I also get really slow times on a repo with ~20,000 tags (though order
> > ~3 minutes rather than ~30, probably due to having an SSD on this
> > machine) -- but ONLY IF the refs are packed first (git pack-refs
> > --all). If the refs
The issue of deadnaming aside, turning on log.mailmap by default is
the sensible thing to do given that other Git features already honor
it that way. Having it ignored-by-default (but only sometimes) just
adds confusion when a mailmap is available.
> > > - The '.mailmap' provides a list of trans
Hello,
On Thu, Aug 8, 2019 at 10:07 PM Phil Hord wrote:
>
> The issue of deadnaming aside, turning on log.mailmap by default is
> the sensible thing to do given that other Git features already honor
> it that way. Having it ignored-by-default (but only sometimes) just
> adds confusion when a mai
On Thu, Aug 08, 2019 at 11:08:14PM +, Yagnatinsky, Mark wrote:
> Okay, my attempt at better wording for the docs is not going well, because it
> turns I that I still don't understand the behavior here!
> I thought that "input" means that CRLF will become LF on "git add" but that
> seems to be
Git For Windows' installer can't see my Atom installation.
I got Atom directly from Atom's official site.
I think git can't see it because of this unfortunate fact.
It doesn't let you choose where to install,
and it installs to your appdata folder.
Any idea what I need to do?
On Thu, Aug 8, 2019 at 1:21 PM Johannes Schindelin
wrote:
> On Tue, 6 Aug 2019, Carlo Marcelo Arenas Belón wrote:
> > Eitherway, since I am unable to replicate the original bug or take
> > performance numbers in a representative environment without Windows
> > this is only published as an RFC, eve
90 matches
Mail list logo
