Hi Peff,
Jeff King writes:
On Tue, Jul 29, 2014 at 01:18:00AM +0200, Fabian Ruch wrote:
this is a reroll of the patch series that enables rudimentary support
of line options for git-rebase's to-do list commands and reimplements
the well-known commands `reword` and `squash` in terms of a
Hi,
Git v2.1.0-rc0 has been released for one week, and I'm sorry it's a bit late to
announce the startup of new round of l10n. This time there are 38 new
messages need to be translated since last update for v2.0.0:
l10n: git.pot: v2.1.0 round 1 (38 new, 9 removed)
Generate po/git.pot
On Sun, Aug 3, 2014 at 1:13 AM, Torsten Bögershausen tbo...@web.de wrote:
On 08/01/2014 07:55 PM, Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes:
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
Somewhat underexplained,
On Mon, Aug 4, 2014 at 12:19 AM, Junio C Hamano gits...@pobox.com wrote:
I think you, who dug to find out where to add the check, already
know this, and I am writing this mainly for myself and for the list
archive, but when the knee-jerk has-syjmlink-leading-path missing?
reaction came to me,
Tanay Abhra tanay...@gmail.com writes:
From: Matthieu Moy matthieu@grenoble-inp.fr
I usually use my @imag.fr, not @grenoble-inp.fr address as Git author
(even though my mailer has @grenoble-inp.fr as From: field). Both
addresses are equivalent so it's no big deal.
--
Matthieu Moy
Tanay Abhra tanay...@gmail.com writes:
[Patch v7]: style nit corrected. (1/8) is Matthieu's translation patch.
git_die_config_linenr() helper function added. Diff between v6
and v7 appended for review.
This series is now
Reviewed-by: Matthieu Moy matthieu@imag.fr
Thanks,
--
`git_pretty_formats_config()` continues without checking git_config_string's
return value which can lead to a SEGFAULT. Instead return -1 when
git_config_string fails signalling `git_config()` to die printing the location
of the erroneous variable.
Signed-off-by: Tanay Abhra tanay...@gmail.com
Fabian Ruch baf...@gmail.com writes:
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -555,20 +555,7 @@ do_next () {
comment_for_reflog reword
mark_action_done
- do_pick $sha1 $rest
- # TODO: Work around the fact
Tanay Abhra tanay...@gmail.com writes:
`git_pretty_formats_config()` continues without checking git_config_string's
return value which can lead to a SEGFAULT.
Indeed, without the patch:
$ git -c pretty.my= log --pretty=my
error: Missing value for 'pretty.my'
Hi Matthieu,
thanks for taking a look at this patch series. I might have caused some
confusion by starting with version v1 again after removing the RFC tag.
The current reroll[1] is tagged with PATCH v1, not PATCH RFC v2.
I'm sorry if this is the reason why your reply appears on this sub-thread.
Duy Nguyen pclo...@gmail.com writes:
Just checking, you meant CE_UPTODATE, not CE_VALID, right? CE_VALID is
only used with --assume-unchanged
Yup. Thanks.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info
René Scharfe l@web.de writes:
Am 03.08.2014 um 19:19 schrieb Junio C Hamano:
And do we need to use the threaded_ variant of the function here?
Hmmm, this is a tangent, but you comment made me wonder if we also
need to adjust preload_thread() in preload-index.c somehow, but we
do not
Philip Oakley philipoak...@iee.org writes:
Historically (5 Nov 2005 v0.99.9-46-g28ffb89) the git-format-patch used
'origin' as the upstream branch name. That name is now used as the nominal
name for the upstream remote.
While 'origin' would be DWIMmed (do what I mean) to be that remote's
Philip Oakley philipoak...@iee.org writes:
From: Junio C Hamano gits...@pobox.com
Philip Oakley philipoak...@iee.org writes:
From: Junio C Hamano gits...@pobox.com
Sent: Friday, July 25, 2014 11:08 PM
...
| Individual Developer (Participant)[[Individual Developer
(Participant)]]
|
Duy Nguyen pclo...@gmail.com writes:
I didn't realize Mike is making a lot more changes in lockfile.c, part
of that is converting lk-filename to use strbuf [1]. Perhaps I should
just withdraw this series, wait until Mike's series is merged, then
redo 3/3 on top. Or Mike could just take 3/3 in
Tanay Abhra tanay...@gmail.com writes:
Add `git_die_config` that dies printing the line number and the file name
of the highest priority value for the configuration variable `key`.
It has usage in non-callback based config value retrieval where we can
raise an error and die if there is a
Tanay Abhra tanay...@gmail.com writes:
+ grep fatal: bad config variable '\''alias.br'\'' at file line 2 in
.git/config result
This test is too tight (the full string), and also needs to know
about i18n, I think.
--
To unsubscribe from this list: send the line unsubscribe git in
the body
Junio C Hamano gits...@pobox.com writes:
Compared to that, what the user's local 'master' has is much less
relevant. For one thing, if a more recent commit that is on the
remote repository is missing on 'origin/master' because you haven't
fetched recently, by definition that commit will not
brian m. carlson sand...@crustytoothpaste.net writes:
Avoid a nonsensical misreading by moving the modifier closer to the
word it modifies.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/git-imap-send.txt | 2 +-
1 file changed, 1 insertion(+), 1
The ta/config-set API is more or less solidified.
This series builds on the top of 4c715ebb in pu (ta/config-set). On top of it,
it also requires series [1] (Rewrite `git_config()` using config-set API) for
proper error checking.
This series is the first batch of patches which rewrites the
Use `git_config_get_bool()` family instead of `git_config()` to take advantage
of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
http-backend.c | 31 ---
1 file changed, 12 insertions(+), 19 deletions(-)
Use `git_config_get_*()` family instead of `git_config()` to take advantage of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
rerere.c | 43 ---
1 file changed, 12 insertions(+), 31 deletions(-)
Use `git_config_get_*()` family instead of `git_config()` to take advantage of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
fetch-pack.c | 35 ---
1 file changed, 8 insertions(+), 27 deletions(-)
diff
Use `git_config_get_bool()` family instead of `git_config()` to take advantage
of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
archive.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/archive.c
Use `git_config_get_*()` family instead of `git_config()` to take
advantage of the config-set API which provides a cleaner control flow.
Use an intermediate value, as `version` can not be used directly in
git_config_get_int() due to incompatible type.
Signed-off-by: Tanay Abhra
Use `git_config_get_bool()` family instead of `git_config()` to take advantage
of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
daemon.c | 27 +--
1 file changed, 5 insertions(+), 22 deletions(-)
diff --git
Use `git_config_get_*()` family instead of `git_config()` to take advantage of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
builtin/gc.c | 51 ---
1 file changed, 20 insertions(+), 31
Use `git_config_get_value()` instead of `git_config()` to take advantage of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
pager.c | 40 +---
1 file changed, 13 insertions(+), 27 deletions(-)
diff
Use `git_config_get_string()` instead of `git_config()` to take advantage of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
branch.c | 27 +++
1 file changed, 7 insertions(+), 20 deletions(-)
diff --git
Use `git_config_get_string()` instead of `git_config()` to take advantage of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
alias.c | 25 ++---
1 file changed, 6 insertions(+), 19 deletions(-)
diff --git a/alias.c
Use `git_config_get_*()` family instead of `git_config()` to take advantage of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
imap-send.c | 61 +++--
1 file changed, 27
Hi,
Jeff King writes:
On Tue, Jul 29, 2014 at 01:18:03AM +0200, Fabian Ruch wrote:
Specify the git-commit option `--no-verify` to disable the pre-commit
hook when editing the log message. Because `--no-verify` also skips
the commit-msg hook, execute the hook from within
On 8/4/2014 11:37 PM, Junio C Hamano wrote:
Tanay Abhra tanay...@gmail.com writes:
Add `git_die_config` that dies printing the line number and the file name
of the highest priority value for the configuration variable `key`.
It has usage in non-callback based config value retrieval where
On Mon, Aug 4, 2014 at 11:45 AM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Tanay Abhra tanay...@gmail.com writes:
`git_pretty_formats_config()` continues without checking git_config_string's
return value which can lead to a SEGFAULT.
Indeed, without the patch:
$ git -c pretty.my=
On Mon, Aug 4, 2014 at 2:33 PM, Tanay Abhra tanay...@gmail.com wrote:
Use `git_config_get_bool()` family instead of `git_config()` to take
advantage of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
http-backend.c | 31
Steffen Prohaska proha...@zib.de writes:
The data is streamed to the filter process anyway. Better avoid mapping
the file if possible. This is especially useful if a clean filter
reduces the size, for example if it computes a sha1 for binary data,
like git media. The file size that the
Am 02.08.2014 01:10, schrieb Jeff King:
On Fri, Aug 01, 2014 at 06:37:39PM -0400, Jeff King wrote:
Btw.: Using struct-packing on 'struct bitmap_disk_entry' means that the
binary format of .bitmap files is incompatible between GCC and other
builds, correct?
The on-disk format is defined by
Am 02.08.2014 00:37, schrieb Jeff King:
On Tue, Jul 29, 2014 at 10:40:12PM +0200, Karsten Blees wrote:
The sizeof() has to be the same regardless of whether the hashmap_entry
is standalone or in another struct, and therefore must be padded up to
16 bytes. If we stored x in that padding in
Eric Sunshine sunsh...@sunshineco.com writes:
On Mon, Aug 4, 2014 at 11:45 AM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Tanay Abhra tanay...@gmail.com writes:
`git_pretty_formats_config()` continues without checking git_config_string's
return value which can lead to a SEGFAULT.
Tanay Abhra tanay...@gmail.com writes:
I was aping the old git_config() system, it also does exactly what you
described
above. for example, builtin/gc.c line 91,
if (!strcmp(var, gc.pruneexpire)) {
if (value strcmp(value, now)) {
unsigned
Lukas Fleischer g...@cryptocrack.de writes:
In c9a42c4 (bundle: allow rev-list options to exclude annotated tags,
2009-01-02), we added a test to check whether annotated tags, which fall
outside the specified date range, are excluded from bundles. However,
when initializing the repository, a
Lukas Fleischer g...@cryptocrack.de writes:
In commit c9a42c4 (bundle: allow rev-list options to exclude annotated
tags, 2009-01-02), support for excluding annotated tags outside the
specified date range was added. However, the wrong order of parameters
was chosen when calling memchr(). Fix
Tanay Abhra tanay...@gmail.com writes:
@@ -354,12 +338,11 @@ static int run_service(const char *dir, struct
daemon_service *service)
[...]
}
+
if (!enabled) {
logerror('%s': service not enabled for '%s',
service-name, path);
Avoid
Junio C Hamano gits...@pobox.com writes:
diff --git a/t/t5704-bundle.sh b/t/t5704-bundle.sh
index a45c316..2f063ea 100755
--- a/t/t5704-bundle.sh
+++ b/t/t5704-bundle.sh
@@ -6,7 +6,7 @@ test_description='some bundle related tests'
test_expect_success 'setup' '
test_commit initial
On Mon, Aug 04, 2014 at 05:45:44PM +0200, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
`git_pretty_formats_config()` continues without checking git_config_string's
return value which can lead to a SEGFAULT.
Indeed, without the patch:
$ git -c pretty.my= log --pretty=my
Tanay Abhra tanay...@gmail.com writes:
Use `git_config_get_value()` instead of `git_config()` to take advantage of
the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
pager.c | 40 +---
I find the
Tanay Abhra tanay...@gmail.com writes:
+ if (approxidate(prune_expire) = now) {
+ error(_(Invalid %s: '%s'), gc.pruneexpire,
prune_expire);
+ git_die_config(gc.pruneexpire);
+ }
That is a case
Tanay Abhra tanay...@gmail.com writes:
This series is the first batch of patches which rewrites the existing callers
using a non-callback approach.
This series aims to,
* rewrite the existing callers, as you can see from the diff stat the bew API
provides a much concise and clear control
Tanay Abhra tanay...@gmail.com writes:
On 8/4/2014 11:37 PM, Junio C Hamano wrote:
Tanay Abhra tanay...@gmail.com writes:
Add `git_die_config` that dies printing the line number and the file name
of the highest priority value for the configuration variable `key`.
It has usage in
In commit c9a42c4 (bundle: allow rev-list options to exclude annotated
tags, 2009-01-02), support for excluding annotated tags outside the
specified date range was added. However, the wrong order of parameters
was chosen when calling memchr(). Fix this by swapping the character to
search for with
In c9a42c4 (bundle: allow rev-list options to exclude annotated tags,
2009-01-02), we added a test to check whether annotated tags, which fall
outside the specified date range, are excluded from bundles. Complement
this test by also checking whether tags inside the date range are
included. Since
Jeff King p...@peff.net writes:
On Mon, Aug 04, 2014 at 05:45:44PM +0200, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
`git_pretty_formats_config()` continues without checking
git_config_string's
return value which can lead to a SEGFAULT.
Indeed, without the patch:
Hi,
Jeff King writes:
On Tue, Jul 29, 2014 at 01:18:07AM +0200, Fabian Ruch wrote:
The command line used to recreate root commits specifies the option
`-q` which suppresses the commit summary message. However,
git-rebase--interactive tends to tell the user about the commits it
creates in the
Hi Jeff,
Jeff King writes:
On Tue, Jul 29, 2014 at 01:18:08AM +0200, Fabian Ruch wrote:
The command line used to recreate root commits specifies the
effectless option `-C`. It makes git-commit reuse commit message and
authorship of the named commit. However, the commit being amended
here,
From: Junio C Hamano gits...@pobox.com
Philip Oakley philipoak...@iee.org writes:
Historically (5 Nov 2005 v0.99.9-46-g28ffb89) the git-format-patch
used
'origin' as the upstream branch name. That name is now used as the
nominal
name for the upstream remote.
While 'origin' would be DWIMmed
On Mon, Aug 04, 2014 at 11:06:03PM +0200, Matthieu Moy wrote:
Hmm. Not related to the original patch, but that really looks like a
bug. Shouldn't git -c pretty.my= ... set pretty.my to the empty string?
I'd expect git -c pretty.my ... to set it to NULL (i.e., the implicit
true you get
Philip Oakley philipoak...@iee.org writes:
This however is backwards, no? The history on 'origin/master' may
not be up-to-date in the sense that if you run 'git fetch' you might
get more, but it absolutely is up-to-date in the sense that it shows
what the origin has to the best of your
Jeff King p...@peff.net writes:
This is technically a backwards incompatibility, but I'd consider it a
simple bugfix. The existing behavior was unintentional, made no sense,
and was never documented.
Yeah, I tend to agree. I actually would not shed any tears if the
breakage were that it was
v2.1.0-rc1, the first release candidate Git for v2.1, is now
available for testing at the usual places.
The tarballs are found at:
https://www.kernel.org/pub/software/scm/git/testing/
The following public repositories all have a copy of the 'v2.1.0-rc1'
tag and the 'master' branch that the
--
Ez a web-mail rendszergazda.
Kérjük, tájékoztatni kell, hogy az e-mail szerver most lett
frissítve, és az e-mail kell frissíteni immediately.This folyamat az,
hogy a cég e-mail szerver frissítik, és a védett, mint mindig. Kérjük
kattintson az alábbi linkre és kövesse az utasításokat, hogy
From: Junio C Hamano gits...@pobox.com
Philip Oakley philipoak...@iee.org writes:
This however is backwards, no? The history on 'origin/master' may
not be up-to-date in the sense that if you run 'git fetch' you might
get more, but it absolutely is up-to-date in the sense that it shows
what
On 04/08/14 23:31, Junio C Hamano wrote:
v2.1.0-rc1, the first release candidate Git for v2.1, is now
[snip]
* The leaf function to check validity of a refname format has been
micro-optimized, using SSE2 instructions when available. A few
breakages during its development have been
On Mon, Aug 04, 2014 at 11:29:33AM -0700, Junio C Hamano wrote:
brian m. carlson sand...@crustytoothpaste.net writes:
Avoid a nonsensical misreading by moving the modifier closer to the
word it modifies.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Avoid a nonsensical misreading by removing needless text.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/git-imap-send.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt
index
brian m. carlson wrote:
--- a/Documentation/git-imap-send.txt
+++ b/Documentation/git-imap-send.txt
@@ -43,7 +43,7 @@ imap.folder::
imap.tunnel::
Command used to setup a tunnel to the IMAP server through which
commands will be piped instead of using a direct network connection
Jonathan Nieder wrote:
Should the neighboring instances of '[Rr]equired to use imap-send
be changed to plain Required, too? (I suspect yes.)
Here's what that would look like.
-- 8 --
From: brian m. carlson sand...@crustytoothpaste.net
Subject: imap-send doc: omit confusing to use imap-send
On Mon, Aug 04, 2014 at 07:51:08PM -0700, Jonathan Nieder wrote:
Jonathan Nieder wrote:
Should the neighboring instances of '[Rr]equired to use imap-send
be changed to plain Required, too? (I suspect yes.)
Here's what that would look like.
-- 8 --
From: brian m. carlson
brian m. carlson wrote:
This has an extra period at the end of the line.
Good catch.
-- 8 --
Subject: fixup! imap-send doc: omit confusing to use imap-send modifier
---
Thanks,
Jonathan
Documentation/git-imap-send.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
I,Mrs Birgit authenticate this email, you can read about me on:
http://en.wikipedia.org/wiki/Birgit_Rausing
I have funds for you to manage and disburse to various charities of your
choice. If you are sure you can handle this, it will be of help to you and
others. Please reply if you are
69 matches
Mail list logo
