Re: [PATCH v9 10/14] pkt-line: add functions to read/write flush terminated packet streams

2016-10-05 Thread Lars Schneider
> On 04 Oct 2016, at 21:53, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> > >> +int write_packetized_from_buf(const char *src_in, size_t l

Re: [PATCH v9 09/14] pkt-line: add packet_write_gently()

2016-10-05 Thread Lars Schneider
> On 04 Oct 2016, at 21:33, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> >> +static int packet_write_gently(const int fd_out, const char

Re: [PATCH v9 04/14] run-command: add wait_on_exit

2016-10-05 Thread Lars Schneider
> On 04 Oct 2016, at 21:30, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> The flag 'clean_on_exit' kills child processes spawned by Git on exit. >> A

Re: [PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it

2016-09-21 Thread Lars Schneider
> On 21 Sep 2016, at 11:31, stefan.na...@atlas-elektronik.com wrote: > > In the Subject: s/the // > > Am 21.09.2016 um 10:45 schrieb larsxschnei...@gmail.com: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> The TravisCI macOS build is broken bec

Re: [PATCH v7 10/10] convert: add filter..process option

2016-09-15 Thread Lars Schneider
> On 13 Sep 2016, at 17:22, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> diff --git a/contrib/long-running-filter/example.pl >> b/contrib/long-running-filter/example.pl >> ... >> +sub packet_read { >> +my $buffer; >> +my $bytes_read = read STDIN,

Re: [PATCH v7 04/10] pkt-line: add packet_flush_gently()

2016-09-15 Thread Lars Schneider
> On 15 Sep 2016, at 21:44, Jeff King <p...@peff.net> wrote: > > On Thu, Sep 15, 2016 at 05:42:58PM +0100, Lars Schneider wrote: > >>>>>> +int packet_flush_gently(int fd) >>>>>> +{ >>>>>> +packet_tr

Re: [PATCH] run-command: async_exit no longer needs to be public

2016-09-23 Thread Lars Schneider
> On 22 Sep 2016, at 18:56, Ramsay Jones wrote: > > > Signed-off-by: Ramsay Jones > --- > > Hi Lars, > > If you need to re-roll your 'ls/filter-process' branch, could you please > squash this into the relevant commit c42a4cbc

Re: [PATCH] run-command: async_exit no longer needs to be public

2016-09-23 Thread Lars Schneider
> On 23 Sep 2016, at 19:13, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> If you need to re-roll your 'ls/filter-process' branch, could you please >>> squash this into the relevant commit c4

Re: [PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it

2016-09-22 Thread Lars Schneider
> On 21 Sep 2016, at 18:42, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> On 21 Sep 2016, at 11:31, stefan.na...@atlas-elektronik.com wrote: >>> >>> In the Subject: s/the // >>>

Re: [PATCH v2 1/1] git-p4: Add --checkpoint-period option to sync/clone

2016-09-16 Thread Lars Schneider
> On 15 Sep 2016, at 23:17, Ori Rawlings wrote: > > Importing a long history from Perforce into git using the git-p4 tool > can be especially challenging. The `git p4 clone` operation is based > on an all-or-nothing transactionality guarantee. Under real-world >

Re: [PATCH v6 03/13] pkt-line: add packet_write_fmt_gently()

2016-08-26 Thread Lars Schneider
> On 25 Aug 2016, at 23:41, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_write_fmt() would die in case of a write error even though for >>

Re: [PATCH v6 06/13] pkt-line: add functions to read/write flush terminated packet streams

2016-08-26 Thread Lars Schneider
> On 26 Aug 2016, at 00:27, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_write_stream_with_flush_from_fd() and >> packet_write_stream_with

Re: [PATCH v6 05/13] pkt-line: add packet_write_gently()

2016-08-26 Thread Lars Schneider
> On 25 Aug 2016, at 23:50, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_write_fmt() has two shortcomings. First, it uses format_packet() >> whi

Re: [PATCH v6 06/13] pkt-line: add functions to read/write flush terminated packet streams

2016-08-29 Thread Lars Schneider
> On 26 Aug 2016, at 19:21, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >> OK, what function names would be more clear from your point of view? >> >> write_packetized_stream_fro

Re: [PATCH v6 05/13] pkt-line: add packet_write_gently()

2016-08-29 Thread Lars Schneider
> On 26 Aug 2016, at 19:15, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> Do you anticipate future need of non-gently variant of this >>> function? If so, perhaps a helper that takes a boolea

Re: [PATCH v6 09/13] convert: modernize tests

2016-08-29 Thread Lars Schneider
> On 26 Aug 2016, at 22:03, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Use `test_config` to set the config, check that files are empty with >> `t

Re: [PATCH v6 00/13] Git filter protocol

2016-08-29 Thread Lars Schneider
> On 25 Aug 2016, at 13:07, larsxschnei...@gmail.com wrote: > > From: Lars Schneider <larsxschnei...@gmail.com> > > The goal of this series is to avoid launching a new clean/smudge filter > process for each file that is filtered. > > A short summary about v1 to

Re: [PATCH v6 03/13] pkt-line: add packet_write_fmt_gently()

2016-08-25 Thread Lars Schneider
On 25 Aug 2016, at 20:12, Stefan Beller wrote: >> +int packet_write_fmt_gently(int fd, const char *fmt, ...) >> +{ >> + static struct strbuf buf = STRBUF_INIT; >> + va_list args; >> + >> + strbuf_reset(); >> + va_start(args, fmt); >> +

Re: [PATCH v6 07/13] pack-protocol: fix maximum pkt-line size

2016-08-25 Thread Lars Schneider
> On 25 Aug 2016, at 20:59, Stefan Beller <sbel...@google.com> wrote: > >> On Thu, Aug 25, 2016 at 4:07 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> According to LARGE_PACKET_MAX in pkt-line.h the

Re: [PATCH v6 10/13] convert: generate large test files only once

2016-08-25 Thread Lars Schneider
> On 25 Aug 2016, at 21:17, Stefan Beller <sbel...@google.com> wrote: > >> On Thu, Aug 25, 2016 at 4:07 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Generate more interesting large test files &g

Re: [PATCH v6 06/13] pkt-line: add functions to read/write flush terminated packet streams

2016-08-25 Thread Lars Schneider
> On 25 Aug 2016, at 20:46, Stefan Beller <sbel...@google.com> wrote: > >> On Thu, Aug 25, 2016 at 4:07 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_write_stream_with_flush_from_fd() and &g

Re: [PATCH v8 07/11] pkt-line: add functions to read/write flush terminated packet streams

2016-09-27 Thread Lars Schneider
> On 27 Sep 2016, at 11:00, Jeff King <p...@peff.net> wrote: > > On Tue, Sep 27, 2016 at 10:14:16AM +0200, Lars Schneider wrote: > >>>>> + strbuf_grow(sb_out, PKTLINE_DATA_MAXLEN+1); >>>>> + paket_len = packet_read(fd_in, NULL, NU

Re: [PATCH v8 00/11] Git filter protocol

2016-09-29 Thread Lars Schneider
> On 28 Sep 2016, at 23:49, Junio C Hamano wrote: > > I suspect that you are preparing a reroll already, but the one that > is sitting in 'pu' seems to be flaky in t/t0021 and I seem to see > occasional failures from it. > > I didn't trace where the test goes wrong, but one

Re: [PATCH v8 00/11] Git filter protocol

2016-10-03 Thread Lars Schneider
> On 03 Oct 2016, at 19:02, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> If the filter process refuses to die forever when Git told it to >>> shutdown (by closing the pipe to it, for example), t

Re: [PATCH v8 00/11] Git filter protocol

2016-10-03 Thread Lars Schneider
> On 01 Oct 2016, at 22:48, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 01.10.2016 o 20:59, Lars Schneider pisze: >> On 29 Sep 2016, at 23:27, Junio C Hamano <gits...@pobox.com> wrote: >>> Lars Schneider <larsxschnei...@gmail.com> writes: >

Re: [PATCH v8 11/11] convert: add filter..process option

2016-09-30 Thread Lars Schneider
> On 27 Sep 2016, at 17:37, Jakub Narębski wrote: > > Part second of the review of 11/11. > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: > >> + >> +if (!drv->process && (CAP_CLEAN & wanted_capability) && drv->clean) > > This is just a very minor

Re: [PATCH v8 11/11] convert: add filter..process option

2016-09-30 Thread Lars Schneider
> On 27 Sep 2016, at 00:41, Jakub Narębski <jna...@gmail.com> wrote: > > Part first of the review of 11/11. > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> diff --git a/Docume

Re: [PATCH v8 07/11] pkt-line: add functions to read/write flush terminated packet streams

2016-09-27 Thread Lars Schneider
On 26 Sep 2016, at 22:23, Lars Schneider <larsxschnei...@gmail.com> wrote: > > On 25 Sep 2016, at 15:46, Jakub Narębski <jna...@gmail.com> wrote: > >> W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: >>> From: Lars

Re: [PATCH v8 00/11] Git filter protocol

2016-10-01 Thread Lars Schneider
> On 29 Sep 2016, at 23:27, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >> We discussed that issue in v4 and v6: >> http://public-inbox.org/git/20160803225313.pk3tfe5ovz4y3...@sigill.intra.peff

Re: [PATCH v8 11/11] convert: add filter..process option

2016-10-01 Thread Lars Schneider
> On 29 Sep 2016, at 01:14, Jakub Narębski wrote: > > Part third (and last) of the review of v8 11/11. > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com napisał: > > >> @@ -31,7 +31,10 @@ test_expect_success setup ' >> cat test >test.i && >> git add test

Re: [PATCH v8 00/11] Git filter protocol

2016-09-29 Thread Lars Schneider
> On 29 Sep 2016, at 18:57, Junio C Hamano wrote: > > Torsten Bögershausen writes: > >>> 1) Git exits >>> 2) The filter process receives EOF and prints "STOP" to the log >>> 3) t0021 checks the content of the log >>> >>> Sometimes 3 happened before 2 which

Re: [PATCH v3 0/3] quick reroll of Lars's git_open() w/ O_CLOEXEC

2016-10-25 Thread Lars Schneider
> On 25 Oct 2016, at 20:16, Junio C Hamano wrote: > > Here is to make sure everybody is on the same page regarding the > series. The patches are adjusted for comments from Eric and Dscho. Thank you, Junio! Your v3 looks good to me and I compiled and tested it on Windows.

Re: [PATCH v1 1/2] config.mak.in: set NO_OPENSSL and APPLE_COMMON_CRYPTO for macOS >10.11

2016-11-09 Thread Lars Schneider
> On 09 Nov 2016, at 09:18, Torsten Bögershausen <tbo...@web.de> wrote: > > On 07.11.16 18:26, Jeff King wrote: >> On Sun, Nov 06, 2016 at 08:35:04PM +0100, Lars Schneider wrote: >> >>> Good point. I think I found an even easier way to achieve the same. &

Re: [PATCH 1/4] t0021: use write_script to create rot13 shell script

2016-11-06 Thread Lars Schneider
> On 02 Nov 2016, at 19:17, Jeff King wrote: > > This avoids us fooling around with $SHELL_PATH and the > executable bit ourselves. > > Signed-off-by: Jeff King > --- > t/t0021-conversion.sh | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff

Re: [PATCH 4/4] t0021: fix filehandle usage on older perl

2016-11-06 Thread Lars Schneider
> On 02 Nov 2016, at 19:23, Jeff King wrote: > > The rot13-filter.pl script calls methods on implicitly > defined filehandles (STDOUT, and the result of an open() > call). Prior to perl 5.13, these methods are not > automatically loaded, and perl will complain with: > > Can't

Re: [PATCH 3/4] t0021: use $PERL_PATH for rot13-filter.pl

2016-11-06 Thread Lars Schneider
> On 02 Nov 2016, at 19:20, Jeff King wrote: > > The rot13-filter.pl script hardcodes "#!/usr/bin/perl", and > does not respect $PERL_PATH at all. That is a problem if the > system does not have perl at that path, or if it has a perl > that is too old to run a complicated script

Re: [PATCH (optional)] t0021: use arithmetic expansion to trim whitespace from wc -c output

2016-11-06 Thread Lars Schneider
> On 03 Nov 2016, at 21:22, Johannes Sixt wrote: > > Instead of a pipeline with sed and a useless use of cat, return the > unmodified text of wc -c from function file_size, but substitute the > result with arithmetic expansion to get rid of the leading whitespace > that some

Re: [PATCH 1/4] t0021: use write_script to create rot13 shell script

2016-11-06 Thread Lars Schneider
> On 06 Nov 2016, at 15:29, Jeff King <p...@peff.net> wrote: > > On Sun, Nov 06, 2016 at 03:25:33PM +0100, Lars Schneider wrote: > >> This looks good to me (and it works on my machine). >> However, I took a look at the "write_script" function and f

Re: [PATCH v5 08/27] sequencer: completely revamp the "todo" script parsing

2016-11-06 Thread Lars Schneider
> On 21 Oct 2016, at 14:24, Johannes Schindelin > wrote: > > When we came up with the "sequencer" idea, we really wanted to have > kind of a plumbing equivalent of the interactive rebase. Hence the > choice of words: the "todo" script, a "pick", etc. > > ... > >

Re: [PATCH] t0021: expect more variations in the output of uniq -c

2016-11-06 Thread Lars Schneider
ere it is as a proper patch. > > Am 03.11.2016 um 01:41 schrieb Lars Schneider: >>> On 2 Nov 2016, at 18:03, Johannes Sixt <j...@kdbg.org> wrote: >>> +sort "$FILE" | uniq -c | >>> +sed -e "s/^ *[0-9][0-9]* *IN: /x IN: /" >

Re: [PATCH 2/4] t0021: put $TEST_ROOT in $PATH

2016-11-06 Thread Lars Schneider
> On 02 Nov 2016, at 19:18, Jeff King wrote: > > We create a rot13.sh script in the trash directory, but need > to call it by its full path when we have moved our cwd to > another directory. Let's just put $TEST_ROOT in our $PATH so > that the script is always found. > > This is

Re: [PATCH v1 1/2] config.mak.in: set NO_OPENSSL and APPLE_COMMON_CRYPTO for macOS >10.11

2016-11-06 Thread Lars Schneider
> On 17 Oct 2016, at 11:50, Jeff King <p...@peff.net> wrote: > > On Sun, Oct 16, 2016 at 05:25:49PM -0700, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Apple removed the OpenSSL header files in macOS 10.11

Re: [PATCH v1 2/2] travis-ci: disable GIT_TEST_HTTPD for macOS

2016-11-06 Thread Lars Schneider
> On 17 Oct 2016, at 02:25, larsxschnei...@gmail.com wrote: > > From: Lars Schneider <larsxschnei...@gmail.com> > > TravisCI changed their default macOS image from 10.10 to 10.11 [1]. > Unfortunately the HTTPD tests do not run out of the box using the > pre-installe

Re: [PATCH (optional)] t0021: use arithmetic expansion to trim whitespace from wc -c output

2016-11-06 Thread Lars Schneider
> On 06 Nov 2016, at 20:31, Johannes Sixt <j...@kdbg.org> wrote: > > Am 06.11.2016 um 16:45 schrieb Lars Schneider: >> >>> On 03 Nov 2016, at 21:22, Johannes Sixt <j...@kdbg.org> wrote: >>> This is a pure optimization that reduces the numb

Re: [git-for-windows] [ANNOUNCE] Prerelease: Git for Windows v2.11.0-rc0

2016-11-09 Thread Lars Schneider
On 05 Nov 2016, at 10:50, Johannes Schindelin wrote: > Dear Git users, > > I finally got around to rebase the Windows-specific patches (which seem to > not make it upstream as fast as we get new ones) on top of upstream Git > v2.11.0-rc0, and to bundle installers,

Re: [git-for-windows] [ANNOUNCE] Prerelease: Git for Windows v2.11.0-rc0

2016-11-11 Thread Lars Schneider
On 10 Nov 2016, at 22:39, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Lars, > > On Wed, 9 Nov 2016, Lars Schneider wrote: > >> On 05 Nov 2016, at 10:50, Johannes Schindelin <johannes.schinde...@gmx.de> >> wrote: >> >>>

Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-11 Thread Lars Schneider
On 11 Nov 2016, at 10:31, Jeff King <p...@peff.net> wrote: > On Fri, Nov 11, 2016 at 10:28:56AM +0100, Lars Schneider wrote: > >>> Yeah, that is the solution I was going to suggest. The credentials are >>> totally orthogonal to the filters, and

Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-11 Thread Lars Schneider
On 10 Nov 2016, at 17:08, Jeff King <p...@peff.net> wrote: > On Thu, Nov 10, 2016 at 01:10:17PM +0100, Matthieu Moy wrote: > >> Lars Schneider <larsxschnei...@gmail.com> writes: >> >>> I haven't looked at an implemenation approach at all. I wonder if t

Re: [PATCH v1 0/2] Fix default macOS build locally and on Travis CI

2016-11-11 Thread Lars Schneider
On 10 Nov 2016, at 22:34, Junio C Hamano <gits...@pobox.com> wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> I've followed what was available at the public-inbox archive, but it >>> is unclear what the conclusion was. >>> >

Re: [PATCH v1 2/2] travis-ci: disable GIT_TEST_HTTPD for macOS

2016-11-11 Thread Lars Schneider
On 11 Nov 2016, at 09:47, Jeff King <p...@peff.net> wrote: > On Fri, Nov 11, 2016 at 09:22:51AM +0100, Lars Schneider wrote: > >> There would be an alternative way to approach the problem: >> Someone (GitHub?, BitBucket?, GitLab?, ...) could setup a bunch of we

Re: [PATCH v1 2/2] travis-ci: disable GIT_TEST_HTTPD for macOS

2016-11-11 Thread Lars Schneider
On 10 Nov 2016, at 17:10, Jeff King <p...@peff.net> wrote: > On Thu, Nov 10, 2016 at 12:07:14PM +0100, Lars Schneider wrote: > >>> Using Apache in the tests has been the source of frequent portability >>> problems and configuration headaches. I do wonder if we'

Re: [PATCH v1 0/2] Fix default macOS build locally and on Travis CI

2016-11-10 Thread Lars Schneider
> On 10 Nov 2016, at 00:39, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Apple removed the OpenSSL header files in macOS and therefore Git does >>

[RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-10 Thread Lars Schneider
Hi, we just implemented the first "real-world" user of the new clean/smudge "filter protocol" interface (see "convert: add filter..process option" edcc858 for details) and the results are fantastic. Filtering 12,000 files in my artificial test repo is more than 60x faster (depending on the

Re: [PATCH v1 2/2] travis-ci: disable GIT_TEST_HTTPD for macOS

2016-11-10 Thread Lars Schneider
> On 07 Nov 2016, at 22:20, Jeff King <p...@peff.net> wrote: > > On Sun, Nov 06, 2016 at 10:42:36PM +0100, Lars Schneider wrote: > >>> From: Lars Schneider <larsxschnei...@gmail.com> >>> >>> TravisCI changed their default macOS image from 10

Re: What's cooking in git.git (Oct 2016, #04; Mon, 17)

2016-10-18 Thread Lars Schneider
> On 17 Oct 2016, at 15:28, Junio C Hamano wrote: > ... > > * ls/filter-process (2016-10-17) 14 commits > - contrib/long-running-filter: add long running filter example > - convert: add filter..process option > - convert: prepare filter..process option > - convert: make

Re: What's cooking in git.git (Oct 2016, #05; Thu, 20)

2016-10-21 Thread Lars Schneider
> On 21 Oct 2016, at 06:08, Johannes Schindelin > wrote: > > Hi Junio & Lars, > > On Thu, 20 Oct 2016, Junio C Hamano wrote: > >> * ls/filter-process (2016-10-17) 14 commits >> (merged to 'next' on 2016-10-19 at ffd0de042c) >> + contrib/long-running-filter: add

Re: [PATCH 0/3] fix travis TAP/--verbose conflict

2016-10-24 Thread Lars Schneider
> On 21 Oct 2016, at 12:41, Jeff King wrote: > > On Fri, Oct 21, 2016 at 04:43:48AM -0400, Jeff King wrote: > >> The obvious fix would be to send "--verbose" output to stderr, but I >> suspect that would end up annoying for people who do: >> >> ./t5547-push-quarantine.sh -v |

Re: [PATCH v2 2/2] read-cache: make sure file handles are not inherited by child processes

2016-10-24 Thread Lars Schneider
> On 24 Oct 2016, at 21:22, Johannes Sixt <j...@kdbg.org> wrote: > > Am 24.10.2016 um 20:03 schrieb larsxschnei...@gmail.com: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> This fixes "convert: add filter..process option" (edcc8581) o

Prove "Tests out of sequence" Error

2016-10-20 Thread Lars Schneider
Hi, on TravisCI I see these weird "Tests out of sequence" errors with prove and they seem to not go away. I assume the reason that they not go away is that the ".prove" file is carried over from on build to another (but I can't look into this file on TravisCI). Has anyone an idea where these

Re: [PATCH] t0021, t5615: use $PWD instead of $(pwd) in PATH-like shell variables

2016-11-14 Thread Lars Schneider
> On 13 Nov 2016, at 02:13, Junio C Hamano wrote: > > Johannes Schindelin writes: > >>> Thanks. Dscho, does this fix both of these issues to you? >> >> Apparently it does because the CI jobs for `master` and for `next` pass. > > OK, thanks for

Re: RFC: Enable delayed responses to Git clean/smudge filter requests

2016-11-24 Thread Lars Schneider
> On 15 Nov 2016, at 19:03, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> The filter itself would need to be aware of parallelism >>> if it lives for multiple objects, right? >> >> Cor

Re: RFC: Enable delayed responses to Git clean/smudge filter requests

2016-11-17 Thread Lars Schneider
> On 17 Nov 2016, at 00:46, Junio C Hamano wrote: > > Jakub Narębski writes: > >>> I intend to implement this feature only for the new long running filter >>> process protocol. OK with you? >> >> If I remember and understand it correctly, current version

Re: RFC: Enable delayed responses to Git clean/smudge filter requests

2016-11-16 Thread Lars Schneider
> On 16 Nov 2016, at 19:15, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> * You'd need to rein in the maximum parallelism somehow, as you do >>> not want to see hundreds of competing filter pro

Re: RFC: Enable delayed responses to Git clean/smudge filter requests

2016-11-15 Thread Lars Schneider
> On 15 Nov 2016, at 02:03, Eric Wong <e...@80x24.org> wrote: > > Lars Schneider <larsxschnei...@gmail.com> wrote: >> Hi, >> >> Git always performs a clean/smudge filter on files in sequential order. >> Sometimes a filter operation can take

Re: RFC: Enable delayed responses to Git clean/smudge filter requests

2016-11-16 Thread Lars Schneider
On 15 Nov 2016, at 19:03, Junio C Hamano <gits...@pobox.com> wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> The filter itself would need to be aware of parallelism >>> if it lives for multiple objects, right? >> >> Correct.

Re: 2.11.0-rc1 will not be tagged for a few days

2016-11-11 Thread Lars Schneider
> On 11 Nov 2016, at 17:13, Johannes Schindelin > wrote: > > Hi Junio, > > On Thu, 10 Nov 2016, Junio C Hamano wrote: > >> Junio C Hamano writes: >> >>> I'll report back an updated schedule when able. >> >> I pushed some updates out on

Re: 2.11.0-rc1 will not be tagged for a few days

2016-11-11 Thread Lars Schneider
> On 11 Nov 2016, at 18:31, Lars Schneider <larsxschnei...@gmail.com> wrote: > >> >> On 11 Nov 2016, at 18:05, Lars Schneider <larsxschnei...@gmail.com> wrote: >> >> >>> On 11 Nov 2016, at 17:13, Johannes Schindelin <johannes.schinde...@

Re: 2.11.0-rc1 will not be tagged for a few days

2016-11-11 Thread Lars Schneider
> On 11 Nov 2016, at 18:05, Lars Schneider <larsxschnei...@gmail.com> wrote: > > >> On 11 Nov 2016, at 17:13, Johannes Schindelin <johannes.schinde...@gmx.de> >> wrote: >> >> Hi Junio, >> >> On Thu, 10 Nov 2016, Junio C Hamano

Re: [PATCH v1 2/2] travis-ci: disable GIT_TEST_HTTPD for macOS

2016-11-15 Thread Lars Schneider
> On 15 Nov 2016, at 13:07, Heiko Voigt <hvo...@hvoigt.net> wrote: > > On Fri, Nov 11, 2016 at 09:22:51AM +0100, Lars Schneider wrote: >> To all macOS users on the list: >> Does anyone execute the tests with GIT_TEST_HTTPD enabled successfully? > > Nope

RFC: Enable delayed responses to Git clean/smudge filter requests

2016-11-14 Thread Lars Schneider
Hi, Git always performs a clean/smudge filter on files in sequential order. Sometimes a filter operation can take a noticeable amount of time. This blocks the entire Git process. I would like to give a filter process the possibility to answer Git with "I got your request, I am processing it,

Re: 2.11.0-rc1 will not be tagged for a few days

2016-11-12 Thread Lars Schneider
> On 11 Nov 2016, at 22:22, Johannes Sixt wrote: > > Am 11.11.2016 um 22:07 schrieb Junio C Hamano: >> Junio C Hamano writes: >> >>> OK, then let's have >>> >>> filter_git () { >>> rm -f rot13-filter.log && >>> git "$@" >>>

Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-12 Thread Lars Schneider
> On 11 Nov 2016, at 21:27, Jeff King wrote: > > On Fri, Nov 11, 2016 at 09:02:52PM +0100, Dennis Kaarsemaker wrote: > Are you sure about that? If I do: echo url=https://example.com/repo.git | git credential fill I get prompted for a username and

Re: What's cooking in git.git (Oct 2016, #09; Mon, 31)

2016-11-02 Thread Lars Schneider
On 2 Nov 2016, at 17:04, Torsten Bögershausen wrote: >> * ls/filter-process (2016-10-17) 14 commits >> (merged to 'next' on 2016-10-19 at ffd0de042c) > > Some (late, as I recently got a new battery for the Mac OS 10.6 test system) > comments: > t0021 failes here: > > > Can't

Re: What's cooking in git.git (Oct 2016, #09; Mon, 31)

2016-11-03 Thread Lars Schneider
> On 2 Nov 2016, at 17:43, Johannes Sixt wrote: > > Am 02.11.2016 um 18:04 schrieb Torsten Bögershausen: >>> * ls/filter-process (2016-10-17) 14 commits >>> (merged to 'next' on 2016-10-19 at ffd0de042c) >> >> Some (late, as I recently got a new battery for the Mac OS 10.6 test

Re: [PATCH v11 13/14] convert: add filter..process option

2016-11-02 Thread Lars Schneider
> On 2 Nov 2016, at 18:03, Johannes Sixt wrote: > >> Am 17.10.2016 um 01:20 schrieb larsxschnei...@gmail.com: >> +# Compare two files and ensure that `clean` and `smudge` respectively are >> +# called at least once if specified in the `expect` file. The actual >> +# invocation

Re: [PATCH v10 13/14] convert: add filter..process option

2016-10-11 Thread Lars Schneider
> On 09 Oct 2016, at 07:32, Torsten Bögershausen wrote: > > On 09.10.16 01:06, Jakub Narębski wrote: >>> + +packet: git< status=abort +packet: git< + + +After the filter has processed

Re: [PATCH v10 13/14] convert: add filter..process option

2016-10-11 Thread Lars Schneider
> On 09 Oct 2016, at 01:06, Jakub Narębski <jna...@gmail.com> wrote: > > Part 1 of review, starting with the protocol v2 itself. > > W dniu 08.10.2016 o 13:25, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >

Re: [PATCH v10 13/14] convert: add filter..process option

2016-10-11 Thread Lars Schneider
> On 10 Oct 2016, at 21:58, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > > [...] >> +# Count unique lines except clean invocations in two files and compare >> +# them. Clean invocations are not counted because their number can vary. >> +# c.f. >>

Re: [PATCH] convert: mark a file-local symbol static

2016-10-15 Thread Lars Schneider
> On 15 Oct 2016, at 14:01, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: > > > > On 15/10/16 16:05, Lars Schneider wrote: >>> On 11 Oct 2016, at 16:46, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: > [snip] >>> -void stop_multi_file_f

Re: [PATCH v10 04/14] run-command: add clean_on_exit_handler

2016-10-16 Thread Lars Schneider
> On 16 Oct 2016, at 01:03, Johannes Schindelin <johannes.schinde...@gmx.de> > wrote: > > Hi Lars, > > On Sat, 15 Oct 2016, Lars Schneider wrote: > >> >>> On 11 Oct 2016, at 05:12, Johannes Schindelin <johannes.schinde...@gmx.de> >>>

[RFC] Case insensitive Git attributes

2016-10-16 Thread Lars Schneider
Hi, Git attributes for path names are generally case sensitive. However, on a case insensitive file system (e.g. macOS/Windows) they appear to be case insensitive (`*.bar` would match `foo.bar` and `foo.BAR`). That works great until a Git users joins the party with a case sensitive file

Re: [PATCH v10 13/14] convert: add filter..process option

2016-10-16 Thread Lars Schneider
> On 11 Oct 2016, at 03:09, Torsten Bögershausen <tbo...@web.de> wrote: > > On Tue, Oct 11, 2016 at 10:11:22AM +0200, Lars Schneider wrote: >> >>> On 10 Oct 2016, at 21:58, Junio C Hamano <gits...@pobox.com> wrote: >

Re: [PATCH v10 14/14] contrib/long-running-filter: add long running filter example

2016-10-15 Thread Lars Schneider
> On 08 Oct 2016, at 22:42, Torsten Bögershausen <tbo...@web.de> wrote: > > On 08.10.16 13:25, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Add a simple pass-thru filter as example implementation for th

Re: [PATCH v10 13/14] convert: add filter..process option

2016-10-15 Thread Lars Schneider
@Peff: If you have time, it would be great if you could comment on one question below prefixed with "@Peff". Thanks! > On 12 Oct 2016, at 03:54, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 12.10.2016 o 00:26, Lars Schneider pisze: >>> On 09 Oct 2

Re: [PATCH v10 04/14] run-command: add clean_on_exit_handler

2016-10-15 Thread Lars Schneider
> On 11 Oct 2016, at 05:12, Johannes Schindelin > wrote: > > Hi Lars, > > On Sat, 8 Oct 2016, larsxschnei...@gmail.com wrote: > >> @@ -31,6 +32,15 @@ static void cleanup_children(int sig, int in_signal) >> while (children_to_clean) { >> struct

Re: [PATCH] convert: mark a file-local symbol static

2016-10-15 Thread Lars Schneider
> On 11 Oct 2016, at 16:46, Ramsay Jones wrote: > > If you need to re-roll your 'ls/filter-process' branch, could you > please squash this into commit 85290197 > ("convert: add filter..process option", 08-10-2016). > > > -void stop_multi_file_filter(struct

Re: Serious bug with Git-2.11.0-64-bit and Git-LFS

2016-12-08 Thread Lars Schneider
ci-Fi Effects/Effects/Debris/Meshes/debris_junk.FBX" git commit -m "Move files properly to GitLFS" git push Afterwards you should be able to use the latest version of Git and GitLFS without trouble. Cheers, Lars PS: Top posting is not that popular in the Git community ;-) > >

Re: Serious bug with Git-2.11.0-64-bit and Git-LFS

2016-12-08 Thread Lars Schneider
> On 08 Dec 2016, at 12:46, Nick Warr wrote: > > Using Git-2.11.0 with the latest git-lfs 1.5.2 (also tested with > 1.5.3) cloning from our locally hosted gitlab CE server via HTTPS. > > When cloning a repo (large, 3.3 gig in git, 10.3 in LFS) for the > first time

Re: test failure

2016-12-17 Thread Lars Schneider
> On 16 Dec 2016, at 21:32, Ramsay Jones wrote: > > Hi Lars, > > For the last two days, I've noticed t0021.15 on the 'pu' branch has been > failing intermittently (well it fails with: 'make test >ptest-out', but > when run by hand, it fails only say 1-in-6,

Re: test failure

2016-12-17 Thread Lars Schneider
> On 17 Dec 2016, at 15:28, Lars Schneider <larsxschnei...@gmail.com> wrote: > > >> On 16 Dec 2016, at 21:32, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: >> >> Hi Lars, >> >> For the last two days, I've noticed t0021.15 on the 'p

Re: [PATCH v1] convert: add "status=delayed" to filter process protocol

2017-01-11 Thread Lars Schneider
> On 09 Jan 2017, at 00:42, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Some `clean` / `smudge` filters might require a significant amount of >> ti

Re: [PATCH v1] convert: add "status=delayed" to filter process protocol

2017-01-11 Thread Lars Schneider
> On 08 Jan 2017, at 21:45, Eric Wong wrote: > > larsxschnei...@gmail.com wrote: >> +++ b/t/t0021/rot13-filter.pl > >> +$DELAY{'test-delay1.r'} = 1; >> +$DELAY{'test-delay3.r'} = 3; >> >> open my $debug, ">>", "rot13-filter.log" or die "cannot open log file: $!"; >> >> @@

Re: [PATCH v1] convert: add "status=delayed" to filter process protocol

2017-01-11 Thread Lars Schneider
> On 10 Jan 2017, at 23:11, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 09.01.2017 o 00:42, Junio C Hamano pisze: >> larsxschnei...@gmail.com writes: >>> From: Lars Schneider <larsxschnei...@gmail.com> >>> >>> Some `clean`

Re: [PATCH v1] convert: add "status=delayed" to filter process protocol

2017-01-11 Thread Lars Schneider
> On 08 Jan 2017, at 21:14, Torsten Bögershausen <tbo...@web.de> wrote: > > On Sun, Jan 08, 2017 at 08:17:36PM +0100, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Some `clean` / `smudge` filters might require a s

Re: [PATCH v1] convert: add "status=delayed" to filter process protocol

2017-01-11 Thread Lars Schneider
> On 10 Jan 2017, at 00:38, Taylor Blau wrote: > > I've been considering some alternative approaches in order to make the > communication between Git and any extension that implements this protocol more > intuitive. > > In particular, I'm considering alternatives to: > >>

Re: RFC: Enable delayed responses to Git clean/smudge filter requests

2017-01-11 Thread Lars Schneider
> On 09 Jan 2017, at 21:44, Stefan Beller <sbel...@google.com> wrote: > > On Mon, Nov 14, 2016 at 1:09 PM, Lars Schneider > <larsxschnei...@gmail.com> wrote: >> Hi, >> >> Git always performs a clean/smudge filter on files in sequential order

Re: [RFC/PATCH v3 00/16] Add initial experimental external ODB support

2016-12-03 Thread Lars Schneider
> On 30 Nov 2016, at 22:04, Christian Couder wrote: > > Goal > > > Git can store its objects only in the form of loose objects in > separate files or packed objects in a pack file. > > To be able to better handle some kind of objects, for example big > blobs,

Re: [PATCH v1] git-p4: add config to retry p4 commands; retry 3 times by default

2016-12-05 Thread Lars Schneider
> On 04 Dec 2016, at 15:03, larsxschnei...@gmail.com wrote: > > From: Lars Schneider <lars.schnei...@autodesk.com> Hi Junio, if you decide to queue this patch and/or the "git-p4: fix empty file processing for large file system backend GitLFS", please use my signed-of

Re: [PATCH 1/2] asciidoctor: fix user-manual to be built by `asciidoctor`

2017-01-05 Thread Lars Schneider
> On 04 Jan 2017, at 09:08, Jeff King wrote: > > On Mon, Jan 02, 2017 at 05:03:57PM +0100, Johannes Schindelin wrote: > >> From: =?UTF-8?q?=EB=A7=88=EB=88=84=EC=97=98?= >> >> The `user-manual.txt` is designed as a `book` but the `Makefile` wants >> to

Re: What's cooking in git.git (Dec 2016, #08; Tue, 27)

2016-12-29 Thread Lars Schneider
> On 28 Dec 2016, at 00:11, Junio C Hamano wrote: > > > * bw/realpath-wo-chdir (2016-12-22) 5 commits > (merged to 'next' on 2016-12-22 at fea8fa870f) > + real_path: canonicalize directory separators in root parts > + real_path: have callers use real_pathdup and

<    1   2   3   4   5   6   7   8   9   10   >