Re: [PATCH] blame: add option to print tips (--tips)

Hey Junio, On Tue, Jan 24, 2017 at 12:06 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> We can probably make it useful with some extended efforts. I use >> git-blame and I sometimes find that I don't need things

Re: [PATCH] tag: add tag.createReflog option

Hey Cornelius, On Wed, Jan 25, 2017 at 5:49 AM, wrote: > From: Cornelius Weig > > Git does not create a history for tags, in contrast to common > expectation to simply version everything. This can be changed by using > the

SoC Microprojects 2017

blocked by institute proxy) but I have included it as a link[1]. And here is the PR[2]. [1]: https://patch-diff.githubusercontent.com/raw/git/git.github.io/pull/219.patch [2]: https://github.com/git/git.github.io/pull/219 Regards, Pranit Bauva

Re: feature request: user email config per domain

e the repo will get the first preference and then the global ~/.gitconfig. This will work for you assuming that you have different repos for your company and for your open source work. Will this solve your problem? Regards, Pranit Bauva

Re: [PATCH 3/3] show-branch: use skip_prefix to drop magic numbers

me); > } > } > Did you purposely miss the one in line number 278 of builtin/show-branch.c because I think you only touched up the parts which were related to "refs/" but didn't explicitly mention it in the commit message? if (starts_with(pretty_str, "[PATC

Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C

r > put: if you send another iteration of the patch series), please squash > this fix in. > > Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> Thanks for making this fix! :) I will squash it in. Regards, Pranit Bauva

Re: [PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C

free(bad_ref); > - if (!good_glob) > - free(good_glob); > - if (!bad_syn) > - free(bad_syn); > - if (!good_syn) > - free(good_syn); > + free(bad_ref); > + free(good_glob); > + free(bad_syn); > + free(good_syn); > return retval; > } This helps a lot ;) Thanks! Regards, Pranit Bauva

Re: GSoC 2017: application open, deadline = February 9, 2017

sure whether I would be able to help with actual project ideas but I will try. I will do it within a week or so. Regards, Pranit Bauva

[PATCH v13 08/13] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

sc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 33 - git-bisect.sh| 20 ++-- 2 files changed, 34 insertions(+), 19 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bi

[PATCH v13 09/13] bisect--helper: `bisect_write` shell function in C

lt;chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 97 git-bisect.sh| 25 ++--- 2 files changed, 94 insertions(+), 28 deletions(-) diff --git a/builtin/bisect--helper.

[PATCH v13 06/13] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()

is_empty_file() can help to refactor a lot of code. This will be very helpful in porting "git bisect" to C. Suggested-by: Torsten Bögershausen <tbo...@web.de> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org>

[PATCH v13 05/13] t6030: explicitly test for bisection cleanup

Add test to explicitly check that 'git bisect reset' is working as expected. This is already covered implicitly by the test suite. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.

[PATCH v13 13/13] bisect--helper: `bisect_start` shell function partially in C

nei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 252 +-- git-bisect.sh| 133 + 2 files chang

[PATCH v13 11/13] bisect--helper: `bisect_next_check` & bisect_voc shell function in C

lt;chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 103 ++- git-bisect.sh| 60 ++- 2 files changed, 106 insertions(+), 57 deletions(-) diff --git a/builti

[PATCH v13 12/13] bisect--helper: `get_terms` & `bisect_terms` shell function in C

are ported, this subcommand will be retired but its implementation will be called by some other methods. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builti

[PATCH v13 03/13] bisect--helper: `write_terms` shell function in C

implementation will be called by some other method. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 36 +

[PATCH v13 02/13] bisect: rewrite `check_term_format` shell function in C

will be introduced for write_terms(). Helped-by: Johannes Schindelein <johannes.schindel...@gmx.de> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- built

[PATCH v13 07/13] bisect--helper: `bisect_reset` shell function in C

com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 48 +++- git-bisect.sh| 28 ++-- 2 files changed, 49 insertion

[PATCH v13 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

annes.schinde...@gmx.de> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 17 +++-- 1 file changed, 11 insertions(+), 6

[PATCH v13 10/13] bisect--helper: `check_and_set_terms` shell function in C

g> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 52 +++- git-bisect.sh| 36 - 2 files changed, 55 insertions(+), 33 deletions(-) diff --git a/builtin/bisect--

[PATCH v13 04/13] bisect--helper: `bisect_clean_state` shell function in C

are ported, this subcommand will be retired but its implementation will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com

Re: [PATCH v13 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

Hey everyone, On Sat, Aug 20, 2016 at 2:02 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: > `--next-all` is meant to be used as a subcommand to support multiple > "operation mode" though the current implementation does not contain any > other subcommand along side with

Re: [PATCH v13 04/13] bisect--helper: `bisect_clean_state` shell function in C

Hey, On Sat, Aug 20, 2016 at 2:02 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: > Reimplement `bisect_clean_state` shell function in C and add a > `bisect-clean-state` subcommand to `git bisect--helper` to call it from > git-bisect.sh . > > Using `--bisect-clean-state` su

Re: Editing a typo in the message given to "git commit"

hy this commands functions in a particular way (in which you think it should not) or you find a possible bug then feel free to discuss it on this mailing list. Also to save other people's time, first search for the doubt in the archives or google about it. [1]: https://groups.google.com/forum/#!forum/git-

Re: [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` shell function in C

Hey Junio, On Thu, Aug 4, 2016 at 9:15 PM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >>> Also you do not seem to check the error from the function to smudge >>> the "result" you are returning

Re: [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` shell function in C

Hey Junio, On Thu, Aug 4, 2016 at 10:20 PM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> Hey Junio, >> >> On Thu, Aug 4, 2016 at 9:15 PM, Junio C Hamano <gits...@pobox.com> wrote: >>> Pranit Ba

Re: Git in Outreachy December-March?

ly days! These days a lot of my fellow students don't really use IRC for communication and see you can see there were really less number of people inquiring about GSoC in #git-devel. We can prefer slack or any other alternative. Regards, Pranit Bauva

Re: [PATCH v14 14/27] bisect--helper: `bisect_next` and `bisect_auto_next` shell function in C

Hey Junio, Sorry for a late replay. On Fri, Aug 26, 2016 at 2:00 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> A lot of parts of bisect.c uses exit() and these signals are then >> trapped in the `bisect_start` fu

Re: [PATCH v14 14/27] bisect--helper: `bisect_next` and `bisect_auto_next` shell function in C

Hey Junio, On Tue, Aug 30, 2016 at 11:55 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: > >>> @@ -729,7 +735,7 @@ static struct commit **get_bad_and_good_commits(int >>> *rev_nr) >>> return rev; >>> } >>> >>> -static void ha

Re: [PATCH v14 14/27] bisect--helper: `bisect_next` and `bisect_auto_next` shell function in C

Hey Junio, On Wed, Aug 31, 2016 at 1:03 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> This is a very tricky one. I have purposely not included this after a >> lot of testing. I have hand tested with the origin

Re: [PATCH v14 09/27] bisect--helper: `bisect_write` shell function in C

Hey Junio, On Sun, Aug 28, 2016 at 2:52 AM, Junio C Hamano <gits...@pobox.com> wrote: > > Pranit Bauva <pranit.ba...@gmail.com> writes: > > >>> +struct bisect_terms { > >>> + struct strbuf term_good; > >>> + struct strbuf term_bad;

Bug: git-add .* errors out

out. I am currently using git 2.9.3 on Ubuntu 15.04 while he is using git 1.9.1 on Ubuntu 16.04. What might have gone wrong? Regards, Pranit Bauva

Re: Bug: git-add .* errors out

Hey Thomas, On Mon, Sep 12, 2016 at 1:09 AM, Thomas Gummerer <t.gumme...@gmail.com> wrote: > Hi, > > On 09/12, Pranit Bauva wrote: >> Hey everyone, >> >> One of my friend was trying to add files using the command `git add >> .*` and got an error that

Re: [PATCH v14 07/27] bisect--helper: `bisect_reset` shell function in C

Hey Junio, On Fri, Aug 26, 2016 at 9:59 PM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >>> Also this version fails to catch "bisect reset a b c" as an error, I >>> suspect. >> >> It di

Re: [PATCH v14 09/27] bisect--helper: `bisect_write` shell function in C

Hey Junio, On Thu, Aug 25, 2016 at 4:00 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> +struct bisect_terms { >> + struct strbuf term_good; >> + struct strbuf term_bad; >> +}; > > I thin

Re: [PATCH v14 11/27] bisect--helper: `bisect_next_check` & bisect_voc shell function in C

Hey Junio, On Thu, Aug 25, 2016 at 4:10 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> +static int mark_good(const char *refname, const struct object_id *oid, >> + int flag, void *cb_data) >

Re: [PATCH v14 12/27] bisect--helper: `get_terms` & `bisect_terms` shell function in C

Hey Junio, On Thu, Aug 25, 2016 at 11:35 PM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> +static int bisect_terms(struct bisect_terms *terms, const char **argv, int >> argc) >> +{ >> +

Re: [PATCH v14 08/27] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

Hey Junio, On Thu, Aug 25, 2016 at 3:43 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> +static int is_expected_rev(const char *expected_hex) >> +{ >> + struct strbuf actual_hex

Re: [PATCH v14 21/27] bisect--helper: `bisect_log` shell function in C

Hey Junio, On Sat, Aug 27, 2016 at 4:37 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> +static int bisect_log(void) >> +{ >> + struct strbuf buf = STRBUF_INIT; >> + >> + if (st

Re: [PATCH v14 13/27] bisect--helper: `bisect_start` shell function partially in C

Hey Junio, On Fri, Aug 26, 2016 at 12:32 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> +static int bisect_start(struct bisect_terms *terms, int no_checkout, >> + const char **argv,

Re: [PATCH v14 07/27] bisect--helper: `bisect_reset` shell function in C

Hey Junio, On Thu, Aug 25, 2016 at 2:42 AM, Junio C Hamano <gits...@pobox.com> wrote: > > Pranit Bauva <pranit.ba...@gmail.com> writes: > > > +static int bisect_reset(const char *commit) > > +{ > > + struct strbuf branch = S

Re: [PATCH v14 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

cc4-000...@eu-west-1.amazonses.com/ [2]: http://public-inbox.org/git/01020156b73fe66f-bfad6316-39d4-4577-8f75-d1b4b2031263-000...@eu-west-1.amazonses.com/ [3]: http://public-inbox.org/git/01020156b73fe6ce-3b204354-849b-40fd-93ff-2ebcf77df91c-000...@eu-west-1.amazonses.com/ Regards, Pranit Bauva --

Re: [PATCH v14 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

Hey Junio, On Wed, Aug 24, 2016 at 1:58 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> `--next-all` is meant to be used as a subcommand to support multiple >> "operation mode" though the current impl

[PATCH v14 02/27] bisect: rewrite `check_term_format` shell function in C

will be introduced for write_terms(). Helped-by: Johannes Schindelein <johannes.schindel...@gmx.de> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- built

[PATCH v14 22/27] bisect--helper: `bisect_replay` shell function in C

are ported, this subcommand will be retired and will be called by some other method. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bise

[PATCH v14 15/27] bisect--helper: retire `--bisect-clean-state` subcommand

The `bisect-clean-state` subcommand is no longer used in the shell script while the C code uses `bisect_clean_state()` thus remove the subcommand. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauv

[PATCH v14 23/27] bisect--helper: retire `--bisect-write` subcommand

The `--bisect-write` subcommand is no longer used in the shell script and the function `bisect_write()` is called from the C implementation. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauv

[PATCH v14 09/27] bisect--helper: `bisect_write` shell function in C

lt;chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 97 git-bisect.sh| 25 ++--- 2 files changed, 94 insertions(+), 28 deletions(-) diff --git a/builtin/bisect--helper.

[PATCH v14 16/27] bisect--helper: retire `--next-all` subcommand

The `--next-all` subcommand is no longer used in the shell script and the function `bisect_next_all()` is called from the C implementation of `bisect_next()`. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by:

[PATCH v14 21/27] bisect--helper: `bisect_log` shell function in C

, this subcommand will be retired and will be called by some other method. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bis

[PATCH v14 14/27] bisect--helper: `bisect_next` and `bisect_auto_next` shell function in C

function to C so as to use the existing test suite. As more functions are ported, this subcommand will be retired and will be called by some other methods. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by:

[PATCH v14 18/27] bisect--helper: `bisect_state` & `bisect_head` shell function in C

g> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 84 git-bisect.sh| 57 +++- 2 files changed, 89 insertions(+), 52 deletions(-) diff --git a/builtin/bisect--helper.

[PATCH v14 13/27] bisect--helper: `bisect_start` shell function partially in C

nei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 238 ++- git-bisect.sh| 133 +- 2 files chang

[PATCH v14 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

annes.schinde...@gmx.de> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 17 +++-- 1 file changed, 11 insertions(+), 6

[PATCH v14 17/27] bisect--helper: `bisect_autostart` shell function in C

lt;chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 40 git-bisect.sh| 23 +-- 2 files changed, 41 insertions(+), 22 deletions(-) diff --git a/builtin/bisect--helper.

[PATCH v14 04/27] bisect--helper: `bisect_clean_state` shell function in C

are ported, this subcommand will be retired but its implementation will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com

[PATCH v14 06/27] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()

is_empty_file() can help to refactor a lot of code. This will be very helpful in porting "git bisect" to C. Suggested-by: Torsten Bögershausen <tbo...@web.de> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org>

[PATCH v14 19/27] bisect--helper: retire `--check-expected-revs` subcommand

; Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 861c07d..6cc990b 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -8

[PATCH v14 27/27] bisect--helper: remove the dequote in bisect_start()

uting" code introduced by the commit 25b48b5c. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 59

[PATCH v14 12/27] bisect--helper: `get_terms` & `bisect_terms` shell function in C

are ported, this subcommand will be retired but its implementation will be called by some other methods. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builti

[PATCH v14 20/27] bisect--helper: retire `--write-terms` subcommand

g> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 6cc990b..1b6e5d8 100644 --- a/builtin/bisect--helper.c +++ b/builti

[PATCH v14 24/27] bisect--helper: retire `--check-and-set-terms` subcommand

The `--check-and-set-terms` subcommand is no longer used in the shell script and the function `check_and_set_terms()` is called from the C implementation. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by:

[PATCH v14 05/27] t6030: explicitly test for bisection cleanup

Add test to explicitly check that 'git bisect reset' is working as expected. This is already covered implicitly by the test suite. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.

[PATCH v14 26/27] bisect--helper: retire `--bisect-auto-next` subcommand

The `--bisect-auto-next` subcommand is no longer used in the shell script and the function `bisect_auto_next` is called from the C implementation. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauv

[PATCH v14 03/27] bisect--helper: `write_terms` shell function in C

implementation will be called by some other method. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 36 +

[PATCH v14 10/27] bisect--helper: `check_and_set_terms` shell function in C

g> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 52 +++- git-bisect.sh| 36 - 2 files changed, 55 insertions(+), 33 deletions(-) diff --git a/builtin/bisect--

[PATCH v14 11/27] bisect--helper: `bisect_next_check` & bisect_voc shell function in C

lt;chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 103 ++- git-bisect.sh| 60 ++- 2 files changed, 106 insertions(+), 57 deletions(-) diff --git a/builti

[PATCH v14 25/27] bisect--helper: retire `--bisect-autostart` subcommand

The `--bisect-autostart` subcommand is no longer used in the shell script and the function `bisect_autostart()` is called from the C implementation. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by:

[PATCH v14 07/27] bisect--helper: `bisect_reset` shell function in C

com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 48 +++- git-bisect.sh| 28 ++-- 2 files changed, 49 insertion

[PATCH v14 08/27] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

sc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 33 - git-bisect.sh| 20 ++-- 2 files changed, 34 insertions(+), 19 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bi

[PATCH] rev-list-options: clarify the usage of -n/--max-number

-n=, -, --max-number= shows the last n commits specified in irrespective of whether --reverse is used or not. With --reverse, it just shows the last n commits in reverse order. Reported-by: Ruediger Meier <sweet_...@gmx.de> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> ---

Re: [PATCH v2] rev-list-options: clarify the usage of --reverse

Hey Junio, On Wed, Sep 28, 2016 at 3:42 AM, Junio C Hamano <gits...@pobox.com> wrote: > "Philip Oakley" <philipoak...@iee.org> writes: > >> micro-nit: 'first' and 'last' can be tricky to distinguish for lists... > > Let's do this then. > > -- >

Re: [PATCH] rev-list-options: clarify the usage of -n/--max-number

Hey Junio, On Tue, Sep 27, 2016 at 10:21 PM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> -n=, -, --max-number= shows the last n commits >> specified in irrespective of whether --reverse is used or not. >> With

[PATCH v2] rev-list-options: clarify the usage of --reverse

Specify even more clearly that --reverse works only with the commits which are chosen to be shown so as to eliminate the confusion as to whether the first n or the last n commits with be shown when used with `-n --reverse`. Reported-by: Ruediger Meier <sweet_...@gmx.de> Signed-off-by:

Re: [PATCH v15 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

-018e2a7aa6f7-000...@eu-west-1.amazonses.com/T/#m7c26060fcf95abbd19f93742d7317eef87b915a1 [2]: http://public-inbox.org/git/01020157c38b19e0-81123fa5-5d9d-4f64-8f1b-ff336e83ebe4-000...@eu-west-1.amazonses.com/T/#u [3]: http://paste.ubuntu.com/23323581/ Regards, Pranit Bauva

[PATCH v15 16/27] bisect--helper: retire `--bisect-clean-state` subcommand

The `bisect-clean-state` subcommand is no longer used in the shell script while the C code uses `bisect_clean_state()` thus remove the subcommand. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauv

[PATCH v15 15/27] bisect--helper: `bisect_next` and `bisect_auto_next` shell function in C

the existing test suite. As more functions are ported, this subcommand will be retired and will be called by some other methods. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.

[PATCH v15 22/27] bisect--helper: `bisect_log` shell function in C

, this subcommand will be retired and will be called by some other method. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bis

[PATCH v15 07/27] bisect--helper: `bisect_reset` shell function in C

com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 48 +++- git-bisect.sh| 28 ++-- 2 files changed, 49 insertion

[PATCH v15 05/27] t6030: explicitly test for bisection cleanup

Add test to explicitly check that 'git bisect reset' is working as expected. This is already covered implicitly by the test suite. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.

[PATCH v15 21/27] bisect--helper: retire `--write-terms` subcommand

g> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index d5fe35b..493034c 100644 --- a/builtin/bisect--helper.c +++ b/builti

[PATCH v15 06/27] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()

is_empty_file() can help to refactor a lot of code. This will be very helpful in porting "git bisect" to C. Suggested-by: Torsten Bögershausen <tbo...@web.de> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org>

[PATCH v15 13/27] bisect--helper: `bisect_start` shell function partially in C

nei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 217 ++- git-bisect.sh| 133 + 2 files chang

[PATCH v15 10/27] bisect--helper: `check_and_set_terms` shell function in C

` into `struct bisect_terms` and write it out to the file BISECT_TERMS. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bis

[PATCH v15 04/27] bisect--helper: `bisect_clean_state` shell function in C

are ported, this subcommand will be retired but its implementation will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com

[PATCH v15 09/27] bisect--helper: `bisect_write` shell function in C

and pass the memory address around functions. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 94 +++

[PATCH v15 14/27] t6030: no cleanup with bad merge base

The bisection cleanup should be performed with bad merge base so that the user can return to its original position with `git bisect reset`. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauv

[PATCH v15 12/27] bisect--helper: `get_terms` & `bisect_terms` shell function in C

n Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c| 72 +++-- git-bisect.sh | 35 ++ t/t6030-bisect-porcelain.sh | 2 +- 3 files changed, 73 insertio

[PATCH v15 20/27] bisect--helper: retire `--check-expected-revs` subcommand

; Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 1481c6d..d5fe35b 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -8

[PATCH v15 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

annes.schinde...@gmx.de> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 17 +++-- 1 file changed, 11 insertions(+), 6

[PATCH v15 19/27] bisect--helper: `bisect_state` & `bisect_head` shell function in C

g> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 86 git-bisect.sh| 57 +++- 2 files changed, 91 insertions(+), 52 deletions(-) diff --git a/builtin/bisect--helper.

[PATCH v15 18/27] bisect--helper: `bisect_autostart` shell function in C

lt;chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 40 git-bisect.sh| 23 +-- 2 files changed, 41 insertions(+), 22 deletions(-) diff --git a/builtin/bisect--helper.

[PATCH v15 02/27] bisect: rewrite `check_term_format` shell function in C

will be introduced for write_terms(). Helped-by: Johannes Schindelein <johannes.schindel...@gmx.de> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- built

[PATCH v15 25/27] bisect--helper: retire `--bisect-autostart` subcommand

The `--bisect-autostart` subcommand is no longer used in the shell script and the function `bisect_autostart()` is called from the C implementation. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by:

[PATCH v15 17/27] bisect--helper: retire `--next-all` subcommand

The `--next-all` subcommand is no longer used in the shell script and the function `bisect_next_all()` is called from the C implementation of `bisect_next()`. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by:

[PATCH v15 26/27] bisect--helper: retire `--bisect-auto-next` subcommand

The `--bisect-auto-next` subcommand is no longer used in the shell script and the function `bisect_auto_next` is called from the C implementation. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauv

[PATCH v15 03/27] bisect--helper: `write_terms` shell function in C

implementation will be called by some other method. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 36 +

[PATCH v15 08/27] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

sc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 33 - git-bisect.sh| 20 ++-- 2 files changed, 34 insertions(+), 19 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bi

[PATCH v15 23/27] bisect--helper: `bisect_replay` shell function in C

are ported, this subcommand will be retired and will be called by some other method. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bise

[PATCH v15 24/27] bisect--helper: retire `--bisect-write` subcommand

The `--bisect-write` subcommand is no longer used in the shell script and the function `bisect_write()` is called from the C implementation. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauv

<    1   2   3   4   5   6   >