Re: [PATCH v2 3/3] Use the newly-introduced regexec_buf() function

2016-09-08 Thread Junio C Hamano
Jeff King writes: >> commit f96e5673 ("grep: use REG_STARTEND for all matching if available", >> 22-05-2010) introduced this test and expects ".. NUL characters themselves >> are not matched in any way". With the native library on cygwin they are >> matched, with the compat/regex

Re: [PATCH v2 3/3] Use the newly-introduced regexec_buf() function

2016-09-08 Thread Jeff King
On Thu, Sep 08, 2016 at 08:06:35PM +0100, Ramsay Jones wrote: > > Actually, I take it back again. Your test case doesn't have an embedded > > NUL in it (so we check that git finds it, but aside from the lack of > > segfault, stock git would already find it). > > This reminds me ... despite the

Re: [PATCH v2 3/3] Use the newly-introduced regexec_buf() function

2016-09-08 Thread Ramsay Jones
On 08/09/16 09:35, Jeff King wrote: > On Thu, Sep 08, 2016 at 04:14:46AM -0400, Jeff King wrote: > >> On Thu, Sep 08, 2016 at 04:10:24AM -0400, Jeff King wrote: >> >>> On Thu, Sep 08, 2016 at 09:54:51AM +0200, Johannes Schindelin wrote: >>> > diff.c | 3 ++- >

Re: [PATCH v2 3/3] Use the newly-introduced regexec_buf() function

2016-09-08 Thread Jeff King
On Thu, Sep 08, 2016 at 04:14:46AM -0400, Jeff King wrote: > On Thu, Sep 08, 2016 at 04:10:24AM -0400, Jeff King wrote: > > > On Thu, Sep 08, 2016 at 09:54:51AM +0200, Johannes Schindelin wrote: > > > > > > diff.c | 3 ++- > > > > diffcore-pickaxe.c | 18 -- > > > >

Re: [PATCH v2 3/3] Use the newly-introduced regexec_buf() function

2016-09-08 Thread Jeff King
On Thu, Sep 08, 2016 at 04:10:24AM -0400, Jeff King wrote: > On Thu, Sep 08, 2016 at 09:54:51AM +0200, Johannes Schindelin wrote: > > > > diff.c | 3 ++- > > > diffcore-pickaxe.c | 18 -- > > > xdiff-interface.c | 13 - > > > 3 files changed, 14

Re: [PATCH v2 3/3] Use the newly-introduced regexec_buf() function

2016-09-08 Thread Jeff King
On Thu, Sep 08, 2016 at 09:54:51AM +0200, Johannes Schindelin wrote: > > diff.c | 3 ++- > > diffcore-pickaxe.c | 18 -- > > xdiff-interface.c | 13 - > > 3 files changed, 14 insertions(+), 20 deletions(-) > > I just realized that this should switch the

Re: [PATCH v2 3/3] Use the newly-introduced regexec_buf() function

2016-09-08 Thread Johannes Schindelin
Hi, On Thu, 8 Sep 2016, Johannes Schindelin wrote: > The new regexec_buf() function operates on buffers with an explicitly > specified length, rather than NUL-terminated strings. > > We need to use this function whenever the buffer we want to pass to > regexec() may have been mmap()ed (and is

[PATCH v2 3/3] Use the newly-introduced regexec_buf() function

2016-09-08 Thread Johannes Schindelin
The new regexec_buf() function operates on buffers with an explicitly specified length, rather than NUL-terminated strings. We need to use this function whenever the buffer we want to pass to regexec() may have been mmap()ed (and is hence not NUL-terminated). Note: the original motivation for