On Sun, Jan 6, 2013 at 1:43 PM, Junio C Hamano gits...@pobox.com wrote:
How is the file that points at the real git dir removed with this
fix, by the way?
It's part of the worktree cleanup, pointed by junk_work_tree. And
because junk_work_tree is not set up for --bare, I guess we still need
to
Michael Haggerty mhag...@alum.mit.edu writes:
On 01/04/2013 10:47 PM, Junio C Hamano wrote:
Reviewed-by is for those who are familiar with the part of the
system being touched to say I reviewed this patch, it looks good,
and Michael indeed was involved in recent updates to the refs.c
Duy Nguyen wrote:
And
because junk_work_tree is not set up for --bare, I guess we still need
to fix --bare --separate-git-dir case, or forbid it because i'm not
sure if that case makes sense at all.
Forbidding it makes sense to
Hi,
Torsten Bögershausen wrote:
Stephen Linda Smith wrote:
git co 9fca6c make all
... The make errored out as before
[...]
git co 9fca6c^ make all
... and this compiles to completion
CYGWIN_NT-5.1 WINXPMACHINE 1.7.14(0.260/5/3) 2012-04-24 17:22
i686 Cygwin
[...]
You can either
On 06.01.13 10:32, Jonathan Nieder wrote:
Hi,
Torsten Bögershausen wrote:
Stephen Linda Smith wrote:
git co 9fca6c make all
... The make errored out as before
[...]
git co 9fca6c^ make all
... and this compiles to completion
CYGWIN_NT-5.1 WINXPMACHINE 1.7.14(0.260/5/3)
--separate-git-dir was added to clone with the repository away from
standard position worktree/.git. It does not make sense to use it
without creating working directory.
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
---
On Sun, Jan 6, 2013 at 4:16 PM, Jonathan Nieder jrnie...@gmail.com
Torsten Bögershausen wrote:
The short version:
Cygwin versions 1.7.1 up to 1.7.16 use the same header files as cygwin 1.5
[...]
I don't know if we want to improve the Makefile to enable
CYGWIN_V15_WIN32API = YesPlease
for cygwin versions 1.7.1 .. 1.7.16 (which are outdated)
Confusing.
Nguyễn Thái Ngọc Duy wrote:
--separate-git-dir was added to clone with the repository away from
standard position worktree/.git. It does not make sense to use it
without creating working directory.
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
The patch correctly implements the
On 01/05/2013 04:11 PM, Eric S. Raymond wrote:
Perhaps I was unclear. I consider the interface design error to
be not in the fact that all the blobs are written first or detached,
but rather that the implementation detail of the two separate journal
files is ever exposed.
I understand why
On 01/06/2013 04:57 AM, Jonathan Nieder wrote:
Torsten Bögershausen wrote:
The short version:
Cygwin versions 1.7.1 up to 1.7.16 use the same header files as cygwin 1.5
[...]
I don't know if we want to improve the Makefile to enable
CYGWIN_V15_WIN32API = YesPlease
for cygwin versions 1.7.1
When building manual pages, the source text is transformed to XML with
AsciiDoc before the man pages are generated from the XML with xmlto.
Fix the dependencies in the Makefile so that the XML files are rebuilt
when asciidoc.conf changes and not just the manual pages from
unchanged XML, and move
On Wed, Jan 02, 2013 at 12:54:19PM +, Adam Spiers wrote:
On Tue, Jan 1, 2013 at 8:52 PM, Junio C Hamano gits...@pobox.com wrote:
Adam Spiers g...@adamspiers.org writes:
diff --git a/dir.c b/dir.c
index ee8e711..89e27a6 100644
--- a/dir.c
+++ b/dir.c
@@ -2,6 +2,8 @@
* This
Mark Levedahl wrote:
However, the newer
win32api is provided only for the current cygwin release series, which can
be reliably identified by having dll version 1.7.x, while the older frozen
releases (dll versions 1.6.x from redhat,
On Sun, Jan 06, 2013 at 04:01:53AM -0800, Jonathan Nieder wrote:
When building manual pages, the source text is transformed to XML with
AsciiDoc before the man pages are generated from the XML with xmlto.
Fix the dependencies in the Makefile so that the XML files are rebuilt
when
On Sat, Jan 05, 2013 at 11:12:25PM -0800, Junio C Hamano wrote:
Jonathan Nieder jrnie...@gmail.com writes:
But in fact the current options list doesn't seem to be well organized at
all.
What do you think would be a logical way to group these?
Features of input syntax
--date-format
The OPTIONS section of this manpage has grown long without any
particular organization to ensure it remains manageable. Split into
categories to make the documentation for each option easier to find.
The categories:
1. Features of the input format, such as the date format and whether
the
John Keeping wrote:
How about this?
Ah, our patches crossed.
I left the Semantics of execution options with the general options
since I couldn't think of a sensible heading
Neat trick. :)
[...]
-- 8 --
The options in git-fast-import(1) are not currently arranged in a
logical order,
Windows disallows file names that contain a star. Arrange the test setup
to insert the file name f* in the repository without the corresponding
file in the worktree.
Signed-off-by: Johannes Sixt j...@kdbg.org
---
t/t6130-pathspec-noglob.sh | 8 +++-
1 file changed, 7 insertions(+), 1
On Sunday, January 06, 2013 04:09:17 AM Jonathan Nieder wrote:
Mark Levedahl wrote:
However, the
newer
win32api is provided only for the current cygwin release series, which
On Sun, Jan 06, 2013 at 05:51:09AM -0800, Jonathan Nieder wrote:
John Keeping wrote:
I left the Semantics of execution options with the general options
since I couldn't think of a sensible heading
Neat trick. :)
I took inspiration from git-pull(1), which has a few general options
followed
On Sun, Jan 06, 2013 at 03:07:43PM +0100, Johannes Sixt wrote:
Windows disallows file names that contain a star. Arrange the test setup
to insert the file name f* in the repository without the corresponding
file in the worktree.
[...]
- test_commit star f*
+ # insert file f* in the
On Fri, Jan 04, 2013 at 01:03:59PM -0800, Junio C Hamano wrote:
Adam Spiers g...@adamspiers.org writes:
diff --git a/builtin/clean.c b/builtin/clean.c
index 0c7b3d0..bd18b88 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -97,9 +97,10 @@ int cmd_clean(int argc, const char
We record the uncompressed and compressed sizes and the CRC of streamed
files as zero in the local header of the file. The actual values are
recorded in an extra data descriptor after the file content, and in the
usual ZIP directory entry at the end of the archive.
While we know the compressed
On Fri, Jan 04, 2013 at 11:54:34PM -0800, Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
Adam Spiers g...@adamspiers.org writes:
diff --git a/builtin/clean.c b/builtin/clean.c
index 0c7b3d0..bd18b88 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -97,9 +97,10
The documentation for the ALLOC_GROW API implicitly encouraged
developers to use ary as the variable name for the array which is
dynamically grown. However ary is an unusual abbreviation hardly
used anywhere else in the source tree, and it is also better to name
variables based on their contents
On Fri, Jan 04, 2013 at 01:13:12PM -0800, Junio C Hamano wrote:
Adam Spiers g...@adamspiers.org writes:
On Thu, Jan 3, 2013 at 7:17 PM, Junio C Hamano gits...@pobox.com wrote:
* as/check-ignore (2012-12-28) 19 commits
- Add git-check-ignore sub-command
- setup.c: document get_pathspec()
Hi,
On Fri, Dec 28, 2012 at 11:42:00PM -0500, Eric S. Raymond wrote:
Heiko Voigt hvo...@hvoigt.net:
Maybe you could add that information to the parsecvs compile
instructions? I think just because it takes some effort to compile does
not justify to remove this useful pointer here. When I
This is the v4 re-roll of the check-ignore series, which is based on
Junio's as/dir-c-cleanup topic branch f6198812 (dir.c: rename
free_excludes() to clear_exclude_list(), 2012-12-27). As previously
discussed, the earlier parts of the v3 series seem to be complete and
are progressing to 'next'.
Fix a grammatical issue in the description of these functions, and
make it more obvious how and why seen[] can be reused across multiple
invocations.
Signed-off-by: Adam Spiers g...@adamspiers.org
---
dir.c | 38 ++
dir.h | 6 ++
2 files changed, 32
For exclude patterns read in from files, the filename is stored in the
exclude list, and the originating line number is stored in the
individual exclude (counting starting at 1).
For exclude patterns provided on the command line, a string describing
the source of the patterns is stored in the
The 'argc' argument passed to validate_pathspec() was never used.
Signed-off-by: Adam Spiers g...@adamspiers.org
---
builtin/add.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/add.c b/builtin/add.c
index c689f37..1f62ba3 100644
--- a/builtin/add.c
+++
Since we have just created a new pathspec-handling library, now is a
good time to add some comments explaining get_pathspec().
Signed-off-by: Adam Spiers g...@adamspiers.org
---
The deprecation warning is new since v3.
setup.c | 19 +++
1 file changed, 19 insertions(+)
diff
This works in a similar manner to git-check-attr.
Thanks to Jeff King and Junio C Hamano for the idea:
http://thread.gmane.org/gmane.comp.version-control.git/108671/focus=108815
Signed-off-by: Adam Spiers g...@adamspiers.org
---
Several minor improvements since v3:
- rename char *dir to slash
This will be reused by a new git check-ignore command.
Also document validate_pathspec().
Signed-off-by: Adam Spiers g...@adamspiers.org
---
Unlike v3, this series doesn't make validate_pathspec() public.
builtin/add.c | 10 ++
pathspec.c| 12
pathspec.h| 1 +
3
Extract the body of the for loop in treat_gitlinks() into a separate
check_path_for_gitlink() function so that it can be reused elsewhere.
This paves the way for a new check-ignore sub-command.
Also document treat_gitlinks().
Signed-off-by: Adam Spiers g...@adamspiers.org
---
Unlike v3, this
Perform the following function renames to make it explicit that these
pathspec handling functions are for matching against the index, rather
than against a tree or the working directory.
- fill_pathspec_matches() - add_pathspec_matches_against_index()
- find_used_pathspec() -
Extract the following functions from builtin/add.c to pathspec.c, in
preparation for reuse by a new git check-ignore command:
- fill_pathspec_matches()
- find_used_pathspec()
The functions being extracted are not changed in any way, except
removal of the 'static' qualifier.
Also add
Fix a bug in two scripts that call unzip, use the opportunity for a small
cleanup, move all ZIP related tests out of t5000 and finally skip testing
symlinks if unzip doesn't support them.
The first one allows running t5000 with the unzip from pkgsrc manually on
NetBSD, which succeeds. The last
InfoZIP's unzip takes default parameters from the environment variable
UNZIP. Unset it in the test library and use GIT_UNZIP for specifying
alternate versions of the unzip command instead.
t0024 wasn't even using variable for the actual extraction. t5000
was, but when setting it to InfoZIP's
This change makes the code smaller and we can put it at the top of
the script, its rightful place as setup code.
Signed-off-by: Rene Scharfe rene.scha...@lsrfire.ath.cx
---
t/t0024-crlf-archive.sh | 12 +---
t/t5000-tar-tree.sh | 12 +---
2 files changed, 10 insertions(+), 14
Only add a symlink to the repository if both the filesystem and
unzip support symlinks. To check the latter, add a ZIP file
containing a symlink, created like this with InfoZIP zip 3.0:
$ echo sample text textfile
$ ln -s textfile symlink
$ zip -y infozip-symlinks.zip
On Sun, Jan 06, 2013 at 06:49:00PM +0100, René Scharfe wrote:
This change makes the code smaller and we can put it at the top of
the script, its rightful place as setup code.
Would it be better to add the setting of GIT_UNZIP and
test_lazy_prereq to test-lib.sh so they aren't duplicated in both
Jonathan Nieder jrnie...@gmail.com writes:
Mark Levedahl wrote:
However, the newer
win32api is provided only for the current cygwin release series, which can
be reliably identified by having dll version 1.7.x, while the older frozen
Adam Spiers g...@adamspiers.org writes:
On Fri, Jan 04, 2013 at 01:03:59PM -0800, Junio C Hamano wrote:
Adam Spiers g...@adamspiers.org writes:
diff --git a/builtin/clean.c b/builtin/clean.c
index 0c7b3d0..bd18b88 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -97,9 +97,10 @@
Adam Spiers g...@adamspiers.org writes:
The documentation for the ALLOC_GROW API implicitly encouraged
developers to use ary as the variable name for the array which is
dynamically grown. However ary is an unusual abbreviation hardly
used anywhere else in the source tree, and it is also
On 06.01.13 20:54, Junio C Hamano wrote:
Jonathan Nieder jrnie...@gmail.com writes:
Mark Levedahl wrote:
However, the newer
win32api is provided only for the current cygwin release series, which can
be reliably identified by having
On Sun, Jan 06, 2013 at 12:29:33PM -0800, Junio C Hamano wrote:
Adam Spiers g...@adamspiers.org writes:
The documentation for the ALLOC_GROW API implicitly encouraged
developers to use ary as the variable name for the array which is
dynamically grown. However ary is an unusual
Adam Spiers g...@adamspiers.org writes:
Sounds good. To follow not type but contents, a further rewrite
with s/array/item/ is even better, no?
I agree.
Thanks for a quick response; let's do this then.
-- 8 --
From: Adam Spiers g...@adamspiers.org
The documentation for the ALLOC_GROW API
On 01/06/2013 02:54 PM, Junio C Hamano wrote:
Jonathan Nieder jrnie...@gmail.com writes:
Mark Levedahl wrote:
However, the newer
win32api is provided only for the current cygwin release series, which can
be reliably identified by
-Original Message-
From: git-ow...@vger.kernel.org
[mailto:git-ow...@vger.kernel.org] On Behalf Of Mark Levedahl
Sent: Sunday, January 06, 2013 16:10
To: Junio C Hamano
Cc: Jonathan Nieder; Torsten Bögershausen; Stephen Linda
Smith; Jason Pyeron; git@vger.kernel.org; Eric Blake
On 01/06/2013 03:51 PM, Torsten Bögershausen wrote:
Hm, I haven't understood the connection between the dll (cygwin1.dll
?) which is used in runtime, and the header files which are used when
compiling. Are they updated at the same time when updating from 1.7.16
to 1.7.17 ? Until I updated my
Thanks; so perhaps you can give me an OK to forge your S-o-b to the
following?
-- 8 --
From: Mark Levedahl mleved...@gmail.com
Date: Sun, 6 Jan 2013 11:56:33 -0800
Subject: [PATCH] Makefile: add comment on CYGWIN_V15_WIN32API
There is no documented, reliable, and future-proof method to
determine
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes:
This is another step towards the pathspec unification. This series
introduces a get_pathspec() alternative: parse_pathspec(). The new
function intializes struct pathspec directly. Many builtin commands
(except mv) are converted to use this
-Original Message-
From: Junio C Hamano
Sent: Sunday, January 06, 2013 16:36
Thanks; so perhaps you can give me an OK to forge your S-o-b
to the following?
I am personally fine with it, because cygwin is used by developers not
production systems and I expect my developers to
On 01/06/2013 04:35 PM, Junio C Hamano wrote:
Thanks; so perhaps you can give me an OK to forge your S-o-b to the
following?
-- 8 --
From: Mark Levedahl mleved...@gmail.com
Date: Sun, 6 Jan 2013 11:56:33 -0800
Subject: [PATCH] Makefile: add comment on CYGWIN_V15_WIN32API
There is no
Tracked directories (i.e. directories containing tracked files) that
are ignored must be reported as ignored if they contain untracked files.
Currently, files in the index can't be reported as ignored and are
automatically dropped from the list:
- When core.ignorecase is false, directories
On Sun, Jan 06, 2013 at 12:25:48PM -0800, Junio C Hamano wrote:
Adam Spiers g...@adamspiers.org writes:
On Fri, Jan 04, 2013 at 01:03:59PM -0800, Junio C Hamano wrote:
Adam Spiers g...@adamspiers.org writes:
diff --git a/builtin/clean.c b/builtin/clean.c
index 0c7b3d0..bd18b88
John Keeping j...@keeping.me.uk writes:
On Sun, Jan 06, 2013 at 05:51:09AM -0800, Jonathan Nieder wrote:
...
Nice description.
While doing this, fix the duplicate '--done' documentation by taking the
best bits of each. Also combine the descriptions of '--relative-marks'
and
Jonathan Nieder jrnie...@gmail.com writes:
Nguyễn Thái Ngọc Duy wrote:
--separate-git-dir was added to clone with the repository away from
standard position worktree/.git. It does not make sense to use it
without creating working directory.
Signed-off-by: Nguyễn Thái Ngọc Duy
On Sun, Jan 06, 2013 at 10:53:11PM +, Adam Spiers wrote:
That's a valid point. However, the ary[0] part which assumes external
knowledge of the internal implementation can trivially be avoided by
squashing this patch onto the commit we are discussing:
[snipped]
diff --git
Adam Spiers g...@adamspiers.org writes:
That's a valid point. However, the ary[0] part which assumes external
knowledge of the internal implementation can trivially be avoided by
squashing this patch onto the commit we are discussing:
diff --git a/builtin/clean.c b/builtin/clean.c
index
Thanks.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
(1) Only print out the names of the files and directories that got
actually deleted.
(2) Show warning message for ignored untracked git repositories
Consider the following repo layout:
test.git/
|-- tracked_dir/
| |-- some_tracked_file
| |-- some_untracked_file
|--
Zoltan Klinger wrote:
$ git clean -fd
Removing tracked_dir/some_untracked_file
Removing untracked_file
Removing untracked_foo/
Removing untracked_some.git/
The message displayed to the user is slightly misleading. The foo/
directory has not been removed because of foo/frotz.git
Today I had to move my first submodule, and I discovered that Git's
support for this is pretty limited. There have been a few patch
series attempting to address this [1,2], but none of them seems to
have pushed through into master (although I can't put my finger on a
reason for why). There are
On Sun, Jan 6, 2013 at 1:20 PM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote:
--- a/setup.c
+++ b/setup.c
@@ -250,6 +250,8 @@ static unsigned prefix_pathspec(struct pathspec_item
*item,
*raw = item-match;
item-len = strlen(item-match);
item-nowildcard_len =
On Mon, Jan 7, 2013 at 6:13 AM, Junio C Hamano gits...@pobox.com wrote:
I don't know what would go in the explanation here blank above,
though. Is it possible that some people are relying on this option
combination?
I do not necessarily think we must say it happens not to work
already for
(just cc-ing Jens and Peter, who might be interested)
W. Trevor King wrote:
Today I had to move my first submodule, and I discovered that Git's
support for this is pretty limited. There have been a few patch
series attempting to address this [1,2], but none of them seems to
have pushed
2013/1/5 Pete Wyckoff p...@padd.com:
sh...@keba.be wrote on Thu, 03 Jan 2013 15:58 -0500:
While struggling to get git-p4 to work properly with branches, I
thought the documentation on http://git-scm.com/docs/git-p4 could use
some improvements:
Thanks, I definitely appreciate the constructive
Field names like To:, Cc:, etc should be treated as case-independent;
use a case-insensitive regexp to match them as such. Previously,
git-send-email would send email messages with a lowercase cc: line in
the body without actually sending a copy of the message to that address.
Signed-off-by:
Duy Nguyen pclo...@gmail.com writes:
On Mon, Jan 7, 2013 at 6:13 AM, Junio C Hamano gits...@pobox.com wrote:
I don't know what would go in the explanation here blank above,
though. Is it possible that some people are relying on this option
combination?
I do not necessarily think we must
about git 1.8.2
* git push now requires -f to update a tag, even if it is a
fast-forward, as tags are meant to be fixed points.
Does the server side validate this? Do we need to upgrade git on
server side to support this?
--
To unsubscribe from this list: send the line unsubscribe git in
the
What's cooking in git.git (Jan 2013, #03; Sun, 6)
--
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'.
The tip of 'next' will be rewound and
I forgot to say that tonight's 'pu' seems to break t0008 and does
not pass the self-test. I didn't try figuring out if this is the
result of some mismerge, or one (or more) of the topics are broken.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to
Nickolai Zeldovich nicko...@csail.mit.edu writes:
Field names like To:, Cc:, etc should be treated as case-independent;
use a case-insensitive regexp to match them as such. Previously,
git-send-email would send email messages with a lowercase cc: line in
the body without actually sending a
On Sun, Jan 6, 2013 at 10:27 PM, Junio C Hamano gits...@pobox.com wrote:
While I think this patch is a sensible thing to do, I at the same
time wonder who is writing cc: in the lowercase in the first
place, and if that is one of our tools, we should fix that part as
well. Such a header would
On Sun, Jan 6, 2013 at 8:23 PM, 乙酸鋰 ch3co...@gmail.com wrote:
about git 1.8.2
* git push now requires -f to update a tag, even if it is a
fast-forward, as tags are meant to be fixed points.
Does the server side validate this? Do we need to upgrade git on
server side to support this?
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I have not had any issue until I ran a git fsck recently, which
repored gzip and crc errors in some pack files. git fsck does not
seem to repair the errors, only report them. I would like to try to
rebuild my repository, without downloading any more
René Scharfe wrote:
InfoZIP's unzip takes default parameters from the environment variable
UNZIP. Unset it in the test library and use GIT_UNZIP for specifying
alternate versions of the unzip command instead.
t0024 wasn't even using variable for the actual extraction. t5000
was, but when
Is there a practical way to eliminate the spam here? Could vger.kernel.org use a
postini (list maintainers contact me offline about this) account?
-Jason
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
- -
- Jason
-Original Message-
From: Mark Levedahl
Sent: Sunday, January 06, 2013 17:17
On 01/06/2013 02:54 PM, Junio C Hamano wrote:
Jonathan Nieder jrnie...@gmail.com writes:
Mark Levedahl wrote:
However,
the newer
Am 07.01.2013 02:39, schrieb Jonathan Nieder:
(just cc-ing Jens and Peter, who might be interested)
I´m currently working on teaching mv to move submodules and intend
to send those patches to the list after finishing submodule deinit.
Please see
Jason Pyeron jpye...@pdinc.us writes:
[administrivia: please never cull CC list when you respond to a
message on this list without a good reason]
circumvent the Cygwin API (and by extension, Cygwin project goals).
So, perhaps a better path forward is to disable / remove the
above code by
Jens Lehmann jens.lehm...@web.de writes:
Am 07.01.2013 02:39, schrieb Jonathan Nieder:
(just cc-ing Jens and Peter, who might be interested)
I´m currently working on teaching mv to move submodules and intend
to send those patches to the list after finishing submodule deinit.
Thanks for a
Nickolai Zeldovich nicko...@csail.mit.edu writes:
On Sun, Jan 6, 2013 at 10:27 PM, Junio C Hamano gits...@pobox.com wrote:
While I think this patch is a sensible thing to do, I at the same
time wonder who is writing cc: in the lowercase in the first
place, and if that is one of our tools, we
85 matches
Mail list logo
