Re: [Query] Can we ignore case for commiters name in shortlog?
On 30 November 2012 16:49, Max Horn wrote: > I don't see how wrong case is different from any other form of misspelling. > And mailmap is there precisely to handle such problems. Now, if these case > issues were for some reasons very frequent, it might be worth adding > dedicated support for it. But this seems dubious to me -- do you have any > evidence for this? Indeed, do you have more than just the one example? I don't have another example, but i have seen it many times. This happens when people use different repo's to send patches and by mistake have mentioned names in different case in them in their local .git/config files. -- viresh -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Query] Can we ignore case for commiters name in shortlog?
viresh kumar writes: > I was just thinking if we can ignore case for commiter name while > listing stuff here? > So, that we get over any manual mistakes from commiter. See git-shortlog(1), section Mapping Authors. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Query] Can we ignore case for commiters name in shortlog?
David Aguilar wrote in message : > There's a feature that does exactly this. > http://www.kernel.org/pub/software/scm/git/docs/git-shortlog.html By the way, the mailmap ignore case which is annoying. I have commits as damien.olivier.robert+...@gmail.com and a dummy email address robert@numenor.night-elves. I thought that putting: Damien Robert in the .mailmap would unify the two adresses, but it does not: git shortlog -se 15 Damien Robert 266 Damien Robert as you can see, the Damien.Olivier.Robert+git as been lowercased to damien.olivier.robert, so I am forced to write a mailmap like this: Damien Robert Damien Robert git shortlog -se 281 Damien Robert -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Query] Can we ignore case for commiters name in shortlog?
On 30.11.2012, at 04:35, viresh kumar wrote: > On 30 November 2012 09:03, Nicolas Pitre wrote: > >> Have a look at the .mailmap file in the top directory of your repo. > > Repeating what i said to David in other mail: > > I have my name there :) > > I thought using names with different case is actually different then > misspelling > it. And so, everybody must not be required to update their names in mailmap > with different case. So, with same email id and same name (that may be in > different case), we can show commits together in shortlog. I don't see how wrong case is different from any other form of misspelling. And mailmap is there precisely to handle such problems. Now, if these case issues were for some reasons very frequent, it might be worth adding dedicated support for it. But this seems dubious to me -- do you have any evidence for this? Indeed, do you have more than just the one example? In a nutshell, there seem to be two options here, and I know which *I* find more appealing ;) 1) continue this discussion over several emails to design a new feature (an option, config setting, whatever) to handle your special case, then sit down and write code for it, add documentation, add test cases to test it. 2) You just add a single entry to your mailmap to solve your problem at hand. :-) Cheers, Max-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Query] Can we ignore case for commiters name in shortlog?
On 30 November 2012 09:03, Nicolas Pitre wrote: > Have a look at the .mailmap file in the top directory of your repo. Repeating what i said to David in other mail: I have my name there :) I thought using names with different case is actually different then misspelling it. And so, everybody must not be required to update their names in mailmap with different case. So, with same email id and same name (that may be in different case), we can show commits together in shortlog. -- viresh -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Query] Can we ignore case for commiters name in shortlog?
On Fri, 30 Nov 2012, viresh kumar wrote: > Hi Junio and others, > > I have a query. git shortlog lists the patches submitted per commiter, like: > > > Viresh Kumar (7): > > cpufreq: Improve debug prints > > cpufreq: return early from __cpufreq_driver_getavg() > > cpufreq: governors: remove redundant code > > cpufreq: Fix sparse warnings by updating cputime64_t to u64 > > cpufreq: Fix sparse warning by making local function static > > cpufreq: Avoid calling cpufreq driver's target() routine if > > target_freq == policy->cur > > cpufreq: Make sure target freq is within limits > > > viresh kumar (3): > > cpufreq / core: Fix typo in comment describing show_bios_limit() > > cpufreq / core: Fix printing of governor and driver name > > cpufreq: Move common part from governors to separate file, v2 > > I know, there was something wrong at my end and i have commited stuff > with different cases. > > I was just thinking if we can ignore case for commiter name while > listing stuff here? > So, that we get over any manual mistakes from commiter. Have a look at the .mailmap file in the top directory of your repo. Nicolas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Query] Can we ignore case for commiters name in shortlog?
On 30 November 2012 08:54, David Aguilar wrote: > There's a feature that does exactly this. > > http://www.kernel.org/pub/software/scm/git/docs/git-shortlog.html > > See the section called "Mapping Authors". > It discusses the .mailmap file. I have my name there :) I thought using names with different case is actually different then misspelling it. And so, everybody must not be required to update their names in mailmap with different case. So, with same email id and same name (that may be in different case), we can show commits together in shortlog. -- viresh -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Query] Can we ignore case for commiters name in shortlog?
On Thu, Nov 29, 2012 at 6:09 PM, viresh kumar wrote: > Hi Junio and others, > > I have a query. git shortlog lists the patches submitted per commiter, like: > >> Viresh Kumar (7): >> cpufreq: Improve debug prints >> cpufreq: return early from __cpufreq_driver_getavg() >> cpufreq: governors: remove redundant code >> cpufreq: Fix sparse warnings by updating cputime64_t to u64 >> cpufreq: Fix sparse warning by making local function static >> cpufreq: Avoid calling cpufreq driver's target() routine if >> target_freq == policy->cur >> cpufreq: Make sure target freq is within limits > >> viresh kumar (3): >> cpufreq / core: Fix typo in comment describing show_bios_limit() >> cpufreq / core: Fix printing of governor and driver name >> cpufreq: Move common part from governors to separate file, v2 > > I know, there was something wrong at my end and i have commited stuff > with different cases. > > I was just thinking if we can ignore case for commiter name while > listing stuff here? > So, that we get over any manual mistakes from commiter. There's a feature that does exactly this. http://www.kernel.org/pub/software/scm/git/docs/git-shortlog.html See the section called "Mapping Authors". It discusses the .mailmap file. -- David -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[Query] Can we ignore case for commiters name in shortlog?
Hi Junio and others, I have a query. git shortlog lists the patches submitted per commiter, like: > Viresh Kumar (7): > cpufreq: Improve debug prints > cpufreq: return early from __cpufreq_driver_getavg() > cpufreq: governors: remove redundant code > cpufreq: Fix sparse warnings by updating cputime64_t to u64 > cpufreq: Fix sparse warning by making local function static > cpufreq: Avoid calling cpufreq driver's target() routine if target_freq > == policy->cur > cpufreq: Make sure target freq is within limits > viresh kumar (3): > cpufreq / core: Fix typo in comment describing show_bios_limit() > cpufreq / core: Fix printing of governor and driver name > cpufreq: Move common part from governors to separate file, v2 I know, there was something wrong at my end and i have commited stuff with different cases. I was just thinking if we can ignore case for commiter name while listing stuff here? So, that we get over any manual mistakes from commiter. -- viresh -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
