Re: [PATCH] [git-am] Handle git show output correctly
Peter Jones pjo...@redhat.com writes: Subject: [PATCH] [git-am] Handle git show output correctly The convention in Git is subsystem: summary of change (i.e. no brackets around git-am, just am: and no capital for Handle). My other concerns (name of stgit, multi-lines subject lines and lack of documentation) still hold. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [git-am] Handle git show output correctly
Matthieu Moy matthieu@grenoble-inp.fr writes: Peter Jones pjo...@redhat.com writes: Subject: [PATCH] [git-am] Handle git show output correctly The convention in Git is subsystem: summary of change (i.e. no brackets around git-am, just am: and no capital for Handle). My other concerns (name of stgit, multi-lines subject lines and lack of documentation) still hold. We do not want to apply git show output that munges the log message, period. If you want to give patches to somebody (or to yourself) via e-mail or via sneaker-net, git format-patch is there for you. Do not butcher am to accept a format that is not meant for patch transport in the first place. If you want to screw something in to your shelf, you would use a screw and a screwdriver. You do not try to hammer a nail using your screwdriver, find that the screwdriver is not very useful as a hammer and modify the screwdriver to hit your nail. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [git-am] Handle git show output correctly
On Wed, 2012-09-12 at 10:32 -0700, Junio C Hamano wrote: We do not want to apply git show output that munges the log message, period. If you want to give patches to somebody (or to yourself) via e-mail or via sneaker-net, git format-patch is there for you. Do not butcher am to accept a format that is not meant for patch transport in the first place. If you want to screw something in to your shelf, you would use a screw and a screwdriver. You do not try to hammer a nail using your screwdriver, find that the screwdriver is not very useful as a hammer and modify the screwdriver to hit your nail. That seems to be completely missing the point - people /send/ them without knowing, and as a maintainer of several projects, it's /hostile/ to people who are trying to help by sending patches to go around in circles with them about the fact that they typed the wrong command. I'd rather just take the patch, but right now the tools won't let me, and for completely arbitrary reasons. Let me put it a different way - if you won't accept git-am handling git show output because git show has output that wasn't designed to be parsed ever, would you be opposed to a patch that switches the git show output to be something usable? -- Peter -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [git-am] Handle git show output correctly
Peter Jones pjo...@redhat.com writes: Let me put it a different way - if you won't accept git-am handling git show output because git show has output that wasn't designed to be parsed ever, would you be opposed to a patch that switches the git show output to be something usable? The output from the command is optimized for humans, but you could invoke git show --pretty=email if you want to, so I do not think you need any patch to do that. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] git-am: Handle git show output correctly
On 09/13/2012 12:19 AM, Junio C Hamano wrote: Dan Johnson computerdr...@gmail.com writes: Not really. If we start encouraging people to use git show output as a kosher input to am, we would have to support such use forever, and we end up painting ourselves in a corner we cannot get out of easily. If git am emitted a warning when accepting git show output, it seems like it would support Peter's use-case without encouraging bad behavior? Are you seriously suggesting me to sell to our users a new feature saying this does not work reliably, we would not recommend using it, no, really, don't trust it. from the day the feature is introduced, especially when we know it will not be the feature does not work well yet, but it will, we promise but is and it may become worse in the future? I do not see much point in doing that. Besides, what bad behaviour do we avoid from encouraging with such an approach? As Peter said, the problem is not on the part of the user who ended up with an output from git show, when he really wants output from git format-patch. Giving the warning to the user of git am is too late. It might be enough to either enable format-patch output or print a warning to stderr when stdout is not a tty. I believe that would at least mitigate the problem, and it might educate the user as well. We already modify output format when stdout is not a tty (removing colors), so we're not giving guarantees about its format when it's piped somewhere. I believe that would provide almost every scenario with the expected outcome (including 'git show | grep'), but there will be a handful of very surprised people as well. -- Andreas Ericsson andreas.erics...@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 Considering the successes of the wars on alcohol, poverty, drugs and terror, I think we should give some serious thought to declaring war on peace. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] git-am: Handle git show output correctly
Dan Johnson computerdr...@gmail.com writes: I was assuming Peter would accept the patch, and reply with a in the future, please submit the output of format-patch, thus correcting the submitter's behavior. This warning would serve someone who did not know that they wanted the output of format-patch, and hopefully teach them to send such a reply message. Next time, please do this rarely has worked in practice. This is because the moment you accepted the current patch, you have already lost the carrot ;-) -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
