Re: [PATCH] git-svn: Fix termination issues for remote svn connections

2013-09-06 Thread Junio C Hamano
"Uli Heller" writes: > On Fri, September 6, 2013 2:44 pm, Kyle J. McKay wrote: > ... >> In any case, I can now reproduce the problem (serf 1.3.1 still breaks >> since it does not yet contain the fix and it is the most recent serf >> release available). >> >> And the Git/SVN/Ra.pm fix does elimina

Re: [PATCH] git-svn: Fix termination issues for remote svn connections

2013-09-06 Thread Uli Heller
On Fri, September 6, 2013 2:44 pm, Kyle J. McKay wrote: > On Sep 6, 2013, at 05:06, Uli Heller wrote: >>> I'm using Git built from master (57e4c1783). I see the same behavior >>> both with and without the SVN/Ra.pm patch (and using both bulk >>> updates >>> and skelta mode). Does the problem not

Re: [PATCH] git-svn: Fix termination issues for remote svn connections

2013-09-06 Thread Kyle J. McKay
On Sep 5, 2013, at 11:48, Junio C Hamano wrote: I am Cc'ing Kyle McKay who apparently had some experience working with git-svn with newer svn that can only use serf, hoping that we can get an independent opinion/test just to be sure. On Sep 3, 2013, at 00:35, Uli Heller wrote: When using git-s

Re: [PATCH] git-svn: Fix termination issues for remote svn connections

2013-09-06 Thread Kyle J. McKay
On Sep 6, 2013, at 05:06, Uli Heller wrote: I'm using Git built from master (57e4c1783). I see the same behavior both with and without the SVN/Ra.pm patch (and using both bulk updates and skelta mode). Does the problem not happen on a git svn clone? I can force serf back to version 1.2.1 an

Re: [PATCH] git-svn: Fix termination issues for remote svn connections

2013-09-06 Thread Uli Heller
On Fri, September 6, 2013 1:46 pm, Kyle J. McKay wrote: > On Sep 5, 2013, at 11:48, Junio C Hamano wrote: >> "Uli Heller" writes: >> >>> When using git-svn in combination with serf-1.2.1 core dumps are >>> created on termination. This is caused by a bug in serf, a fix for >>> the bug exists (see >

Re: [PATCH] git-svn: Fix termination issues for remote svn connections

2013-09-06 Thread Kyle J. McKay
On Sep 5, 2013, at 11:48, Junio C Hamano wrote: "Uli Heller" writes: When using git-svn in combination with serf-1.2.1 core dumps are created on termination. This is caused by a bug in serf, a fix for the bug exists (see https://code.google.com/p/serf/source/detail?r=2146) . Nevertheless, I

Re: [PATCH] git-svn: Fix termination issues for remote svn connections

2013-09-05 Thread Junio C Hamano
Eric Wong writes: > Junio C Hamano wrote: >> "Uli Heller" writes: >> > Nevertheless, I think it makes sense to fix the issue within the >> > git perl module Ra.pm, too. The change frees the private copy of >> > the remote access object on termination which prevents the error >> > from happening

Re: [PATCH] git-svn: Fix termination issues for remote svn connections

2013-09-05 Thread Eric Wong
Junio C Hamano wrote: > "Uli Heller" writes: > > Nevertheless, I think it makes sense to fix the issue within the > > git perl module Ra.pm, too. The change frees the private copy of > > the remote access object on termination which prevents the error > > from happening. > Thanks. Please sign-o

Re: [PATCH] git-svn: Fix termination issues for remote svn connections

2013-09-05 Thread Junio C Hamano
"Uli Heller" writes: > When using git-svn in combination with serf-1.2.1 core dumps are > created on termination. This is caused by a bug in serf, a fix for > the bug exists (see https://code.google.com/p/serf/source/detail?r=2146). > Nevertheless, I think it makes sense to fix the issue within t