Re: Trial git RPM's..
Chris Wright [EMAIL PROTECTED] writes: * Linus Torvalds ([EMAIL PROTECTED]) wrote: And it does not pass my torture test of building rpm's on debian, but that is not a huge problem. Ok, why is debian problematic? Is there some missing dependency or something? I really haven't ever done an rpm, and the git rpm target was all done by Chris Wright, so I don't have any clue at all. Again, patches welcome. Heh debian rpm build...I missed that bit in Eric's message. Eric, care to give details? Ok paged back in my state. The practical problem is that rpmbuild try to lookup the build dependencies which simply aren't present on debian. Patch will be along shortly once I get the glitches fixed. One last issue with building packages. Some distros are still shipping GNU interactive tools so git as a package name for the rpm is problematic. At the very least it is extremely confusing that git-0.99 is a more recent package that git-4.3.20. Eric - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Trial git RPM's..
On Tue, 12 Jul 2005, Eric W. Biederman wrote: One last issue with building packages. Some distros are still shipping GNU interactive tools so git as a package name for the rpm is problematic. At the very least it is extremely confusing that git-0.99 is a more recent package that git-4.3.20. Ahh. Dang, I should have remembered this. We should call the rpm git-core-0.99, not just git-0.99. Chris, I assume this is just changing the name in the spec-file from git to git-core? Linus - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Trial git RPM's..
Linus Torvalds [EMAIL PROTECTED] writes: Ahh. Dang, I should have remembered this. We should call the rpm git-core-0.99, not just git-0.99. Chris, I assume this is just changing the name in the spec-file from git to git-core? The name of the tarball needs to be updated as well. Eric - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Trial git RPM's..
On Tue, 12 Jul 2005, Eric W. Biederman wrote: The name of the tarball needs to be updated as well. Yes, I noticed. I ended up renaming the spec-file too. Pushed out, Linus - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Trial git RPM's..
* Linus Torvalds ([EMAIL PROTECTED]) wrote: On Tue, 12 Jul 2005, Eric W. Biederman wrote: The name of the tarball needs to be updated as well. Yes, I noticed. I ended up renaming the spec-file too. Pushed out, Yup, looks good. -chris - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Trial git RPM's..
Linus Torvalds [EMAIL PROTECTED] writes: Ok, I tagged a v0.99 thing, and pushed it out. I've also made trial RPM's of it: src, ppc64 and x86. They're build on whatever random machines I had, and on the ppc64 I chose to do it on my FC4 machine that has newer libraries than my YDL one. The x86 thing is FC3, I do believe. I haven't really verified the RPM's in any other way than a trial installation on one machine, and gitk seemed to work. Whoop. The idea being that this is a good way to check whether the rpm target works, _and_ cogito can have something to build against. A couple of pieces. The dist target has assumes git-tar-tree is in the path. Making it so you have to have git installed to build the rpm. The man pages are not built. The build dependencies do not call out the tools necessary to build the man pages. And it does not pass my torture test of building rpm's on debian, but that is not a huge problem. Are you still up for a patch that records who and when made a tag? I sent one but it seems to have been lost. Eric - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Trial git RPM's..
* Eric W. Biederman ([EMAIL PROTECTED]) wrote: Linus Torvalds [EMAIL PROTECTED] writes: Ok, I tagged a v0.99 thing, and pushed it out. I've also made trial RPM's of it: src, ppc64 and x86. They're build on whatever random machines I had, and on the ppc64 I chose to do it on my FC4 machine that has newer libraries than my YDL one. The x86 thing is FC3, I do believe. I haven't really verified the RPM's in any other way than a trial installation on one machine, and gitk seemed to work. Whoop. The idea being that this is a good way to check whether the rpm target works, _and_ cogito can have something to build against. A couple of pieces. The dist target has assumes git-tar-tree is in the path. Making it so you have to have git installed to build the rpm. Known, and was a reasonable assumption in my environment. It's simple bootstrapping issue. The man pages are not built. The build dependencies do not call out the tools necessary to build the man pages. That was rather intentional, because the asciidoc package is not common. thanks, -chris - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Trial git RPM's..
Linus Torvalds [EMAIL PROTECTED] wrote: On Mon, 11 Jul 2005, Eric W. Biederman wrote: A couple of pieces. The dist target has assumes git-tar-tree is in the path. Making it so you have to have git installed to build the rpm. Yes. Maybe we could relax that requirement by using ./git-tar-tree or something? That still requires that you have _built_ git to do the rpm, but at least you won't have had to install it. I don't see a problem here. Sure, you need git to build git, so place it in Build-requires: Need to install the binary to build the next from source, that's all. Just like gcc ;-) [...] The man pages are not built. The build dependencies do not call out the tools necessary to build the man pages. Most people don't have asciidoc, and I'm not sure we want to require it. Maybe we could have a separate make man-rpm target for that? Would have to be a requirement for building anyway. There is a (not really nice) SRPM at http://www.pvv.ntnu.no/~terjeros/rpms/asciidoc/. Will see to clean it up. -- Dr. Horst H. von Brand User #22616 counter.li.org Departamento de Informatica Fono: +56 32 654431 Universidad Tecnica Federico Santa Maria +56 32 654239 Casilla 110-V, Valparaiso, ChileFax: +56 32 797513 - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Trial git RPM's..
Linus Torvalds [EMAIL PROTECTED] writes: On Mon, 11 Jul 2005, Eric W. Biederman wrote: A couple of pieces. The dist target has assumes git-tar-tree is in the path. Making it so you have to have git installed to build the rpm. Yes. Maybe we could relax that requirement by using ./git-tar-tree or something? That still requires that you have _built_ git to do the rpm, but at least you won't have had to install it. Does that fit the rpm build process? Or does an rpm build make something like that really inconvenient? I don't know, patches welcome. That would be sane. The reason I worry about having it installed is that if git-tar-tree changes without building first you will run the old version instead of the new one. The man pages are not built. The build dependencies do not call out the tools necessary to build the man pages. Most people don't have asciidoc, and I'm not sure we want to require it. Maybe we could have a separate make man-rpm target for that? Or just have a make man target and only require the rpm to use it. You certainly want to require making the man pages when building the rpm. Which means only those people who build rpms or build man pages need asciidoc. And it does not pass my torture test of building rpm's on debian, but that is not a huge problem. Ok, why is debian problematic? Mostly because debian is not rpm based. If you are real careful you can build rpm's on debian. It is almost as bad as complaining that git does not build on windows with Microsoft's compiler. I was getting a really generic error. I need to look into it deeper to see if is something that is avoidable. Is there some missing dependency or something? I really haven't ever done an rpm, and the git rpm target was all done by Chris Wright, so I don't have any clue at all. Again, patches welcome. Will do. Eric - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Trial git RPM's..
Linus Torvalds [EMAIL PROTECTED] writes: On Mon, 11 Jul 2005, Eric W. Biederman wrote: Are you still up for a patch that records who and when made a tag? I sent one but it seems to have been lost. I'd really actually prefer for the code to be shared with the commit code, so that the user info (name, email, date) would not just be exactly the same, but would share the same code so that we don't end up having them ever get out of sync. Sounds fair. That would imply moving parts of git-tag-script into mktag.c. Actually I was looking at doing a git-ident thing that will just compute who git thinks you are. And then git-commit-tree can just popen it to share code. That looks like how the logic has been accomplished in other places. Moving parts of git-tag-script into mktag is hard because you have to generate a flat file to pass to gpg. And I don't think I am ready to hard code the call to gpg into mktag, as some other signing method may come along. Although that may be the saner choice. Anyway the git-ident thing is easy and informative for debugging so I will finish coding that up as soon as I get home. Eric - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Trial git RPM's..
On Mon, 11 Jul 2005, Eric W. Biederman wrote: Actually I was looking at doing a git-ident thing that will just compute who git thinks you are. And then git-commit-tree can just popen it to share code. That looks like how the logic has been accomplished in other places. I hate popen() if there's a reasonable functional interface in a library. popen() is damn inefficient for doing something like this that is all C anyway. Linus - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Trial git RPM's..
Linus Torvalds [EMAIL PROTECTED] writes: On Mon, 11 Jul 2005, Eric W. Biederman wrote: Actually I was looking at doing a git-ident thing that will just compute who git thinks you are. And then git-commit-tree can just popen it to share code. That looks like how the logic has been accomplished in other places. I hate popen() if there's a reasonable functional interface in a library. popen() is damn inefficient for doing something like this that is all C anyway. Ok two new files then. The new library function, and then the utility that calls it. Eric - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
