Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Dave Borowitz
On Mon, Apr 28, 2014 at 12:40 PM, Junio C Hamano wrote: > "'Dave Borowitz ' via msysGit" > writes: > >> I think I should probably re-roll the patch to default to the old >> behavior (blind -lcurl) if curl-config returns the empty string, which >> I believe is also the case when the binary is not

Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Junio C Hamano
"'Dave Borowitz ' via msysGit" writes: > I think I should probably re-roll the patch to default to the old > behavior (blind -lcurl) if curl-config returns the empty string, which > I believe is also the case when the binary is not found. Thanks for a prompt response; as this may indicate a poss

Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Dave Borowitz
On Mon, Apr 28, 2014 at 11:31 AM, Junio C Hamano wrote: > Erik Faye-Lund writes: > >> We're using Curl 7.30.0 in msysGit (and thus also Git for Windows), so >> we should be able to include it. However, we do not have curl-config >> installed. > > Hmmm, between 2.0-rc0 and 2.0-rc1 there is 61a64ff

Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Junio C Hamano
Erik Faye-Lund writes: > We're using Curl 7.30.0 in msysGit (and thus also Git for Windows), so > we should be able to include it. However, we do not have curl-config > installed. Hmmm, between 2.0-rc0 and 2.0-rc1 there is 61a64fff (Makefile: use curl-config to determine curl flags, 2014-04-15)

Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Erik Faye-Lund
On Mon, Apr 28, 2014 at 8:39 PM, Dave Borowitz wrote: > On Mon, Apr 28, 2014 at 11:31 AM, Junio C Hamano wrote: >> Erik Faye-Lund writes: >> >>> We're using Curl 7.30.0 in msysGit (and thus also Git for Windows), so >>> we should be able to include it. However, we do not have curl-config >>> ins

Re: [msysGit] Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Erik Faye-Lund
On Mon, Apr 28, 2014 at 3:47 PM, Marat Radchenko wrote: > On Mon, Apr 28, 2014 at 03:20:46PM +0200, Johannes Schindelin wrote: >> That way, upstream Git does not have anything to change (and we avoid >> discussing five versions of essentially the same patch :-P). > > This bug isn't specific to msy

Re: [msysGit] Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Marat Radchenko
On Mon, Apr 28, 2014 at 03:20:46PM +0200, Johannes Schindelin wrote: > That way, upstream Git does not have anything to change (and we avoid > discussing five versions of essentially the same patch :-P). This bug isn't specific to msysGit but also affects all environments where curl-config is not

Re: [msysGit] Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Erik Faye-Lund
On Mon, Apr 28, 2014 at 3:20 PM, Johannes Schindelin wrote: > Hi kusma, > > On Mon, 28 Apr 2014, Erik Faye-Lund wrote: > >> On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund wrote: >> > So it seems that 08900987 ("Decide whether to build http-push in the >> > Makefile") makes a bad assumption abou

Re: [msysGit] Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Johannes Schindelin
Hi kusma, On Mon, 28 Apr 2014, Erik Faye-Lund wrote: > On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund wrote: > > So it seems that 08900987 ("Decide whether to build http-push in the > > Makefile") makes a bad assumption about the availability of > > curl-config on new libcurl installations; it

Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Erik Faye-Lund
On Mon, Apr 28, 2014 at 11:01 AM, Erik Faye-Lund wrote: > On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund wrote: >> So it seems that 08900987 ("Decide whether to build http-push in the >> Makefile") makes a bad assumption about the availability of >> curl-config on new libcurl installations; it'

Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Erik Faye-Lund
On Mon, Apr 28, 2014 at 11:01 AM, Erik Faye-Lund wrote: > On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund wrote: >> So it seems that 08900987 ("Decide whether to build http-push in the >> Makefile") makes a bad assumption about the availability of >> curl-config on new libcurl installations; it'

Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Erik Faye-Lund
On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund wrote: > So it seems that 08900987 ("Decide whether to build http-push in the > Makefile") makes a bad assumption about the availability of > curl-config on new libcurl installations; it's not present on "stock" > Windows builds. I wonder, though.

Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Erik Faye-Lund
On Mon, Apr 28, 2014 at 9:36 AM, Marat Radchenko wrote: > Silvola Tuomas wrote >> Hello, >> >> I installed git for windows 1.9.0 but any push operation I tried with it >> produced an error message saying "git: 'http-push' is not a git command". >> Other commands like pull, add, and commit worked j

Re: git version 1.9.0 missing git-http-push?

2014-04-28 Thread Marat Radchenko
Silvola Tuomas wrote > Hello, > > I installed git for windows 1.9.0 but any push operation I tried with it > produced an error message saying "git: 'http-push' is not a git command". > Other commands like pull, add, and commit worked just fine. > At the end of this day I noticed that C:\Program Fi

git version 1.9.0 missing git-http-push?

2014-04-27 Thread Silvola Tuomas
Hello, I installed git for windows 1.9.0 but any push operation I tried with it produced an error message saying "git: 'http-push' is not a git command". Other commands like pull, add, and commit worked just fine. At the end of this day I noticed that C:\Program Files (x86)\Git\libexec\git-core