[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2589: ARTEMIS-2281 Enhancements for addresses/queues of web console

2019-04-04 Thread GitBox
michaelandrepearce commented on issue #2589: ARTEMIS-2281 Enhancements for addresses/queues of web console URL: https://github.com/apache/activemq-artemis/pull/2589#issuecomment-480109849 @sebthom looks good to me, will merge in tomorrow, if no other comments.

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2588: NO-JIRA Fix log statement in sessions.js

2019-04-04 Thread GitBox
michaelandrepearce edited a comment on issue #2588: NO-JIRA Fix log statement in sessions.js URL: https://github.com/apache/activemq-artemis/pull/2588#issuecomment-480109681 @sebthom nice catch! will merge in soon. This is

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2588: NO-JIRA Fix log statement in sessions.js

2019-04-04 Thread GitBox
michaelandrepearce commented on issue #2588: NO-JIRA Fix log statement in sessions.js URL: https://github.com/apache/activemq-artemis/pull/2588#issuecomment-480109681 @sebthom nice! will merge in soon. This is an automated

[GitHub] [activemq-website] jbertram commented on issue #6: Add Artemis Docs ReWrite rule

2019-04-04 Thread GitBox
jbertram commented on issue #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6#issuecomment-480108807 Squash and I'll merge. This is an automated message from the Apache Git Service. To

[GitHub] [activemq-website] jbertram commented on a change in pull request #6: Add Artemis Docs ReWrite rule

2019-04-04 Thread GitBox
jbertram commented on a change in pull request #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6#discussion_r272412403 ## File path: src/.htaccess ## @@ -2,5 +2,6 @@ RewriteEngine On RewriteRule ^camel/(.*)$

[GitHub] [activemq-website] michaelandrepearce commented on a change in pull request #6: Add Artemis Docs ReWrite rule

2019-04-04 Thread GitBox
michaelandrepearce commented on a change in pull request #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6#discussion_r27240 ## File path: src/.htaccess ## @@ -2,5 +2,6 @@ RewriteEngine On RewriteRule ^camel/(.*)$

[GitHub] [activemq-website] michaelandrepearce commented on a change in pull request #6: Add Artemis Docs ReWrite rule

2019-04-04 Thread GitBox
michaelandrepearce commented on a change in pull request #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6#discussion_r27240 ## File path: src/.htaccess ## @@ -2,5 +2,6 @@ RewriteEngine On RewriteRule ^camel/(.*)$

[GitHub] [activemq-website] michaelandrepearce opened a new pull request #6: Add Artemis Docs ReWrite rule

2019-04-04 Thread GitBox
michaelandrepearce opened a new pull request #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-website] michaelandrepearce commented on issue #6: Add Artemis Docs ReWrite rule

2019-04-04 Thread GitBox
michaelandrepearce commented on issue #6: Add Artemis Docs ReWrite rule URL: https://github.com/apache/activemq-website/pull/6#issuecomment-480100558 @jbertram wdyt? This is an automated message from the Apache Git Service.

[GitHub] [activemq-artemis] jbertram edited a comment on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
jbertram edited a comment on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-480028367 To the point about application requirements in this use-case, there are definitely requirements for the

[GitHub] [activemq-artemis] jbertram commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
jbertram commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-480028367 To the point about application requirements in this use-case, there are definitely requirements for the application if it

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
jbertram commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272323801 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272321577 ## File path:

[GitHub] [activemq-artemis] asfgit closed pull request #2608: NO-JIRA Adding Compatibility tests on Large Message for HornetQ

2019-04-04 Thread GitBox
asfgit closed pull request #2608: NO-JIRA Adding Compatibility tests on Large Message for HornetQ URL: https://github.com/apache/activemq-artemis/pull/2608 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] gemmellr commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
gemmellr commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-479986758 I'd guess that Tim probably meant that doing it in the broker still requires the application to generate unique details

[GitHub] [activemq-artemis] jbertram commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
jbertram commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-479978220 The duplicate detection is done by the broker as that is the only reliable place for the duplicate to be detected. See

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
jbertram commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272271119 ## File path:

[GitHub] [activemq-artemis] tabish121 commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
tabish121 commented on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-479976744 @jbertram Given there's no requirements laid out in the issue I can't say for sure other than to say that if you want it

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272269532 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272269532 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272269532 ## File path:

[GitHub] [activemq-artemis] jbertram opened a new pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

2019-04-04 Thread GitBox
jbertram opened a new pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609 I'm not entirely sure this should be an application property. Will someone with more expertise with AMQP weigh in? @tabish121? Should it

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2608: NO-JIRA Adding Compatibility tests on Large Message for HornetQ

2019-04-04 Thread GitBox
clebertsuconic commented on issue #2608: NO-JIRA Adding Compatibility tests on Large Message for HornetQ URL: https://github.com/apache/activemq-artemis/pull/2608#issuecomment-479957703 I was working on a test to validate an user's issue, and I had to write a test to prove it was a non

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #2608: NO-JIRA Adding Compatibility tests on Large Message for HornetQ

2019-04-04 Thread GitBox
clebertsuconic opened a new pull request #2608: NO-JIRA Adding Compatibility tests on Large Message for HornetQ URL: https://github.com/apache/activemq-artemis/pull/2608 This is an automated message from the Apache Git

[GitHub] [activemq-artemis] franz1981 commented on issue #2607: ARTEMIS-2291 Added test for ClassCastException on JMSBridgeImpl::stop

2019-04-04 Thread GitBox
franz1981 commented on issue #2607: ARTEMIS-2291 Added test for ClassCastException on JMSBridgeImpl::stop URL: https://github.com/apache/activemq-artemis/pull/2607#issuecomment-479873109 @clebertsuconic @jbertram I'm not very happy about this test, because I've modified the running