[GitHub] [hive] maheshk114 commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

maheshk114 commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r466826953 ## File path: ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query94_anti_join.q.out ## @@ -0,0 +1,94 @@ +PREHOOK: query: explain cbo

[GitHub] [hive] maheshk114 commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

maheshk114 commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r466826675 ## File path: ql/src/test/results/clientpositive/perf/tez/cbo_query16_anti_join.q.out ## @@ -0,0 +1,99 @@ +PREHOOK: query: explain cbo Review comment:

[GitHub] [hive] maheshk114 commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

maheshk114 commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r466826103 ## File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ## @@ -2162,7 +2162,8 @@ private static void populateLlapDaemonVarsSet(Set

[GitHub] [hive] maheshk114 commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

maheshk114 commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r466825617 ## File path: ql/src/test/results/clientpositive/llap/subquery_notexists_having.q.out ## @@ -31,7 +31,8 @@ STAGE PLANS: Tez A masked pattern

[GitHub] [hive] maheshk114 commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

maheshk114 commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r466822516 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java ## @@ -2129,6 +2133,16 @@ private RelNode

[GitHub] [hive] maheshk114 commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

maheshk114 commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r466819572 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java ## @@ -92,7 +104,7 @@ public void

[GitHub] [hive] maheshk114 commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

maheshk114 commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r466819149 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAntiSemiJoinRule.java ## @@ -0,0 +1,105 @@ +/* + * Licensed to the

[GitHub] [hive] maheshk114 commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

maheshk114 commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r466818492 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinAntiJoinMultiKeyOperator.java ## @@ -0,0 +1,400 @@ +/* + * Licensed

[GitHub] [hive] maheshk114 commented on a change in pull request #1147: HIVE-23716: Support Anti Join in Hive

maheshk114 commented on a change in pull request #1147: URL: https://github.com/apache/hive/pull/1147#discussion_r466818194 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinAntiJoinLongOperator.java ## @@ -0,0 +1,315 @@ +/* + * Licensed to

[GitHub] [hive] GuoPhilipse removed a comment on pull request #1363: HIVE-23996: Remove unused line to keep code clean

GuoPhilipse removed a comment on pull request #1363: URL: https://github.com/apache/hive/pull/1363#issuecomment-669876714 cc @pvary This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hive] jcamachor opened a new pull request #1374: HIVE-24012: Support for rewriting with materialized views containing …

jcamachor opened a new pull request #1374: URL: https://github.com/apache/hive/pull/1374 …grouping sets ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change?

[GitHub] [hive] sam-an-cloudera opened a new pull request #1373: HIVE-24004: Improve performance for filter hook for superuser path

sam-an-cloudera opened a new pull request #1373: URL: https://github.com/apache/hive/pull/1373 This is an improvement on filter hook. For superuser if we can skip authorization, we don't need to create authorizer. This can save some CPU cycles.

[GitHub] [hive] sam-an-cloudera commented on pull request #1372: HIVE-24004: Improve performance for filter hook for superuser path

sam-an-cloudera commented on pull request #1372: URL: https://github.com/apache/hive/pull/1372#issuecomment-670265392 problem with jenkins. Do another one. This is an automated message from the Apache Git Service. To

[GitHub] [hive] sam-an-cloudera closed pull request #1372: HIVE-24004: Improve performance for filter hook for superuser path

sam-an-cloudera closed pull request #1372: URL: https://github.com/apache/hive/pull/1372 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hive] sam-an-cloudera opened a new pull request #1372: HIVE-24002: Improve performance for filter hook for superuser path

sam-an-cloudera opened a new pull request #1372: URL: https://github.com/apache/hive/pull/1372 This is an improvement on filter hook. For superuser if we can skip authorization, we don't need to create authorizer. This can save some CPU cycles.

[GitHub] [hive] deniskuzZ closed pull request #1369: HIVE-24000: Put exclusive MERGE INSERT under the feature flag

deniskuzZ closed pull request #1369: URL: https://github.com/apache/hive/pull/1369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] deniskuzZ opened a new pull request #1371: HIVE-24000: Put exclusive MERGE INSERT under the feature flag

deniskuzZ opened a new pull request #1371: URL: https://github.com/apache/hive/pull/1371 (cherry picked from commit 0e4b02af485cb1972ebc4f251d853c710e70164f) test out fix ### What changes were proposed in this pull request? Pushed exclusive MERGE INSERT under

[GitHub] [hive] vineetgarg02 merged pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 merged pull request #1315: URL: https://github.com/apache/hive/pull/1315 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hive] kishendas commented on a change in pull request #1355: send tableId to get_partition APIs

kishendas commented on a change in pull request #1355: URL: https://github.com/apache/hive/pull/1355#discussion_r466627274 ## File path: ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestTxnManager.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hive] kishendas commented on a change in pull request #1355: send tableId to get_partition APIs

kishendas commented on a change in pull request #1355: URL: https://github.com/apache/hive/pull/1355#discussion_r466626987 ## File path: ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreClient.java ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] kishendas commented on a change in pull request #1355: send tableId to get_partition APIs

kishendas commented on a change in pull request #1355: URL: https://github.com/apache/hive/pull/1355#discussion_r466626887 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -474,6 +476,12 @@ public static Hive get() throws HiveException { return

[GitHub] [hive] kishendas commented on a change in pull request #1355: send tableId to get_partition APIs

kishendas commented on a change in pull request #1355: URL: https://github.com/apache/hive/pull/1355#discussion_r466625978 ## File path: ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreClientApiArgumentsChecker.java ## @@ -0,0 +1,140 @@ +/* + * Licensed to the

[GitHub] [hive] vihangk1 commented on a change in pull request #1355: send tableId to get_partition APIs

vihangk1 commented on a change in pull request #1355: URL: https://github.com/apache/hive/pull/1355#discussion_r466598803 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -474,6 +476,12 @@ public static Hive get() throws HiveException { return

[GitHub] [hive] vihangk1 commented on a change in pull request #1330: HIVE-23890: Create HMS endpoint for querying file lists using FlatBuf…

vihangk1 commented on a change in pull request #1330: URL: https://github.com/apache/hive/pull/1330#discussion_r466575514 ## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ## @@ -1861,6 +1861,19 @@ struct ScheduledQueryProgressInfo{

[GitHub] [hive] aasha commented on a change in pull request #1358: HIVE-23955 : Classification of Error Codes in Replication

aasha commented on a change in pull request #1358: URL: https://github.com/apache/hive/pull/1358#discussion_r466579718 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java ## @@ -196,12 +203,14 @@ private String

[GitHub] [hive] pkumarsinha commented on a change in pull request #1358: HIVE-23955 : Classification of Error Codes in Replication

pkumarsinha commented on a change in pull request #1358: URL: https://github.com/apache/hive/pull/1358#discussion_r466578320 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/DirCopyTask.java ## @@ -86,107 +87,59 @@ private boolean checkIfPathExist(Path sourcePath,

[GitHub] [hive] pkumarsinha commented on a change in pull request #1358: HIVE-23955 : Classification of Error Codes in Replication

pkumarsinha commented on a change in pull request #1358: URL: https://github.com/apache/hive/pull/1358#discussion_r466576634 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java ## @@ -196,12 +203,14 @@ private String

[GitHub] [hive] jcamachor commented on a change in pull request #1357: HIVE-23963: UnsupportedOperationException in queries 74 and 84 while applying HiveCardinalityPreservingJoinRule

jcamachor commented on a change in pull request #1357: URL: https://github.com/apache/hive/pull/1357#discussion_r466575229 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelDistribution.java ## @@ -81,8 +84,16 @@ public RelDistribution

[GitHub] [hive] aasha commented on a change in pull request #1358: HIVE-23955 : Classification of Error Codes in Replication

aasha commented on a change in pull request #1358: URL: https://github.com/apache/hive/pull/1358#discussion_r466574105 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java ## @@ -132,31 +130,40 @@ private AtlasReplInfo createAtlasReplInfo() throws

[GitHub] [hive] pkumarsinha commented on a change in pull request #1358: HIVE-23955 : Classification of Error Codes in Replication

pkumarsinha commented on a change in pull request #1358: URL: https://github.com/apache/hive/pull/1358#discussion_r466574279 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java ## @@ -132,31 +130,40 @@ private AtlasReplInfo createAtlasReplInfo()

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466570882 ## File path: ql/src/test/results/clientpositive/llap/prepare_plan.q.out ## @@ -0,0 +1,1575 @@ +PREHOOK: query: explain extended prepare pcount from

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466568964 ## File path: ql/src/test/results/clientpositive/llap/prepare_plan.q.out ## @@ -0,0 +1,1575 @@ +PREHOOK: query: explain extended prepare pcount from

[GitHub] [hive] aasha commented on a change in pull request #1358: HIVE-23955 : Classification of Error Codes in Replication

aasha commented on a change in pull request #1358: URL: https://github.com/apache/hive/pull/1358#discussion_r466563797 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java ## @@ -196,12 +203,14 @@ private String

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466563430 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/ExecuteStatementAnalyzer.java ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466561873 ## File path: parser/src/java/org/apache/hadoop/hive/ql/parse/PrepareStatementParser.g ## @@ -0,0 +1,66 @@ +/** + Licensed to the Apache Software

[GitHub] [hive] ashish-kumar-sharma opened a new pull request #1370: HIVE-23887: Reset Columns stats in Export Statement

ashish-kumar-sharma opened a new pull request #1370: URL: https://github.com/apache/hive/pull/1370 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change?

[GitHub] [hive] aasha commented on a change in pull request #1358: HIVE-23955 : Classification of Error Codes in Replication

aasha commented on a change in pull request #1358: URL: https://github.com/apache/hive/pull/1358#discussion_r466546396 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/DirCopyTask.java ## @@ -86,107 +87,59 @@ private boolean checkIfPathExist(Path sourcePath,

[GitHub] [hive] aasha commented on a change in pull request #1358: HIVE-23955 : Classification of Error Codes in Replication

aasha commented on a change in pull request #1358: URL: https://github.com/apache/hive/pull/1358#discussion_r466544742 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java ## @@ -132,31 +130,40 @@ private AtlasReplInfo createAtlasReplInfo() throws

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466534477 ## File path: ql/src/test/queries/clientpositive/prepare_plan.q ## @@ -0,0 +1,113 @@ +--! qt:dataset:src +--! qt:dataset:alltypesorc + +set

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466533583 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -1619,6 +1620,12 @@ public static ColStatistics

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466533366 ## File path: ql/src/test/results/clientpositive/llap/udf_greatest.q.out ## @@ -63,7 +63,7 @@ STAGE PLANS: alias: src Row Limit

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1315: [HIVE-23951] Support parameterized queries in WHERE/HAVING clause

vineetgarg02 commented on a change in pull request #1315: URL: https://github.com/apache/hive/pull/1315#discussion_r466531974 ## File path: ql/src/test/results/clientpositive/llap/prepare_plan.q.out ## @@ -0,0 +1,2512 @@ +PREHOOK: query: explain extended prepare pcount from

[GitHub] [hive] viirya commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch

viirya commented on pull request #1365: URL: https://github.com/apache/hive/pull/1365#issuecomment-670017177 @sunchao Ok, I see. I will do. Thanks. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hive] deniskuzZ opened a new pull request #1369: HIVE-24000: Put exclusive MERGE INSERT under the feature flag

deniskuzZ opened a new pull request #1369: URL: https://github.com/apache/hive/pull/1369 (cherry picked from commit 0e4b02af485cb1972ebc4f251d853c710e70164f) ### What changes were proposed in this pull request? Pushed exclusive MERGE INSERT under the feature flag

[GitHub] [hive] deniskuzZ closed pull request #1366: HIVE-24000: Put exclusive MERGE INSERT under the feature flag

deniskuzZ closed pull request #1366: URL: https://github.com/apache/hive/pull/1366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] klcopp opened a new pull request #1368: HIVE-24001: Don't cache MapWork in tez/ObjectCache during query-based compaction

klcopp opened a new pull request #1368: URL: https://github.com/apache/hive/pull/1368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hive] pkumarsinha commented on a change in pull request #1358: HIVE-23955 : Classification of Error Codes in Replication

pkumarsinha commented on a change in pull request #1358: URL: https://github.com/apache/hive/pull/1358#discussion_r466420110 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java ## @@ -132,31 +130,40 @@ private AtlasReplInfo createAtlasReplInfo()

[GitHub] [hive] sunchao commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch

sunchao commented on pull request #1365: URL: https://github.com/apache/hive/pull/1365#issuecomment-669959284 @viirya It may be because the PR action only support master and branch-2 right now, not branch-2.3. I suggest you submit a patch to the JIRA ticket similar to

[GitHub] [hive] aasha opened a new pull request #1367: HIVE-23993 Handle irrecoverable errors

aasha opened a new pull request #1367: URL: https://github.com/apache/hive/pull/1367 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r466421484 ## File path: ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out ## @@ -79,27 +79,25 @@ STAGE PLANS: Tez A masked

[GitHub] [hive] deniskuzZ opened a new pull request #1366: HIVE-24000: Put exclusive MERGE INSERT under the feature flag

deniskuzZ opened a new pull request #1366: URL: https://github.com/apache/hive/pull/1366 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r466414395 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r466410669 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r466404775 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java ## @@ -2054,7 +2067,8 @@ private void markSemiJoinForDPP(OptimizeTezProcContext

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r466404256 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java ## @@ -1887,13 +1898,14 @@ private void

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r466368067 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java ## @@ -1737,35 +1737,46 @@ private static double getBloomFilterBenefit( }

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r466367481 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r466366197 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r466365583 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r466365453 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SemiJoinReductionMerge.java ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] GuoPhilipse commented on pull request #1363: HIVE-23996: Remove unused line to keep code clean

GuoPhilipse commented on pull request #1363: URL: https://github.com/apache/hive/pull/1363#issuecomment-669876714 cc @pvary This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hive] zabetak commented on a change in pull request #1325: HIVE-21196 HIVE-23940 Multi-column semijoin reducers and TPC-H datasets

zabetak commented on a change in pull request #1325: URL: https://github.com/apache/hive/pull/1325#discussion_r466347783 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java ## @@ -53,6 +53,34 @@ private static final Logger LOG =

[GitHub] [hive] zabetak commented on a change in pull request #1357: HIVE-23963: UnsupportedOperationException in queries 74 and 84 while applying HiveCardinalityPreservingJoinRule

zabetak commented on a change in pull request #1357: URL: https://github.com/apache/hive/pull/1357#discussion_r466296959 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelDistribution.java ## @@ -81,8 +84,16 @@ public RelDistribution

[GitHub] [hive] dengzhhu653 commented on pull request #1205: HIVE-23800: Add hooks when HiveServer2 stops due to OutOfMemoryError

dengzhhu653 commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-669832758 > sorry @dengzhhu653 lately I was a little bit flooded with all kind of stuff...and right now I'm on holiday - will get back to your patch next week! sorry for disturbing

[GitHub] [hive] dengzhhu653 edited a comment on pull request #1205: HIVE-23800: Add hooks when HiveServer2 stops due to OutOfMemoryError

dengzhhu653 edited a comment on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-669832758 > sorry @dengzhhu653 lately I was a little bit flooded with all kind of stuff...and right now I'm on holiday - will get back to your patch next week! sorry for

[GitHub] [hive] kgyrtkirk commented on pull request #1205: HIVE-23800: Add hooks when HiveServer2 stops due to OutOfMemoryError

kgyrtkirk commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-669804983 sorry @dengzhhu653 lately I was a little bit flooded with all kind of stuff...and right now I'm on holiday - will get back to your patch next week!

[GitHub] [hive] kishendas commented on pull request #1355: send tableId to get_partition APIs

kishendas commented on pull request #1355: URL: https://github.com/apache/hive/pull/1355#issuecomment-669758040 > Can you add (or modify) some tests to make sure these APIs don't regress in future. Sure, I have added tests to make sure both validWriteIdList and tableId are sent