deniskuzZ merged PR #4970:
URL: https://github.com/apache/hive/pull/4970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #4970:
URL: https://github.com/apache/hive/pull/4970#issuecomment-1938382067
## [
tarak271 commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1481076713
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/CompactionHouseKeeperService.java:
##
@@ -0,0 +1,47 @@
+/*
+ *
tarak271 commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1481076152
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -78,17 +86,13 @@ public void run()
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1479613805
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -78,17 +81,13 @@ public void
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1474397325
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -78,17 +86,13 @@ public void
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1479616586
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -78,17 +81,13 @@ public void
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1479613805
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -78,17 +81,13 @@ public void
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1479613805
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -78,17 +81,13 @@ public void
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1479613805
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -78,17 +81,13 @@ public void
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1479596354
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -78,17 +81,13 @@ public void
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1474397325
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -78,17 +86,13 @@ public void
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1479588018
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##
@@ -95,13 +95,16 @@ public class MetastoreConf {
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1479579510
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/CompactionHouseKeeperService.java:
##
@@ -0,0 +1,47 @@
+/*
+ *
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1478415646
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/CompactionHouseKeeperService.java:
##
@@ -0,0 +1,54 @@
+/*
+ *
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1478411498
##
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java:
##
@@ -3508,9 +3509,15 @@ public void testRemoveDuplicateCompletedTxnComponents()
throws
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1478409760
##
ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java:
##
@@ -3345,9 +3355,14 @@ public void testNoTxnComponentsForScheduledQueries()
throws Exception {
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1478408746
##
ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java:
##
@@ -1244,9 +1245,16 @@ void
testInitiatorWithMultipleFailedCompactionsForVariousTblProperties(String
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1478402920
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##
@@ -97,6 +97,9 @@ public class MetastoreConf {
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1478399358
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/HouseKeepingTasks.java:
##
@@ -61,6 +62,11 @@ public List
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1474399258
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/CompactionHouseKeeperService.java:
##
@@ -0,0 +1,54 @@
+/*
+ *
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1474399258
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/CompactionHouseKeeperService.java:
##
@@ -0,0 +1,54 @@
+/*
+ *
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1474397325
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -78,17 +86,13 @@ public void
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1474396549
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -78,17 +86,13 @@ public void
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1474392029
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -38,16 +40,22 @@ public class
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1474383103
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -38,16 +40,22 @@ public class
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1474383103
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -38,16 +40,22 @@ public class
tarak271 commented on PR #4970:
URL: https://github.com/apache/hive/pull/4970#issuecomment-1914671075
@deniskuzZ could you please help guide on the next steps with this pull
request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tarak271 commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1448321975
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -38,16 +40,22 @@ public class
deniskuzZ commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1447106370
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/service/AcidHouseKeeperService.java:
##
@@ -38,16 +40,22 @@ public class
tarak271 commented on PR #4970:
URL: https://github.com/apache/hive/pull/4970#issuecomment-1877031025
@InvisibleProgrammer Thanks for the reply
> we have a recurring problem that affects multiple customers so it makes
sense to change the default?
Yes, that is the reason why we
InvisibleProgrammer commented on PR #4970:
URL: https://github.com/apache/hive/pull/4970#issuecomment-1876788448
@tarak271 , thank you for your reply. This looks great.
I have only one question left: I assume the root cause of a change is a
customer escalation. And having larger
tarak271 commented on PR #4970:
URL: https://github.com/apache/hive/pull/4970#issuecomment-1876703532
@InvisibleProgrammer
Thanks a lot for your valuable inputs.
1. This pull request is aimed at separating the compaction housekeeping
tasks into a new service
2. By doing this
InvisibleProgrammer commented on PR #4970:
URL: https://github.com/apache/hive/pull/4970#issuecomment-1875219288
Hi, please let me putting some thoughts about the change here:
Firstly, I like the idea of decoupling the AcidHouseKeeperService. As I see,
it already does five different
tarak271 commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1437403252
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/HouseKeepingTasks.java:
##
@@ -61,6 +62,11 @@ public List
tarak271 commented on code in PR #4970:
URL: https://github.com/apache/hive/pull/4970#discussion_r1437402694
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##
@@ -97,6 +97,9 @@ public class MetastoreConf {
sonarcloud[bot] commented on PR #4970:
URL: https://github.com/apache/hive/pull/4970#issuecomment-1870510546
## [