[GitHub] [hive] shreenidhiSaigaonkar commented on a diff in pull request #3736: HIVE-26711 The very first REPL Load should make the Target Database read-only.

2023-01-17 Thread GitBox
shreenidhiSaigaonkar commented on code in PR #3736: URL: https://github.com/apache/hive/pull/3736#discussion_r1071876874 ## itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplWithReadOnlyHook.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] tarak271 opened a new pull request, #3959: HIVE-26952 - set the value of metastore.storage.schema.reader.impl t…

2023-01-17 Thread GitBox
tarak271 opened a new pull request, #3959: URL: https://github.com/apache/hive/pull/3959 …o org.apache.hadoop.hive.metastore.SerDeStorageSchemaReader as default ### What changes were proposed in this pull request? set the value of the config metastore.storage.schema.reader.i

[GitHub] [hive] harshal-16 closed pull request #3958: HIVE-26932: Cleanup dump directory for eventId which was failed in previous dump cycle

2023-01-17 Thread GitBox
harshal-16 closed pull request #3958: HIVE-26932: Cleanup dump directory for eventId which was failed in previous dump cycle URL: https://github.com/apache/hive/pull/3958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [hive] harshal-16 opened a new pull request, #3960: HIVE-26933: Cleanup dump directory for eventId which was failed in previous dump cycle

2023-01-17 Thread GitBox
harshal-16 opened a new pull request, #3960: URL: https://github.com/apache/hive/pull/3960 Problem: - If Incremental Dump operation failes while dumping any event id in the staging directory. Then dump directory for this event id along with file _dumpmetadata still exists in the d

[GitHub] [hive] sonarcloud[bot] commented on pull request #3953: HIVE-26943 : Fix NPE during Optimised Bootstrap when db is dropped

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3953: URL: https://github.com/apache/hive/pull/3953#issuecomment-1385107300 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3801: HIVE-22977: Merge delta files instead of running a query in major/min…

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3801: URL: https://github.com/apache/hive/pull/3801#issuecomment-1385108588 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] deniskuzZ commented on a diff in pull request #3910: HIVE-26904: commitCompaction of query-based compaction should not fail when tmp table dirs are already cleaned up

2023-01-17 Thread GitBox
deniskuzZ commented on code in PR #3910: URL: https://github.com/apache/hive/pull/3910#discussion_r1071993848 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java: ## @@ -245,16 +243,32 @@ private static void disableLlapCaching(HiveConf conf) { * @thr

[GitHub] [hive] deniskuzZ commented on a diff in pull request #3822: HIVE-26793: Create a new configuration to override 'no compaction' for tables

2023-01-17 Thread GitBox
deniskuzZ commented on code in PR #3822: URL: https://github.com/apache/hive/pull/3822#discussion_r1072005883 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java: ## @@ -613,8 +613,9 @@ private boolean isEligibleForCompaction(CompactionInfo ci, return

[GitHub] [hive] deniskuzZ commented on a diff in pull request #3822: HIVE-26793: Create a new configuration to override 'no compaction' for tables

2023-01-17 Thread GitBox
deniskuzZ commented on code in PR #3822: URL: https://github.com/apache/hive/pull/3822#discussion_r1072005883 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java: ## @@ -613,8 +613,9 @@ private boolean isEligibleForCompaction(CompactionInfo ci, return

[GitHub] [hive] stiga-huang commented on a diff in pull request #3910: HIVE-26904: commitCompaction of query-based compaction should not fail when tmp table dirs are already cleaned up

2023-01-17 Thread GitBox
stiga-huang commented on code in PR #3910: URL: https://github.com/apache/hive/pull/3910#discussion_r1072021489 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java: ## @@ -245,16 +243,32 @@ private static void disableLlapCaching(HiveConf conf) { * @t

[GitHub] [hive] rkirtir commented on a diff in pull request #3880: [WIP] HIVE-26804 : Cancel Compactions in initiated state

2023-01-17 Thread GitBox
rkirtir commented on code in PR #3880: URL: https://github.com/apache/hive/pull/3880#discussion_r1072022432 ## standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift: ## @@ -1393,6 +1393,22 @@ struct ShowCompactResponse { 1: required list compacts, }

[GitHub] [hive] rkirtir commented on a diff in pull request #3880: [WIP] HIVE-26804 : Cancel Compactions in initiated state

2023-01-17 Thread GitBox
rkirtir commented on code in PR #3880: URL: https://github.com/apache/hive/pull/3880#discussion_r1072022879 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -6242,4 +6246,86 @@ public boolean isWrapperFor(Class if

[GitHub] [hive] rkirtir commented on a diff in pull request #3880: [WIP] HIVE-26804 : Cancel Compactions in initiated state

2023-01-17 Thread GitBox
rkirtir commented on code in PR #3880: URL: https://github.com/apache/hive/pull/3880#discussion_r1072023166 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnQueries.java: ## @@ -50,4 +50,20 @@ public class TxnQueries { " \"CC_H

[GitHub] [hive] rkirtir commented on a diff in pull request #3880: [WIP] HIVE-26804 : Cancel Compactions in initiated state

2023-01-17 Thread GitBox
rkirtir commented on code in PR #3880: URL: https://github.com/apache/hive/pull/3880#discussion_r1072024074 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -6242,4 +6246,86 @@ public boolean isWrapperFor(Class if

[GitHub] [hive] sonarcloud[bot] commented on pull request #3959: HIVE-26952 - set the value of metastore.storage.schema.reader.impl t…

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3959: URL: https://github.com/apache/hive/pull/3959#issuecomment-1385259486 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] veghlaci05 commented on a diff in pull request #3880: [WIP] HIVE-26804 : Cancel Compactions in initiated state

2023-01-17 Thread GitBox
veghlaci05 commented on code in PR #3880: URL: https://github.com/apache/hive/pull/3880#discussion_r1072059615 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -6242,4 +6245,91 @@ public boolean isWrapperFor(Class

[GitHub] [hive] sonarcloud[bot] commented on pull request #3882: HIVE-26802 Create qtest that runs the queries that query-based compac…

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3882: URL: https://github.com/apache/hive/pull/3882#issuecomment-1385333728 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3960: HIVE-26933: Cleanup dump directory for eventId which was failed in previous dump cycle

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3960: URL: https://github.com/apache/hive/pull/3960#issuecomment-1385428005 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] TaoZex opened a new pull request, #3961: HIVE-26956: Improv find_in_set function

2023-01-17 Thread GitBox
TaoZex opened a new pull request, #3961: URL: https://github.com/apache/hive/pull/3961 ### What changes were proposed in this pull request? Improv find_in_set function ### Why are the changes needed? Code redundancy ### Does this PR introduce _any_

[GitHub] [hive] sonarcloud[bot] commented on pull request #3935: HIVE-26717: Query based Rebalance compaction on insert-only tables

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3935: URL: https://github.com/apache/hive/pull/3935#issuecomment-1385511656 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] difin commented on a diff in pull request #3833: HIVE-26809: Upgrade ORC to 1.8.1.

2023-01-17 Thread GitBox
difin commented on code in PR #3833: URL: https://github.com/apache/hive/pull/3833#discussion_r1072298943 ## ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java: ## @@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean isCompressed

[GitHub] [hive] amansinha100 commented on a diff in pull request #3939: HIVE-26925: MV with iceberg storage format fails when contains 'PARTITIONED ON' clause due to column number/types difference.

2023-01-17 Thread GitBox
amansinha100 commented on code in PR #3939: URL: https://github.com/apache/hive/pull/3939#discussion_r1072338247 ## iceberg/iceberg-handler/src/test/queries/positive/mv_iceberg_partitioned_orc.q: ## @@ -0,0 +1,16 @@ +-- MV data is stored by partitioned iceberg testing the existi

[GitHub] [hive] sonarcloud[bot] commented on pull request #3961: HIVE-26956: Improve find_in_set function

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3961: URL: https://github.com/apache/hive/pull/3961#issuecomment-1385647100 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] kasakrisz commented on a diff in pull request #3939: HIVE-26925: MV with iceberg storage format fails when contains 'PARTITIONED ON' clause due to column number/types difference.

2023-01-17 Thread GitBox
kasakrisz commented on code in PR #3939: URL: https://github.com/apache/hive/pull/3939#discussion_r1072440879 ## iceberg/iceberg-handler/src/test/queries/positive/mv_iceberg_partitioned_orc.q: ## @@ -0,0 +1,16 @@ +-- MV data is stored by partitioned iceberg testing the existing

[GitHub] [hive] zabetak commented on a diff in pull request #3852: HIVE-22173: Query with multiple lateral views hangs during compilation

2023-01-17 Thread GitBox
zabetak commented on code in PR #3852: URL: https://github.com/apache/hive/pull/3852#discussion_r1072441255 ## ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java: ## @@ -94,8 +95,8 @@ public ParseContext transform(ParseContext pctx) throws SemanticException {

[GitHub] [hive] zabetak commented on a diff in pull request #3852: HIVE-22173: Query with multiple lateral views hangs during compilation

2023-01-17 Thread GitBox
zabetak commented on code in PR #3852: URL: https://github.com/apache/hive/pull/3852#discussion_r1072443296 ## common/src/java/org/apache/hadoop/hive/conf/HiveConf.java: ## @@ -3710,7 +3710,12 @@ public static enum ConfVars { HIVE_EXPLAIN_USER("hive.explain.user", true,

[GitHub] [hive] zabetak commented on a diff in pull request #3852: HIVE-22173: Query with multiple lateral views hangs during compilation

2023-01-17 Thread GitBox
zabetak commented on code in PR #3852: URL: https://github.com/apache/hive/pull/3852#discussion_r1072444905 ## ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out: ## @@ -121,7 +121,6 @@ STAGE PLANS: TableScan alias: expod1

[GitHub] [hive] zabetak commented on pull request #3852: HIVE-22173: Query with multiple lateral views hangs during compilation

2023-01-17 Thread GitBox
zabetak commented on PR #3852: URL: https://github.com/apache/hive/pull/3852#issuecomment-1385709912 > Also, the commit message mentions partition pruning but I didn't see changes related to that (I might have missed it). @amansinha100 The partition pruning optimization also relies on

[GitHub] [hive] zabetak commented on pull request #3852: HIVE-22173: Query with multiple lateral views hangs during compilation

2023-01-17 Thread GitBox
zabetak commented on PR #3852: URL: https://github.com/apache/hive/pull/3852#issuecomment-1385710968 @amansinha100 I addressed your comments can you please have another look. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [hive] zabetak closed pull request #3901: HIVE-26896 : Test fixes for lineage3.q and load_static_ptn_into_bucketed_table.q

2023-01-17 Thread GitBox
zabetak closed pull request #3901: HIVE-26896 : Test fixes for lineage3.q and load_static_ptn_into_bucketed_table.q URL: https://github.com/apache/hive/pull/3901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [hive] deniskuzZ commented on a diff in pull request #3935: HIVE-26717: Query based Rebalance compaction on insert-only tables

2023-01-17 Thread GitBox
deniskuzZ commented on code in PR #3935: URL: https://github.com/apache/hive/pull/3935#discussion_r1072518934 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java: ## @@ -342,15 +342,17 @@ public CompactionInfo fi

[GitHub] [hive] sonarcloud[bot] commented on pull request #3955: HIVE-26947: Handle compaction.Worker sleep for err cases to avoid high frequency connection respawning to HMS

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3955: URL: https://github.com/apache/hive/pull/3955#issuecomment-1385777432 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] difin commented on a diff in pull request #3833: HIVE-26809: Upgrade ORC to 1.8.1.

2023-01-17 Thread GitBox
difin commented on code in PR #3833: URL: https://github.com/apache/hive/pull/3833#discussion_r1072298943 ## ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java: ## @@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean isCompressed

[GitHub] [hive] difin commented on a diff in pull request #3833: HIVE-26809: Upgrade ORC to 1.8.1.

2023-01-17 Thread GitBox
difin commented on code in PR #3833: URL: https://github.com/apache/hive/pull/3833#discussion_r1072298943 ## ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java: ## @@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean isCompressed

[GitHub] [hive] sonarcloud[bot] commented on pull request #3852: HIVE-22173: Query with multiple lateral views hangs during compilation

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3852: URL: https://github.com/apache/hive/pull/3852#issuecomment-1385831457 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] simhadri-g opened a new pull request, #3962: HIVE-26928: LlapIoImpl::getParquetFooterBuffersFromCache throws excep…

2023-01-17 Thread GitBox
simhadri-g opened a new pull request, #3962: URL: https://github.com/apache/hive/pull/3962 …tion when metadata cache is disabled ### What changes were proposed in this pull request? If metadata / LLAP cache is disabled (hive.llap.io.memory.mode=none) at the time of initiali

[GitHub] [hive] sonarcloud[bot] commented on pull request #3939: HIVE-26925: MV with iceberg storage format fails when contains 'PARTITIONED ON' clause due to column number/types difference.

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3939: URL: https://github.com/apache/hive/pull/3939#issuecomment-1385854313 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] scarlin-cloudera commented on a diff in pull request #3934: HIVE-26922: Deadlock when rebuilding Materialized view stored by Iceberg

2023-01-17 Thread GitBox
scarlin-cloudera commented on code in PR #3934: URL: https://github.com/apache/hive/pull/3934#discussion_r1072847233 ## ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java: ## @@ -3122,7 +3117,19 @@ Seems much cleaner if each stmt is identified as a particular HiveOperation

[GitHub] [hive] sonarcloud[bot] commented on pull request #3801: HIVE-22977: Merge delta files instead of running a query in major/min…

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3801: URL: https://github.com/apache/hive/pull/3801#issuecomment-1386083177 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] scarlin-cloudera commented on a diff in pull request #3936: HIVE-26924: Alter materialized view enable rewrite throws SemanticException for source iceberg table

2023-01-17 Thread GitBox
scarlin-cloudera commented on code in PR #3936: URL: https://github.com/apache/hive/pull/3936#discussion_r1072857383 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rewrite/AlterMaterializedViewRewriteAnalyzer.java: ## @@ -68,10 +68,12 @@ public void analyze

[GitHub] [hive] sonarcloud[bot] commented on pull request #3962: HIVE-26928: LlapIoImpl::getParquetFooterBuffersFromCache throws excep…

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3962: URL: https://github.com/apache/hive/pull/3962#issuecomment-1386187492 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3939: HIVE-26925: MV with iceberg storage format fails when contains 'PARTITIONED ON' clause due to column number/types difference.

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3939: URL: https://github.com/apache/hive/pull/3939#issuecomment-1386210004 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] github-actions[bot] commented on pull request #3779: HIVE-26757: Add sfs+ofs support

2023-01-17 Thread GitBox
github-actions[bot] commented on PR #3779: URL: https://github.com/apache/hive/pull/3779#issuecomment-1386276682 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

[GitHub] [hive] github-actions[bot] closed pull request #3744: HIVE-26648:removing direct depedency of bouncycastle

2023-01-17 Thread GitBox
github-actions[bot] closed pull request #3744: HIVE-26648:removing direct depedency of bouncycastle URL: https://github.com/apache/hive/pull/3744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] github-actions[bot] commented on pull request #3780: HIVE-26598: Fix unsetting of db params for optimized bootstrap when r…

2023-01-17 Thread GitBox
github-actions[bot] commented on PR #3780: URL: https://github.com/apache/hive/pull/3780#issuecomment-1386276643 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

[GitHub] [hive] github-actions[bot] closed pull request #3727: HIVE-26648:Upgrade Bouncy Castle to 1.70 due to high CVEs

2023-01-17 Thread GitBox
github-actions[bot] closed pull request #3727: HIVE-26648:Upgrade Bouncy Castle to 1.70 due to high CVEs URL: https://github.com/apache/hive/pull/3727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] amanraj2520 commented on pull request #3954: HIVE-26945 : Fixed qyery39, query47, query49 and query57 q.out files

2023-01-17 Thread GitBox
amanraj2520 commented on PR #3954: URL: https://github.com/apache/hive/pull/3954#issuecomment-1386394089 Hi @zabetak @abstractdog Can you please approve this. There is one flaky test that is failing. I have fixed that in https://github.com/apache/hive/pull/3928 -- This is an automated me

[GitHub] [hive] amanraj2520 commented on pull request #3928: HIVE-26915: Disable TestCodahaleMetrics.testFileReporting flaky

2023-01-17 Thread GitBox
amanraj2520 commented on PR #3928: URL: https://github.com/apache/hive/pull/3928#issuecomment-1386395934 @zabetak Here is another flakiness http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-3954/4/tests -- This is an automated message from the Apache Git Servic

[GitHub] [hive] amanraj2520 commented on pull request #3928: HIVE-26915: Disable TestCodahaleMetrics.testFileReporting flaky

2023-01-17 Thread GitBox
amanraj2520 commented on PR #3928: URL: https://github.com/apache/hive/pull/3928#issuecomment-1386397424 @zabetak @abstractdog Can you please review and merge this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hive] stiga-huang commented on a diff in pull request #3910: HIVE-26904: commitCompaction of query-based compaction should not fail when tmp table dirs are already cleaned up

2023-01-17 Thread GitBox
stiga-huang commented on code in PR #3910: URL: https://github.com/apache/hive/pull/3910#discussion_r1073054442 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java: ## @@ -245,16 +243,32 @@ private static void disableLlapCaching(HiveConf conf) { * @t

[GitHub] [hive] xiuzhu9527 commented on pull request #3764: HIVE-26739: Fix the hiveserver2 error(No valid credentials provided) connecting metastore when HADOOP_USER_NAME environment variable exists

2023-01-17 Thread GitBox
xiuzhu9527 commented on PR #3764: URL: https://github.com/apache/hive/pull/3764#issuecomment-1386425591 thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hive] TaoZex closed pull request #3961: HIVE-26956: Improve find_in_set function

2023-01-17 Thread GitBox
TaoZex closed pull request #3961: HIVE-26956: Improve find_in_set function URL: https://github.com/apache/hive/pull/3961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [hive] pudidic commented on pull request #3788: HIVE-26597: Fix unsetting of db property repl.target.for in ReplicationSemanticAnalyzer

2023-01-17 Thread GitBox
pudidic commented on PR #3788: URL: https://github.com/apache/hive/pull/3788#issuecomment-1386474212 LGTM +1. I'll merge it as it's a trivial change. Thank you. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hive] pudidic merged pull request #3788: HIVE-26597: Fix unsetting of db property repl.target.for in ReplicationSemanticAnalyzer

2023-01-17 Thread GitBox
pudidic merged PR #3788: URL: https://github.com/apache/hive/pull/3788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or

[GitHub] [hive] vinitpatni opened a new pull request, #3963: HIVE-26599: Registering Tables metric during second cycle of optimise…

2023-01-17 Thread GitBox
vinitpatni opened a new pull request, #3963: URL: https://github.com/apache/hive/pull/3963 …d bootstrap ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change?

[GitHub] [hive] sonarcloud[bot] commented on pull request #3961: HIVE-26956: Improve find_in_set function

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3961: URL: https://github.com/apache/hive/pull/3961#issuecomment-1386535042 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] SourabhBadhya commented on a diff in pull request #3959: HIVE-26952 - set the value of metastore.storage.schema.reader.impl t…

2023-01-17 Thread GitBox
SourabhBadhya commented on code in PR #3959: URL: https://github.com/apache/hive/pull/3959#discussion_r1073148504 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java: ## @@ -67,6 +67,9 @@ public class MetastoreConf {

[GitHub] [hive] pudidic commented on a diff in pull request #3953: HIVE-26943 : Fix NPE during Optimised Bootstrap when db is dropped

2023-01-17 Thread GitBox
pudidic commented on code in PR #3953: URL: https://github.com/apache/hive/pull/3953#discussion_r1073149035 ## ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java: ## @@ -721,6 +721,10 @@ private int executeIncrementalLoad(long loadStartTime) throws Exception {

[GitHub] [hive] shreenidhiSaigaonkar commented on a diff in pull request #3953: HIVE-26943 : Fix NPE during Optimised Bootstrap when db is dropped

2023-01-17 Thread GitBox
shreenidhiSaigaonkar commented on code in PR #3953: URL: https://github.com/apache/hive/pull/3953#discussion_r1073152555 ## ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java: ## @@ -721,6 +721,10 @@ private int executeIncrementalLoad(long loadStartTime) throws E

[GitHub] [hive] sonarcloud[bot] commented on pull request #3801: HIVE-22977: Merge delta files instead of running a query in major/min…

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3801: URL: https://github.com/apache/hive/pull/3801#issuecomment-1386603262 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3780: HIVE-26598: Fix unsetting of db params for optimized bootstrap when r…

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #3780: URL: https://github.com/apache/hive/pull/3780#issuecomment-1386612591 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality