Havret edited a comment on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533690118
I'm not a Java expert, but what I remember from Uncle Bob's Clean Code I
read years ago, you shouldn't use checked exception as they violate open
Havret commented on a change in pull request #33: NO-JIRA: Update docs
URL: https://github.com/apache/activemq-nms-amqp/pull/33#discussion_r326775649
##
File path: docs/configuration.md
##
@@ -0,0 +1,21 @@
+# Client configuration
+This file details various configuration
Havret commented on a change in pull request #33: NO-JIRA: Update docs
URL: https://github.com/apache/activemq-nms-amqp/pull/33#discussion_r326775649
##
File path: docs/configuration.md
##
@@ -0,0 +1,21 @@
+# Client configuration
+This file details various configuration
Havret edited a comment on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533690118
I'm not a Java expert, but what I remember from Uncle Bob's Clean Code I
read years ago, you shouldn't use checked exception as they violate open
Havret edited a comment on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533690118
I'm not a Java expert, but what I remember from Uncle Bob's Clean Code I
read years ago, you shouldn't use checked exception as they violate open
cjwmorgan-sol commented on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533730425
I find having the provider intentionally hiding potential unintended errors
at the cost of a log for a single scenario seems like a bad idea.
Havret commented on issue #28: NO-JIRA: Extend logging
URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533690118
I'm not a Java expert, but what I remember from Uncle Bob's Clean Code I
read years ago, you shouldn't use checked exception as they violate open closed
franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use
RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533606931
@wy96f @clebertsuconic
Just for completeness that's what would change:
-
franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use
RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533606931
@wy96f @clebertsuconic
Just for completeness that's what would change:
-
franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use
RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533606931
Just for completeness that's what would change (ie no additional copies with
heap buffers
franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use
RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533606931
@wy96f @clebertsuconic
Just for completeness that's what would change:
-
franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use
RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533606931
@wy96f @clebertsuconic
Just for completeness that's what would change:
-
franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use
RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533606931
@wy96f @clebertsuconic
Just for completeness that's what would change:
-
franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use
RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533606931
@wy96f @clebertsuconic
Just for completeness that's what would change:
-
franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use
RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533606931
@wy96f @clebertsuconic
Just for completeness that's what would change:
-
franz1981 edited a comment on issue #2844: ARTEMIS-1811 NIO Seq File should use
RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533606931
@wy96f @clebertsuconic
Just for completeness that's what would change:
-
franz1981 closed pull request #2832: ARTEMIS-2482 Large messages could leak
native ByteBuffers
URL: https://github.com/apache/activemq-artemis/pull/2832
This is an automated message from the Apache Git Service.
To respond
gemmellr commented on a change in pull request #12: Publish ActiveMQ 5.15.10
release
URL: https://github.com/apache/activemq-website/pull/12#discussion_r326543695
##
File path: src/xml-reference.md
##
@@ -51,6 +51,7 @@ XBean XML Reference
gemmellr commented on a change in pull request #12: Publish ActiveMQ 5.15.10
release
URL: https://github.com/apache/activemq-website/pull/12#discussion_r326542262
##
File path: src/components/classic/download/index.md
##
@@ -7,12 +7,12 @@ type: activemq5
These are the
franz1981 commented on issue #2844: ARTEMIS-1811 NIO Seq File should use
RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533591180
@wy96f @clebertsuconic This should solve the memory leak issue with the
minimum amount of changes.
franz1981 opened a new pull request #2844: ARTEMIS-1811 NIO Seq File should use
RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844
It use RandomAccessFile to allow using heap buffers without additional
copies and/or leaks of direct buffers, as
jbonofre commented on a change in pull request #12: Publish ActiveMQ 5.15.10
release
URL: https://github.com/apache/activemq-website/pull/12#discussion_r326604413
##
File path: src/xml-reference.md
##
@@ -51,6 +51,7 @@ XBean XML Reference
jbonofre commented on a change in pull request #12: Publish ActiveMQ 5.15.10
release
URL: https://github.com/apache/activemq-website/pull/12#discussion_r326604234
##
File path: src/components/classic/download/index.md
##
@@ -7,12 +7,12 @@ type: activemq5
These are the
asfgit merged pull request #12: Publish ActiveMQ 5.15.10 release
URL: https://github.com/apache/activemq-website/pull/12
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
asfgit merged pull request #12: Publish ActiveMQ 5.15.10 release
URL: https://github.com/apache/activemq-website/pull/12
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
franz1981 commented on issue #2844: ARTEMIS-1811 NIO Seq File should use
RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#issuecomment-533606931
Just for completeness that's what would change (ie no additional copies with
heap buffers anymore):
clebertsuconic commented on issue #2843: ARTEMIS-2496 Revert catch up with
zero-copy, as it's causing issues i…
URL: https://github.com/apache/activemq-artemis/pull/2843#issuecomment-533541903
@wy96f is this really a feature you really would like to have?
- as we moved through this
27 matches
Mail list logo
