Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

kasakrisz commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1602810089 ## hplsql/src/main/java/org/apache/hive/hplsql/Var.java: ## @@ -629,6 +630,31 @@ else if (type == Type.STRING) { } return toString(); } + + public String

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

sonarcloud[bot] commented on PR #5182: URL: https://github.com/apache/hive/pull/5182#issuecomment-2112520756 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

sonarcloud[bot] commented on PR #5182: URL: https://github.com/apache/hive/pull/5182#issuecomment-2111060813 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1600532609 ## hplsql/src/main/java/org/apache/hive/hplsql/functions/FunctionMisc.java: ## @@ -59,6 +64,43 @@ public void register(BuiltinFunctions f) { void

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1600530827 ## hplsql/src/main/java/org/apache/hive/hplsql/functions/FunctionDatetime.java: ## @@ -162,6 +174,35 @@ void toTimestamp(HplsqlParser.Expr_func_paramsContext ctx) {

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1600530114 ## hplsql/src/main/java/org/apache/hive/hplsql/Stmt.java: ## @@ -787,8 +787,19 @@ public Integer insertValues(HplsqlParser.Insert_stmtContext ctx) { for (int i =

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1600529809 ## hplsql/src/main/java/org/apache/hive/hplsql/Expression.java: ## @@ -110,7 +110,17 @@ else if (ctx.interval_item() != null) { } else {

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

sonarcloud[bot] commented on PR #5182: URL: https://github.com/apache/hive/pull/5182#issuecomment-2107758848 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

kasakrisz commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1575886634 ## hplsql/src/main/java/org/apache/hive/hplsql/functions/FunctionDatetime.java: ## @@ -162,6 +174,35 @@ void toTimestamp(HplsqlParser.Expr_func_paramsContext ctx) {

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

sonarcloud[bot] commented on PR #5182: URL: https://github.com/apache/hive/pull/5182#issuecomment-2065929338 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

sonarcloud[bot] commented on PR #5182: URL: https://github.com/apache/hive/pull/5182#issuecomment-2065140555 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1570924896 ## hplsql/src/main/java/org/apache/hive/hplsql/functions/FunctionMisc.java: ## @@ -211,6 +269,16 @@ public void partCount(HplsqlParser.Expr_spec_funcContext ctx) {

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1570924035 ## hplsql/src/main/java/org/apache/hive/hplsql/functions/FunctionMisc.java: ## @@ -113,7 +155,9 @@ void currentUser(HplsqlParser.Expr_spec_funcContext ctx) { }

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1570920471 ## hplsql/src/main/java/org/apache/hive/hplsql/functions/FunctionMisc.java: ## @@ -59,6 +64,43 @@ public void register(BuiltinFunctions f) { void

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1570919635 ## hplsql/src/main/java/org/apache/hive/hplsql/functions/FunctionDatetime.java: ## @@ -162,6 +174,35 @@ void toTimestamp(HplsqlParser.Expr_func_paramsContext ctx) {

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1570916828 ## hplsql/src/main/java/org/apache/hive/hplsql/Var.java: ## @@ -612,7 +613,7 @@ else if (type == Type.TIMESTAMP) { if (t.length() > len) { t =

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1570912666 ## hplsql/src/main/java/org/apache/hive/hplsql/Stmt.java: ## @@ -787,8 +787,19 @@ public Integer insertValues(HplsqlParser.Insert_stmtContext ctx) { for (int i =

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1570900994 ## hplsql/src/main/java/org/apache/hive/hplsql/Stmt.java: ## @@ -787,8 +787,19 @@ public Integer insertValues(HplsqlParser.Insert_stmtContext ctx) { for (int i =

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1570658422 ## hplsql/src/main/java/org/apache/hive/hplsql/Expression.java: ## @@ -565,7 +575,11 @@ public void operatorConcatSql(HplsqlParser.Expr_concatContext ctx) {

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1570337451 ## hplsql/src/main/java/org/apache/hive/hplsql/Expression.java: ## @@ -110,7 +110,17 @@ else if (ctx.interval_item() != null) { } else {

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1570148189 ## hplsql/src/main/antlr4/org/apache/hive/hplsql/Hplsql.g4: ## @@ -1563,7 +1563,7 @@ non_reserved_words : // Tokens that are not reserved words

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

kasakrisz commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1557648667 ## hplsql/src/main/java/org/apache/hive/hplsql/Var.java: ## @@ -601,7 +602,7 @@ else if (type == Type.STRING) { return (String)value; } else if (type

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

sonarcloud[bot] commented on PR #5182: URL: https://github.com/apache/hive/pull/5182#issuecomment-2040448911 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] HIVE-28143: After HIVE-27492 fix, some HPLSQL built-in functions like trim, lower are not working when used in insert statement. [hive]

sonarcloud[bot] commented on PR #5182: URL: https://github.com/apache/hive/pull/5182#issuecomment-2039795751 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate