sagnikc-dremio commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r478829379
##
File path: cpp/src/gandiva/precompiled/extended_math_ops_test.cc
##
@@ -87,6 +87,22 @@ TEST(TestExtendedMathOps, TestLogWithBase) {
sagnikc-dremio commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r478829379
##
File path: cpp/src/gandiva/precompiled/extended_math_ops_test.cc
##
@@ -87,6 +87,22 @@ TEST(TestExtendedMathOps, TestLogWithBase) {
sagnikc-dremio commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r478829379
##
File path: cpp/src/gandiva/precompiled/extended_math_ops_test.cc
##
@@ -87,6 +87,22 @@ TEST(TestExtendedMathOps, TestLogWithBase) {
kiszk commented on a change in pull request #8035:
URL: https://github.com/apache/arrow/pull/8035#discussion_r478827719
##
File path: cpp/src/gandiva/precompiled/extended_math_ops_test.cc
##
@@ -87,6 +87,20 @@ TEST(TestExtendedMathOps, TestLogWithBase) {
emkornfield commented on pull request #6676:
URL: https://github.com/apache/arrow/pull/6676#issuecomment-682321629
I think any automation we can get is useful and we can file a follow-up JIRA
to check periodically for cython. Unless I'm missing something even python
only support is a
emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r478826768
##
File path: cpp/src/gandiva/precompiled/extended_math_ops_test.cc
##
@@ -87,6 +87,22 @@ TEST(TestExtendedMathOps, TestLogWithBase) {
arw2019 commented on a change in pull request #8044:
URL: https://github.com/apache/arrow/pull/8044#discussion_r478814578
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -3531,11 +3533,11 @@ def test_dictionary_from_pandas_specified_type():
assert
jianxind commented on pull request #8071:
URL: https://github.com/apache/arrow/pull/8071#issuecomment-682305713
cc @nealrichardson @pitrou
homebrew-cpp is green now. Seems apple clang doesn't extract
"-march=skylake-avx512" to "-mavx512f -mavx512cd -mavx512vl -mavx512dq
emkornfield commented on pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#issuecomment-682300209
> With the vectorized round_int32_int32, why are we passing -5 as the second
argument? Would be glad if you could clarify.
I wanted to verify that with a static value,
emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r478803947
##
File path: cpp/src/gandiva/precompiled/extended_math_ops.cc
##
@@ -111,6 +112,76 @@ LOG_WITH_BASE(float64, float64, float64)
POWER(float64,
sagnikc-dremio commented on pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#issuecomment-682297850
> With the two changes mentioned round_int32_int32 can be vectorized.
>
> https://godbolt.org/z/fabEn6
>
> With LLVM it actually doesn't necessarily seem to
sagnikc-dremio commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r478803356
##
File path: cpp/src/gandiva/precompiled/extended_math_ops.cc
##
@@ -111,6 +112,76 @@ LOG_WITH_BASE(float64, float64, float64)
POWER(float64,
sagnikc-dremio commented on a change in pull request #8035:
URL: https://github.com/apache/arrow/pull/8035#discussion_r478802287
##
File path: cpp/src/gandiva/precompiled/extended_math_ops_test.cc
##
@@ -87,6 +87,20 @@ TEST(TestExtendedMathOps, TestLogWithBase) {
github-actions[bot] commented on pull request #8071:
URL: https://github.com/apache/arrow/pull/8071#issuecomment-682292096
Revision: e521bdf33ccae2d9f2c89c71247ca4eba5b9
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #8071:
URL: https://github.com/apache/arrow/pull/8071#issuecomment-682291899
https://issues.apache.org/jira/browse/ARROW-9877
This is an automated message from the Apache Git
jianxind commented on pull request #8071:
URL: https://github.com/apache/arrow/pull/8071#issuecomment-682289580
@github-actions crossbow submit homebrew-cpp
This is an automated message from the Apache Git Service.
To
jianxind opened a new pull request #8071:
URL: https://github.com/apache/arrow/pull/8071
Apple Clang cannot unzip "-march=skylake-avx512" exactly.
Also fix AVX512 detect to include AVX512F, AVX512BW, AVX512VL, AVX512CD,
AVX512DQ
Signed-off-by: Frank Du
zhztheplayer commented on a change in pull request #7965:
URL: https://github.com/apache/arrow/pull/7965#discussion_r478793658
##
File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
##
@@ -120,6 +120,14 @@ TEST(TestArithmeticOps, TestBitwiseOps) {
yewero closed pull request #8070:
URL: https://github.com/apache/arrow/pull/8070
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8070:
URL: https://github.com/apache/arrow/pull/8070#issuecomment-682279249
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
yewero commented on issue #8062:
URL: https://github.com/apache/arrow/issues/8062#issuecomment-682278735
Here is a solution: #8070
This is an automated message from the Apache Git Service.
To respond to the message, please
mrkn commented on a change in pull request #7898:
URL: https://github.com/apache/arrow/pull/7898#discussion_r478785713
##
File path: cpp/src/arrow/array/array_dict_test.cc
##
@@ -904,6 +904,67 @@ TEST(TestDecimalDictionaryBuilder, DoubleTableSize) {
yewero opened a new pull request #8070:
URL: https://github.com/apache/arrow/pull/8070
fix a bug in #8062
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jianxind commented on pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#issuecomment-682263721
> Since ARROW_USER_SIMD_LEVEL (environment variable) is enough to fix this,
do we want to keep ARROW_RUNTIME_SIMD_LEVEL (CMake setting) or not?
I will vote +1 to keep
kiszk commented on pull request #7938:
URL: https://github.com/apache/arrow/pull/7938#issuecomment-682259059
@kou Thank you. Now, a TravisCI job is finished correctly with many
failures. Could you review this again?
This is
jduo commented on pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#issuecomment-682225959
> Some minor notes...I think we should resolve how exactly to treat
Handshake in the design docs, though
@lidavidm @pitrou , I've added a comment in the design doc about how
jduo commented on a change in pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#discussion_r478695524
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/grpc/ContextAdapter.java
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
jorisvandenbossche commented on a change in pull request #8069:
URL: https://github.com/apache/arrow/pull/8069#discussion_r478689723
##
File path: python/pyarrow/_dataset.pyx
##
@@ -539,7 +549,7 @@ cdef class FileSystemDataset(Dataset):
]:
if not
jorisvandenbossche commented on a change in pull request #8065:
URL: https://github.com/apache/arrow/pull/8065#discussion_r478678307
##
File path: docs/source/python/filesystems.rst
##
@@ -34,21 +34,87 @@ underlying storage, are automatically dereferenced. Only
basic
jorisvandenbossche commented on a change in pull request #8065:
URL: https://github.com/apache/arrow/pull/8065#discussion_r478678088
##
File path: docs/source/python/filesystems.rst
##
@@ -34,21 +34,87 @@ underlying storage, are automatically dereferenced. Only
basic
nealrichardson commented on a change in pull request #8065:
URL: https://github.com/apache/arrow/pull/8065#discussion_r478671300
##
File path: docs/source/python/filesystems.rst
##
@@ -34,21 +34,87 @@ underlying storage, are automatically dereferenced. Only
basic
jorisvandenbossche commented on a change in pull request #8065:
URL: https://github.com/apache/arrow/pull/8065#discussion_r478665527
##
File path: docs/source/python/filesystems.rst
##
@@ -34,21 +34,87 @@ underlying storage, are automatically dereferenced. Only
basic
nealrichardson commented on a change in pull request #8065:
URL: https://github.com/apache/arrow/pull/8065#discussion_r478656124
##
File path: docs/source/python/filesystems.rst
##
@@ -34,21 +34,87 @@ underlying storage, are automatically dereferenced. Only
basic
nealrichardson commented on a change in pull request #8069:
URL: https://github.com/apache/arrow/pull/8069#discussion_r478630774
##
File path: cpp/src/arrow/dataset/file_base.h
##
@@ -195,15 +195,15 @@ class ARROW_DS_EXPORT FileSystemDataset : public Dataset {
///
bkietz opened a new pull request #8069:
URL: https://github.com/apache/arrow/pull/8069
In addition, the constructor now ensures that all fragments in a file system
dataset belong to the provided filesystem.
This is an
vivkong commented on pull request #8047:
URL: https://github.com/apache/arrow/pull/8047#issuecomment-682090334
Right I understand. Thanks @emkornfield and @kou.
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #8068:
URL: https://github.com/apache/arrow/pull/8068#issuecomment-682065220
https://issues.apache.org/jira/browse/ARROW-9876
This is an automated message from the Apache Git
pitrou commented on pull request #8068:
URL: https://github.com/apache/arrow/pull/8068#issuecomment-682059475
Uncached ARM job: 32 minutes
(https://travis-ci.org/github/pitrou/arrow/jobs/721744337)
Cached ARM job: 5 minutes
(https://travis-ci.org/github/pitrou/arrow/jobs/721755186)
pitrou opened a new pull request #8068:
URL: https://github.com/apache/arrow/pull/8068
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pitrou closed pull request #7992:
URL: https://github.com/apache/arrow/pull/7992
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on a change in pull request #8067:
URL: https://github.com/apache/arrow/pull/8067#discussion_r478525557
##
File path: python/pyarrow/_fs.pyx
##
@@ -419,17 +420,27 @@ cdef class FileSystem(_Weakrefable):
vector[c_string] paths
github-actions[bot] commented on pull request #8067:
URL: https://github.com/apache/arrow/pull/8067#issuecomment-682034382
https://issues.apache.org/jira/browse/ARROW-9875
This is an automated message from the Apache Git
pitrou commented on pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#issuecomment-682032875
As for naming, according to various dictionaries, "empty" as a noun (and
"empties") is rather informal.
It seems `AppendEmptyValue` and `AppendEmptyValues` may be more
pitrou commented on a change in pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#discussion_r478519678
##
File path: cpp/src/arrow/buffer_builder.h
##
@@ -292,6 +292,11 @@ class TypedBufferBuilder {
return Status::OK();
}
+ void Forward(int64_t
pitrou commented on a change in pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#discussion_r478516412
##
File path: cpp/src/arrow/array/builder_nested.h
##
@@ -109,6 +109,25 @@ class BaseListBuilder : public ArrayBuilder {
return Status::OK();
}
+
pitrou commented on a change in pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#discussion_r478516181
##
File path: cpp/src/arrow/array/builder_nested.h
##
@@ -109,6 +109,25 @@ class BaseListBuilder : public ArrayBuilder {
return Status::OK();
}
+
pitrou commented on a change in pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#discussion_r478514839
##
File path: cpp/src/arrow/pretty_print.cc
##
@@ -339,6 +339,17 @@ class ArrayPrinter : public PrettyPrinter {
children.reserve(array.num_fields());
jorisvandenbossche commented on a change in pull request #8044:
URL: https://github.com/apache/arrow/pull/8044#discussion_r478505587
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -3531,11 +3533,11 @@ def test_dictionary_from_pandas_specified_type():
assert
pitrou commented on pull request #8067:
URL: https://github.com/apache/arrow/pull/8067#issuecomment-682023137
It's likely the docstring was written by @kszucs actually. The reason it
doesn't accept `pathlib.Path` is that `pathlib` represents local paths.
wqc200 commented on a change in pull request #8033:
URL: https://github.com/apache/arrow/pull/8033#discussion_r478504215
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -713,6 +718,9 @@ impl fmt::Debug for Expr {
match self {
Expr::Alias(expr,
jorisvandenbossche commented on pull request #8067:
URL: https://github.com/apache/arrow/pull/8067#issuecomment-682018886
@pitrou the docstring of `get_file_info` says it accepts a list of
"path-likes". I assumed this would mean it stringifies things like
pathlib.Path, but that is
jorisvandenbossche opened a new pull request #8067:
URL: https://github.com/apache/arrow/pull/8067
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on pull request #8066:
URL: https://github.com/apache/arrow/pull/8066#issuecomment-682012816
https://issues.apache.org/jira/browse/ARROW-9646
This is an automated message from the Apache Git
nealrichardson commented on issue #8062:
URL: https://github.com/apache/arrow/issues/8062#issuecomment-682011308
Thanks. Could you please [open a JIRA
issue](https://arrow.apache.org/docs/developers/contributing.html#report-bugs-and-propose-features)?
And would you be interested in
bkietz opened a new pull request #8066:
URL: https://github.com/apache/arrow/pull/8066
Adds `ParquetFileFormat::WriteFragment`, with support for custom writer
properties (currently exposed as members of ParquetFileFormat until
https://issues.apache.org/jira/browse/ARROW-9749 )
pitrou commented on a change in pull request #7898:
URL: https://github.com/apache/arrow/pull/7898#discussion_r478484727
##
File path: cpp/src/arrow/array/array_dict_test.cc
##
@@ -904,6 +904,67 @@ TEST(TestDecimalDictionaryBuilder, DoubleTableSize) {
nealrichardson edited a comment on pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#issuecomment-682000384
> > Is there a JIRA open to upgrade to thrift 0.13.0?
>
> @emkornfield AFAIK, there is no such a JIRA, and I am not sure if we have
a plan to upgrade to
nealrichardson commented on pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#issuecomment-682000384
> > Is there a JIRA open to upgrade to thrift 0.13.0?
>
> @emkornfield AFAIK, there is no such a JIRA, and I am not sure if we have
a plan to upgrade to thrift
github-actions[bot] commented on pull request #8065:
URL: https://github.com/apache/arrow/pull/8065#issuecomment-681996219
https://issues.apache.org/jira/browse/ARROW-9858
This is an automated message from the Apache Git
jorisvandenbossche commented on pull request #8065:
URL: https://github.com/apache/arrow/pull/8065#issuecomment-681995199
There is probably still plenty to improve in wording and actual examples,
but started putting some content on the page.
@nealrichardson if you have specific
jorisvandenbossche opened a new pull request #8065:
URL: https://github.com/apache/arrow/pull/8065
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rymurr commented on pull request #8059:
URL: https://github.com/apache/arrow/pull/8059#issuecomment-681960845
Hey @mariusvniekerk with intellij I have found that running `mvn clean
install` from a terminal first helps a lot. Also ensure that under Build ->
Compiler -> Java Compiler you
ursabot commented on pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#issuecomment-681948156
[AMD64 Conda Crossbow Submit
(#124163)](https://ci.ursalabs.org/#builders/98/builds/652) builder has been
succeeded.
Revision: 94a8b776cea1e75d431e7d6ae38d2e4b830593dc
wesm commented on pull request #7992:
URL: https://github.com/apache/arrow/pull/7992#issuecomment-681947570
Thanks. +1 from me
This is an automated message from the Apache Git Service.
To respond to the message, please log
mariusvniekerk commented on pull request #8059:
URL: https://github.com/apache/arrow/pull/8059#issuecomment-681947055
I tried setup that up but I could not get intellij to be able to run a test
suite at all. Are there some docs around how to set up the ide to work properly
for arrow work?
pitrou commented on pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#issuecomment-681945538
@ursabot crossbow submit test-conda-cpp-valgrind
This is an automated message from the Apache Git Service.
To
pitrou commented on pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#issuecomment-681945189
Since ARROW_USER_SIMD_LEVEL (environment variable) is enough to fix this, do
we want to keep ARROW_RUNTIME_SIMD_LEVEL (CMake setting) or not?
pitrou commented on pull request #7992:
URL: https://github.com/apache/arrow/pull/7992#issuecomment-681943423
I've tried the suggested API changes but they would require some annoying
C++ wrangling that's basically not worth it. Will merge if CI green.
jorisvandenbossche opened a new pull request #8064:
URL: https://github.com/apache/arrow/pull/8064
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on pull request #8064:
URL: https://github.com/apache/arrow/pull/8064#issuecomment-681926850
https://issues.apache.org/jira/browse/ARROW-9864
This is an automated message from the Apache Git
wesm closed pull request #6506:
URL: https://github.com/apache/arrow/pull/6506
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm commented on pull request #6506:
URL: https://github.com/apache/arrow/pull/6506#issuecomment-681920010
Will close for now until there is bandwidth to make a push on this project.
This is an automated message from the
liyafan82 commented on a change in pull request #8036:
URL: https://github.com/apache/arrow/pull/8036#discussion_r478382465
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -191,8 +193,15 @@ struct Divide {
template
static enable_if_floating_point
jorisvandenbossche commented on pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#issuecomment-681904949
@wjones1 I tested this branch locally, and can actually reproduce the
errors.
I don't see what you described above
jorisvandenbossche commented on pull request #6676:
URL: https://github.com/apache/arrow/pull/6676#issuecomment-681906038
If we are OK with this being rather limited for now (limited to the part of
pyarrow that is written in python, as I understand cython is not yet
supported), then I am
pitrou closed pull request #8060:
URL: https://github.com/apache/arrow/pull/8060
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou closed pull request #8036:
URL: https://github.com/apache/arrow/pull/8036
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8063:
URL: https://github.com/apache/arrow/pull/8063#issuecomment-681897891
https://issues.apache.org/jira/browse/ARROW-8383
This is an automated message from the Apache Git
pitrou closed pull request #8061:
URL: https://github.com/apache/arrow/pull/8061
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb commented on pull request #8032:
URL: https://github.com/apache/arrow/pull/8032#issuecomment-681867726
Good luck -- at this stage of a project (when architecture is changing a
bunch) know it is hard to make small / easy to review PRs. I hope the
comments are helpful and I am
alamb commented on a change in pull request #8032:
URL: https://github.com/apache/arrow/pull/8032#discussion_r478319729
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -1042,6 +998,35 @@ pub fn can_coerce_from(type_into: , type_from:
) -> bool {
}
}
+/// A
praveenbingo closed pull request #8001:
URL: https://github.com/apache/arrow/pull/8001
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kszucs commented on pull request #6506:
URL: https://github.com/apache/arrow/pull/6506#issuecomment-681836270
I'd assume so, but not sure when are we going to have the time for it.
This is an automated message from the
liyafan82 commented on a change in pull request #8036:
URL: https://github.com/apache/arrow/pull/8036#discussion_r478277035
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -191,8 +193,15 @@ struct Divide {
template
static enable_if_floating_point
fredgan commented on pull request #8046:
URL: https://github.com/apache/arrow/pull/8046#issuecomment-681810466
@sbinet Hi Sebastien, I concerned about it. But the loop bodies have some
return values(error values), so it's not simple to do like this. So I think it
's not worth to do like
yewero commented on issue #8062:
URL: https://github.com/apache/arrow/issues/8062#issuecomment-681753227
I found a solution for R 3.5.1:
Install Apache Arrow based on the following page:
https://arrow.apache.org/install/.
Then, the code in `linuxlibs.R` could be skipped during
liyafan82 commented on a change in pull request #8036:
URL: https://github.com/apache/arrow/pull/8036#discussion_r478231513
##
File path: cpp/src/arrow/compare.cc
##
@@ -968,6 +989,7 @@ class ScalarEqualsVisitor {
protected:
const Scalar& right_;
bool result_;
+
liyafan82 commented on a change in pull request #8036:
URL: https://github.com/apache/arrow/pull/8036#discussion_r478231393
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc
##
@@ -165,12 +166,17 @@ class TestBinaryArithmetic : public TestBase {
void
liyafan82 commented on a change in pull request #8036:
URL: https://github.com/apache/arrow/pull/8036#discussion_r478230891
##
File path: cpp/src/arrow/compare.cc
##
@@ -862,7 +862,11 @@ class TypeEqualsVisitor {
class ScalarEqualsVisitor {
public:
- explicit
liyafan82 commented on a change in pull request #8036:
URL: https://github.com/apache/arrow/pull/8036#discussion_r478230727
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -191,8 +193,15 @@ struct Divide {
template
static enable_if_floating_point
yewero opened a new issue #8062:
URL: https://github.com/apache/arrow/issues/8062
When I install arrow using`install.packages("arrow")`, an error occurred:
```
trying URL 'https://cloud.r-project.org/src/contrib/arrow_1.0.0.tar.gz'
Content type 'application/x-gzip' length 274139
liyafan82 commented on pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#issuecomment-681623530
> Is there a JIRA open to upgrade to thrift 0.13.0?
@emkornfield AFAIK, there is no such a JIRA, and I am not sure if we have a
plan to upgrade to thrift 0.13.0 recently.
92 matches
Mail list logo
