Re: [PR] Ankush/provenance [arrow-rs]

2025-06-23 Thread via GitHub
agola11 closed pull request #7759: Ankush/provenance URL: https://github.com/apache/arrow-rs/pull/7759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: g

Re: [PR] feat(csharp/src/Apache.Arrow.Adbc): OpenTelemetry tracing baseline [arrow-adbc]

2025-06-23 Thread via GitHub
birschick-bq commented on code in PR #2847: URL: https://github.com/apache/arrow-adbc/pull/2847#discussion_r2162949551 ## csharp/src/Apache.Arrow.Adbc/Tracing/IActivityTracer.cs: ## @@ -0,0 +1,52 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* co

Re: [PR] chore: bump typescript-eslint from 8.33.1 to 8.35.0 [arrow-js]

2025-06-23 Thread via GitHub
kou merged PR #174: URL: https://github.com/apache/arrow-js/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

Re: [PR] Variant: Write Variant Values as JSON [arrow-rs]

2025-06-23 Thread via GitHub
carpecodeum commented on PR #7670: URL: https://github.com/apache/arrow-rs/pull/7670#issuecomment-2998645194 > @alamb @scovich Thank you so much guys for your time and dedication for reviewing this PR, I have tried to fix all the suggestions given by you guys, Sorry for the delay in resolvi

Re: [PR] chore: bump @swc/core from 1.11.31 to 1.12.5 [arrow-js]

2025-06-23 Thread via GitHub
kou merged PR #179: URL: https://github.com/apache/arrow-js/pull/179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

Re: [I] Use prefix first for comparisons, resort to data buffer for remaining data on equal values [arrow-rs]

2025-06-23 Thread via GitHub
zhuqi-lucas commented on issue #7744: URL: https://github.com/apache/arrow-rs/issues/7744#issuecomment-2998576455 Next step i will try non-inlined case improvement for this ticket, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] Use prefix first for comparisons, resort to data buffer for remaining data on equal values [arrow-rs]

2025-06-23 Thread via GitHub
zhuqi-lucas commented on issue #7744: URL: https://github.com/apache/arrow-rs/issues/7744#issuecomment-2998575283 Thank you @Dandandan @alamb, Exactly big win with prefix compare(convert to u128 kernel based compare) from the try with continue inlined compare improvement: https://git

Re: [PR] chore: Fix auto documentation update [arrow-js]

2025-06-23 Thread via GitHub
kou commented on PR #173: URL: https://github.com/apache/arrow-js/pull/173#issuecomment-2998502016 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] chore: Fix auto documentation update [arrow-js]

2025-06-23 Thread via GitHub
kou merged PR #173: URL: https://github.com/apache/arrow-js/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

Re: [PR] chore: bump eslint-plugin-jest from 28.9.0 to 29.0.1 [arrow-js]

2025-06-23 Thread via GitHub
kou merged PR #178: URL: https://github.com/apache/arrow-js/pull/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

Re: [PR] chore(go/adbc): bump google.golang.org/api from 0.237.0 to 0.238.0 in /go/adbc [arrow-adbc]

2025-06-23 Thread via GitHub
lidavidm merged PR #3010: URL: https://github.com/apache/arrow-adbc/pull/3010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] MINOR: [CI][C++] Try awslabs/aws-c-common#1210 [arrow]

2025-06-23 Thread via GitHub
kou closed pull request #46890: MINOR: [CI][C++] Try awslabs/aws-c-common#1210 URL: https://github.com/apache/arrow/pull/46890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] MINOR: [CI][C++] Try awslabs/aws-c-common#1210 [arrow]

2025-06-23 Thread via GitHub
kou commented on PR #46890: URL: https://github.com/apache/arrow/pull/46890#issuecomment-2998477538 The build error has gone: https://github.com/apache/arrow/actions/runs/15837935459/job/44645200779?pr=46890#step:7:3565 ```text [ 22%] Building C object _deps/aws-c-common-build/CM

[PR] chore: bump @swc/core from 1.11.31 to 1.12.5 [arrow-js]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #179: URL: https://github.com/apache/arrow-js/pull/179 Bumps [@swc/core](https://github.com/swc-project/swc) from 1.11.31 to 1.12.5. Changelog Sourced from https://github.com/swc-project/swc/blob/main/CHANGELOG.md";>@​swc/core's changelog.

Re: [PR] GH-46877: [MATLAB] Add `arrow.tabular.Table.fromRecordBatches` static method [arrow]

2025-06-23 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46885: URL: https://github.com/apache/arrow/pull/46885#issuecomment-2998454027 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8515a08b92b92ea6ba7ca6588ed336487322fb43. There were no

Re: [PR] chore: bump eslint-plugin-jest from 28.9.0 to 29.0.1 [arrow-js]

2025-06-23 Thread via GitHub
kou commented on PR #178: URL: https://github.com/apache/arrow-js/pull/178#issuecomment-2998443655 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] chore: bump rollup from 4.43.0 to 4.44.0 [arrow-js]

2025-06-23 Thread via GitHub
kou merged PR #177: URL: https://github.com/apache/arrow-js/pull/177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

Re: [PR] chore(csharp): Bump System.Net.Http.WinHttpHandler to 8.0.3 [arrow-adbc]

2025-06-23 Thread via GitHub
CurtHagenlocher merged PR #3013: URL: https://github.com/apache/arrow-adbc/pull/3013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [I] [CI][Dev] Fix shellcheck errors in the ci/scripts/install_gcs_testbench.sh [arrow]

2025-06-23 Thread via GitHub
kou commented on issue #46881: URL: https://github.com/apache/arrow/issues/46881#issuecomment-2998373048 Issue resolved by pull request 46882 https://github.com/apache/arrow/pull/46882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-46881: [CI][Dev] Fix shellcheck errors in the ci/scripts/install_gcs_testbench.sh [arrow]

2025-06-23 Thread via GitHub
kou merged PR #46882: URL: https://github.com/apache/arrow/pull/46882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-46683: Add utf8_zfill kernel for sign-aware zero padding [arrow]

2025-06-23 Thread via GitHub
iabhi4 commented on PR #46815: URL: https://github.com/apache/arrow/pull/46815#issuecomment-2998365344 Just pushed the final changes. I introduced `ZeroFillOptions` as a standalone class instead of overloading `PadOptions`, renamed the kernel to `utf8_zero_fill` for clarity, and added a cle

Re: [PR] chore: bump rxjs from 7.8.1 to 7.8.2 [arrow-js]

2025-06-23 Thread via GitHub
kou merged PR #176: URL: https://github.com/apache/arrow-js/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

Re: [PR] chore: bump google-closure-compiler from 20250609.0.0 to 20250619.0.0 [arrow-js]

2025-06-23 Thread via GitHub
kou merged PR #175: URL: https://github.com/apache/arrow-js/pull/175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

Re: [PR] MINOR: [CI][C++] Try awslabs/aws-c-common#1210 [arrow]

2025-06-23 Thread via GitHub
github-actions[bot] commented on PR #46890: URL: https://github.com/apache/arrow/pull/46890#issuecomment-2998352770 Revision: 3e98c36a521c54436f054fe4745e02d0c8b382af Submitted crossbow builds: [ursacomputing/crossbow @ actions-476b2c3941](https://github.com/ursacomputing/crossbow/bra

Re: [PR] MINOR: [CI][C++] Try awslabs/aws-c-common#1210 [arrow]

2025-06-23 Thread via GitHub
kou commented on PR #46890: URL: https://github.com/apache/arrow/pull/46890#issuecomment-2998347128 @github-actions crossbow submit -g r -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] MINOR: [CI][C++] Try awslabs/aws-c-common#1210 [arrow]

2025-06-23 Thread via GitHub
kou opened a new pull request, #46890: URL: https://github.com/apache/arrow/pull/46890 This is just for testing the patch. We never merge this. Thanks for opening a pull request! If this is your first pull request you can find detailed information on how to contribute here:

Re: [I] Release 21.0.0 [arrow-swift]

2025-06-23 Thread via GitHub
kou commented on issue #49: URL: https://github.com/apache/arrow-swift/issues/49#issuecomment-2998337143 Oh, do we need to register this repository "before" not "after" the first release from this repository? -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] feat: Make `ArrowTypeId` and `Info` enums `Sendable` [arrow-swift]

2025-06-23 Thread via GitHub
kou merged PR #43: URL: https://github.com/apache/arrow-swift/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] [Variant] Improve getter API for `VariantList` and `VariantObject` [arrow-rs]

2025-06-23 Thread via GitHub
friendlymatthew commented on code in PR #7757: URL: https://github.com/apache/arrow-rs/pull/7757#discussion_r2162702443 ## parquet-variant/src/variant/list.rs: ## @@ -123,7 +123,11 @@ impl<'m, 'v> VariantList<'m, 'v> { self.len() == 0 } -pub fn get(&self, ind

Re: [PR] [Variant] Improve getter API for `VariantList` and `VariantObject` [arrow-rs]

2025-06-23 Thread via GitHub
friendlymatthew commented on code in PR #7757: URL: https://github.com/apache/arrow-rs/pull/7757#discussion_r2162700336 ## parquet-variant/src/variant/list.rs: ## @@ -123,7 +123,11 @@ impl<'m, 'v> VariantList<'m, 'v> { self.len() == 0 } -pub fn get(&self, ind

[PR] [Variant] Improve getter API for `VariantList` and `VariantObject` [arrow-rs]

2025-06-23 Thread via GitHub
friendlymatthew opened a new pull request, #7757: URL: https://github.com/apache/arrow-rs/pull/7757 # Which issue does this PR close? Closes https://github.com/apache/arrow-rs/issues/7756 # Rationale for this change Renames `VariantObject::get_field_by_name` to `VariantOb

Re: [I] Release 21.0.0 [arrow-js]

2025-06-23 Thread via GitHub
assignUser commented on issue #167: URL: https://github.com/apache/arrow-js/issues/167#issuecomment-2998307470 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] Update release instructions to not push tags until release is approved [arrow-rs]

2025-06-23 Thread via GitHub
etseidl commented on code in PR #7754: URL: https://github.com/apache/arrow-rs/pull/7754#discussion_r2162692344 ## dev/release/README.md: ## @@ -109,21 +109,21 @@ distribution servers. While the official release artifact is a signed tarball, we also tag the commit it was cre

Re: [PR] chore(go/adbc): bump github.com/apache/arrow-go/v18 from 18.3.0 to 18.3.1 in /go/adbc [arrow-adbc]

2025-06-23 Thread via GitHub
lidavidm merged PR #3011: URL: https://github.com/apache/arrow-adbc/pull/3011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] feat(arrrow/compute/expr): support substrait timestamp and decimal properly [arrow-go]

2025-06-23 Thread via GitHub
lidavidm commented on code in PR #418: URL: https://github.com/apache/arrow-go/pull/418#discussion_r2162689805 ## arrow/compute/utils.go: ## @@ -353,19 +354,45 @@ func commonTemporal(vals ...arrow.DataType) arrow.DataType { } zone

Re: [PR] chore(java): bump com.microsoft.sqlserver:mssql-jdbc from 12.10.0.jre11 to 12.10.1.jre11 in /java [arrow-adbc]

2025-06-23 Thread via GitHub
lidavidm merged PR #3015: URL: https://github.com/apache/arrow-adbc/pull/3015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] feat(csharp/src/Drivers/Databricks): Fix for older DBR versions consuming DirectResults [arrow-adbc]

2025-06-23 Thread via GitHub
toddmeng-db closed pull request #3014: feat(csharp/src/Drivers/Databricks): Fix for older DBR versions consuming DirectResults URL: https://github.com/apache/arrow-adbc/pull/3014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[PR] chore: bump eslint-plugin-jest from 28.9.0 to 29.0.1 [arrow-js]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #178: URL: https://github.com/apache/arrow-js/pull/178 Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 28.9.0 to 29.0.1. Release notes Sourced from https://github.com/jest-community/eslint-plugin-jest

Re: [PR] test(csharp/src/Drivers): add Spice.ai test target [arrow-adbc]

2025-06-23 Thread via GitHub
lidavidm commented on code in PR #2961: URL: https://github.com/apache/arrow-adbc/pull/2961#discussion_r2162670633 ## .github/workflows/integration.yml: ## @@ -323,3 +323,47 @@ jobs: run: | ./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build" env B

Re: [PR] feat(csharp/src/Drivers/Databricks): Fix reading results for 11.x and below hybrid results [arrow-adbc]

2025-06-23 Thread via GitHub
toddmeng-db commented on code in PR #3014: URL: https://github.com/apache/arrow-adbc/pull/3014#discussion_r2162671339 ## csharp/src/Drivers/Databricks/DatabricksConnection.cs: ## @@ -319,21 +318,16 @@ internal override IArrowArrayStream NewReader(T statement, Schema schema, TGe

Re: [PR] feat(csharp/src/Drivers/Databricks): Fix reading results for 11.x and below hybrid results [arrow-adbc]

2025-06-23 Thread via GitHub
toddmeng-db commented on code in PR #3014: URL: https://github.com/apache/arrow-adbc/pull/3014#discussion_r2162671339 ## csharp/src/Drivers/Databricks/DatabricksConnection.cs: ## @@ -319,21 +318,16 @@ internal override IArrowArrayStream NewReader(T statement, Schema schema, TGe

[PR] chore(java): bump com.microsoft.sqlserver:mssql-jdbc from 12.10.0.jre11 to 12.10.1.jre11 in /java [arrow-adbc]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #3015: URL: https://github.com/apache/arrow-adbc/pull/3015 [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.microsoft.sqlserver:mssql-jdbc&package-manager=maven&previou

[PR] fix [arrow-adbc]

2025-06-23 Thread via GitHub
toddmeng-db opened a new pull request, #3014: URL: https://github.com/apache/arrow-adbc/pull/3014 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] chore(csharp): Bump System.Net.Http.WinHttpHandler to 8.0.3 [arrow-adbc]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #3013: URL: https://github.com/apache/arrow-adbc/pull/3013 Performed the following updates: - Updated System.Net.Http.WinHttpHandler from 8.0.2 to 8.0.3 in /csharp/Directory.Build.props, /csharp/Directory.Build.targets, /csharp/src/Drivers/BigQu

Re: [PR] chore(rust): bump prost from 0.13.5 to 0.14.0 in /rust [arrow-adbc]

2025-06-23 Thread via GitHub
dependabot[bot] commented on PR #2981: URL: https://github.com/apache/arrow-adbc/pull/2981#issuecomment-2998189348 Superseded by #3012. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] chore(rust): bump prost from 0.13.5 to 0.14.0 in /rust [arrow-adbc]

2025-06-23 Thread via GitHub
dependabot[bot] closed pull request #2981: chore(rust): bump prost from 0.13.5 to 0.14.0 in /rust URL: https://github.com/apache/arrow-adbc/pull/2981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] chore(rust): bump prost from 0.13.5 to 0.14.1 in /rust [arrow-adbc]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #3012: URL: https://github.com/apache/arrow-adbc/pull/3012 Bumps [prost](https://github.com/tokio-rs/prost) from 0.13.5 to 0.14.1. Changelog Sourced from https://github.com/tokio-rs/prost/blob/master/CHANGELOG.md";>prost's changelog.

[PR] chore: bump rollup from 4.43.0 to 4.44.0 [arrow-js]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #177: URL: https://github.com/apache/arrow-js/pull/177 Bumps [rollup](https://github.com/rollup/rollup) from 4.43.0 to 4.44.0. Release notes Sourced from https://github.com/rollup/rollup/releases";>rollup's releases. v4.44.0 4.44.

[PR] chore(go/adbc): bump github.com/apache/arrow-go/v18 from 18.3.0 to 18.3.1 in /go/adbc [arrow-adbc]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #3011: URL: https://github.com/apache/arrow-adbc/pull/3011 Bumps [github.com/apache/arrow-go/v18](https://github.com/apache/arrow-go) from 18.3.0 to 18.3.1. Release notes Sourced from https://github.com/apache/arrow-go/releases";>github.co

Re: [I] [Variant] Improved API for accessing Variant Objects and lists [arrow-rs]

2025-06-23 Thread via GitHub
friendlymatthew commented on issue #7756: URL: https://github.com/apache/arrow-rs/issues/7756#issuecomment-2998131829 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[I] [Variant] Improved API for accessing Variant Objects and lists [arrow-rs]

2025-06-23 Thread via GitHub
alamb opened a new issue, #7756: URL: https://github.com/apache/arrow-rs/issues/7756 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** After @scovich's PR to validate objects on construction - https://github.com/apache/arrow-

Re: [PR] [Variant] Support nested lists and object lists [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on code in PR #7740: URL: https://github.com/apache/arrow-rs/pull/7740#discussion_r2162613664 ## parquet-variant/src/builder.rs: ## @@ -148,189 +318,112 @@ fn make_room_for_header(buffer: &mut Vec, start_pos: usize, header_size: usi /// /// # Example: [`Varian

Re: [PR] GH-46877: [MATLAB] Add `arrow.tabular.Table.fromRecordBatches` static method [arrow]

2025-06-23 Thread via GitHub
sgilmore10 merged PR #46885: URL: https://github.com/apache/arrow/pull/46885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.ap

[PR] chore: bump rxjs from 7.8.1 to 7.8.2 [arrow-js]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #176: URL: https://github.com/apache/arrow-js/pull/176 Bumps [rxjs](https://github.com/reactivex/rxjs) from 7.8.1 to 7.8.2. Changelog Sourced from https://github.com/ReactiveX/rxjs/blob/7.8.2/CHANGELOG.md";>rxjs's changelog. https:/

[PR] chore: bump google-closure-compiler from 20250609.0.0 to 20250619.0.0 [arrow-js]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #175: URL: https://github.com/apache/arrow-js/pull/175 Bumps [google-closure-compiler](https://github.com/google/closure-compiler-npm) from 20250609.0.0 to 20250619.0.0. Release notes Sourced from https://github.com/google/closure-compile

Re: [PR] [Variant] Support nested lists and object lists [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on code in PR #7740: URL: https://github.com/apache/arrow-rs/pull/7740#discussion_r2162606284 ## parquet-variant/src/builder.rs: ## @@ -148,189 +318,112 @@ fn make_room_for_header(buffer: &mut Vec, start_pos: usize, header_size: usi /// /// # Example: [`Varian

[PR] chore: bump typescript-eslint from 8.33.1 to 8.35.0 [arrow-js]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #174: URL: https://github.com/apache/arrow-js/pull/174 Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 8.33.1 to 8.35.0. Release notes Sourced from https://github

[PR] [Variant] Add Variant::as_object and Variant::as_list [arrow-rs]

2025-06-23 Thread via GitHub
alamb opened a new pull request, #7755: URL: https://github.com/apache/arrow-rs/pull/7755 # Which issue does this PR close? # Rationale for this change - While reviewing @friendlymatthew 's PR https://github.com/apache/arrow-rs/pull/7749 I found that the code to get the

Re: [PR] [Variant] Use `BTreeMap` for `VariantBuilder.dict` and `ObjectBuilder.fields` to maintain invariants upon entry writes [arrow-rs]

2025-06-23 Thread via GitHub
friendlymatthew commented on PR #7720: URL: https://github.com/apache/arrow-rs/pull/7720#issuecomment-2998103938 > I think that would be a good idea -- I'll plan to merge the BTree part and then we can iterate on other things in a follow on Hi @alamb, is there anything blocking this f

[PR] fix(go/adbc/driver/internal/driverbase): fix missing interface func [arrow-adbc]

2025-06-23 Thread via GitHub
zeroshade opened a new pull request, #3009: URL: https://github.com/apache/arrow-adbc/pull/3009 Looks like the changes and update for the Otel infrastructure introduced a mismatch with how the interface for ExecuteSchema is handled. As a result we have a failing test: ``` === RUN

Re: [I] [JS] apache-arrow doesn't work on platform restricting eval/new Function [arrow-js]

2025-06-23 Thread via GitHub
kou commented on issue #54: URL: https://github.com/apache/arrow-js/issues/54#issuecomment-2998078506 Do you have an idea how to solve this? If so, could you open a PR for it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] fix(go/adbc/driver/internal/driverbase): fix missing interface func [arrow-adbc]

2025-06-23 Thread via GitHub
zeroshade merged PR #3009: URL: https://github.com/apache/arrow-adbc/pull/3009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.

Re: [PR] test(csharp/src/Drivers): add Spice.ai test target [arrow-adbc]

2025-06-23 Thread via GitHub
kou commented on PR #2961: URL: https://github.com/apache/arrow-adbc/pull/2961#issuecomment-2998070945 (Sorry for hijacking here but... @CurtHagenlocher could you check https://github.com/apache/arrow/pull/46752#issuecomment-2968759580 ? I want to proceed moving `csharp/` in apache/arrow to

Re: [PR] [Variant] Support nested lists and object lists [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on PR #7740: URL: https://github.com/apache/arrow-rs/pull/7740#issuecomment-2998066206 Yes indeed, @scovich your review would be very helpful. I plan to review this PR as well tomorrow -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] feat: Add Validation for Variant Deciaml [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on PR #7738: URL: https://github.com/apache/arrow-rs/pull/7738#issuecomment-2998063415 @scovich and @friendlymatthew perhaps you have some time to review this PR as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] feat: Add Validation for Variant Deciaml [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on code in PR #7738: URL: https://github.com/apache/arrow-rs/pull/7738#discussion_r2162586376 ## parquet-variant/src/variant.rs: ## @@ -850,28 +970,28 @@ impl From for Variant<'_, '_> { impl From<(i32, u8)> for Variant<'_, '_> { fn from(value: (i32, u8))

Re: [PR] test(csharp/src/Drivers): add Spice.ai test target [arrow-adbc]

2025-06-23 Thread via GitHub
kou commented on code in PR #2961: URL: https://github.com/apache/arrow-adbc/pull/2961#discussion_r2162584477 ## compose.yaml: ## @@ -208,7 +208,7 @@ services: DREMIO_JAVA_EXTRA_OPTS: "-Ddebug.addDefaultUser=true -Ddremio.eula.disabled=true" healthcheck: test

Re: [PR] fix: Implement support for appending Object and List variants in VariantBuilder [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on PR #7735: URL: https://github.com/apache/arrow-rs/pull/7735#issuecomment-2998040404 Thanks again @ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] [Variant] Panic when appending Object or List to VariantBuilder [arrow-rs]

2025-06-23 Thread via GitHub
alamb closed issue #7701: [Variant] Panic when appending Object or List to VariantBuilder URL: https://github.com/apache/arrow-rs/issues/7701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] fix: Implement support for appending Object and List variants in VariantBuilder [arrow-rs]

2025-06-23 Thread via GitHub
alamb merged PR #7735: URL: https://github.com/apache/arrow-rs/pull/7735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

Re: [PR] [Variant] Fix several overflow panic risks for 32-bit arch [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on code in PR #7752: URL: https://github.com/apache/arrow-rs/pull/7752#discussion_r2162581909 ## parquet-variant/src/variant/object.rs: ## @@ -140,7 +151,11 @@ impl<'m, 'v> VariantObject<'m, 'v> { self.field_offsets_start_byte, i,

Re: [PR] Add fallible versions of temporal functions that may panic [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on PR #7737: URL: https://github.com/apache/arrow-rs/pull/7737#issuecomment-2997797543 🤖 `./gh_compare_arrow.sh` [Benchmark Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_arrow.sh) Running Linux aal-dev 6.11.0-1015-gcp #15~24.04.1-Ubuntu SMP

[PR] chore: Bump github.com/stoewer/go-strcase from 1.3.0 to 1.3.1 [arrow-go]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #423: URL: https://github.com/apache/arrow-go/pull/423 Bumps [github.com/stoewer/go-strcase](https://github.com/stoewer/go-strcase) from 1.3.0 to 1.3.1. Release notes Sourced from https://github.com/stoewer/go-strcase/releases";>github.com

Re: [PR] GH-46871: [C++][Parquet] Restore implementation of 3 arrow::FileReader::GetRecordBatchReader() functions [arrow]

2025-06-23 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46868: URL: https://github.com/apache/arrow/pull/46868#issuecomment-2997184670 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit dacec3080f8a7c245dc884d278ea6280942086f0. There were 11

Re: [PR] Update release instructions to not push tags until release is approved [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on code in PR #7754: URL: https://github.com/apache/arrow-rs/pull/7754#discussion_r2162579794 ## dev/release/create-tarball.sh: ## @@ -64,7 +64,7 @@ else tar=tar fi -release_hash=$(cd "${SOURCE_TOP_DIR}" && git rev-list --max-count=1 ${tag}) +release_hash

Re: [PR] Update release instructions to not push tags until release is approved [arrow-rs]

2025-06-23 Thread via GitHub
kou commented on code in PR #7754: URL: https://github.com/apache/arrow-rs/pull/7754#discussion_r2162567116 ## dev/release/README.md: ## @@ -109,21 +109,21 @@ distribution servers. While the official release artifact is a signed tarball, we also tag the commit it was created

[PR] chore(go/adbc): bump google.golang.org/api from 0.237.0 to 0.238.0 in /go/adbc [arrow-adbc]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #3010: URL: https://github.com/apache/arrow-adbc/pull/3010 Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.237.0 to 0.238.0. Release notes Sourced from https://github.com/googleapis/google-api-go-c

[I] Buildable reproducible release builds [arrow-rs]

2025-06-23 Thread via GitHub
findepi opened a new issue, #7751: URL: https://github.com/apache/arrow-rs/issues/7751 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** ### Problem description From security standpoint it would be great to have reprod

Re: [I] Is 55.2.0 an RC or actually released? 🤔 [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on issue #7753: URL: https://github.com/apache/arrow-rs/issues/7753#issuecomment-2997994021 PR: - https://github.com/apache/arrow-rs/pull/7754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Update release instructions to not push tags until release is approved [arrow-rs]

2025-06-23 Thread via GitHub
alamb opened a new pull request, #7754: URL: https://github.com/apache/arrow-rs/pull/7754 # Which issue does this PR close? - Closes https://github.com/apache/arrow-rs/issues/7753 # Rationale for this change When we push a tag like `55.2.0` to github it now makes a github

[PR] chore: Bump github.com/hamba/avro/v2 from 2.28.0 to 2.29.0 [arrow-go]

2025-06-23 Thread via GitHub
dependabot[bot] opened a new pull request, #422: URL: https://github.com/apache/arrow-go/pull/422 Bumps [github.com/hamba/avro/v2](https://github.com/hamba/avro) from 2.28.0 to 2.29.0. Release notes Sourced from https://github.com/hamba/avro/releases";>github.com/hamba/avro/v2's r

Re: [I] Polars datetime with timezone to Snowflake [arrow-adbc]

2025-06-23 Thread via GitHub
zeroshade commented on issue #2843: URL: https://github.com/apache/arrow-adbc/issues/2843#issuecomment-2997597232 Okay, I did a small test: I created a polars dataframe, wrote a parquet file and then followed the same strategy we use to insert the file into a snowflake table. After th

Re: [I] Add version API [arrow-swift]

2025-06-23 Thread via GitHub
dongjoon-hyun commented on issue #48: URL: https://github.com/apache/arrow-swift/issues/48#issuecomment-2997271893 I believe Git Hub tagging with version numbers are enough to serve the compilation. I don't think we need to recognize Arrow Swift implementation during the runtime. -- This

Re: [I] [Python][Azure][Docs] Add documentation about AzureFilesystem [arrow]

2025-06-23 Thread via GitHub
kou commented on issue #41496: URL: https://github.com/apache/arrow/issues/41496#issuecomment-2997936979 Ah, it may be related. Let's try it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] feat: add option for ipc.writer to skip writing schema [arrow-go]

2025-06-23 Thread via GitHub
alvarowolfx commented on PR #421: URL: https://github.com/apache/arrow-go/pull/421#issuecomment-2997936166 Naming is hard, so I'm open to suggestion on the `WithSchemalessOutput ` option -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] feat: add option for ipc.writer to skip writing schema [arrow-go]

2025-06-23 Thread via GitHub
alvarowolfx opened a new pull request, #421: URL: https://github.com/apache/arrow-go/pull/421 ### Rationale for this change The BigQuery Storage Write API now accepts Arrow data. But schema data and record batches needs to send separately. Right now the `ipc.NewWriter` writes the schema

Re: [I] Is 55.2.0 an RC or actually released? 🤔 [arrow-rs]

2025-06-23 Thread via GitHub
kou commented on issue #7753: URL: https://github.com/apache/arrow-rs/issues/7753#issuecomment-2997876582 Oh, sorry. I misunderstood the apache/arrow-rs release process. I thought that we tag `X.Y.Z-rcN` for RC (before vote) and we tag `X.Y.Z` for release (after vote). If using

Re: [PR] Add fallible versions of temporal functions that may panic [arrow-rs]

2025-06-23 Thread via GitHub
adriangb commented on PR #7737: URL: https://github.com/apache/arrow-rs/pull/7737#issuecomment-2997832353 > Would you have time to do that? Yes I think I should have time in the next couple days! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] GH-45290: [Docs][Release] Change show_version_warning_banner substitution [arrow]

2025-06-23 Thread via GitHub
kou commented on code in PR #46883: URL: https://github.com/apache/arrow/pull/46883#discussion_r2162500380 ## dev/release/post-09-docs.sh: ## @@ -85,6 +85,10 @@ find docs \ -exec \ sed -i.bak \ -e "s/DOCUMENTATION_OPTIONS.show_version_warning_banner = true/DOCUMENTATIO

Re: [I] Is 55.2.0 an RC or actually released? 🤔 [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on issue #7753: URL: https://github.com/apache/arrow-rs/issues/7753#issuecomment-2997890109 > I misunderstood the apache/arrow-rs release process. > I thought that we tag `X.Y.Z-rcN` for RC (before vote) and we tag `X.Y.Z` for release (after vote). I think this is w

Re: [PR] Add fallible versions of temporal functions that may panic [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on PR #7737: URL: https://github.com/apache/arrow-rs/pull/7737#issuecomment-2997883653 🤖: Benchmark completed Details ``` group fix-possible-panicsmain -

Re: [I] [C++][Parquet] Integer dictionary bitwidth preservation breaks multi-file read behaviour in pyarrow 20 [arrow]

2025-06-23 Thread via GitHub
hadrian-reppas commented on issue #46629: URL: https://github.com/apache/arrow/issues/46629#issuecomment-2997813098 Hi, I'm taking a look at this issue and had a few questions: 1. What are some situations where schemas are normalized when reading the files? The only `FragmentEvolutionStra

Re: [PR] Add fallible versions of temporal functions that may panic [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on PR #7737: URL: https://github.com/apache/arrow-rs/pull/7737#issuecomment-2997849751 🤖: Benchmark completed Details ``` groupfix-possible-panicsmain ----

Re: [PR] Add fallible versions of temporal functions that may panic [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on PR #7737: URL: https://github.com/apache/arrow-rs/pull/7737#issuecomment-2997849870 🤖 `./gh_compare_arrow.sh` [Benchmark Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_arrow.sh) Running Linux aal-dev 6.11.0-1015-gcp #15~24.04.1-Ubuntu SMP

Re: [PR] Add fallible versions of temporal functions that may panic [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on PR #7737: URL: https://github.com/apache/arrow-rs/pull/7737#issuecomment-2997806189 Additional context is we hit this panic in DataFusion: - https://github.com/apache/datafusion/pull/16491 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add fallible versions of temporal functions that may panic [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on code in PR #7737: URL: https://github.com/apache/arrow-rs/pull/7737#discussion_r2162437987 ## arrow-arith/src/numeric.rs: ## @@ -510,49 +510,122 @@ fn timestamp_op( } /// Arithmetic trait for date arrays -/// -/// Note: these should be fallible (#4456) tr

Re: [I] Is 55.2.0 an RC or actually released? 🤔 [arrow-rs]

2025-06-23 Thread via GitHub
alamb commented on issue #7753: URL: https://github.com/apache/arrow-rs/issues/7753#issuecomment-2997769336 The current `55.2.0` tag is an RC It isn't an "official apache release" until we approve it and push to crates.io Maybe the automation added by @kou in https://github.

[I] Is 55.2.0 an RC or actually released? 🤔 [arrow-rs]

2025-06-23 Thread via GitHub
rtyler opened a new issue, #7753: URL: https://github.com/apache/arrow-rs/issues/7753 #7394 is the discussion about an RC and creating the release of 55.2.0 but there is already a tag and marked release [here](https://github.com/apache/arrow-rs/releases/tag/55.2.0) for 55.2.0 😖 I am

Re: [I] [MATLAB] Add `arrow.tabular.Table.fromRecordBatches` static method [arrow]

2025-06-23 Thread via GitHub
sgilmore10 commented on issue #46877: URL: https://github.com/apache/arrow/issues/46877#issuecomment-2997742659 Issue resolved by pull request 46885 https://github.com/apache/arrow/pull/46885 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] feat: Make `ArrowTypeId` and `Info` enums `Sendable` [arrow-swift]

2025-06-23 Thread via GitHub
dongjoon-hyun commented on PR #43: URL: https://github.com/apache/arrow-swift/pull/43#issuecomment-2997227448 CI fails again at the identical error, `setup-swift`. https://github.com/user-attachments/assets/deecc981-4f22-44b6-b08e-76751bf7b5ee"; /> -- This is an automated message f

  1   2   3   >