[GitHub] [arrow] westonpace commented on a diff in pull request #33676: GH-33673: [C++] Standardize as-of-join convention for past and future tolerance

2023-01-20 Thread GitBox
westonpace commented on code in PR #33676: URL: https://github.com/apache/arrow/pull/33676#discussion_r1082894510 ## cpp/src/arrow/compute/exec/options.h: ## @@ -523,7 +523,8 @@ class ARROW_EXPORT AsofJoinNodeOptions : public ExecNodeOptions { /// /// \see `Keys` for

[GitHub] [arrow] westonpace commented on pull request #33770: GH-33760: [R][C++] Handle nested field refs in scanner

2023-01-20 Thread GitBox
westonpace commented on PR #33770: URL: https://github.com/apache/arrow/pull/33770#issuecomment-1398740288 > I haven't run C++ unit tests in forever, so figured I'd get some feedback before diving in there. Sorry, I was thinking of R e2e tests. I would hope the C++ change is

[GitHub] [arrow] nealrichardson commented on issue #33702: [R] Package Arrow 11.0.0 for R/CRAN

2023-01-20 Thread GitBox
nealrichardson commented on issue #33702: URL: https://github.com/apache/arrow/issues/33702#issuecomment-1398734889 gcc13 no longer shows up on https://cran.r-project.org/web/checks/check_results_arrow.html so we're good there. Just have to deal with clang 16 now :/ -- This is an

[GitHub] [arrow] nealrichardson commented on issue #33635: R package may be failing to compile on gcc13

2023-01-20 Thread GitBox
nealrichardson commented on issue #33635: URL: https://github.com/apache/arrow/issues/33635#issuecomment-1398733956 https://cran.r-project.org/web/checks/check_results_arrow.html no longer shows a gcc13 issue, so perhaps BDR rebuilt latest and the issue resolved. -- This is an automated

[GitHub] [arrow-rs] ursabot commented on pull request #3554: Fix final page row count in parquet-index binary

2023-01-20 Thread GitBox
ursabot commented on PR #3554: URL: https://github.com/apache/arrow-rs/pull/3554#issuecomment-1398731968 Benchmark runs are scheduled for baseline = 19e3e8c8314f87d8c2acf3a7b69538fdec6f793c and contender = 0ec5f72e6d21556d5677b74dd5d45d93c5af0b38. 0ec5f72e6d21556d5677b74dd5d45d93c5af0b38

[GitHub] [arrow-datafusion] charlesbluca opened a new issue, #5004: `LogicalPlan.schema()` returns incorrect schema for `CreateMemoryTable` and `CreateView`

2023-01-20 Thread GitBox
charlesbluca opened a new issue, #5004: URL: https://github.com/apache/arrow-datafusion/issues/5004 **Describe the bug** For `LogicalPlan::CreateMemoryTable` and `CreateView`, `schema()` returns the schema of the input plan, rather than the schema of the newly created table/view:

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3572: Packing array into dictionary of generic byte array

2023-01-20 Thread GitBox
viirya commented on code in PR #3572: URL: https://github.com/apache/arrow-rs/pull/3572#discussion_r1082878810 ## arrow-cast/src/cast.rs: ## @@ -3344,42 +3350,23 @@ where Ok(Arc::new(b.finish())) } -// Packs the data as a StringDictionaryArray, if possible, with the -//

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3572: Packing array into dictionary of generic byte array

2023-01-20 Thread GitBox
viirya commented on code in PR #3572: URL: https://github.com/apache/arrow-rs/pull/3572#discussion_r1082878810 ## arrow-cast/src/cast.rs: ## @@ -3344,42 +3350,23 @@ where Ok(Arc::new(b.finish())) } -// Packs the data as a StringDictionaryArray, if possible, with the -//

[GitHub] [arrow-rs] viirya merged pull request #3554: Fix final page row count in parquet-index binary

2023-01-20 Thread GitBox
viirya merged PR #3554: URL: https://github.com/apache/arrow-rs/pull/3554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow] ursabot commented on pull request #33792: GH-33789: [Go] Add Err() to RecordReader

2023-01-20 Thread GitBox
ursabot commented on PR #33792: URL: https://github.com/apache/arrow/pull/33792#issuecomment-1398720935 Benchmark runs are scheduled for baseline = bf8780d0ff794c50312d799a9e877430e99dcf8b and contender = f744bab97fb6e10663b0b414855534e24383056b. f744bab97fb6e10663b0b414855534e24383056b

[GitHub] [arrow-rs] comphead commented on a diff in pull request #3570: Remove unwrap on datetime cast for CSV writer

2023-01-20 Thread GitBox
comphead commented on code in PR #3570: URL: https://github.com/apache/arrow-rs/pull/3570#discussion_r1082867652 ## arrow-csv/src/writer.rs: ## @@ -672,4 +710,26 @@ sed do eiusmod tempor,-556132.25,1,,2019-04-18T02:45:55.55500,23:46:03,foo let expected =

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3574: Add external variant to ParquetError (#3285)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3574: URL: https://github.com/apache/arrow-rs/pull/3574#discussion_r1082867599 ## parquet/src/errors.rs: ## @@ -17,12 +17,13 @@ //! Common Parquet errors and macros. +use std::error::Error; use std::{cell, io, result, str};

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3574: Add external variant to ParquetError (#3285)

2023-01-20 Thread GitBox
viirya commented on code in PR #3574: URL: https://github.com/apache/arrow-rs/pull/3574#discussion_r1082866719 ## parquet/src/errors.rs: ## @@ -17,12 +17,13 @@ //! Common Parquet errors and macros. +use std::error::Error; use std::{cell, io, result, str}; #[cfg(feature

[GitHub] [arrow] westonpace commented on a diff in pull request #14596: ARROW-18258: [Docker] Substrait Integration Testing

2023-01-20 Thread GitBox
westonpace commented on code in PR #14596: URL: https://github.com/apache/arrow/pull/14596#discussion_r1082859333 ## ci/scripts/integration_substrait.sh: ## @@ -0,0 +1,30 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [arrow-rs] ursabot commented on pull request #3563: Implement Extend for ArrayBuilder (#1841)

2023-01-20 Thread GitBox
ursabot commented on PR #3563: URL: https://github.com/apache/arrow-rs/pull/3563#issuecomment-1398686577 Benchmark runs are scheduled for baseline = a1cedb4fdfb561eda4e836a6c8fcb898d7a37029 and contender = 19e3e8c8314f87d8c2acf3a7b69538fdec6f793c. 19e3e8c8314f87d8c2acf3a7b69538fdec6f793c

[GitHub] [arrow-rs] tustvold closed issue #3562: Panic on Key Overflow in Dictionary Builders

2023-01-20 Thread GitBox
tustvold closed issue #3562: Panic on Key Overflow in Dictionary Builders URL: https://github.com/apache/arrow-rs/issues/3562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-rs] tustvold merged pull request #3563: Implement Extend for ArrayBuilder (#1841)

2023-01-20 Thread GitBox
tustvold merged PR #3563: URL: https://github.com/apache/arrow-rs/pull/3563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow-rs] tustvold closed issue #1841: Implement Extend for Builder

2023-01-20 Thread GitBox
tustvold closed issue #1841: Implement Extend for Builder URL: https://github.com/apache/arrow-rs/issues/1841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [arrow] ursabot commented on pull request #33768: GH-33767: [Go] Clear out parameter in ArrowArrayStream.get_next

2023-01-20 Thread GitBox
ursabot commented on PR #33768: URL: https://github.com/apache/arrow/pull/33768#issuecomment-1398677269 Benchmark runs are scheduled for baseline = a4236abd3b88fb1d4db55ec82afcaf7f50183639 and contender = bf8780d0ff794c50312d799a9e877430e99dcf8b. bf8780d0ff794c50312d799a9e877430e99dcf8b

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3570: Remove unwrap on datetime cast for CSV writer

2023-01-20 Thread GitBox
tustvold commented on code in PR #3570: URL: https://github.com/apache/arrow-rs/pull/3570#discussion_r1082820993 ## arrow-csv/src/writer.rs: ## @@ -88,6 +88,35 @@ where lexical_to_string(c.value(i)) } +fn invalid_cast_error(dt: String, col_index: usize, row_index:

[GitHub] [arrow] github-actions[bot] commented on pull request #14596: ARROW-18258: [Docker] Substrait Integration Testing

2023-01-20 Thread GitBox
github-actions[bot] commented on PR #14596: URL: https://github.com/apache/arrow/pull/14596#issuecomment-1398662412 Revision: 8dafc82cd91e88070a5f55a7f0e3966f5a845682 Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] github-actions[bot] commented on pull request #14596: ARROW-18258: [Docker] Substrait Integration Testing

2023-01-20 Thread GitBox
github-actions[bot] commented on PR #14596: URL: https://github.com/apache/arrow/pull/14596#issuecomment-1398660480 Revision: 85554d34a7553d21cd91eb19b5ac797293752336 Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow-rs] comphead commented on a diff in pull request #3570: Remove unwrap on datetime cast for CSV writer

2023-01-20 Thread GitBox
comphead commented on code in PR #3570: URL: https://github.com/apache/arrow-rs/pull/3570#discussion_r1082816995 ## arrow-csv/src/writer.rs: ## @@ -88,6 +88,35 @@ where lexical_to_string(c.value(i)) } +fn invalid_cast_error(dt: String, col_index: usize, row_index:

[GitHub] [arrow] vibhatha commented on pull request #14596: ARROW-18258: [Docker] Substrait Integration Testing

2023-01-20 Thread GitBox
vibhatha commented on PR #14596: URL: https://github.com/apache/arrow/pull/14596#issuecomment-1398659669 @github-actions crossbow submit test-conda-python-3.9-substrait -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow-rs] comphead commented on a diff in pull request #3570: Remove unwrap on datetime cast for CSV writer

2023-01-20 Thread GitBox
comphead commented on code in PR #3570: URL: https://github.com/apache/arrow-rs/pull/3570#discussion_r1082815909 ## arrow-csv/src/writer.rs: ## @@ -88,6 +88,35 @@ where lexical_to_string(c.value(i)) } +fn invalid_cast_error(dt: String, col_index: usize, row_index:

[GitHub] [arrow] vibhatha commented on pull request #14596: ARROW-18258: [Docker] Substrait Integration Testing

2023-01-20 Thread GitBox
vibhatha commented on PR #14596: URL: https://github.com/apache/arrow/pull/14596#issuecomment-1398656902 @github-actions crossbow submit test-conda-python-3.9-substrait -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow-datafusion] ozankabak commented on pull request #5003: Support for bounded execution when window frame involves UNBOUNDED PRECEDING

2023-01-20 Thread GitBox
ozankabak commented on PR #5003: URL: https://github.com/apache/arrow-datafusion/pull/5003#issuecomment-1398656384 A quick summary to help reviews: If all you are doing is something like a running sum, you can get the job done with bounded memory even if your frame is ever-growing. This

[GitHub] [arrow-ballista] thinkharderdev opened a new issue, #619: Prune unneccessary data from task definition

2023-01-20 Thread GitBox
thinkharderdev opened a new issue, #619: URL: https://github.com/apache/arrow-ballista/issues/619 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** A clear and concise description of what the problem is. Ex. I'm always frustrated

[GitHub] [arrow-datafusion] ozankabak commented on a diff in pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
ozankabak commented on code in PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#discussion_r1082791126 ## datafusion/common/src/utils.rs: ## @@ -103,6 +111,53 @@ where Ok(low) } +/// This function searches for a tuple of given values (`target`) among

[GitHub] [arrow] ursabot commented on pull request #33772: GH-15137: [C++][CI] Fix ASAN error in streaming JSON reader tests

2023-01-20 Thread GitBox
ursabot commented on PR #33772: URL: https://github.com/apache/arrow/pull/33772#issuecomment-1398646800 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/83ac5871fe62452a9c95ecf98c4fa293...401cb18adbd5447281de8b14c6c232c5/)

[GitHub] [arrow] ursabot commented on pull request #33772: GH-15137: [C++][CI] Fix ASAN error in streaming JSON reader tests

2023-01-20 Thread GitBox
ursabot commented on PR #33772: URL: https://github.com/apache/arrow/pull/33772#issuecomment-1398646540 Benchmark runs are scheduled for baseline = a1a587b1d1415a96edbb358cdf363241064a6d64 and contender = a4236abd3b88fb1d4db55ec82afcaf7f50183639. a4236abd3b88fb1d4db55ec82afcaf7f50183639

[GitHub] [arrow] wjones127 commented on a diff in pull request #33694: MINOR: [C++][Parquet] Rephrase decimal annotation

2023-01-20 Thread GitBox
wjones127 commented on code in PR #33694: URL: https://github.com/apache/arrow/pull/33694#discussion_r1082720103 ## cpp/src/parquet/properties.h: ## @@ -452,19 +452,39 @@ class PARQUET_EXPORT WriterProperties { return this->disable_statistics(path->ToDotString()); }

[GitHub] [arrow-datafusion] ozankabak commented on pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
ozankabak commented on PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#issuecomment-1398641302 Thank you for carefully reviewing @alamb. We will consider further optimizing by leveraging `RowFormat` in a follow-on PR. As @mustafasrepo mentions, it is not obvious to use

[GitHub] [arrow-datafusion] ozankabak commented on a diff in pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
ozankabak commented on code in PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#discussion_r1082791126 ## datafusion/common/src/utils.rs: ## @@ -103,6 +111,53 @@ where Ok(low) } +/// This function searches for a tuple of given values (`target`) among

[GitHub] [arrow-adbc] lidavidm commented on pull request #356: feat(go/adbc/driver/pkg/cmake): cmake build for Go shared library drivers

2023-01-20 Thread GitBox
lidavidm commented on PR #356: URL: https://github.com/apache/arrow-adbc/pull/356#issuecomment-1398624356 Weird - it actually fails on SQlite here now. ``` === Building driver/sqlite === + mkdir -p /adbc/build/x64/driver/sqlite + pushd /adbc/build/x64/driver/sqlite

[GitHub] [arrow] zeroshade commented on a diff in pull request #33795: GH-33794: [Go] Add SetRecordReader to PreparedStatement

2023-01-20 Thread GitBox
zeroshade commented on code in PR #33795: URL: https://github.com/apache/arrow/pull/33795#discussion_r1082761204 ## go/arrow/flight/flightsql/client.go: ## @@ -518,22 +544,44 @@ func (p *PreparedStatement) GetSchema(ctx context.Context) (*flight.SchemaResult return

[GitHub] [arrow] zeroshade commented on a diff in pull request #33795: GH-33794: [Go] Add SetRecordReader to PreparedStatement

2023-01-20 Thread GitBox
zeroshade commented on code in PR #33795: URL: https://github.com/apache/arrow/pull/33795#discussion_r1082759927 ## go/arrow/flight/flightsql/client.go: ## @@ -518,22 +544,44 @@ func (p *PreparedStatement) GetSchema(ctx context.Context) (*flight.SchemaResult return

[GitHub] [arrow] zeroshade commented on a diff in pull request #33795: GH-33794: [Go] Add SetRecordReader to PreparedStatement

2023-01-20 Thread GitBox
zeroshade commented on code in PR #33795: URL: https://github.com/apache/arrow/pull/33795#discussion_r1082757863 ## go/arrow/flight/flightsql/client.go: ## @@ -491,6 +490,33 @@ func (p *PreparedStatement) ExecuteUpdate(ctx context.Context) (nrecords int64, return

[GitHub] [arrow] ursabot commented on pull request #33778: GH-33777: [R] Nightly builds failing due to dataset test not being skipped on builds without datasets module

2023-01-20 Thread GitBox
ursabot commented on PR #33778: URL: https://github.com/apache/arrow/pull/33778#issuecomment-1398613044 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/2eb76bfb924947cb97a14cbb8822eecf...83ac5871fe62452a9c95ecf98c4fa293/)

[GitHub] [arrow] ursabot commented on pull request #33778: GH-33777: [R] Nightly builds failing due to dataset test not being skipped on builds without datasets module

2023-01-20 Thread GitBox
ursabot commented on PR #33778: URL: https://github.com/apache/arrow/pull/33778#issuecomment-1398612792 Benchmark runs are scheduled for baseline = fc1f9ebbc4c3ae77d5cfc2f9322f4373d3d19b8a and contender = a1a587b1d1415a96edbb358cdf363241064a6d64. a1a587b1d1415a96edbb358cdf363241064a6d64

[GitHub] [arrow] nealrichardson commented on pull request #33770: GH-33760: [R][C++] Handle nested field refs in scanner

2023-01-20 Thread GitBox
nealrichardson commented on PR #33770: URL: https://github.com/apache/arrow/pull/33770#issuecomment-1398606967 > Do you want some unit tests? Of course, this needs some. The tests that were added for this function when it was introduced

[GitHub] [arrow-datafusion] avantgardnerio commented on pull request #4834: (#4462) Postgres compatibility tests using sqllogictest

2023-01-20 Thread GitBox
avantgardnerio commented on PR #4834: URL: https://github.com/apache/arrow-datafusion/pull/4834#issuecomment-1398604791 > 1. Don't orchestrate the postgres containers with rust test code Good catch... I :100: % agree with this. -- This is an automated message from the Apache Git

[GitHub] [arrow-datafusion] mustafasrepo opened a new pull request, #5003: Support for bounded execution when window frame involves UNBOUNDED PRECEDING

2023-01-20 Thread GitBox
mustafasrepo opened a new pull request, #5003: URL: https://github.com/apache/arrow-datafusion/pull/5003 # Which issue does this PR close? Closes [#4978](https://github.com/apache/arrow-datafusion/issues/4978) # Rationale for this change Currently, queries

[GitHub] [arrow] LucyMcGowan commented on issue #14826: write_dataset is crashing on my machine

2023-01-20 Thread GitBox
LucyMcGowan commented on issue #14826: URL: https://github.com/apache/arrow/issues/14826#issuecomment-1398595442 Installing the most recent version of R fixed this! Thank you @assignUser -- do you want me to close the issue? -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #33808: GH-20272: [C++] Bump version of bundled AWS SDK

2023-01-20 Thread GitBox
github-actions[bot] commented on PR #33808: URL: https://github.com/apache/arrow/pull/33808#issuecomment-1398593959 * Closes: #20272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] js8544 opened a new pull request, #33808: GH-20272: [C++] Bump version of bundled AWS SDK

2023-01-20 Thread GitBox
js8544 opened a new pull request, #33808: URL: https://github.com/apache/arrow/pull/33808 ### Rationale for this change Bump AWS SDK version to 1.10.55. ### What changes are included in this PR? Bump AWS SDK version to 1.10.55. -- This is an

[GitHub] [arrow-datafusion] mustafasrepo commented on a diff in pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
mustafasrepo commented on code in PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#discussion_r1082729694 ## datafusion/common/src/utils.rs: ## @@ -22,8 +22,16 @@ use arrow::array::ArrayRef; use arrow::compute::SortOptions; use std::cmp::Ordering; +///

[GitHub] [arrow] ablack3 commented on issue #33807: Using dplyr::tally with an Arrow FileSystemDataset crashes R

2023-01-20 Thread GitBox
ablack3 commented on issue #33807: URL: https://github.com/apache/arrow/issues/33807#issuecomment-1398589729 This might be a clue ``` *** caught illegal operation *** address 0x13d7349a8, cause 'illegal opcode' Traceback: 1: Array__GetScalar(Array$create(x,

[GitHub] [arrow] wjones127 commented on a diff in pull request #33694: MINOR: [C++][Parquet] Rephrase decimal annotation

2023-01-20 Thread GitBox
wjones127 commented on code in PR #33694: URL: https://github.com/apache/arrow/pull/33694#discussion_r1082720103 ## cpp/src/parquet/properties.h: ## @@ -452,19 +452,39 @@ class PARQUET_EXPORT WriterProperties { return this->disable_statistics(path->ToDotString()); }

[GitHub] [arrow] ursabot commented on pull request #33764: GH-15109: [Python] Allow creation of non empty struct array with zero field

2023-01-20 Thread GitBox
ursabot commented on PR #33764: URL: https://github.com/apache/arrow/pull/33764#issuecomment-1398577405 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/2e36b6e440484302ad20c5b43dc9a58c...2eb76bfb924947cb97a14cbb8822eecf/)

[GitHub] [arrow-datafusion] ursabot commented on pull request #5002: Bump sqllogictest to v0.11.1

2023-01-20 Thread GitBox
ursabot commented on PR #5002: URL: https://github.com/apache/arrow-datafusion/pull/5002#issuecomment-1398576985 Benchmark runs are scheduled for baseline = 03601bee545599a8be3ef982bc98f7b3a71fb3df and contender = 92d0a054c23e5fba91718db32ccd933ce86dd2b6.

[GitHub] [arrow] ursabot commented on pull request #33764: GH-15109: [Python] Allow creation of non empty struct array with zero field

2023-01-20 Thread GitBox
ursabot commented on PR #33764: URL: https://github.com/apache/arrow/pull/33764#issuecomment-1398576941 Benchmark runs are scheduled for baseline = e920474d7f1dbc7702c08117481db0cd4297b581 and contender = fc1f9ebbc4c3ae77d5cfc2f9322f4373d3d19b8a. fc1f9ebbc4c3ae77d5cfc2f9322f4373d3d19b8a

[GitHub] [arrow-datafusion] xudong963 merged pull request #5002: Bump sqllogictest to v0.11.1

2023-01-20 Thread GitBox
xudong963 merged PR #5002: URL: https://github.com/apache/arrow-datafusion/pull/5002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow-rs] tustvold closed issue #3159: Support Nested Types in Row Format

2023-01-20 Thread GitBox
tustvold closed issue #3159: Support Nested Types in Row Format URL: https://github.com/apache/arrow-rs/issues/3159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [arrow] wjones127 commented on a diff in pull request #33694: MINOR: [C++][Parquet] Rephrase decimal annotation

2023-01-20 Thread GitBox
wjones127 commented on code in PR #33694: URL: https://github.com/apache/arrow/pull/33694#discussion_r1082703943 ## cpp/src/parquet/properties.h: ## @@ -452,19 +452,39 @@ class PARQUET_EXPORT WriterProperties { return this->disable_statistics(path->ToDotString()); }

[GitHub] [arrow-adbc] paleolimbot commented on issue #366: [Discuss] Is the conventional commit format working?

2023-01-20 Thread GitBox
paleolimbot commented on issue #366: URL: https://github.com/apache/arrow-adbc/issues/366#issuecomment-1398565056 I rather like reading the conventional commit PR notifications...it's not perfectly consistent but it's *more* consistent than Arrow's "language-only" component. I'd like to

[GitHub] [arrow-rs] DDtKey commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-20 Thread GitBox
DDtKey commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1081030906 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-adbc] lidavidm merged pull request #364: ci: download arch-specific golang

2023-01-20 Thread GitBox
lidavidm merged PR #364: URL: https://github.com/apache/arrow-adbc/pull/364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow] ursabot commented on pull request #33780: GH-33779: [R] Nightly builds (R 3.5 and 3.6) failing due to field refs test

2023-01-20 Thread GitBox
ursabot commented on PR #33780: URL: https://github.com/apache/arrow/pull/33780#issuecomment-1398538971 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/ad7d2fade4df48c7b3718a3d97031fd1...2e36b6e440484302ad20c5b43dc9a58c/)

[GitHub] [arrow] ursabot commented on pull request #33780: GH-33779: [R] Nightly builds (R 3.5 and 3.6) failing due to field refs test

2023-01-20 Thread GitBox
ursabot commented on PR #33780: URL: https://github.com/apache/arrow/pull/33780#issuecomment-1398538353 Benchmark runs are scheduled for baseline = 4c698fb3c2a2b4ee046c6ad6e992e81ed90c7b0e and contender = e920474d7f1dbc7702c08117481db0cd4297b581. e920474d7f1dbc7702c08117481db0cd4297b581

[GitHub] [arrow-rs] alamb commented on pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
alamb commented on PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#issuecomment-1398536300 cc @Ted-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [arrow-adbc] lidavidm commented on pull request #365: feat(r): Add R Driver Manager

2023-01-20 Thread GitBox
lidavidm commented on PR #365: URL: https://github.com/apache/arrow-adbc/pull/365#issuecomment-1398533476 For those cpplint failures, you might need something like this:

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082678855 ## parquet/src/util/bit_util.rs: ## @@ -17,76 +17,104 @@ use std::{cmp, mem::size_of}; -use crate::data_type::AsBytes; +use crate::data_type::{AsBytes,

[GitHub] [arrow-datafusion] ursabot commented on pull request #4984: minor: Update data type support documentation

2023-01-20 Thread GitBox
ursabot commented on PR #4984: URL: https://github.com/apache/arrow-datafusion/pull/4984#issuecomment-1398518494 Benchmark runs are scheduled for baseline = 5dd5ffd5ea84d843b9ef34d0eaa9ac992618f6e2 and contender = 03601bee545599a8be3ef982bc98f7b3a71fb3df.

[GitHub] [arrow-adbc] lidavidm commented on pull request #364: ci: download arch-specific golang

2023-01-20 Thread GitBox
lidavidm commented on PR #364: URL: https://github.com/apache/arrow-adbc/pull/364#issuecomment-1398515942 Ok, it works now. One of the Go builds is a little flaky. https://github.com/lidavidm/arrow-adbc/actions/runs/3968565812/jobs/6801899981 -- This is an automated message from the

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082672997 ## parquet/src/bin/parquet-index.rs: ## @@ -132,7 +132,7 @@ fn compute_row_counts(offset_index: &[PageLocation], rows: i64) -> Vec { } /// Prints index

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082672397 ## parquet/src/file/page_index/index.rs: ## @@ -53,14 +53,14 @@ pub enum Index { /// will only return pageLocations without min_max index, /// `NONE`

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082671978 ## parquet/src/util/bit_util.rs: ## @@ -17,76 +17,104 @@ use std::{cmp, mem::size_of}; -use crate::data_type::AsBytes; +use crate::data_type::{AsBytes,

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082671374 ## parquet/src/file/statistics.rs: ## @@ -181,11 +181,11 @@ pub fn from_thrift( // min/max statistics for INT96 columns.

[GitHub] [arrow-datafusion-python] andygrove opened a new pull request, #147: Rename default branch from master to main

2023-01-20 Thread GitBox
andygrove opened a new pull request, #147: URL: https://github.com/apache/arrow-datafusion-python/pull/147 # Which issue does this PR close? Part of https://github.com/apache/arrow-datafusion-python/issues/144 # Rationale for this change See issue #

[GitHub] [arrow-datafusion] mustafasrepo commented on a diff in pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
mustafasrepo commented on code in PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#discussion_r1082669525 ## datafusion/common/src/utils.rs: ## @@ -103,6 +111,53 @@ where Ok(low) } +/// This function searches for a tuple of given values (`target`)

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082668780 ## parquet/src/util/bit_util.rs: ## @@ -17,76 +17,104 @@ use std::{cmp, mem::size_of}; -use crate::data_type::AsBytes; +use crate::data_type::{AsBytes,

[GitHub] [arrow] thisisnic merged pull request #33748: GH-33746: [R] Update NEWS.md for 11.0.0

2023-01-20 Thread GitBox
thisisnic merged PR #33748: URL: https://github.com/apache/arrow/pull/33748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow] westonpace commented on issue #33699: [CI][C++] Nightly tests for valgrind have been failing for the last

2023-01-20 Thread GitBox
westonpace commented on issue #33699: URL: https://github.com/apache/arrow/issues/33699#issuecomment-1398508810 Alternatively, we could try reducing the runtime of these tests when valgrind is enabled. `parquet-arrow-test` for example tries many different type variations (8 different

[GitHub] [arrow-datafusion] xudong963 commented on a diff in pull request #5002: Bump sqllogictest to v0.11.1

2023-01-20 Thread GitBox
xudong963 commented on code in PR #5002: URL: https://github.com/apache/arrow-datafusion/pull/5002#discussion_r1082666973 ## datafusion/core/tests/sqllogictests/src/main.rs: ## @@ -109,7 +109,7 @@ pub async fn main() -> Result<()> { info!("Using complete mode to

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5002: Bump sqllogictest to v0.11.1

2023-01-20 Thread GitBox
alamb commented on code in PR #5002: URL: https://github.com/apache/arrow-datafusion/pull/5002#discussion_r1082665326 ## datafusion/core/tests/sqllogictests/src/main.rs: ## @@ -109,7 +109,7 @@ pub async fn main() -> Result<()> { info!("Using complete mode to

[GitHub] [arrow-datafusion] alamb closed pull request #4922: Update sqllogictest requirement from 0.10.0 to 0.11.1

2023-01-20 Thread GitBox
alamb closed pull request #4922: Update sqllogictest requirement from 0.10.0 to 0.11.1 URL: https://github.com/apache/arrow-datafusion/pull/4922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-datafusion] dependabot[bot] commented on pull request #4922: Update sqllogictest requirement from 0.10.0 to 0.11.1

2023-01-20 Thread GitBox
dependabot[bot] commented on PR #4922: URL: https://github.com/apache/arrow-datafusion/pull/4922#issuecomment-1398506919 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [arrow-datafusion] alamb commented on pull request #4922: Update sqllogictest requirement from 0.10.0 to 0.11.1

2023-01-20 Thread GitBox
alamb commented on PR #4922: URL: https://github.com/apache/arrow-datafusion/pull/4922#issuecomment-1398506861 Dupe of https://github.com/apache/arrow-datafusion/pull/4922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow-datafusion] alamb commented on pull request #4960: Update pyo3 requirement from 0.17.1 to 0.18.0

2023-01-20 Thread GitBox
alamb commented on PR #4960: URL: https://github.com/apache/arrow-datafusion/pull/4960#issuecomment-1398505810 This needs to wait for arrow to update pyo3, which conveniently @viirya did in https://github.com/apache/arrow-rs/pull/3557 -- This is an automated message from the Apache Git

[GitHub] [arrow-datafusion] xudong963 merged pull request #4984: minor: Update data type support documentation

2023-01-20 Thread GitBox
xudong963 merged PR #4984: URL: https://github.com/apache/arrow-datafusion/pull/4984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow] westonpace commented on issue #33699: [CI][C++] Nightly tests for valgrind have been failing for the last

2023-01-20 Thread GitBox
westonpace commented on issue #33699: URL: https://github.com/apache/arrow/issues/33699#issuecomment-1398505553 I tried looking into this a bit more today. I ran the `parquet-reader-test` on master, on the same commit that last passed (df4cb9588) and on a really old commit

[GitHub] [arrow-datafusion] alamb commented on pull request #4922: Update sqllogictest requirement from 0.10.0 to 0.11.1

2023-01-20 Thread GitBox
alamb commented on PR #4922: URL: https://github.com/apache/arrow-datafusion/pull/4922#issuecomment-1398501978 Pushed 48e3681 for updated API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-datafusion-python] andygrove commented on issue #144: Change default branch name from master to main

2023-01-20 Thread GitBox
andygrove commented on issue #144: URL: https://github.com/apache/arrow-datafusion-python/issues/144#issuecomment-1398500876 INFRA issue: https://issues.apache.org/jira/browse/INFRA-24106 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow-rs] bmmeijers commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
bmmeijers commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082651910 ## parquet/src/bin/parquet-index.rs: ## @@ -132,7 +132,7 @@ fn compute_row_counts(offset_index: &[PageLocation], rows: i64) -> Vec { } /// Prints index

[GitHub] [arrow-datafusion] xudong963 opened a new pull request, #5002: Bump sqllogictest to v0.11.1

2023-01-20 Thread GitBox
xudong963 opened a new pull request, #5002: URL: https://github.com/apache/arrow-datafusion/pull/5002 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are these changes

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4995: [Feature] support describe file

2023-01-20 Thread GitBox
alamb commented on code in PR #4995: URL: https://github.com/apache/arrow-datafusion/pull/4995#discussion_r1082633781 ## datafusion/core/src/datasource/listing/table.rs: ## @@ -67,6 +67,10 @@ pub struct ListingTableConfig { pub file_schema: Option, /// Optional

[GitHub] [arrow-datafusion-python] jdye64 commented on pull request #145: Substrait bindings

2023-01-20 Thread GitBox
jdye64 commented on PR #145: URL: https://github.com/apache/arrow-datafusion-python/pull/145#issuecomment-1398497972 Hey @andygrove thanks! However, something is broken with the Github actions setup. While this PR showed all the CI passing that was actually a red herring. Only a single

[GitHub] [arrow] rtpsw commented on pull request #33676: GH-33673: [C++] Standardize as-of-join convention for past and future tolerance

2023-01-20 Thread GitBox
rtpsw commented on PR #33676: URL: https://github.com/apache/arrow/pull/33676#issuecomment-1398491977 Ping @westonpace - it would be great if this can be reviewed quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow-datafusion] ozankabak commented on a diff in pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
ozankabak commented on code in PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#discussion_r1082640117 ## datafusion/common/src/utils.rs: ## @@ -103,6 +111,53 @@ where Ok(low) } +/// This function searches for a tuple of given values (`target`) among

[GitHub] [arrow-rs] Sach1nAgarwal commented on pull request #3576: Propagate EOF Error from AsyncRead

2023-01-20 Thread GitBox
Sach1nAgarwal commented on PR #3576: URL: https://github.com/apache/arrow-rs/pull/3576#issuecomment-1398490172 I will try to write a test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-ballista] thinkharderdev commented on pull request #560: Cluster state refactor part 1

2023-01-20 Thread GitBox
thinkharderdev commented on PR #560: URL: https://github.com/apache/arrow-ballista/pull/560#issuecomment-1398487737 I'll plan on merging this tomorrow morning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow-adbc] lidavidm commented on pull request #356: feat(go/adbc/driver/pkg/cmake): cmake build for Go shared library drivers

2023-01-20 Thread GitBox
lidavidm commented on PR #356: URL: https://github.com/apache/arrow-adbc/pull/356#issuecomment-1398487632 Something about the Go build in the sdist is flaky, when it tries to remove the generated header. Maybe instead of removing it, we just add a .gitignore and move on? -- This is an

[GitHub] [arrow] ursabot commented on pull request #15223: GH-15203: [Java] Implement writing compressed files

2023-01-20 Thread GitBox
ursabot commented on PR #15223: URL: https://github.com/apache/arrow/pull/15223#issuecomment-1398486539 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/200a70d5895c419f9ee6659640af67d5...ad7d2fade4df48c7b3718a3d97031fd1/)

[GitHub] [arrow-rs] ursabot commented on pull request #3576: Propagate EOF Error from AsyncRead

2023-01-20 Thread GitBox
ursabot commented on PR #3576: URL: https://github.com/apache/arrow-rs/pull/3576#issuecomment-1398486113 Benchmark runs are scheduled for baseline = a61da1e655e76e8676f1cdb021b13551e720b0de and contender = a1cedb4fdfb561eda4e836a6c8fcb898d7a37029. a1cedb4fdfb561eda4e836a6c8fcb898d7a37029

[GitHub] [arrow-datafusion] ursabot commented on pull request #5001: Minor: Document how to create `ListingTables`

2023-01-20 Thread GitBox
ursabot commented on PR #5001: URL: https://github.com/apache/arrow-datafusion/pull/5001#issuecomment-1398486164 Benchmark runs are scheduled for baseline = e566bfc4af0ffb53717a784ab423d407473b62a0 and contender = 6d770ad0d747e9e87752888ddd3dd69d6765.

[GitHub] [arrow-datafusion] ursabot commented on pull request #5000: Allow overriding error type in DataFusion Result

2023-01-20 Thread GitBox
ursabot commented on PR #5000: URL: https://github.com/apache/arrow-datafusion/pull/5000#issuecomment-1398486195 Benchmark runs are scheduled for baseline = 6d770ad0d747e9e87752888ddd3dd69d6765 and contender = 5dd5ffd5ea84d843b9ef34d0eaa9ac992618f6e2.

[GitHub] [arrow-datafusion] ursabot commented on pull request #4944: Only add outer filter once when transforming exists/in subquery to join

2023-01-20 Thread GitBox
ursabot commented on PR #4944: URL: https://github.com/apache/arrow-datafusion/pull/4944#issuecomment-1398486136 Benchmark runs are scheduled for baseline = 22d106a6564345a746699cd5eb1fc84b9267ce83 and contender = e566bfc4af0ffb53717a784ab423d407473b62a0.

[GitHub] [arrow] ursabot commented on pull request #15223: GH-15203: [Java] Implement writing compressed files

2023-01-20 Thread GitBox
ursabot commented on PR #15223: URL: https://github.com/apache/arrow/pull/15223#issuecomment-1398486089 Benchmark runs are scheduled for baseline = e4019add4189a9abe25f8ff6f12099ed19921104 and contender = 4c698fb3c2a2b4ee046c6ad6e992e81ed90c7b0e. 4c698fb3c2a2b4ee046c6ad6e992e81ed90c7b0e

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #4999: Add dictionary_expresions feature (#4386)

2023-01-20 Thread GitBox
tustvold commented on code in PR #4999: URL: https://github.com/apache/arrow-datafusion/pull/4999#discussion_r1082628665 ## datafusion/physical-expr/Cargo.toml: ## @@ -35,12 +35,15 @@ path = "src/lib.rs" [features] crypto_expressions = ["md-5", "sha2", "blake2", "blake3"]

  1   2   3   4   5   6   7   8   9   10   >