Re: [PR] Minor: get mutable ref to `SessionConfig` in `SessionState` [arrow-datafusion]

2024-04-15 Thread via GitHub
milenkovicm commented on PR #10050: URL: https://github.com/apache/arrow-datafusion/pull/10050#issuecomment-2056566260 > @milenkovicm as you have been using the extension points, any thing you can do or suggest to make using them easier would be awesome as well. Thank you for your help so

Re: [PR] Minor: get mutable ref to `SessionConfig` in `SessionState` [arrow-datafusion]

2024-04-15 Thread via GitHub
alamb merged PR #10050: URL: https://github.com/apache/arrow-datafusion/pull/10050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Minor: get mutable ref to `SessionConfig` in `SessionState` [arrow-datafusion]

2024-04-14 Thread via GitHub
MichaelScofield commented on code in PR #10050: URL: https://github.com/apache/arrow-datafusion/pull/10050#discussion_r1564766462 ## datafusion/execution/src/config.rs: ## @@ -500,7 +500,7 @@ impl SessionConfig { /// ``` /// /// [^1]: Compare that to

Re: [PR] Minor: get mutable ref to `SessionConfig` in `SessionState` [arrow-datafusion]

2024-04-14 Thread via GitHub
MichaelScofield commented on code in PR #10050: URL: https://github.com/apache/arrow-datafusion/pull/10050#discussion_r1564759712 ## datafusion/execution/src/config.rs: ## @@ -500,7 +500,7 @@ impl SessionConfig { /// ``` /// /// [^1]: Compare that to

Re: [PR] Minor: get mutable ref to `SessionConfig` in `SessionState` [arrow-datafusion]

2024-04-13 Thread via GitHub
alamb commented on code in PR #10050: URL: https://github.com/apache/arrow-datafusion/pull/10050#discussion_r1564036274 ## datafusion/execution/src/config.rs: ## @@ -500,7 +500,7 @@ impl SessionConfig { /// ``` /// /// [^1]: Compare that to [`ConfigOptions`]

Re: [PR] Minor: get mutable ref to `SessionConfig` in `SessionState` [arrow-datafusion]

2024-04-12 Thread via GitHub
milenkovicm commented on code in PR #10050: URL: https://github.com/apache/arrow-datafusion/pull/10050#discussion_r1563183060 ## datafusion/execution/src/config.rs: ## @@ -500,7 +500,7 @@ impl SessionConfig { /// ``` /// /// [^1]: Compare that to

Re: [PR] Minor: get mutable ref to `SessionConfig` in `SessionState` [arrow-datafusion]

2024-04-12 Thread via GitHub
alamb commented on code in PR #10050: URL: https://github.com/apache/arrow-datafusion/pull/10050#discussion_r1562964008 ## datafusion/execution/src/config.rs: ## @@ -500,7 +500,7 @@ impl SessionConfig { /// ``` /// /// [^1]: Compare that to [`ConfigOptions`]

Re: [PR] Minor: get mutable ref to `SessionConfig` in `SessionState` [arrow-datafusion]

2024-04-12 Thread via GitHub
MichaelScofield commented on PR #10050: URL: https://github.com/apache/arrow-datafusion/pull/10050#issuecomment-2051171970 @alamb can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Minor: get mutable ref to `SessionConfig` in `SessionState` [arrow-datafusion]

2024-04-12 Thread via GitHub
MichaelScofield opened a new pull request, #10050: URL: https://github.com/apache/arrow-datafusion/pull/10050 ## Which issue does this PR close? Closes #. ## Rationale for this change The `SessionConfig` has an "`extensions: AnyMap`", can be used "... to