github-actions[bot] commented on issue #7014:
URL: https://github.com/apache/arrow/pull/7014#issuecomment-617881461
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you
kiszk commented on issue #6954:
URL: https://github.com/apache/arrow/pull/6954#issuecomment-617854855
Is the function `Armv8CrcHashParallel` uses somewhere? Sorry if I overlook
it.
This is an automated message from the
kiszk edited a comment on issue #6954:
URL: https://github.com/apache/arrow/pull/6954#issuecomment-617854855
Is the function `Armv8CrcHashParallel` used somewhere? Sorry if I overlook
it.
This is an automated message from
kszucs commented on issue #7000:
URL: https://github.com/apache/arrow/pull/7000#issuecomment-617868408
@ursabot build
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mindhash opened a new pull request #7014:
URL: https://github.com/apache/arrow/pull/7014
Hello team,
This minor change makes newBuilder() public to reduce verbosity in upstream.
To give you example, I am working on a parquet read / write into Arrow
Record batch where the parquet
pitrou commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r413092039
##
File path: cpp/src/arrow/util/hash_util.h
##
@@ -27,39 +27,27 @@
#include "arrow/util/logging.h"
#include "arrow/util/macros.h"
-#include
andygrove commented on a change in pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#discussion_r413404215
##
File path: rust/datafusion/src/utils.rs
##
@@ -74,6 +74,29 @@ macro_rules! make_string {
}};
}
+macro_rules! make_string_from_list {
+
andygrove commented on a change in pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#discussion_r413404556
##
File path: rust/datafusion/src/utils.rs
##
@@ -120,6 +143,7 @@ pub fn array_value_to_string(column: array::ArrayRef, row:
usize) -> Result {
andygrove commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r413408444
##
File path: rust/arrow/src/array/mod.rs
##
@@ -85,6 +85,7 @@ mod array;
mod builder;
mod data;
mod equal;
+mod union;
Review comment:
I
andygrove commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r413408241
##
File path: rust/arrow/src/array/equal.rs
##
@@ -1046,6 +1062,30 @@ impl PartialEq for Value {
}
}
+impl JsonEqual for UnionArray {
+fn
andygrove commented on issue #6972:
URL: https://github.com/apache/arrow/pull/6972#issuecomment-618100341
Thanks @markhildreth for the detailed write-up in the JIRA! I've started
looking through this.
I'm not sure I understand all the points you made yet, but if there is a way
to
wesm commented on issue #5947:
URL: https://github.com/apache/arrow/pull/5947#issuecomment-618107435
@praveenbingo @projjal would you be able to take a look now?
This is an automated message from the Apache Git Service.
To
fsaintjacques commented on issue #7011:
URL: https://github.com/apache/arrow/pull/7011#issuecomment-61869
I understood that @bkietz added an entry for this, maybe it doesn't have the
benchmark enabled?
This is an
wesm commented on issue #7011:
URL: https://github.com/apache/arrow/pull/7011#issuecomment-618111873
manylinux1 uses gcc 4.8 but does not build the benchmarks.
This is an automated message from the Apache Git Service.
To
houqp commented on issue #7009:
URL: https://github.com/apache/arrow/pull/7009#issuecomment-618158794
@nevi-me rebased and tests are passing now :)
This is an automated message from the Apache Git Service.
To respond to the
andygrove commented on a change in pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#discussion_r413403760
##
File path: rust/datafusion/src/utils.rs
##
@@ -74,6 +74,29 @@ macro_rules! make_string {
}};
}
+macro_rules! make_string_from_list {
+
andygrove commented on a change in pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#discussion_r413403453
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -828,8 +828,8 @@ mod tests {
.build()?;
let expected = "Projection: #id\
-
andygrove commented on issue #4140:
URL: https://github.com/apache/arrow/pull/4140#issuecomment-618098211
@bryantbiggs I will take a look at the release tag issue this weekend.
This is an automated message from the Apache
fsaintjacques commented on issue #7000:
URL: https://github.com/apache/arrow/pull/7000#issuecomment-618110604
Addressed most comments and updated followup ticket with what's missing.
PTAL and merge quickly so we can unblock the blocked tickets :)
xuancong84 opened a new issue #7017:
URL: https://github.com/apache/arrow/issues/7017
Dear developers, I realize that complex numbers in Numpy arrays and Pandas
dataframe/series can be serialized, but complex numbers in Python structures
(e.g., `[1, 2.5, 3+1.j, np.nan]`) cannot be
kou commented on issue #6996:
URL: https://github.com/apache/arrow/pull/6996#issuecomment-618066972
Could you make a JIRA?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mcassels commented on issue #6770:
URL: https://github.com/apache/arrow/pull/6770#issuecomment-618082896
@andygrove @nevi-me do you have any thoughts on this?
This is an automated message from the Apache Git Service.
To
wesm commented on issue #7011:
URL: https://github.com/apache/arrow/pull/7011#issuecomment-618102656
Another gcc 4.8 issue here. We may need a more comprehensive build that also
builds the benchmark executables
This is an
fsaintjacques commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413428461
##
File path: cpp/src/arrow/util/bit_util.h
##
@@ -43,13 +43,18 @@
#if defined(_MSC_VER)
#include
+#include
#pragma intrinsic(_BitScanReverse)
andygrove commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r413407658
##
File path: rust/arrow/src/array/equal.rs
##
@@ -692,6 +692,22 @@ impl ArrayEqual for StructArray {
}
}
+impl ArrayEqual for UnionArray {
+
andygrove commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r413407264
##
File path: rust/arrow/src/array/equal.rs
##
@@ -692,6 +692,22 @@ impl ArrayEqual for StructArray {
}
}
+impl ArrayEqual for UnionArray {
+
github-actions[bot] commented on issue #7014:
URL: https://github.com/apache/arrow/pull/7014#issuecomment-618187424
https://issues.apache.org/jira/browse/ARROW-8563
This is an automated message from the Apache Git Service.
tustvold commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r412736972
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
tustvold commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r412736972
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
kou commented on issue #7008:
URL: https://github.com/apache/arrow/pull/7008#issuecomment-617615843
@github-actions crossbow submit gandiva-jar-xenial
This is an automated message from the Apache Git Service.
To respond to
jianxind commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r412709153
##
File path: docs/source/developers/benchmarks.rst
##
@@ -59,7 +59,7 @@ Sometimes, it is required to pass custom CMake flags, e.g.
.. code-block:: shell
tustvold commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r412736972
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
github-actions[bot] commented on issue #7008:
URL: https://github.com/apache/arrow/pull/7008#issuecomment-617616494
Revision: 1e235ddc11ff6ee4620b62e3b5f9a318d117512b
Submitted crossbow builds: [ursa-labs/crossbow @
houqp commented on issue #7009:
URL: https://github.com/apache/arrow/pull/7009#issuecomment-617600824
looks like the windows CI is failing with error not related to my change:
```
"error: \'rustfmt.exe\' is not installed for the toolchain
kou commented on issue #7008:
URL: https://github.com/apache/arrow/pull/7008#issuecomment-617618030
Can we move the Docker image for building Gandiva on Linux to our
`ci/docker/` like
https://github.com/apache/arrow/blob/master/python/manylinux201x/Dockerfile-x86_64_base_2014
?
tustvold commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r412736972
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
tustvold commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r412736972
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
tustvold commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r412736972
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
mrkn commented on issue #6667:
URL: https://github.com/apache/arrow/pull/6667#issuecomment-618185887
@rok Thank you for working this! I'll merge this.
This is an automated message from the Apache Git Service.
To respond to
pitrou commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r412926608
##
File path: rust/arrow/src/array/union.rs
##
@@ -0,0 +1,1172 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
jianxind commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r412846457
##
File path: docs/source/developers/benchmarks.rst
##
@@ -59,7 +59,7 @@ Sometimes, it is required to pass custom CMake flags, e.g.
.. code-block:: shell
pitrou commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r412925276
##
File path: rust/arrow/src/array/union.rs
##
@@ -0,0 +1,1172 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
pitrou commented on issue #6981:
URL: https://github.com/apache/arrow/pull/6981#issuecomment-617744347
As a sidenote, I think you may want to start with Arrow unittests before
trying to make Parquet unittests successful. Parquet relies on many Arrow
facilities.
nevi-me opened a new pull request #7010:
URL: https://github.com/apache/arrow/pull/7010
This adds the `rustfmt` component to the Rust installations in Windows and
MacOS, and fixes `rustfmt` related CI failures.
@kszucs @paddyhoran
pitrou commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r412925276
##
File path: rust/arrow/src/array/union.rs
##
@@ -0,0 +1,1172 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
nevi-me commented on issue #7009:
URL: https://github.com/apache/arrow/pull/7009#issuecomment-617678597
> looks like the windows CI is failing with error not related to my change:
>
> ```
> "error: \'rustfmt.exe\' is not installed for the toolchain
github-actions[bot] commented on issue #7010:
URL: https://github.com/apache/arrow/pull/7010#issuecomment-617680858
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you
nevi-me commented on issue #7004:
URL: https://github.com/apache/arrow/pull/7004#issuecomment-617676072
> @kszucs it's failing due to `rustfmt` not being installed before testing
the flight crate, any idea why this would be the case? Sorry, I don't know much
about GitHub actions yet...
pitrou commented on a change in pull request #6992:
URL: https://github.com/apache/arrow/pull/6992#discussion_r412929769
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -2685,8 +2685,8 @@ class A:
'a': pd.period_range('2000-01-01', periods=20),
})
pitrou commented on a change in pull request #6992:
URL: https://github.com/apache/arrow/pull/6992#discussion_r412929368
##
File path: python/pyarrow/pandas-shim.pxi
##
@@ -55,6 +55,16 @@ cdef class _PandasAPIShim(object):
from distutils.version import LooseVersion
cyb70289 commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r412836834
##
File path: docs/source/developers/benchmarks.rst
##
@@ -59,7 +59,7 @@ Sometimes, it is required to pass custom CMake flags, e.g.
.. code-block:: shell
emkornfield commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413530683
##
File path: cpp/src/arrow/util/bit_util.h
##
@@ -43,13 +43,18 @@
#if defined(_MSC_VER)
#include
+#include
#pragma intrinsic(_BitScanReverse)
kiszk commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r412990504
##
File path: cpp/src/parquet/column_reader.cc
##
@@ -50,6 +51,141 @@ using arrow::internal::checked_cast;
namespace parquet {
+namespace {
+
+inline
fsaintjacques commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r413007995
##
File path: cpp/src/arrow/dataset/dataset.h
##
@@ -84,13 +82,12 @@ class ARROW_DS_EXPORT Fragment {
class ARROW_DS_EXPORT InMemoryFragment :
lidavidm opened a new pull request #7012:
URL: https://github.com/apache/arrow/pull/7012
This is a complete implementation of DoExchange for Java. It is not tested
against the C++ implementation yet, however, it still passes integration tests,
so the internal refactoring should not have
github-actions[bot] commented on issue #7012:
URL: https://github.com/apache/arrow/pull/7012#issuecomment-617824864
https://issues.apache.org/jira/browse/ARROW-8555
This is an automated message from the Apache Git Service.
github-actions[bot] commented on issue #7013:
URL: https://github.com/apache/arrow/pull/7013#issuecomment-617824867
https://issues.apache.org/jira/browse/ARROW-8512
This is an automated message from the Apache Git Service.
wesm commented on issue #6982:
URL: https://github.com/apache/arrow/pull/6982#issuecomment-617827466
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
paddyhoran commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r412974468
##
File path: rust/arrow/src/array/union.rs
##
@@ -0,0 +1,1172 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
kiszk commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r412987615
##
File path: cpp/src/parquet/CMakeLists.txt
##
@@ -336,6 +336,7 @@ set_source_files_properties(public_api_test.cc
add_parquet_test(reader_test
github-actions[bot] commented on issue #7011:
URL: https://github.com/apache/arrow/pull/7011#issuecomment-617806628
https://issues.apache.org/jira/browse/ARROW-8554
This is an automated message from the Apache Git Service.
kiszk commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r413030123
##
File path: cpp/src/arrow/util/hash_util.h
##
@@ -27,39 +27,27 @@
#include "arrow/util/logging.h"
#include "arrow/util/macros.h"
-#include
wesm opened a new pull request #7013:
URL: https://github.com/apache/arrow/pull/7013
None of this code was ever used.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wesm commented on issue #7003:
URL: https://github.com/apache/arrow/issues/7003#issuecomment-617827061
Can you please open a JIRA issue and provide instructions to reproduce?
This is an automated message from the Apache Git
fsaintjacques commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r413074200
##
File path: cpp/src/arrow/dataset/dataset.cc
##
@@ -30,34 +30,40 @@
namespace arrow {
namespace dataset {
-Fragment::Fragment(std::shared_ptr
fsaintjacques commented on a change in pull request #6997:
URL: https://github.com/apache/arrow/pull/6997#discussion_r412951352
##
File path: cpp/src/arrow/memory_pool_benchmark.cc
##
@@ -0,0 +1,127 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
pitrou commented on issue #6997:
URL: https://github.com/apache/arrow/pull/6997#issuecomment-617760416
> I tried with multiple threads and the numbers look very similar between
SystemAlloc and Jemalloc when I would have expected Jemalloc to do better here.
Well, it's a trivial
lidavidm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r412985177
##
File path: cpp/src/parquet/file_reader.h
##
@@ -117,6 +117,15 @@ class PARQUET_EXPORT ParquetFileReader {
// Returns the file metadata. Only one
lidavidm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r412987199
##
File path: cpp/src/parquet/properties.h
##
@@ -56,10 +60,32 @@ class PARQUET_EXPORT ReaderProperties {
bool is_buffered_stream_enabled() const {
lidavidm commented on issue #6656:
URL: https://github.com/apache/arrow/pull/6656#issuecomment-617806080
This should be ready now. The only issue I have is I could not figure out
how to get GCC 4.8 to use the unique_ptr overload of a method instead of the
shared_ptr overload.
paddyhoran commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r412972235
##
File path: rust/arrow/src/array/union.rs
##
@@ -0,0 +1,1172 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
lidavidm commented on issue #6744:
URL: https://github.com/apache/arrow/pull/6744#issuecomment-617784720
Thanks for the review!
> It might be nice to have a convenience for prebuffering an entire row
group. Something like
> auto rg = file_reader->RowGroup(i);
>
plusplusjiajia opened a new pull request #7011:
URL: https://github.com/apache/arrow/pull/7011
https://issues.apache.org/jira/browse/ARROW-8554
This is an automated message from the Apache Git Service.
To respond to the
fsaintjacques commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r413045582
##
File path: cpp/src/arrow/dataset/file_base.cc
##
@@ -222,9 +214,8 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl(
}
Result>
fsaintjacques commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r413045582
##
File path: cpp/src/arrow/dataset/file_base.cc
##
@@ -222,9 +214,8 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl(
}
Result>
fsaintjacques commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r413046083
##
File path: cpp/src/arrow/dataset/dataset.h
##
@@ -100,16 +97,20 @@ class ARROW_DS_EXPORT InMemoryFragment : public Fragment {
RecordBatchVector
sunchao commented on a change in pull request #6949:
URL: https://github.com/apache/arrow/pull/6949#discussion_r413158295
##
File path: rust/parquet/src/util/io.rs
##
@@ -31,47 +33,83 @@ pub trait Position {
}
/// Struct that represents a slice of a file data with
fsaintjacques commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r413164872
##
File path: python/pyarrow/_dataset.pyx
##
@@ -519,30 +500,69 @@ cdef class Fragment:
"""
return
houqp commented on issue #7009:
URL: https://github.com/apache/arrow/pull/7009#issuecomment-617914513
Thanks @nevi-me for the fix, looks like your PR has been approved. I will
wait for the merge.
This is an automated
nealrichardson commented on issue #6995:
URL: https://github.com/apache/arrow/pull/6995#issuecomment-617926040
@github-actions crossbow submit test-conda-r-3.6 test-ubuntu-18.04-r-3.6
This is an automated message from the
kiszk commented on issue #6981:
URL: https://github.com/apache/arrow/pull/6981#issuecomment-617935417
@wesm do you have any comment on this change?
This is an automated message from the Apache Git Service.
To respond to the
wesm commented on issue #6981:
URL: https://github.com/apache/arrow/pull/6981#issuecomment-617947022
I haven't had a chance to look in detail. Perhaps someone on the Parquet
mailing list might be able to help
This is an
github-actions[bot] commented on issue #6995:
URL: https://github.com/apache/arrow/pull/6995#issuecomment-617926769
Revision: 61e54eb79986e3946e15c373c76e3eee4294dd44
Submitted crossbow builds: [ursa-labs/crossbow @
paddyhoran opened a new pull request #7015:
URL: https://github.com/apache/arrow/pull/7015
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on issue #7015:
URL: https://github.com/apache/arrow/pull/7015#issuecomment-618016015
https://issues.apache.org/jira/browse/ARROW-8560
This is an automated message from the Apache Git Service.
wesm commented on issue #7001:
URL: https://github.com/apache/arrow/pull/7001#issuecomment-618021001
@davidanthoff would you mind opening a JIRA issue for this and updating the
PR title?
This is an automated message from
kou opened a new pull request #7016:
URL: https://github.com/apache/arrow/pull/7016
ByteSize() is deprecated and ByteSizeLong() is added since Protobuf 3.4.0.
This is an automated message from the Apache Git Service.
To
kou commented on issue #7016:
URL: https://github.com/apache/arrow/pull/7016#issuecomment-618049071
@github-actions crossbow submit -g gandiva
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on issue #7016:
URL: https://github.com/apache/arrow/pull/7016#issuecomment-618049644
Revision: e6ed98341efbd0f7bfed30a7aaf12935afb85fa5
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on issue #7016:
URL: https://github.com/apache/arrow/pull/7016#issuecomment-618051647
https://issues.apache.org/jira/browse/ARROW-8561
This is an automated message from the Apache Git Service.
nealrichardson commented on issue #6996:
URL: https://github.com/apache/arrow/pull/6996#issuecomment-618053499
@kou are you adding `osx_image: xcode11.3` somewhere already or should I
make a JIRA?
This is an automated
91 matches
Mail list logo
