[GitHub] [arrow] nealrichardson commented on pull request #10833: ARROW-13493 [C++] Anonymous structs in an anonymous union are a GNU extension

2021-07-30 Thread GitBox
nealrichardson commented on pull request #10833: URL: https://github.com/apache/arrow/pull/10833#issuecomment-889950166 I've reproduced the error on https://github.com/apache/arrow/pull/10839, so I'll merge that (assuming I haven't broken other things) and then you can rebase this, run the

[GitHub] [arrow] bkietz commented on a change in pull request #10802: ARROW-1568: [C++] Implement Drop Null Kernel for Arrays

2021-07-30 Thread GitBox
bkietz commented on a change in pull request #10802: URL: https://github.com/apache/arrow/pull/10802#discussion_r679994244 ## File path: cpp/src/arrow/compute/kernels/vector_selection.cc ## @@ -2146,6 +2147,144 @@ class TakeMetaFunction : public MetaFunction { } }; +// --

[GitHub] [arrow] bkietz commented on a change in pull request #10802: ARROW-1568: [C++] Implement Drop Null Kernel for Arrays

2021-07-30 Thread GitBox
bkietz commented on a change in pull request #10802: URL: https://github.com/apache/arrow/pull/10802#discussion_r680002741 ## File path: cpp/src/arrow/compute/kernels/vector_selection.cc ## @@ -2146,6 +2147,144 @@ class TakeMetaFunction : public MetaFunction { } }; +// --

[GitHub] [arrow] nirandaperera commented on a change in pull request #10802: ARROW-1568: [C++] Implement Drop Null Kernel for Arrays

2021-07-30 Thread GitBox
nirandaperera commented on a change in pull request #10802: URL: https://github.com/apache/arrow/pull/10802#discussion_r680002827 ## File path: cpp/src/arrow/compute/kernels/vector_selection.cc ## @@ -2146,6 +2147,144 @@ class TakeMetaFunction : public MetaFunction { } };

[GitHub] [arrow] thisisnic commented on a change in pull request #10710: ARROW-11460: [R] Use system libraries if present on Linux

2021-07-30 Thread GitBox
thisisnic commented on a change in pull request #10710: URL: https://github.com/apache/arrow/pull/10710#discussion_r680012443 ## File path: r/inst/build_arrow_static.sh ## @@ -45,6 +45,19 @@ else ARROW_DEFAULT_PARAM="OFF" fi +if [ "$R_STATIC_DEPENDENCY_SOURCE" = "AUTO" ];

[GitHub] [arrow] dongjoon-hyun commented on pull request #10838: ARROW-13506: [C++][Java] Upgrade ORC to 1.6.9

2021-07-30 Thread GitBox
dongjoon-hyun commented on pull request #10838: URL: https://github.com/apache/arrow/pull/10838#issuecomment-889969658 Also cc @sunchao . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [arrow] nealrichardson closed pull request #10839: ARROW-13510: [CI][R][C++] Add -Wall to fedora-clang-devel as-cran checks

2021-07-30 Thread GitBox
nealrichardson closed pull request #10839: URL: https://github.com/apache/arrow/pull/10839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow] nealrichardson commented on pull request #10833: ARROW-13493 [C++] Anonymous structs in an anonymous union are a GNU extension

2021-07-30 Thread GitBox
nealrichardson commented on pull request #10833: URL: https://github.com/apache/arrow/pull/10833#issuecomment-889973030 ok @nirandaperera, merged, please rebase and then do `@github-actions crossbow submit test-r-linux-as-cran` -- This is an automated message from the Apache Git Service.

[GitHub] [arrow] nirandaperera commented on pull request #10833: ARROW-13493 [C++] Anonymous structs in an anonymous union are a GNU extension

2021-07-30 Thread GitBox
nirandaperera commented on pull request #10833: URL: https://github.com/apache/arrow/pull/10833#issuecomment-889974932 @github-actions crossbow submit test-r-linux-as-cran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] github-actions[bot] commented on pull request #10833: ARROW-13493 [C++] Anonymous structs in an anonymous union are a GNU extension

2021-07-30 Thread GitBox
github-actions[bot] commented on pull request #10833: URL: https://github.com/apache/arrow/pull/10833#issuecomment-889975532 Revision: fe0b1ec8c425c963a7470ace9fd3af14674b37dd Submitted crossbow builds: [ursacomputing/crossbow @ actions-678](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] emkornfield commented on pull request #10627: PARQUET-490: [C++][Parquet] Basic support for encoding DELTA_BINARY_PACKED

2021-07-30 Thread GitBox
emkornfield commented on pull request #10627: URL: https://github.com/apache/arrow/pull/10627#issuecomment-889976082 sorry I have had less time then I would have liked recently for Arrow reviews, will try to get to this soon. -- This is an automated message from the Apache Git Service. T

[GitHub] [arrow] emkornfield commented on pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

2021-07-30 Thread GitBox
emkornfield commented on pull request #10716: URL: https://github.com/apache/arrow/pull/10716#issuecomment-889976220 sorry I have had less time then I would have liked recently for Arrow reviews, will try to get to this soon. -- This is an automated message from the Apache Git Service. T

[GitHub] [arrow] emkornfield commented on a change in pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

2021-07-30 Thread GitBox
emkornfield commented on a change in pull request #10716: URL: https://github.com/apache/arrow/pull/10716#discussion_r680022978 ## File path: go/parquet/internal/encoding/encoding_benchmarks_test.go ## @@ -0,0 +1,461 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [arrow] emkornfield commented on a change in pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

2021-07-30 Thread GitBox
emkornfield commented on a change in pull request #10716: URL: https://github.com/apache/arrow/pull/10716#discussion_r680026208 ## File path: go/parquet/internal/encoding/levels.go ## @@ -0,0 +1,284 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

[GitHub] [arrow] emkornfield commented on a change in pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

2021-07-30 Thread GitBox
emkornfield commented on a change in pull request #10716: URL: https://github.com/apache/arrow/pull/10716#discussion_r680027195 ## File path: go/parquet/internal/encoding/levels.go ## @@ -0,0 +1,284 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

[GitHub] [arrow] emkornfield commented on a change in pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

2021-07-30 Thread GitBox
emkornfield commented on a change in pull request #10716: URL: https://github.com/apache/arrow/pull/10716#discussion_r680027388 ## File path: go/parquet/internal/encoding/levels.go ## @@ -0,0 +1,284 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

[GitHub] [arrow] nealrichardson commented on a change in pull request #10710: ARROW-11460: [R] Use system libraries if present on Linux

2021-07-30 Thread GitBox
nealrichardson commented on a change in pull request #10710: URL: https://github.com/apache/arrow/pull/10710#discussion_r680027557 ## File path: r/inst/build_arrow_static.sh ## @@ -45,6 +45,19 @@ else ARROW_DEFAULT_PARAM="OFF" fi +if [ "$R_STATIC_DEPENDENCY_SOURCE" = "AUT

[GitHub] [arrow] zeroshade commented on a change in pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

2021-07-30 Thread GitBox
zeroshade commented on a change in pull request #10716: URL: https://github.com/apache/arrow/pull/10716#discussion_r680028297 ## File path: go/parquet/internal/encoding/encoding_benchmarks_test.go ## @@ -0,0 +1,461 @@ +// Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [arrow] emkornfield commented on a change in pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

2021-07-30 Thread GitBox
emkornfield commented on a change in pull request #10716: URL: https://github.com/apache/arrow/pull/10716#discussion_r680028272 ## File path: go/parquet/internal/encoding/levels.go ## @@ -0,0 +1,284 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

[GitHub] [arrow] nealrichardson commented on a change in pull request #10710: ARROW-11460: [R] Use system libraries if present on Linux

2021-07-30 Thread GitBox
nealrichardson commented on a change in pull request #10710: URL: https://github.com/apache/arrow/pull/10710#discussion_r680028253 ## File path: r/inst/build_arrow_static.sh ## @@ -45,6 +45,19 @@ else ARROW_DEFAULT_PARAM="OFF" fi +if [ "$R_STATIC_DEPENDENCY_SOURCE" = "AUT

[GitHub] [arrow] zeroshade commented on a change in pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

2021-07-30 Thread GitBox
zeroshade commented on a change in pull request #10716: URL: https://github.com/apache/arrow/pull/10716#discussion_r680029295 ## File path: go/parquet/internal/encoding/levels.go ## @@ -0,0 +1,284 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more con

[GitHub] [arrow] nealrichardson opened a new pull request #10841: ARROW-13511: [CI][R] Fail in the docker build step if R deps don't install

2021-07-30 Thread GitBox
nealrichardson opened a new pull request #10841: URL: https://github.com/apache/arrow/pull/10841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: g

[GitHub] [arrow] nealrichardson commented on a change in pull request #10841: ARROW-13511: [CI][R] Fail in the docker build step if R deps don't install

2021-07-30 Thread GitBox
nealrichardson commented on a change in pull request #10841: URL: https://github.com/apache/arrow/pull/10841#discussion_r680032585 ## File path: ci/scripts/r_deps.sh ## @@ -25,7 +25,12 @@ source_dir=${1}/r pushd ${source_dir} # Install R package dependencies -${R_BIN} -e "i

[GitHub] [arrow] github-actions[bot] commented on pull request #10841: ARROW-13511: [CI][R] Fail in the docker build step if R deps don't install

2021-07-30 Thread GitBox
github-actions[bot] commented on pull request #10841: URL: https://github.com/apache/arrow/pull/10841#issuecomment-889985671 https://issues.apache.org/jira/browse/ARROW-13511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] nealrichardson commented on pull request #10841: ARROW-13511: [CI][R] Fail in the docker build step if R deps don't install

2021-07-30 Thread GitBox
nealrichardson commented on pull request #10841: URL: https://github.com/apache/arrow/pull/10841#issuecomment-889985861 @github-actions crossbow submit -g r -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow] github-actions[bot] commented on pull request #10841: ARROW-13511: [CI][R] Fail in the docker build step if R deps don't install

2021-07-30 Thread GitBox
github-actions[bot] commented on pull request #10841: URL: https://github.com/apache/arrow/pull/10841#issuecomment-889986428 Revision: 8c6073efab365dde7b6a373c0a13019992a3023a Submitted crossbow builds: [ursacomputing/crossbow @ actions-679](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow] emkornfield commented on a change in pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

2021-07-30 Thread GitBox
emkornfield commented on a change in pull request #10716: URL: https://github.com/apache/arrow/pull/10716#discussion_r680034150 ## File path: go/parquet/internal/encoding/levels.go ## @@ -0,0 +1,284 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

[GitHub] [arrow] nealrichardson commented on pull request #10840: ARROW-13496: [CI][R] Repair r-sanitizer job

2021-07-30 Thread GitBox
nealrichardson commented on pull request #10840: URL: https://github.com/apache/arrow/pull/10840#issuecomment-889987032 As best I can tell, it's not that the job is timing out, it's that the job is running without printing anything to stdout for too long (this is what Travis CI would do).

[GitHub] [arrow] zeroshade commented on a change in pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

2021-07-30 Thread GitBox
zeroshade commented on a change in pull request #10716: URL: https://github.com/apache/arrow/pull/10716#discussion_r680037198 ## File path: go/parquet/internal/encoding/levels.go ## @@ -0,0 +1,284 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more con

[GitHub] [arrow-datafusion] jhorstmann commented on pull request #793: Produce correct answers for Group BY NULL (Option 1)

2021-07-30 Thread GitBox
jhorstmann commented on pull request #793: URL: https://github.com/apache/arrow-datafusion/pull/793#issuecomment-889992552 Looks good. I was trying to come up with an example where two distinct keys would end up as the same encoding but could not find any because any variable length types

[GitHub] [arrow] diegodfrf opened a new pull request #10842: ARROW-13469: [C++] Suppress -Wmissing-field-initializers in DayMilliseconds arrow/type.h

2021-07-30 Thread GitBox
diegodfrf opened a new pull request #10842: URL: https://github.com/apache/arrow/pull/10842 Set initial values to DayMilliseconds with 0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [arrow] github-actions[bot] commented on pull request #10842: ARROW-13469: [C++] Suppress -Wmissing-field-initializers in DayMilliseconds arrow/type.h

2021-07-30 Thread GitBox
github-actions[bot] commented on pull request #10842: URL: https://github.com/apache/arrow/pull/10842#issuecomment-89320 https://issues.apache.org/jira/browse/ARROW-13469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] thisisnic commented on pull request #10841: ARROW-13511: [CI][R] Fail in the docker build step if R deps don't install

2021-07-30 Thread GitBox
thisisnic commented on pull request #10841: URL: https://github.com/apache/arrow/pull/10841#issuecomment-890009339 I think building the things in `Suggests` has led to the build rebuilding the markdown content, which then causes it to fail due to other dependencies in the vignettes. --

[GitHub] [arrow] zeroshade commented on a change in pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

2021-07-30 Thread GitBox
zeroshade commented on a change in pull request #10716: URL: https://github.com/apache/arrow/pull/10716#discussion_r680074956 ## File path: go/parquet/internal/encoding/levels.go ## @@ -0,0 +1,284 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more con

[GitHub] [arrow] zeroshade commented on a change in pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

2021-07-30 Thread GitBox
zeroshade commented on a change in pull request #10716: URL: https://github.com/apache/arrow/pull/10716#discussion_r680075490 ## File path: go/parquet/internal/encoding/levels.go ## @@ -0,0 +1,284 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more con

[GitHub] [arrow] thisisnic edited a comment on pull request #10841: ARROW-13511: [CI][R] Fail in the docker build step if R deps don't install

2021-07-30 Thread GitBox
thisisnic edited a comment on pull request #10841: URL: https://github.com/apache/arrow/pull/10841#issuecomment-890009339 I think building the things in `Suggests` has led to the build rebuilding the markdown content, which then causes `test-r-without-arrow` to fail due to other dependenci

[GitHub] [arrow] nealrichardson commented on pull request #10841: ARROW-13511: [CI][R] Fail in the docker build step if R deps don't install

2021-07-30 Thread GitBox
nealrichardson commented on pull request #10841: URL: https://github.com/apache/arrow/pull/10841#issuecomment-890013534 > I think building the things in `Suggests` has led to the build rebuilding the markdown content, which then causes `test-r-without-arrow` to fail due to other dependenci

[GitHub] [arrow] thisisnic commented on pull request #10841: ARROW-13511: [CI][R] Fail in the docker build step if R deps don't install

2021-07-30 Thread GitBox
thisisnic commented on pull request #10841: URL: https://github.com/apache/arrow/pull/10841#issuecomment-890014347 > > I think building the things in `Suggests` has led to the build rebuilding the markdown content, which then causes `test-r-without-arrow` to fail due to other dependencies

[GitHub] [arrow] dongjoon-hyun commented on pull request #10838: ARROW-13506: [C++][Java] Upgrade ORC to 1.6.9

2021-07-30 Thread GitBox
dongjoon-hyun commented on pull request #10838: URL: https://github.com/apache/arrow/pull/10838#issuecomment-890016415 Thank you for your approval, @kiszk . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow] nealrichardson commented on pull request #10833: ARROW-13493 [C++] Anonymous structs in an anonymous union are a GNU extension

2021-07-30 Thread GitBox
nealrichardson commented on pull request #10833: URL: https://github.com/apache/arrow/pull/10833#issuecomment-890020555 Looks like you fixed one warning but there's still another: https://github.com/ursacomputing/crossbow/runs/3203443397?check_suite_focus=true#step:7:192 -- This is an au

[GitHub] [arrow] dongjoon-hyun commented on pull request #10838: ARROW-13506: [C++][Java] Upgrade ORC to 1.6.9

2021-07-30 Thread GitBox
dongjoon-hyun commented on pull request #10838: URL: https://github.com/apache/arrow/pull/10838#issuecomment-890020627 Thank you for your review and approval, @sunchao ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] kiszk commented on pull request #10838: ARROW-13506: [C++][Java] Upgrade ORC to 1.6.9

2021-07-30 Thread GitBox
kiszk commented on pull request #10838: URL: https://github.com/apache/arrow/pull/10838#issuecomment-890023623 cc @emkornfield and @pitrou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] rommelDB opened a new pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
rommelDB opened a new pull request #10843: URL: https://github.com/apache/arrow/pull/10843 Changes: - Added support for decimal128 and decimal256 json converted. - Added unit tests for converting decimal128 and decimal256. (Note: This is not providing inferring support) -- This is

[GitHub] [arrow] github-actions[bot] commented on pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
github-actions[bot] commented on pull request #10843: URL: https://github.com/apache/arrow/pull/10843#issuecomment-890023863 https://issues.apache.org/jira/browse/ARROW-4700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] rommelDB commented on pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
rommelDB commented on pull request #10843: URL: https://github.com/apache/arrow/pull/10843#issuecomment-890024085 Please take it a look @bkietz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow] emkornfield commented on pull request #10838: ARROW-13506: [C++][Java] Upgrade ORC to 1.6.9

2021-07-30 Thread GitBox
emkornfield commented on pull request #10838: URL: https://github.com/apache/arrow/pull/10838#issuecomment-890026317 As long as CI is passing LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [arrow] domoritz closed pull request #10825: MINOR: [JS] Correct main package description in readme

2021-07-30 Thread GitBox
domoritz closed pull request #10825: URL: https://github.com/apache/arrow/pull/10825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] domoritz closed pull request #10826: ARROW-12636: [JS] ESM Tree-Shaking produces broken code

2021-07-30 Thread GitBox
domoritz closed pull request #10826: URL: https://github.com/apache/arrow/pull/10826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] dongjoon-hyun commented on pull request #10838: ARROW-13506: [C++][Java] Upgrade ORC to 1.6.9

2021-07-30 Thread GitBox
dongjoon-hyun commented on pull request #10838: URL: https://github.com/apache/arrow/pull/10838#issuecomment-890027866 Thank you, @emkornfield . Yes, all CIs passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow-datafusion] alamb commented on pull request #793: Produce correct answers for Group BY NULL (Option 1)

2021-07-30 Thread GitBox
alamb commented on pull request #793: URL: https://github.com/apache/arrow-datafusion/pull/793#issuecomment-890031194 Thanks for the reviews @Dandandan and @jhorstmann ! I plan to wait another day or two to see if anyone else has feedback on this approach, but what I am thinking of doing

[GitHub] [arrow] sunchao closed pull request #10838: ARROW-13506: [C++][Java] Upgrade ORC to 1.6.9

2021-07-30 Thread GitBox
sunchao closed pull request #10838: URL: https://github.com/apache/arrow/pull/10838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [arrow] nealrichardson commented on pull request #10841: ARROW-13511: [CI][R] Fail in the docker build step if R deps don't install

2021-07-30 Thread GitBox
nealrichardson commented on pull request #10841: URL: https://github.com/apache/arrow/pull/10841#issuecomment-890037738 > > > I think building the things in `Suggests` has led to the build rebuilding the markdown content, which then causes `test-r-without-arrow` to fail due to other depend

[GitHub] [arrow] sunchao commented on pull request #10838: ARROW-13506: [C++][Java] Upgrade ORC to 1.6.9

2021-07-30 Thread GitBox
sunchao commented on pull request #10838: URL: https://github.com/apache/arrow/pull/10838#issuecomment-890039107 Merged! @emkornfield could you add @dongjoon-hyun to the Arrow contributor list and assign the JIRA to him? thanks! -- This is an automated message from the Apache Git Service

[GitHub] [arrow] ElenaHenderson commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables

2021-07-30 Thread GitBox
ElenaHenderson commented on a change in pull request #10667: URL: https://github.com/apache/arrow/pull/10667#discussion_r680105559 ## File path: dev/conbench_envs/README.md ## @@ -0,0 +1,30 @@ + +## Benchmark Builds Env +This directory contains +- [benchmarks.env](../../dev/co

[GitHub] [arrow] ElenaHenderson commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables

2021-07-30 Thread GitBox
ElenaHenderson commented on a change in pull request #10667: URL: https://github.com/apache/arrow/pull/10667#discussion_r680105559 ## File path: dev/conbench_envs/README.md ## @@ -0,0 +1,30 @@ + +## Benchmark Builds Env +This directory contains +- [benchmarks.env](../../dev/co

[GitHub] [arrow] dongjoon-hyun commented on pull request #10838: ARROW-13506: [C++][Java] Upgrade ORC to 1.6.9

2021-07-30 Thread GitBox
dongjoon-hyun commented on pull request #10838: URL: https://github.com/apache/arrow/pull/10838#issuecomment-890044598 Thank you so much, @sunchao , @kiszk , @emkornfield ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow-datafusion] andygrove merged pull request #789: Implement streaming versions of Dataframe.collect methods

2021-07-30 Thread GitBox
andygrove merged pull request #789: URL: https://github.com/apache/arrow-datafusion/pull/789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: githu

[GitHub] [arrow-datafusion] andygrove closed issue #47: DataFrame.collect() should return async stream rather than a Vec

2021-07-30 Thread GitBox
andygrove closed issue #47: URL: https://github.com/apache/arrow-datafusion/issues/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-datafusion] alamb commented on pull request #786: Remove GroupByScalar and use ScalarValue in preparation for supporting null values in GroupBy

2021-07-30 Thread GitBox
alamb commented on pull request #786: URL: https://github.com/apache/arrow-datafusion/pull/786#issuecomment-890050571 This one seems like an incremental change towards #790 so I am going to merge this in and rebase 790 so the changes are clearer. -- This is an automated message from the

[GitHub] [arrow-datafusion] alamb merged pull request #786: Remove GroupByScalar and use ScalarValue in preparation for supporting null values in GroupBy

2021-07-30 Thread GitBox
alamb merged pull request #786: URL: https://github.com/apache/arrow-datafusion/pull/786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-un

[GitHub] [arrow-datafusion] alamb closed issue #376: Combine GroupByScalar and ScalarValue

2021-07-30 Thread GitBox
alamb closed issue #376: URL: https://github.com/apache/arrow-datafusion/issues/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [arrow-datafusion] alamb edited a comment on pull request #786: Remove GroupByScalar and use ScalarValue in preparation for supporting null values in GroupBy

2021-07-30 Thread GitBox
alamb edited a comment on pull request #786: URL: https://github.com/apache/arrow-datafusion/pull/786#issuecomment-890050571 This one seems like an incremental change towards #790 so I am going to merge this in and rebase 790 so the changes are in that PR are smaller. -- This is an auto

[GitHub] [arrow-datafusion] alamb commented on pull request #793: Produce correct answers for Group BY NULL (Option 1)

2021-07-30 Thread GitBox
alamb commented on pull request #793: URL: https://github.com/apache/arrow-datafusion/pull/793#issuecomment-890051505 Rebased given that https://github.com/apache/arrow-datafusion/pull/786 is merged, so that this PR just shows the delta now -- This is an automated message from the Apache

[GitHub] [arrow] bkietz commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables

2021-07-30 Thread GitBox
bkietz commented on a change in pull request #10667: URL: https://github.com/apache/arrow/pull/10667#discussion_r679945382 ## File path: dev/conbench_envs/README.md ## @@ -0,0 +1,209 @@ + +# Benchmark Builds Env and Hooks +This directory contains: +- [benchmarks.env](benchmark

[GitHub] [arrow] rommelDB edited a comment on pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
rommelDB edited a comment on pull request #10843: URL: https://github.com/apache/arrow/pull/10843#issuecomment-890024085 Please, take a look at it @bkietz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #793: Produce correct answers for Group BY NULL (Option 1)

2021-07-30 Thread GitBox
Dandandan commented on a change in pull request #793: URL: https://github.com/apache/arrow-datafusion/pull/793#discussion_r680125826 ## File path: datafusion/src/physical_plan/hash_aggregate.rs ## @@ -508,7 +511,9 @@ fn dictionary_create_key_for_col( } /// Appends a sequenc

[GitHub] [arrow] felipeblazing commented on a change in pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
felipeblazing commented on a change in pull request #10843: URL: https://github.com/apache/arrow/pull/10843#discussion_r680124458 ## File path: cpp/src/arrow/json/converter_test.cc ## @@ -96,5 +96,27 @@ TEST(ConverterTest, Timestamp) { AssertConvert(timestamp(TimeUnit::SECON

[GitHub] [arrow-datafusion] andygrove commented on issue #771: Release a new version of DataFusion to crates.io

2021-07-30 Thread GitBox
andygrove commented on issue #771: URL: https://github.com/apache/arrow-datafusion/issues/771#issuecomment-890059076 Ballista is now at a point where it supports the TPC-H queries with reasonable performance and I am now working on improving the developer documentation and the user gu

[GitHub] [arrow] felipeblazing commented on a change in pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
felipeblazing commented on a change in pull request #10843: URL: https://github.com/apache/arrow/pull/10843#discussion_r680127350 ## File path: cpp/src/arrow/json/converter_test.cc ## @@ -96,5 +96,27 @@ TEST(ConverterTest, Timestamp) { AssertConvert(timestamp(TimeUnit::SECON

[GitHub] [arrow] felipeblazing commented on a change in pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
felipeblazing commented on a change in pull request #10843: URL: https://github.com/apache/arrow/pull/10843#discussion_r680128199 ## File path: cpp/src/arrow/json/converter.cc ## @@ -147,6 +149,41 @@ class NumericConverter : public PrimitiveConverter { const T& numeric_type_

[GitHub] [arrow] felipeblazing commented on a change in pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
felipeblazing commented on a change in pull request #10843: URL: https://github.com/apache/arrow/pull/10843#discussion_r680128769 ## File path: cpp/src/arrow/json/converter.cc ## @@ -147,6 +149,41 @@ class NumericConverter : public PrimitiveConverter { const T& numeric_type_

[GitHub] [arrow] ElenaHenderson commented on a change in pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables

2021-07-30 Thread GitBox
ElenaHenderson commented on a change in pull request #10667: URL: https://github.com/apache/arrow/pull/10667#discussion_r680129299 ## File path: dev/conbench_envs/README.md ## @@ -0,0 +1,30 @@ + +## Benchmark Builds Env +This directory contains +- [benchmarks.env](../../dev/co

[GitHub] [arrow] rommelDB commented on a change in pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
rommelDB commented on a change in pull request #10843: URL: https://github.com/apache/arrow/pull/10843#discussion_r680131459 ## File path: cpp/src/arrow/json/converter_test.cc ## @@ -96,5 +96,27 @@ TEST(ConverterTest, Timestamp) { AssertConvert(timestamp(TimeUnit::SECOND), s

[GitHub] [arrow] rommelDB commented on a change in pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
rommelDB commented on a change in pull request #10843: URL: https://github.com/apache/arrow/pull/10843#discussion_r680139090 ## File path: cpp/src/arrow/json/converter.cc ## @@ -147,6 +149,41 @@ class NumericConverter : public PrimitiveConverter { const T& numeric_type_; };

[GitHub] [arrow] rommelDB commented on a change in pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
rommelDB commented on a change in pull request #10843: URL: https://github.com/apache/arrow/pull/10843#discussion_r680140494 ## File path: cpp/src/arrow/json/converter.cc ## @@ -147,6 +149,41 @@ class NumericConverter : public PrimitiveConverter { const T& numeric_type_; };

[GitHub] [arrow] bkietz commented on pull request #10722: ARROW-13344: [R] Initial bindings for ExecPlan/ExecNode

2021-07-30 Thread GitBox
bkietz commented on pull request #10722: URL: https://github.com/apache/arrow/pull/10722#issuecomment-890076863 > -MakeScalarAggregateNode and MakeGroupByNode have quite different function signatures, which makes working with the API confusing > -GroupBy doesn't let you specify t

[GitHub] [arrow] nirandaperera commented on pull request #10833: ARROW-13493 [C++] Anonymous structs in an anonymous union are a GNU extension

2021-07-30 Thread GitBox
nirandaperera commented on pull request #10833: URL: https://github.com/apache/arrow/pull/10833#issuecomment-890089863 @github-actions crossbow submit test-r-linux-as-cran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] github-actions[bot] commented on pull request #10833: ARROW-13493 [C++] Anonymous structs in an anonymous union are a GNU extension

2021-07-30 Thread GitBox
github-actions[bot] commented on pull request #10833: URL: https://github.com/apache/arrow/pull/10833#issuecomment-890090342 Revision: 85fc16174a3acfecf24bd505aad5bbda69833111 Submitted crossbow builds: [ursacomputing/crossbow @ actions-680](https://github.com/ursacomputing/crossbow/

[GitHub] [arrow-rs] alamb commented on issue #640: Release candidate verifying script seems work on macOS

2021-07-30 Thread GitBox
alamb commented on issue #640: URL: https://github.com/apache/arrow-rs/issues/640#issuecomment-890099715 @waynexia i also run the verification script on mac without issue I think the comment is outdated -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] rommelDB commented on a change in pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
rommelDB commented on a change in pull request #10843: URL: https://github.com/apache/arrow/pull/10843#discussion_r680131459 ## File path: cpp/src/arrow/json/converter_test.cc ## @@ -96,5 +96,27 @@ TEST(ConverterTest, Timestamp) { AssertConvert(timestamp(TimeUnit::SECOND), s

[GitHub] [arrow] pi-guy-in-the-sky opened a new issue #10844: Getting an `std::istream` from an `arrow::io::InputStream`

2021-07-30 Thread GitBox
pi-guy-in-the-sky opened a new issue #10844: URL: https://github.com/apache/arrow/issues/10844 I'm currently working on a tool in C++ which needs to fetch data from an S3 bucket. Calling `arrow::fs::S3FileSystem::OpenInputStream` allows me to get an `arrow::io::InputStream` that can read f

[GitHub] [arrow-rs] alamb commented on issue #640: Release candidate verifying script seems work on macOS

2021-07-30 Thread GitBox
alamb commented on issue #640: URL: https://github.com/apache/arrow-rs/issues/640#issuecomment-890101254 FWIW the question label already exists (I added it to this issue). It isn't clear to me if everyone can add labels to issues in arrow-rs. Does it work for you @waynexia ? Perhaps

[GitHub] [arrow-rs] alamb opened a new issue #641: Incorrect min/max statistics for strings in parquet files

2021-07-30 Thread GitBox
alamb opened a new issue #641: URL: https://github.com/apache/arrow-rs/issues/641 **Describe the bug** The statistics written by the arrow / parquet writer for String columns seem to be incorrect. **To Reproduce** Run this code: ```rust fn main() { let inp

[GitHub] [arrow-rs] Dandandan merged pull request #637: Speed up filter_record_batch with one array

2021-07-30 Thread GitBox
Dandandan merged pull request #637: URL: https://github.com/apache/arrow-rs/pull/637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow-rs] Dandandan closed issue #636: Avoid materialization of indices in filter_record_batch for single arrays

2021-07-30 Thread GitBox
Dandandan closed issue #636: URL: https://github.com/apache/arrow-rs/issues/636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #793: Produce correct answers for Group BY NULL (Option 1)

2021-07-30 Thread GitBox
alamb commented on a change in pull request #793: URL: https://github.com/apache/arrow-datafusion/pull/793#discussion_r680188332 ## File path: datafusion/src/physical_plan/hash_aggregate.rs ## @@ -644,14 +645,63 @@ fn create_key_for_col(col: &ArrayRef, row: usize, vec: &mut Ve

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #793: Produce correct answers for Group BY NULL (Option 1)

2021-07-30 Thread GitBox
alamb commented on a change in pull request #793: URL: https://github.com/apache/arrow-datafusion/pull/793#discussion_r680188812 ## File path: datafusion/src/scalar.rs ## @@ -1347,6 +1545,29 @@ mod tests { "{}", result); } +#[test] +fn scalar_try

[GitHub] [arrow] nirandaperera commented on pull request #10833: ARROW-13493 [C++] Anonymous structs in an anonymous union are a GNU extension

2021-07-30 Thread GitBox
nirandaperera commented on pull request #10833: URL: https://github.com/apache/arrow/pull/10833#issuecomment-890123629 @nealrichardson I think this is fine now! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] nirandaperera opened a new pull request #10845: ARROW-13268 [C++][Compute] Add ExecNode for semi and anti-semi join

2021-07-30 Thread GitBox
nirandaperera opened a new pull request #10845: URL: https://github.com/apache/arrow/pull/10845 Adding prelim impl of semi joins -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [arrow] github-actions[bot] commented on pull request #10845: ARROW-13268 [C++][Compute] Add ExecNode for semi and anti-semi join

2021-07-30 Thread GitBox
github-actions[bot] commented on pull request #10845: URL: https://github.com/apache/arrow/pull/10845#issuecomment-890126576 https://issues.apache.org/jira/browse/ARROW-13268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #628: Add a note about arrow crate security / safety

2021-07-30 Thread GitBox
codecov-commenter edited a comment on pull request #628: URL: https://github.com/apache/arrow-rs/pull/628#issuecomment-888530892 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/628?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #792: Implement basic common subexpression eliminate optimization

2021-07-30 Thread GitBox
alamb commented on a change in pull request #792: URL: https://github.com/apache/arrow-datafusion/pull/792#discussion_r680194021 ## File path: datafusion/src/execution/context.rs ## @@ -691,6 +693,7 @@ impl Default for ExecutionConfig { Arc::new(SimplifyExpress

[GitHub] [arrow] bkietz closed pull request #10667: ARROW-11691: [Developer][CI] Provide a consolidated .env file for benchmark-relevant environment variables

2021-07-30 Thread GitBox
bkietz closed pull request #10667: URL: https://github.com/apache/arrow/pull/10667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] westonpace commented on a change in pull request #10802: ARROW-1568: [C++] Implement Drop Null Kernel for Arrays

2021-07-30 Thread GitBox
westonpace commented on a change in pull request #10802: URL: https://github.com/apache/arrow/pull/10802#discussion_r680168763 ## File path: cpp/src/arrow/compute/kernels/vector_selection.cc ## @@ -1988,7 +1989,7 @@ class FilterMetaFunction : public MetaFunction { Result> Ta

[GitHub] [arrow] bkietz commented on a change in pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted

2021-07-30 Thread GitBox
bkietz commented on a change in pull request #10843: URL: https://github.com/apache/arrow/pull/10843#discussion_r680213131 ## File path: cpp/src/arrow/json/parser.cc ## @@ -102,6 +102,8 @@ Status Kind::ForType(const DataType& type, Kind::type* kind) { Status Visit(const T

[GitHub] [arrow] kou commented on pull request #10836: ARROW-13503: [GLib][Ruby][Flight] Add support for DoGet

2021-07-30 Thread GitBox
kou commented on pull request #10836: URL: https://github.com/apache/arrow/pull/10836#issuecomment-890149852 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [arrow] kou closed pull request #10836: ARROW-13503: [GLib][Ruby][Flight] Add support for DoGet

2021-07-30 Thread GitBox
kou closed pull request #10836: URL: https://github.com/apache/arrow/pull/10836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow] gcca opened a new pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo

2021-07-30 Thread GitBox
gcca opened a new pull request #10846: URL: https://github.com/apache/arrow/pull/10846 Add the super-scalar variant to set a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [arrow] github-actions[bot] commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo

2021-07-30 Thread GitBox
github-actions[bot] commented on pull request #10846: URL: https://github.com/apache/arrow/pull/10846#issuecomment-890159961 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you ope

[GitHub] [arrow-datafusion] Dandandan opened a new pull request #796: Unsupported conditions in join

2021-07-30 Thread GitBox
Dandandan opened a new pull request #796: URL: https://github.com/apache/arrow-datafusion/pull/796 # Which issue does this PR close? Closes #. # Rationale for this change Move more unsupported conditions in LEFT join to filters. This is needed to get TPC-

  1   2   3   4   5   6   7   8   9   10   >