Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635651096 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635649445 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/OrderedListUserStateTest.java: ## @@ -0,0 +1,684 @@ +/* + * Licensed to the Apache Software

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635648194 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635648194 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635648194 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635635564 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635634072 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635633838 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/OrderedListUserStateTest.java: ## @@ -0,0 +1,684 @@ +/* + * Licensed to the Apache Software

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635632473 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java: ## @@ -600,8 +603,73 @@ public MultimapState bindMultimap( @Override

Re: [PR] Implement ordered list state for FnApi. [beam]

robertwb commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635491282 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java: ## @@ -600,8 +603,73 @@ public MultimapState bindMultimap( @Override

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635439785 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -143,34 +178,162 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635440867 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -143,34 +178,162 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635438022 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635436800 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/OrderedListUserStateTest.java: ## @@ -0,0 +1,645 @@ +/* + * Licensed to the Apache Software

Re: [PR] Implement ordered list state for FnApi. [beam]

codecov[bot] commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-2161543813 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30317?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635410223 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/OrderedListUserStateTest.java: ## @@ -0,0 +1,645 @@ +/* + * Licensed to the Apache Software

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635404668 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635392078 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635356930 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635356930 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635338022 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635259343 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -143,34 +178,162 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635230664 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -97,6 +111,27 @@ public FakeBeamFnStateClient(Map, List>>

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635212828 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635207877 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635202567 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -47,6 +60,7 @@ public class FakeBeamFnStateClient implements

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635202567 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -47,6 +60,7 @@ public class FakeBeamFnStateClient implements

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635202567 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -47,6 +60,7 @@ public class FakeBeamFnStateClient implements

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635196121 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635187117 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635182620 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635176273 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -97,6 +111,27 @@ public FakeBeamFnStateClient(Map, List>>

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635173937 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -47,6 +60,7 @@ public class FakeBeamFnStateClient implements

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635173186 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -47,6 +60,7 @@ public class FakeBeamFnStateClient implements

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635154541 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -143,34 +178,162 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635146802 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1635143775 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -143,34 +178,162 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1631817010 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## Review Comment: Done. -- This is an automated message from

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1630509604 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1630509410 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/OrderedListUserStateTest.java: ## @@ -0,0 +1,597 @@ +/* + * Licensed to the Apache Software

Re: [PR] Implement ordered list state for FnApi. [beam]

github-actions[bot] commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-2112557161 Stopping reviewer notifications for this pull request: requested by reviewer -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-2112554061 stop reviewer notifications -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Implement ordered list state for FnApi. [beam]

github-actions[bot] commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-2112367951 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R:

Re: [PR] Implement ordered list state for FnApi. [beam]

github-actions[bot] commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-2105726584 Reminder, please take a look at this pr: @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1588300082 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1588300082 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1588140845 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/OrderedListUserStateTest.java: ## @@ -0,0 +1,597 @@ +/* + * Licensed to the Apache Software

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1588027273 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## Review Comment: Yes. I think we will need a separate one for

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1588027273 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## Review Comment: Yes. I think we will need a separate one for

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1588084688 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1588080541 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/OrderedListUserStateTest.java: ## @@ -0,0 +1,597 @@ +/* + * Licensed to the Apache Software

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1588027273 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## Review Comment: Yes. I think we will need a separate one for

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1587995856 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1587995856 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1587899863 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1587892941 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +1103,12 @@ message StateClearRequest {} // A response to

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1587889713 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java: ## @@ -600,8 +603,74 @@ public MultimapState bindMultimap( @Override

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1587688898 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] Implement ordered list state for FnApi. [beam]

Abacn commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-2034822148 waiting on author -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Implement ordered list state for FnApi. [beam]

github-actions[bot] commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-2034415747 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for

Re: [PR] Implement ordered list state for FnApi. [beam]

github-actions[bot] commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-2027168571 Reminder, please take a look at this pr: @kennknowles -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Implement ordered list state for FnApi. [beam]

github-actions[bot] commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-2014951449 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R:

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1531296538 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## Review Comment: Or are we going to piggy-back on multimap for

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1531294554 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## Review Comment: Do we also need to add something here:

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1529368187 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/OrderedListUserStateTest.java: ## @@ -0,0 +1,597 @@ +/* + * Licensed to the Apache Software

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1529360968 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/OrderedListUserStateTest.java: ## @@ -0,0 +1,597 @@ +/* + * Licensed to the Apache Software

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1529334529 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1529329576 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1529328943 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1529318766 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1529260758 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/OrderedListUserState.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1529260242 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +1103,12 @@ message StateClearRequest {} // A response to

Re: [PR] Implement ordered list state for FnApi. [beam]

acrites commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1529258289 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java: ## @@ -600,8 +603,74 @@ public MultimapState bindMultimap( @Override

Re: [PR] Implement ordered list state for FnApi. [beam]

robertwb commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1526756757 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] Implement ordered list state for FnApi. [beam]

github-actions[bot] commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-1997307049 Reminder, please take a look at this pr: @robertwb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-1981758955 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Implement ordered list state for FnApi. [beam]

github-actions[bot] commented on PR #30317: URL: https://github.com/apache/beam/pull/30317#issuecomment-1981431117 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @robertwb for label java. Available commands: - `stop

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1511829304 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1021,6 +1033,29 @@ message StateKey { bytes map_key = 5; }

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1511828608 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +,42 @@ message StateClearRequest {} // A response to

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1511828177 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java: ## @@ -169,6 +172,7 @@ public ResultT get() { } @Override +

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1511827360 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -174,6 +215,124 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

robertwb commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1501142124 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +,42 @@ message StateClearRequest {} // A response to

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500882918 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -174,6 +215,124 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500882918 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -174,6 +215,124 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500882918 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -174,6 +215,124 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500882918 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -174,6 +215,124 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500882918 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -174,6 +215,124 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500878413 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +,42 @@ message StateClearRequest {} // A response to

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500872501 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +,42 @@ message StateClearRequest {} // A response to

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500872501 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +,42 @@ message StateClearRequest {} // A response to

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500872501 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +,42 @@ message StateClearRequest {} // A response to

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500872501 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +,42 @@ message StateClearRequest {} // A response to

Re: [PR] Implement ordered list state for FnApi. [beam]

kennknowles commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500851162 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +,42 @@ message StateClearRequest {} // A response

Re: [PR] Implement ordered list state for FnApi. [beam]

kennknowles commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500844153 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +,42 @@ message StateClearRequest {} // A response

Re: [PR] Implement ordered list state for FnApi. [beam]

kennknowles commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1500839373 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +,42 @@ message StateClearRequest {} // A response

Re: [PR] Implement ordered list state for FnApi. [beam]

robertwb commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1498139008 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1075,6 +,42 @@ message StateClearRequest {} // A response to

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1498124213 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -174,6 +215,124 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

robertwb commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1498123563 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -174,6 +215,124 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

robertwb commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1498119280 ## sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/FakeBeamFnStateClient.java: ## @@ -174,6 +215,124 @@ public CompletableFuture

Re: [PR] Implement ordered list state for FnApi. [beam]

shunping commented on code in PR #30317: URL: https://github.com/apache/beam/pull/30317#discussion_r1498118154 ## sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java: ## @@ -169,6 +172,7 @@ public ResultT get() { } @Override +

  1   2   >