[GitHub] [beam] mxm commented on pull request #11997: [BEAM-10249] Populate state cache with initial values before appending

2020-06-12 Thread GitBox
mxm commented on pull request #11997: URL: https://github.com/apache/beam/pull/11997#issuecomment-643192851 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] mxm opened a new pull request #11997: [BEAM-10249] Populate state cache with initial values before appending

2020-06-12 Thread GitBox
mxm opened a new pull request #11997: URL: https://github.com/apache/beam/pull/11997 When new values are added to a bag state, the cache handler in the Python SDK does not check whether the underlying state already has values present. Although the append operation will be sent to the

[GitHub] [beam] stale[bot] closed pull request #9899: [BEAM-8511] [WIP] KinesisIO.Read enhanced fanout

2020-06-12 Thread GitBox
stale[bot] closed pull request #9899: URL: https://github.com/apache/beam/pull/9899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] stale[bot] commented on pull request #9899: [BEAM-8511] [WIP] KinesisIO.Read enhanced fanout

2020-06-12 Thread GitBox
stale[bot] commented on pull request #9899: URL: https://github.com/apache/beam/pull/9899#issuecomment-643106066 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

[GitHub] [beam] mxm commented on pull request #11997: [BEAM-10249] Populate state cache with initial values before appending

2020-06-12 Thread GitBox
mxm commented on pull request #11997: URL: https://github.com/apache/beam/pull/11997#issuecomment-643196692 Failures are unrelated to this change. ``` 12:15:27 import rsa 12:15:27 File

[GitHub] [beam] mxm commented on pull request #11997: [BEAM-10249] Populate state cache with initial values before appending

2020-06-12 Thread GitBox
mxm commented on pull request #11997: URL: https://github.com/apache/beam/pull/11997#issuecomment-643229960 Also Dataflow tests are failing (unrelated): ``` 12:46:05 1: Task failed with an exception. 12:46:05 --- 12:46:05 * Where: 12:46:05 Script

[GitHub] [beam] rm3l edited a comment on pull request #9721: [BEAM-8344] Add inferSchema support in ParquetIO and refactor ParquetTableProvider

2020-06-12 Thread GitBox
rm3l edited a comment on pull request #9721: URL: https://github.com/apache/beam/pull/9721#issuecomment-643280275 Hi there! May I ask if there is any progress on this PR? I first thought this was already merged before realizing that it was auto-closed due to lack of activity. I would

[GitHub] [beam] pulasthi commented on pull request #10888: [BEAM-7304] Twister2 Beam runner

2020-06-12 Thread GitBox
pulasthi commented on pull request #10888: URL: https://github.com/apache/beam/pull/10888#issuecomment-643296314 @iemejia I got the CCLA document from the university and sent to secret...@apache.org and priv...@beam.apache.org, I did not get an ack back yet, Do i need to attach the

[GitHub] [beam] pskevin opened a new pull request #11999: [BEAM-7163] Correcting godoc for passert.Sum

2020-06-12 Thread GitBox
pskevin opened a new pull request #11999: URL: https://github.com/apache/beam/pull/11999 Updating the godoc to reflect actual behavior of `passert.Sum`. It works with `PCollections` (singleton and otherwise) by checking that the sum and count of element(s) are as supplied to by by the

[GitHub] [beam] pskevin commented on pull request #11999: [BEAM-7163] Correcting godoc for passert.Sum

2020-06-12 Thread GitBox
pskevin commented on pull request #11999: URL: https://github.com/apache/beam/pull/11999#issuecomment-643330892 R: @lostluck This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] lastomato commented on pull request #11969: Remove a hack used to retrieve schematized data from HL7v2 messages, …

2020-06-12 Thread GitBox
lastomato commented on pull request #11969: URL: https://github.com/apache/beam/pull/11969#issuecomment-643292858 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lazylynx commented on a change in pull request #11970: [BEAM-7672] add cp37 wheel to acceptableWhlSpecs

2020-06-12 Thread GitBox
lazylynx commented on a change in pull request #11970: URL: https://github.com/apache/beam/pull/11970#discussion_r439450278 ## File path: sdks/python/container/boot.go ## @@ -38,7 +38,7 @@ import ( ) var ( - acceptableWhlSpecs =

[GitHub] [beam] reubenvanammers commented on pull request #11955: [BEAM-10220] add support for implicit nulls for converting between beam rows and json

2020-06-12 Thread GitBox
reubenvanammers commented on pull request #11955: URL: https://github.com/apache/beam/pull/11955#issuecomment-643277304 Cool, I'll look at integrating the stuff implicit null support with the deadletter stuff in JsonToRow after this PR.

[GitHub] [beam] sabhyankar commented on pull request #11998: [BEAM-10250]: Update io_matrix with new SplunkIO

2020-06-12 Thread GitBox
sabhyankar commented on pull request #11998: URL: https://github.com/apache/beam/pull/11998#issuecomment-643295577 R: @pabloem This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] sabhyankar opened a new pull request #11998: [BEAM-10250]: Update io_matrix with new SplunkIO

2020-06-12 Thread GitBox
sabhyankar opened a new pull request #11998: URL: https://github.com/apache/beam/pull/11998 Updating the io_matrix with the new SplunkIO transform that was added via: [PR-11950](https://github.com/apache/beam/pull/11950) Thank you for your

[GitHub] [beam] damondouglas commented on a change in pull request #11979: [BEAM-9679] Add Partition task to Core Transform katas

2020-06-12 Thread GitBox
damondouglas commented on a change in pull request #11979: URL: https://github.com/apache/beam/pull/11979#discussion_r439471700 ## File path: learning/katas/go/Core Transforms/Partition/Partition/go.mod ## @@ -0,0 +1,27 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [beam] rm3l commented on pull request #9721: [BEAM-8344] Add inferSchema support in ParquetIO and refactor ParquetTableProvider

2020-06-12 Thread GitBox
rm3l commented on pull request #9721: URL: https://github.com/apache/beam/pull/9721#issuecomment-643280275 Hi there! May I ask if there any progress on this issue? I first thought this was already merged before realizing that it was auto-closed due to lack of activity. I would be

[GitHub] [beam] tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
tvalentyn commented on a change in pull request #11086: URL: https://github.com/apache/beam/pull/11086#discussion_r439510486 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -45,8 +45,8 @@ may use some caching techniques to share the side inputs between calls in

[GitHub] [beam] tvalentyn commented on pull request #11970: [BEAM-7672] add cp37 wheel to acceptableWhlSpecs

2020-06-12 Thread GitBox
tvalentyn commented on pull request #11970: URL: https://github.com/apache/beam/pull/11970#issuecomment-643374545 LGTM. This improves the situation, however, as I mentioned it would be more reliable to check the python version.

[GitHub] [beam] tvalentyn commented on pull request #11970: [BEAM-7672] add cp37 wheel to acceptableWhlSpecs

2020-06-12 Thread GitBox
tvalentyn commented on pull request #11970: URL: https://github.com/apache/beam/pull/11970#issuecomment-643374850 Run Python Dataflow ValidatesContainer This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-12 Thread GitBox
aromanenko-dev commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r439565391 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the

[GitHub] [beam] acrites opened a new pull request #12003: [BEAM-10244] Adds transform id to TestStream step

2020-06-12 Thread GitBox
acrites opened a new pull request #12003: URL: https://github.com/apache/beam/pull/12003 This is done for the Dataflow runner for both Python and Java. We need the transform id so we can look up relevant info (like environment) in the pipeline proto. @lukecwik

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-12 Thread GitBox
aromanenko-dev commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r439565391 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the

[GitHub] [beam] lostluck commented on pull request #11999: [BEAM-7163] Correcting godoc for passert.Sum

2020-06-12 Thread GitBox
lostluck commented on pull request #11999: URL: https://github.com/apache/beam/pull/11999#issuecomment-643336321 Retest This Please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tvalentyn commented on pull request #11996: [BEAM-10247] Pin google-api-core to 1.17.0

2020-06-12 Thread GitBox
tvalentyn commented on pull request #11996: URL: https://github.com/apache/beam/pull/11996#issuecomment-643381750 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pskevin commented on a change in pull request #11999: [BEAM-7163] Correcting godoc for passert.Sum

2020-06-12 Thread GitBox
pskevin commented on a change in pull request #11999: URL: https://github.com/apache/beam/pull/11999#discussion_r439556128 ## File path: sdks/go/pkg/beam/testing/passert/sum.go ## @@ -22,9 +22,9 @@ import ( "github.com/apache/beam/sdks/go/pkg/beam/internal/errors" )

[GitHub] [beam] pskevin commented on pull request #11999: [BEAM-7163] Correcting godoc for passert.Sum

2020-06-12 Thread GitBox
pskevin commented on pull request #11999: URL: https://github.com/apache/beam/pull/11999#issuecomment-643419296 Thanks! My first PR ever actually. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643424085 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] iemejia commented on pull request #10888: [BEAM-7304] Twister2 Beam runner

2020-06-12 Thread GitBox
iemejia commented on pull request #10888: URL: https://github.com/apache/beam/pull/10888#issuecomment-643343412 We received it. We just have to wait for the ack from the people at the ASF. We will let you know. Thanks! This

[GitHub] [beam] perkss commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
perkss commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643343430 @harshithdwivedi please can you check a look This is an automated message from the Apache Git Service. To

[GitHub] [beam] InigoSJ commented on a change in pull request #11943: [BEAM-10209] Add without_defaults to Mean combiner in Python

2020-06-12 Thread GitBox
InigoSJ commented on a change in pull request #11943: URL: https://github.com/apache/beam/pull/11943#discussion_r439505838 ## File path: sdks/python/apache_beam/transforms/combiners.py ## @@ -66,8 +66,21 @@ class Mean(object): """Combiners for computing arithmetic means of

[GitHub] [beam] perkss commented on a change in pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
perkss commented on a change in pull request #12000: URL: https://github.com/apache/beam/pull/12000#discussion_r439505997 ## File path: examples/kotlin/src/test/java/org/apache/beam/examples/kotlin/cookbook/JoinExamplesTest.kt ## @@ -0,0 +1,101 @@ +/* + * Licensed to the

[GitHub] [beam] tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
tvalentyn commented on a change in pull request #11086: URL: https://github.com/apache/beam/pull/11086#discussion_r439522134 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -78,6 +72,12 @@ or a table. Pipeline construction will fail with a validation error if

[GitHub] [beam] tvalentyn commented on pull request #11970: [BEAM-7672] add cp37 wheel to acceptableWhlSpecs

2020-06-12 Thread GitBox
tvalentyn commented on pull request #11970: URL: https://github.com/apache/beam/pull/11970#issuecomment-643375238 Run Python Dataflow ValidatesContainer This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-12 Thread GitBox
boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r439562951 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the Apache

[GitHub] [beam] pabloem opened a new pull request #12004: Enabling custom retry strategy for BQ streaming inserts.

2020-06-12 Thread GitBox
pabloem opened a new pull request #12004: URL: https://github.com/apache/beam/pull/12004 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] ibzib commented on pull request #12002: [BEAM-9872] Moved Spark validates tests to shared file

2020-06-12 Thread GitBox
ibzib commented on pull request #12002: URL: https://github.com/apache/beam/pull/12002#issuecomment-643426877 Run Python Spark ValidatesRunner This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
pabloem commented on a change in pull request #11086: URL: https://github.com/apache/beam/pull/11086#discussion_r439592201 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -78,6 +72,12 @@ or a table. Pipeline construction will fail with a validation error if

[GitHub] [beam] InigoSJ commented on a change in pull request #11943: [BEAM-10209] Add without_defaults to Mean combiner in Python

2020-06-12 Thread GitBox
InigoSJ commented on a change in pull request #11943: URL: https://github.com/apache/beam/pull/11943#discussion_r439505838 ## File path: sdks/python/apache_beam/transforms/combiners.py ## @@ -66,8 +66,21 @@ class Mean(object): """Combiners for computing arithmetic means of

[GitHub] [beam] perkss commented on a change in pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
perkss commented on a change in pull request #12000: URL: https://github.com/apache/beam/pull/12000#discussion_r439505997 ## File path: examples/kotlin/src/test/java/org/apache/beam/examples/kotlin/cookbook/JoinExamplesTest.kt ## @@ -0,0 +1,101 @@ +/* + * Licensed to the

[GitHub] [beam] tysonjh opened a new pull request #12001: [BEAM-10082] Remove dependency on java.xml.ws.

2020-06-12 Thread GitBox
tysonjh opened a new pull request #12001: URL: https://github.com/apache/beam/pull/12001 Java 11 removed some Java EE modules. The dependency in MetricsHttpSink is for HttpException. Replace this instead with an IOException. Thank you for your

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-12 Thread GitBox
aromanenko-dev commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r439509913 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the

[GitHub] [beam] tvalentyn commented on pull request #11996: [BEAM-10247] Pin google-api-core to 1.17.0

2020-06-12 Thread GitBox
tvalentyn commented on pull request #11996: URL: https://github.com/apache/beam/pull/11996#issuecomment-643382060 I don't know why Jenkins lags. Tests are not triggered: https://builds.apache.org/job/beam_PostCommit_Python37_PR/. PR LGTM but we need to test before merge.

[GitHub] [beam] lostluck commented on a change in pull request #11989: [BEAM-9615] Add String UTF8 coder.

2020-06-12 Thread GitBox
lostluck commented on a change in pull request #11989: URL: https://github.com/apache/beam/pull/11989#discussion_r439546660 ## File path: sdks/go/pkg/beam/core/runtime/coderx/string.go ## @@ -23,6 +23,8 @@ import ( // NewString returns a coder for the string type. It uses

[GitHub] [beam] lostluck merged pull request #11989: [BEAM-9615] Add String UTF8 coder.

2020-06-12 Thread GitBox
lostluck merged pull request #11989: URL: https://github.com/apache/beam/pull/11989 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] annaqin418 opened a new pull request #12002: [BEAM-9872] Moved Spark validates tests to shared file

2020-06-12 Thread GitBox
annaqin418 opened a new pull request #12002: URL: https://github.com/apache/beam/pull/12002 R: @ibzib @robertwb Moved Spark Python validates tests to shared file to support all versions of Python. (Only tested build with py37 locally. There also may be duplicate code that can

[GitHub] [beam] annaqin418 commented on pull request #12002: [BEAM-9872] Moved Spark validates tests to shared file

2020-06-12 Thread GitBox
annaqin418 commented on pull request #12002: URL: https://github.com/apache/beam/pull/12002#issuecomment-643406436 Run Python Spark ValidatesRunner This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-12 Thread GitBox
boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r439566281 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the Apache

[GitHub] [beam] lostluck commented on pull request #11999: [BEAM-7163] Correcting godoc for passert.Sum

2020-06-12 Thread GitBox
lostluck commented on pull request #11999: URL: https://github.com/apache/beam/pull/11999#issuecomment-643415498 Congratulations, you've contributed your first Go SDK PR :D This is an automated message from the Apache Git

[GitHub] [beam] lostluck merged pull request #11999: [BEAM-7163] Correcting godoc for passert.Sum

2020-06-12 Thread GitBox
lostluck merged pull request #11999: URL: https://github.com/apache/beam/pull/11999 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] lostluck edited a comment on pull request #11999: [BEAM-7163] Correcting godoc for passert.Sum

2020-06-12 Thread GitBox
lostluck edited a comment on pull request #11999: URL: https://github.com/apache/beam/pull/11999#issuecomment-643415498 Congratulations, you've contributed your first Go SDK PR :D Don't forget to mark the JIRA issue as Resolved.

[GitHub] [beam] davidyan74 commented on pull request #11996: [BEAM-10247] Pin google-api-core to 1.17.0

2020-06-12 Thread GitBox
davidyan74 commented on pull request #11996: URL: https://github.com/apache/beam/pull/11996#issuecomment-643340622 I'll add the grpc version requirement to both setup.py and base_image_requirements.txt. BTW, the tests failed because of this: 18:13:16 ERROR: Failure: SyntaxError

[GitHub] [beam] harshithdwivedi commented on a change in pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
harshithdwivedi commented on a change in pull request #12000: URL: https://github.com/apache/beam/pull/12000#discussion_r439500849 ## File path: examples/kotlin/src/test/java/org/apache/beam/examples/kotlin/cookbook/JoinExamplesTest.kt ## @@ -0,0 +1,101 @@ +/* + * Licensed to

[GitHub] [beam] apilloud commented on pull request #11990: [BEAM-9999] Remove Apex runner.

2020-06-12 Thread GitBox
apilloud commented on pull request #11990: URL: https://github.com/apache/beam/pull/11990#issuecomment-643362752 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] perkss commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
perkss commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643373391 @pabloem could you please take a look? This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] boyuanzz commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-12 Thread GitBox
boyuanzz commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r439531254 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the Apache

[GitHub] [beam] pabloem commented on pull request #11998: [BEAM-10250]: Update io_matrix with new SplunkIO

2020-06-12 Thread GitBox
pabloem commented on pull request #11998: URL: https://github.com/apache/beam/pull/11998#issuecomment-643384507 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-12 Thread GitBox
aromanenko-dev commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r439547427 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the

[GitHub] [beam] ibzib commented on pull request #12002: [BEAM-9872] Moved Spark validates tests to shared file

2020-06-12 Thread GitBox
ibzib commented on pull request #12002: URL: https://github.com/apache/beam/pull/12002#issuecomment-643412087 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] lostluck commented on pull request #11999: [BEAM-7163] Correcting godoc for passert.Sum

2020-06-12 Thread GitBox
lostluck commented on pull request #11999: URL: https://github.com/apache/beam/pull/11999#issuecomment-643336565 Run Go PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lostluck commented on pull request #11999: [BEAM-7163] Correcting godoc for passert.Sum

2020-06-12 Thread GitBox
lostluck commented on pull request #11999: URL: https://github.com/apache/beam/pull/11999#issuecomment-643336904 (those were commands for jenkins, that presently need committers to trigger) This is an automated message from

[GitHub] [beam] InigoSJ commented on a change in pull request #11943: [BEAM-10209] Add without_defaults to Mean combiner in Python

2020-06-12 Thread GitBox
InigoSJ commented on a change in pull request #11943: URL: https://github.com/apache/beam/pull/11943#discussion_r439507508 ## File path: sdks/python/apache_beam/transforms/combiners.py ## @@ -66,8 +66,21 @@ class Mean(object): """Combiners for computing arithmetic means of

[GitHub] [beam] tvalentyn commented on pull request #11996: [BEAM-10247] Pin google-api-core to 1.17.0

2020-06-12 Thread GitBox
tvalentyn commented on pull request #11996: URL: https://github.com/apache/beam/pull/11996#issuecomment-643353234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] tysonjh commented on pull request #12001: [BEAM-10082] Remove dependency on java.xml.ws.

2020-06-12 Thread GitBox
tysonjh commented on pull request #12001: URL: https://github.com/apache/beam/pull/12001#issuecomment-643353229 R: @echauchot Are you able to review this PR please? This is an automated message from the Apache Git

[GitHub] [beam] aromanenko-dev commented on pull request #9899: [BEAM-8511] [WIP] KinesisIO.Read enhanced fanout

2020-06-12 Thread GitBox
aromanenko-dev commented on pull request #9899: URL: https://github.com/apache/beam/pull/9899#issuecomment-643357320 @jfarr Kind ping on this PR. Would you have a time to finish this one? This is an automated message from

[GitHub] [beam] lostluck commented on a change in pull request #11999: [BEAM-7163] Correcting godoc for passert.Sum

2020-06-12 Thread GitBox
lostluck commented on a change in pull request #11999: URL: https://github.com/apache/beam/pull/11999#discussion_r439544557 ## File path: sdks/go/pkg/beam/testing/passert/sum.go ## @@ -22,9 +22,9 @@ import ( "github.com/apache/beam/sdks/go/pkg/beam/internal/errors" )

[GitHub] [beam] pabloem commented on pull request #11998: [BEAM-10250]: Update io_matrix with new SplunkIO

2020-06-12 Thread GitBox
pabloem commented on pull request #11998: URL: https://github.com/apache/beam/pull/11998#issuecomment-643423576 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] perkss opened a new pull request #12000: BEAM-10221: Add in four tests cases of base on the java equivalent fo…

2020-06-12 Thread GitBox
perkss opened a new pull request #12000: URL: https://github.com/apache/beam/pull/12000 …r the kotlin cookbook examples. **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help

[GitHub] [beam] tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
tvalentyn commented on a change in pull request #11086: URL: https://github.com/apache/beam/pull/11086#discussion_r439511341 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -732,11 +748,20 @@ def _export_files(self, bq): bigquery.TableSchema instance, a

[GitHub] [beam] tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
tvalentyn commented on a change in pull request #11086: URL: https://github.com/apache/beam/pull/11086#discussion_r439511122 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -78,6 +72,12 @@ or a table. Pipeline construction will fail with a validation error if

[GitHub] [beam] InigoSJ commented on a change in pull request #11943: [BEAM-10209] Add without_defaults to Mean combiner in Python

2020-06-12 Thread GitBox
InigoSJ commented on a change in pull request #11943: URL: https://github.com/apache/beam/pull/11943#discussion_r439507508 ## File path: sdks/python/apache_beam/transforms/combiners.py ## @@ -66,8 +66,21 @@ class Mean(object): """Combiners for computing arithmetic means of

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
pabloem commented on a change in pull request #11086: URL: https://github.com/apache/beam/pull/11086#discussion_r439592297 ## File path: CHANGES.md ## @@ -58,6 +58,10 @@ * Support for X source added (Java/Python) ([BEAM-X](https://issues.apache.org/jira/browse/BEAM-X)). *

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643436010 RAT Precommit - can you please add an Apache License header to any new files? (you can copy the header from other kotlin files)

[GitHub] [beam] TheNeuralBit commented on pull request #11570: [BEAM-10047] Merge the stages 'Gather and Sort' and 'Create Batches'

2020-06-12 Thread GitBox
TheNeuralBit commented on pull request #11570: URL: https://github.com/apache/beam/pull/11570#issuecomment-643442999 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643450395 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem merged pull request #11969: Remove a hack used to retrieve schematized data from HL7v2 messages, …

2020-06-12 Thread GitBox
pabloem merged pull request #11969: URL: https://github.com/apache/beam/pull/11969 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #11982: [BEAM-6892] Supporting bucket auto-creation for Dataflow.

2020-06-12 Thread GitBox
pabloem commented on pull request #11982: URL: https://github.com/apache/beam/pull/11982#issuecomment-643507056 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11824: [BEAM-10101] Add HttpIO / HttpFileSystem (Python)

2020-06-12 Thread GitBox
pabloem commented on pull request #11824: URL: https://github.com/apache/beam/pull/11824#issuecomment-643507084 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on pull request #11982: [BEAM-6892] Supporting bucket auto-creation for Dataflow.

2020-06-12 Thread GitBox
pabloem commented on pull request #11982: URL: https://github.com/apache/beam/pull/11982#issuecomment-643509531 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11982: [BEAM-6892] Supporting bucket auto-creation for Dataflow.

2020-06-12 Thread GitBox
pabloem commented on pull request #11982: URL: https://github.com/apache/beam/pull/11982#issuecomment-643512286 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] udim commented on pull request #12007: [BEAM-10254] Fix exception with typing.Pattern

2020-06-12 Thread GitBox
udim commented on pull request #12007: URL: https://github.com/apache/beam/pull/12007#issuecomment-643518795 R: @tvalentyn This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] pabloem commented on pull request #11969: Remove a hack used to retrieve schematized data from HL7v2 messages, …

2020-06-12 Thread GitBox
pabloem commented on pull request #11969: URL: https://github.com/apache/beam/pull/11969#issuecomment-643445960 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11943: [BEAM-10209] Add without_defaults to Mean combiner in Python

2020-06-12 Thread GitBox
pabloem commented on pull request #11943: URL: https://github.com/apache/beam/pull/11943#issuecomment-643446115 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] ibzib commented on pull request #12002: [BEAM-9872] Moved Spark validates tests to shared file

2020-06-12 Thread GitBox
ibzib commented on pull request #12002: URL: https://github.com/apache/beam/pull/12002#issuecomment-643457693 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] pabloem commented on pull request #11838: [BEAM-9322] Modify the TestStream to output a dict when no output_tags are specified

2020-06-12 Thread GitBox
pabloem commented on pull request #11838: URL: https://github.com/apache/beam/pull/11838#issuecomment-643471534 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-643505543 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

2020-06-12 Thread GitBox
pabloem commented on pull request #11929: URL: https://github.com/apache/beam/pull/11929#issuecomment-643505627 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] ibzib commented on a change in pull request #11821: [BEAM-10097, BEAM-5982, BEAM-3080] Use primitive views directly instead of transforming KV> to the view type via a

2020-06-12 Thread GitBox
ibzib commented on a change in pull request #11821: URL: https://github.com/apache/beam/pull/11821#discussion_r439607449 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/View.java ## @@ -157,7 +166,10 @@ private View() {} * PCollectionView} mapping

[GitHub] [beam] stale[bot] commented on pull request #10487: [BEAM-5504] Introduce PubsubAvroTable

2020-06-12 Thread GitBox
stale[bot] commented on pull request #10487: URL: https://github.com/apache/beam/pull/10487#issuecomment-643437807 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

[GitHub] [beam] pabloem commented on pull request #11982: [BEAM-6892] Supporting bucket auto-creation for Dataflow.

2020-06-12 Thread GitBox
pabloem commented on pull request #11982: URL: https://github.com/apache/beam/pull/11982#issuecomment-643442446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] sabhyankar commented on pull request #11998: [BEAM-10250]: Update io_matrix with new SplunkIO

2020-06-12 Thread GitBox
sabhyankar commented on pull request #11998: URL: https://github.com/apache/beam/pull/11998#issuecomment-643442493 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] perkss commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
perkss commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643446840 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11998: [BEAM-10250]: Update io_matrix with new SplunkIO

2020-06-12 Thread GitBox
pabloem commented on pull request #11998: URL: https://github.com/apache/beam/pull/11998#issuecomment-643453548 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #12000: BEAM-10221: Add in example tests cases of Kotlin cookbook

2020-06-12 Thread GitBox
pabloem commented on pull request #12000: URL: https://github.com/apache/beam/pull/12000#issuecomment-643470778 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-643470728 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
pabloem commented on pull request #11086: URL: https://github.com/apache/beam/pull/11086#issuecomment-643470635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem commented on pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

2020-06-12 Thread GitBox
pabloem commented on pull request #11929: URL: https://github.com/apache/beam/pull/11929#issuecomment-643476319 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11996: [BEAM-10247] Pin google-api-core to 1.17.0

2020-06-12 Thread GitBox
aaltay commented on pull request #11996: URL: https://github.com/apache/beam/pull/11996#issuecomment-643493248 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11982: [BEAM-6892] Supporting bucket auto-creation for Dataflow.

2020-06-12 Thread GitBox
pabloem commented on pull request #11982: URL: https://github.com/apache/beam/pull/11982#issuecomment-643511451 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on pull request #12003: [BEAM-10251] Adds transform id to TestStream step

2020-06-12 Thread GitBox
lukecwik commented on pull request #12003: URL: https://github.com/apache/beam/pull/12003#issuecomment-643511556 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

  1   2   >