vmarquez commented on a change in pull request #10546:
URL: https://github.com/apache/beam/pull/10546#discussion_r434318846
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##
@@ -370,384 +488,16 @@ private CassandraIO() {}
vmarquez commented on a change in pull request #10546:
URL: https://github.com/apache/beam/pull/10546#discussion_r434318532
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##
@@ -326,7 +371,78 @@ private CassandraIO() {}
pabloem commented on pull request #11898:
URL: https://github.com/apache/beam/pull/11898#issuecomment-637963899
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
vmarquez commented on a change in pull request #10546:
URL: https://github.com/apache/beam/pull/10546#discussion_r434304763
##
File path:
sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOTest.java
##
@@ -480,66 +527,22 @@ public void testCustomM
vmarquez commented on a change in pull request #10546:
URL: https://github.com/apache/beam/pull/10546#discussion_r434303784
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##
@@ -326,7 +371,78 @@ private CassandraIO() {}
henryken commented on pull request #11761:
URL: https://github.com/apache/beam/pull/11761#issuecomment-637946055
We've made it! 🙌
This is an automated message from the Apache Git Service.
To respond to the message, please log
pabloem commented on pull request #11898:
URL: https://github.com/apache/beam/pull/11898#issuecomment-637945801
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on pull request #11780:
URL: https://github.com/apache/beam/pull/11780#issuecomment-637938193
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
aijamalnk commented on pull request #11780:
URL: https://github.com/apache/beam/pull/11780#issuecomment-637937054
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
aijamalnk commented on pull request #11780:
URL: https://github.com/apache/beam/pull/11780#issuecomment-637936990
@iemejia can you try merging now? I've tried to rebase the change onto master
This is an automated message from
aijamalnk commented on pull request #11780:
URL: https://github.com/apache/beam/pull/11780#issuecomment-637936845
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
boyuanzz commented on pull request #11749:
URL: https://github.com/apache/beam/pull/11749#issuecomment-637922023
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
boyuanzz commented on pull request #11894:
URL: https://github.com/apache/beam/pull/11894#issuecomment-637921787
@robertwb Please take another look : ) A simple clear timer support is added
to FnApiRunner. Thanks!
This is an
jaketf commented on a change in pull request #11862:
URL: https://github.com/apache/beam/pull/11862#discussion_r434278353
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##
@@ -179,25 +189,51 @@ public static Li
jaketf commented on pull request #11702:
URL: https://github.com/apache/beam/pull/11702#issuecomment-637901651
@pabloem yes PTAL. I've removed one of the transforms because just in
writing the tests I realized this was too difficult an interface to use.
--
jaketf removed a comment on pull request #11702:
URL: https://github.com/apache/beam/pull/11702#issuecomment-628285515
To highlight just the latest changes to FhirIO you can take a look at [this
PR on my fork](https://github.com/jaketf/beam/pull/1/files)
--
aaltay merged pull request #11779:
URL: https://github.com/apache/beam/pull/11779
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
aaltay merged pull request #11682:
URL: https://github.com/apache/beam/pull/11682
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
aaltay merged pull request #11885:
URL: https://github.com/apache/beam/pull/11885
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ibzib commented on pull request #11902:
URL: https://github.com/apache/beam/pull/11902#issuecomment-637893319
Brian, if you want, you can try to "verify" the release by making sure the
tag's signature matches whatever Github expects. But I don't think it's too
important so I'm merging this
ibzib merged pull request #11902:
URL: https://github.com/apache/beam/pull/11902
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pabloem commented on pull request #11702:
URL: https://github.com/apache/beam/pull/11702#issuecomment-637890525
should I take a look at the APIs for the transforms?
This is an automated message from the Apache Git Service.
To
TheNeuralBit commented on a change in pull request #11901:
URL: https://github.com/apache/beam/pull/11901#discussion_r434246368
##
File path: sdks/python/apache_beam/transforms/sql.py
##
@@ -74,3 +77,8 @@ def __init__(self, query, dialect=None):
SqlTransformSchema(
TheNeuralBit commented on a change in pull request #11901:
URL: https://github.com/apache/beam/pull/11901#discussion_r434245470
##
File path: sdks/python/apache_beam/typehints/opcodes.py
##
@@ -120,7 +120,7 @@ def get_iter(state, unused_arg):
def symmetric_binary_op(state, u
ibzib opened a new pull request #11905:
URL: https://github.com/apache/beam/pull/11905
R: @mxm
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](
TheNeuralBit opened a new pull request #11904:
URL: https://github.com/apache/beam/pull/11904
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex | Dataflow | Flink | Gearpum
TheNeuralBit opened a new pull request #11903:
URL: https://github.com/apache/beam/pull/11903
The logic in this script is incorrect. `-z` checks if the command writes any
output at all, and `which` always writes output.
Post-Commit Tests Status (on master branch)
---
ibzib opened a new pull request #11902:
URL: https://github.com/apache/beam/pull/11902
R: @TheNeuralBit
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
review
pabloem commented on pull request #11898:
URL: https://github.com/apache/beam/pull/11898#issuecomment-637874451
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on pull request #11898:
URL: https://github.com/apache/beam/pull/11898#issuecomment-637875180
LGTM. I'll merge after tests pass.
This is an automated message from the Apache Git Service.
To respond to the me
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637863213
Failed with:
```
16:39:16
16:39:16 FAILURE: Build failed with an exception.
16:39:16
16:39:16 * What went wrong:
16:39:16 Could not determine the dependencies
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637862976
Run Python 3.6 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637862778
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
boyuanzz commented on pull request #11894:
URL: https://github.com/apache/beam/pull/11894#issuecomment-637860496
> Maybe better to list the runners that should skip instead so that we don't
limit coverage for new/unknown runners?
Re: @tweise It's kind of hard to do that since we have
apilloud commented on a change in pull request #11820:
URL: https://github.com/apache/beam/pull/11820#discussion_r434226724
##
File path:
sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/zetasql/ZetaSqlQuery0.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed
robertwb merged pull request #11878:
URL: https://github.com/apache/beam/pull/11878
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
boyuanzz commented on pull request #11894:
URL: https://github.com/apache/beam/pull/11894#issuecomment-637858581
Run Python Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the mes
KevinGG commented on a change in pull request #11898:
URL: https://github.com/apache/beam/pull/11898#discussion_r434227564
##
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##
@@ -1702,7 +1702,8 @@ def _get_destination_uri(self, temp_location):
logging.debug("gcs_
robertwb commented on pull request #11901:
URL: https://github.com/apache/beam/pull/11901#issuecomment-637855309
@TheNeuralBit Not try to overwhelm you, but I figured you'd be interested in
this one.
This is an automated me
robertwb opened a new pull request #11901:
URL: https://github.com/apache/beam/pull/11901
This allows easy construction of schemas with PCollections.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickl
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637855187
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637852060
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
robertwb merged pull request #11785:
URL: https://github.com/apache/beam/pull/11785
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on a change in pull request #11898:
URL: https://github.com/apache/beam/pull/11898#discussion_r434218178
##
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##
@@ -1702,7 +1702,8 @@ def _get_destination_uri(self, temp_location):
logging.debug("gcs_
robertwb commented on a change in pull request #11766:
URL: https://github.com/apache/beam/pull/11766#discussion_r434217321
##
File path: sdks/python/apache_beam/dataframe/partitionings.py
##
@@ -0,0 +1,133 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
robertwb commented on a change in pull request #11766:
URL: https://github.com/apache/beam/pull/11766#discussion_r434215127
##
File path: sdks/python/apache_beam/dataframe/expressions.py
##
@@ -85,16 +87,10 @@ def evaluate_at(self, session): # type: (Session) -> T
"""Retu
aaltay merged pull request #11897:
URL: https://github.com/apache/beam/pull/11897
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
robertwb commented on a change in pull request #11766:
URL: https://github.com/apache/beam/pull/11766#discussion_r434214501
##
File path: sdks/python/apache_beam/dataframe/partitionings.py
##
@@ -0,0 +1,133 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
robertwb commented on pull request #11878:
URL: https://github.com/apache/beam/pull/11878#issuecomment-637844453
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
KevinGG commented on a change in pull request #11898:
URL: https://github.com/apache/beam/pull/11898#discussion_r434212247
##
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##
@@ -1702,7 +1702,8 @@ def _get_destination_uri(self, temp_location):
logging.debug("gcs_
ibzib merged pull request #11880:
URL: https://github.com/apache/beam/pull/11880
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pabloem commented on pull request #11893:
URL: https://github.com/apache/beam/pull/11893#issuecomment-637839937
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
pabloem commented on pull request #11824:
URL: https://github.com/apache/beam/pull/11824#issuecomment-637831911
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
lukecwik merged pull request #11899:
URL: https://github.com/apache/beam/pull/11899
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on a change in pull request #11824:
URL: https://github.com/apache/beam/pull/11824#discussion_r434194515
##
File path: sdks/python/apache_beam/io/httpio.py
##
@@ -0,0 +1,167 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contrib
TheNeuralBit opened a new pull request #11900:
URL: https://github.com/apache/beam/pull/11900
R: @udim
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex | Dataflow
Akshay-Iyangar commented on pull request #11396:
URL: https://github.com/apache/beam/pull/11396#issuecomment-637828525
@aromanenko-dev @lukecwik could you'll please have a look? Thanks
This is an automated message from the
lukecwik commented on a change in pull request #11873:
URL: https://github.com/apache/beam/pull/11873#discussion_r434197026
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##
@@ -1353,14 +1353,14 @@ public voi
lostluck commented on pull request #11899:
URL: https://github.com/apache/beam/pull/11899#issuecomment-637826896
Run Go PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
lukecwik commented on pull request #11899:
URL: https://github.com/apache/beam/pull/11899#issuecomment-637823925
R: @lostluck @youngoli
This is an automated message from the Apache Git Service.
To respond to the message, ple
lukecwik opened a new pull request #11899:
URL: https://github.com/apache/beam/pull/11899
Now that the SDK has migrated to use the Dataflow runner v2, this is no
longer required.
Thank you for your contribution! Follow this checklist to help us
incorp
iemejia merged pull request #11888:
URL: https://github.com/apache/beam/pull/11888
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
boyuanzz commented on pull request #11749:
URL: https://github.com/apache/beam/pull/11749#issuecomment-637820927
> @boyuanzz Yes, afaik, it's used only for [performance
testing](http://metrics.beam.apache.org/d/bnlHKP3Wz/java-io-it-tests-dataflow?panelId=21&fullscreen&orgId=1&from=158853992
pabloem commented on pull request #11824:
URL: https://github.com/apache/beam/pull/11824#issuecomment-637821019
ok just looking at this now...
This is an automated message from the Apache Git Service.
To respond to the messag
lukecwik commented on a change in pull request #11873:
URL: https://github.com/apache/beam/pull/11873#discussion_r434188515
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##
@@ -1353,14 +1353,14 @@ public voi
iemejia commented on a change in pull request #10546:
URL: https://github.com/apache/beam/pull/10546#discussion_r433896372
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/RingRange.java
##
@@ -55,4 +58,9 @@ public boolean isWrapping() {
p
rionmonster commented on pull request #11761:
URL: https://github.com/apache/beam/pull/11761#issuecomment-637814323
@henryken / @pabloem
Thanks to both of you guys for helping me through this process, both in
review and getting it merged in. I shot out an e-mail on the user mailing
tweise commented on a change in pull request #11894:
URL: https://github.com/apache/beam/pull/11894#discussion_r434181735
##
File path: sdks/python/apache_beam/runners/portability/portable_runner_test.py
##
@@ -241,7 +241,8 @@ def process(self, kv,
index=beam.DoFn.StateParam(i
pabloem commented on pull request #11893:
URL: https://github.com/apache/beam/pull/11893#issuecomment-637810880
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
boyuanzz commented on a change in pull request #11894:
URL: https://github.com/apache/beam/pull/11894#discussion_r434177432
##
File path: sdks/python/apache_beam/runners/portability/portable_runner_test.py
##
@@ -241,7 +241,8 @@ def process(self, kv,
index=beam.DoFn.StateParam
tweise commented on a change in pull request #11894:
URL: https://github.com/apache/beam/pull/11894#discussion_r434176084
##
File path: sdks/python/apache_beam/runners/portability/portable_runner_test.py
##
@@ -241,7 +241,8 @@ def process(self, kv,
index=beam.DoFn.StateParam(i
aromanenko-dev commented on pull request #11749:
URL: https://github.com/apache/beam/pull/11749#issuecomment-637806753
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, pl
aromanenko-dev commented on pull request #11749:
URL: https://github.com/apache/beam/pull/11749#issuecomment-637806567
@boyuanzz Yes, afaik, it's used only for [performance
testing](http://metrics.beam.apache.org/d/bnlHKP3Wz/java-io-it-tests-dataflow?panelId=21&fullscreen&orgId=1&from=15885
pabloem commented on pull request #11896:
URL: https://github.com/apache/beam/pull/11896#issuecomment-637806282
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on a change in pull request #11898:
URL: https://github.com/apache/beam/pull/11898#discussion_r434172894
##
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##
@@ -1702,7 +1702,8 @@ def _get_destination_uri(self, temp_location):
logging.debug("gcs_
pabloem commented on pull request #11898:
URL: https://github.com/apache/beam/pull/11898#issuecomment-637803100
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
KevinGG commented on pull request #11898:
URL: https://github.com/apache/beam/pull/11898#issuecomment-637798776
R: @pabloem
PTAL, thx!
This is an automated message from the Apache Git Service.
To respond to the message, p
KevinGG opened a new pull request #11898:
URL: https://github.com/apache/beam/pull/11898
The error messages emit from bigquery io:
1. For Java SDK, updated error message when tempLocation is not set.
2. For Python SDK, updated error message when neither gcs_location nor
temp_loca
dmvk commented on pull request #11889:
URL: https://github.com/apache/beam/pull/11889#issuecomment-637793402
Run Flink ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message, pleas
pabloem commented on pull request #11761:
URL: https://github.com/apache/beam/pull/11761#issuecomment-637793166
thanks a lot @rionmonster @henryken - I'd encourage you to announce on user@
or even write a blog post if you feel up to it : )
-
dmvk commented on pull request #11889:
URL: https://github.com/apache/beam/pull/11889#issuecomment-637792716
Run Flink Validates Runner
This is an automated message from the Apache Git Service.
To respond to the message, plea
pabloem commented on pull request #11761:
URL: https://github.com/apache/beam/pull/11761#issuecomment-637792899
Thank you!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pabloem merged pull request #11761:
URL: https://github.com/apache/beam/pull/11761
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
boyuanzz commented on pull request #11894:
URL: https://github.com/apache/beam/pull/11894#issuecomment-637786219
`test_pardo_timers_clear` doesn't work with multi-workers in fn_runner.
Going to skip it with multi-workers.
Th
pabloem commented on pull request #11761:
URL: https://github.com/apache/beam/pull/11761#issuecomment-637783954
unfortunately the ASF now only allows committers to trigger tests.
Triggering...
This is an automated message fr
pabloem commented on pull request #11761:
URL: https://github.com/apache/beam/pull/11761#issuecomment-637783731
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
lukecwik merged pull request #11891:
URL: https://github.com/apache/beam/pull/11891
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rionmonster commented on pull request #11761:
URL: https://github.com/apache/beam/pull/11761#issuecomment-637781876
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, pleas
rionmonster edited a comment on pull request #11761:
URL: https://github.com/apache/beam/pull/11761#issuecomment-637781462
@pabloem
Doh! It looks like one of the headers was missed. Just pushed up another
commit to add that one. I don't know if I have the power to trigger a retest
(
rionmonster commented on pull request #11761:
URL: https://github.com/apache/beam/pull/11761#issuecomment-637781462
@pabloem
Doh! It looks like one of the headers was missed. Just pushed up another
commit to add that one.
stale[bot] commented on pull request #10958:
URL: https://github.com/apache/beam/pull/10958#issuecomment-637778766
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
TheNeuralBit opened a new pull request #11897:
URL: https://github.com/apache/beam/pull/11897
R: @aaltay
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex | Dataflo
robertwb commented on a change in pull request #11785:
URL: https://github.com/apache/beam/pull/11785#discussion_r434143456
##
File path: sdks/python/apache_beam/dataframe/doctests.py
##
@@ -242,6 +242,11 @@ def __init__(self, env, use_beam=True, **kwargs):
**kwargs)
dmvk commented on pull request #11889:
URL: https://github.com/apache/beam/pull/11889#issuecomment-637769674
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log o
pabloem commented on pull request #11893:
URL: https://github.com/apache/beam/pull/11893#issuecomment-637768756
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
pabloem commented on pull request #11893:
URL: https://github.com/apache/beam/pull/11893#issuecomment-637768610
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
TheNeuralBit edited a comment on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-637764980
Failures in VR tests are all known and don't represent regressions:
- Samza: testOutputTimestampDefault
[BEAM-10025](https://issues.apache.org/jira/browse/BEAM-1002
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-637764980
Failures in VR tests are all known and don't represent regressions:
Samza: testOutputTimestampDefault
[BEAM-10025](https://issues.apache.org/jira/browse/BEAM-10025)
Spa
pabloem commented on pull request #11761:
URL: https://github.com/apache/beam/pull/11761#issuecomment-637764092
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
chunyang commented on pull request #11896:
URL: https://github.com/apache/beam/pull/11896#issuecomment-637762788
R: @pabloem
This is an automated message from the Apache Git Service.
To respond to the message, please log on
1 - 100 of 210 matches
Mail list logo
