youngoli opened a new pull request #12008:
URL: https://github.com/apache/beam/pull/12008
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] [**Choose
rezarokni commented on pull request #11929:
URL: https://github.com/apache/beam/pull/11929#issuecomment-643561830
@pabloem Fixed checkstyle in test, sorry about that.
This is an automated message from the Apache Git Service.
lostluck commented on pull request #11989:
URL: https://github.com/apache/beam/pull/11989#issuecomment-643546739
That's been filed as https://issues.apache.org/jira/browse/BEAM-7009
And I have the rest of schemas to finish up which will definely require not
putting that off any
lostluck edited a comment on pull request #11989:
URL: https://github.com/apache/beam/pull/11989#issuecomment-643546739
@lukecwik That's been filed as
https://issues.apache.org/jira/browse/BEAM-7009
And I have the rest of schemas to finish up which will definely require not
lazylynx commented on pull request #11970:
URL: https://github.com/apache/beam/pull/11970#issuecomment-643530809
> it would be more reliable to check the python version.
@tvalentyn Sorry, I misunderstood your comment.
I'll update.
stale[bot] commented on pull request #11405:
URL: https://github.com/apache/beam/pull/11405#issuecomment-643527359
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
ibzib commented on a change in pull request #11821:
URL: https://github.com/apache/beam/pull/11821#discussion_r439607449
##
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/View.java
##
@@ -157,7 +166,10 @@ private View() {}
* PCollectionView} mapping
jfarr commented on pull request #9899:
URL: https://github.com/apache/beam/pull/9899#issuecomment-643525635
> @jfarr Kind ping on this PR. Would you have a time to finish this one?
@aromanenko-dev Sure, I'm just waiting for a resolution on BEAM-9702. Did
you still want to merge that
udim commented on pull request #12007:
URL: https://github.com/apache/beam/pull/12007#issuecomment-643518902
Hopefully tests will run if I make this comment?
This is an automated message from the Apache Git Service.
To
udim commented on pull request #12007:
URL: https://github.com/apache/beam/pull/12007#issuecomment-643518795
R: @tvalentyn
This is an automated message from the Apache Git Service.
To respond to the message, please log on
udim opened a new pull request #12007:
URL: https://github.com/apache/beam/pull/12007
Fixes `convert_to_beam_type` on `typing.Pattern` and `typing.Match` (both of
type `typing._TypeAlias`) to not throw an exception.
Only Python versions 3.6.{8,9} are known to be affected.
Also
ibzib opened a new pull request #12006:
URL: https://github.com/apache/beam/pull/12006
Same as #11711, I have no idea why it didn't occur to me to look at Spark
too.
R: @robertwb @annaqin418
Thank you for your contribution! Follow this
udim commented on a change in pull request #11982:
URL: https://github.com/apache/beam/pull/11982#discussion_r439674896
##
File path: sdks/python/apache_beam/options/pipeline_options_validator_test.py
##
@@ -93,7 +93,7 @@ def test_missing_required_options(self):
udim commented on a change in pull request #11982:
URL: https://github.com/apache/beam/pull/11982#discussion_r439674768
##
File path: sdks/python/apache_beam/options/pipeline_options_validator_test.py
##
@@ -93,7 +93,7 @@ def test_missing_required_options(self):
JustineKoa edited a comment on pull request #11964:
URL: https://github.com/apache/beam/pull/11964#issuecomment-641651721
R: @angoenka
This is an automated message from the Apache Git Service.
To respond to the message,
lukecwik commented on pull request #11989:
URL: https://github.com/apache/beam/pull/11989#issuecomment-643512623
Can go add a test which imports standard_coders.yaml and ensures the
encoding matches the bytes and vice versa?
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-643512286
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
lukecwik commented on pull request #12003:
URL: https://github.com/apache/beam/pull/12003#issuecomment-643511813
Confirmed that this is unused in Go SDK.
This is an automated message from the Apache Git Service.
To respond
lukecwik commented on pull request #12003:
URL: https://github.com/apache/beam/pull/12003#issuecomment-643511556
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-643511451
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11943:
URL: https://github.com/apache/beam/pull/11943#issuecomment-643510656
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-643510550
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-643510455
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-643510430
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11943:
URL: https://github.com/apache/beam/pull/11943#issuecomment-643510332
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
InigoSJ commented on pull request #11943:
URL: https://github.com/apache/beam/pull/11943#issuecomment-643510251
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-643509531
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-643507056
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11824:
URL: https://github.com/apache/beam/pull/11824#issuecomment-643507084
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pabloem commented on pull request #11086:
URL: https://github.com/apache/beam/pull/11086#issuecomment-643505543
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11929:
URL: https://github.com/apache/beam/pull/11929#issuecomment-643505627
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem merged pull request #11969:
URL: https://github.com/apache/beam/pull/11969
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem merged pull request #11998:
URL: https://github.com/apache/beam/pull/11998
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
JustineKoa commented on pull request #11964:
URL: https://github.com/apache/beam/pull/11964#issuecomment-643499673
@angoenka Thanks! It is ready to merge now.
This is an automated message from the Apache Git Service.
To
angoenka commented on pull request #11964:
URL: https://github.com/apache/beam/pull/11964#issuecomment-643498758
Thanks @JustineKoa
This looks good to me.
Let me know if i should merge it.
This is an automated message
aaltay commented on pull request #11996:
URL: https://github.com/apache/beam/pull/11996#issuecomment-643493248
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12005:
URL: https://github.com/apache/beam/pull/12005#issuecomment-643479856
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11929:
URL: https://github.com/apache/beam/pull/11929#issuecomment-643479659
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia commented on pull request #11967:
URL: https://github.com/apache/beam/pull/11967#issuecomment-643479230
@darshanj could you rebase this PR please?
This is an automated message from the Apache Git Service.
To
KevinGG commented on pull request #12005:
URL: https://github.com/apache/beam/pull/12005#issuecomment-643476941
R: @rohdesamuel
R: @pabloem
PTAL, thx!
This is an automated message from the Apache Git Service.
To
pabloem commented on pull request #11929:
URL: https://github.com/apache/beam/pull/11929#issuecomment-643476319
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
ibzib commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-643473716
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
ibzib commented on a change in pull request #12002:
URL: https://github.com/apache/beam/pull/12002#discussion_r439631658
##
File path: sdks/python/test-suites/portable/common.gradle
##
@@ -99,34 +101,110 @@ task flinkTriggerTranscript() {
}
}
+
+task createProcessWorker
ihji commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-643472344
Looks like the author of the library released the fix.
This is an automated message from the Apache Git Service.
To
ihji closed pull request #11995:
URL: https://github.com/apache/beam/pull/11995
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pabloem commented on pull request #11824:
URL: https://github.com/apache/beam/pull/11824#issuecomment-643471642
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pabloem commented on pull request #11838:
URL: https://github.com/apache/beam/pull/11838#issuecomment-643471534
Run Portable_Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #12000:
URL: https://github.com/apache/beam/pull/12000#issuecomment-643470778
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11086:
URL: https://github.com/apache/beam/pull/11086#issuecomment-643470635
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pabloem commented on pull request #11086:
URL: https://github.com/apache/beam/pull/11086#issuecomment-643470728
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
ibzib commented on pull request #12002:
URL: https://github.com/apache/beam/pull/12002#issuecomment-643469436
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pabloem commented on pull request #11995:
URL: https://github.com/apache/beam/pull/11995#issuecomment-643459669
let's merge this to unblock others while the new RSA fix comes out?
This is an automated message from the Apache
pabloem commented on pull request #11959:
URL: https://github.com/apache/beam/pull/11959#issuecomment-643458605
fyi @jaketf
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ibzib commented on pull request #12002:
URL: https://github.com/apache/beam/pull/12002#issuecomment-643457693
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ibzib commented on pull request #12002:
URL: https://github.com/apache/beam/pull/12002#issuecomment-643454864
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pabloem commented on pull request #11998:
URL: https://github.com/apache/beam/pull/11998#issuecomment-643453548
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12000:
URL: https://github.com/apache/beam/pull/12000#issuecomment-643452551
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12000:
URL: https://github.com/apache/beam/pull/12000#issuecomment-643450395
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
perkss commented on pull request #12000:
URL: https://github.com/apache/beam/pull/12000#issuecomment-643446840
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11943:
URL: https://github.com/apache/beam/pull/11943#issuecomment-643446115
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11969:
URL: https://github.com/apache/beam/pull/11969#issuecomment-643445960
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11969:
URL: https://github.com/apache/beam/pull/11969#issuecomment-643445786
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11998:
URL: https://github.com/apache/beam/pull/11998#issuecomment-643444118
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on pull request #11570:
URL: https://github.com/apache/beam/pull/11570#issuecomment-643442999
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
sabhyankar commented on pull request #11998:
URL: https://github.com/apache/beam/pull/11998#issuecomment-643442493
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-643442446
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
stale[bot] commented on pull request #10487:
URL: https://github.com/apache/beam/pull/10487#issuecomment-643437807
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
pabloem commented on pull request #12000:
URL: https://github.com/apache/beam/pull/12000#issuecomment-643436010
RAT Precommit - can you please add an Apache License header to any new
files? (you can copy the header from other kotlin files)
pabloem commented on a change in pull request #11086:
URL: https://github.com/apache/beam/pull/11086#discussion_r439592297
##
File path: CHANGES.md
##
@@ -58,6 +58,10 @@
* Support for X source added (Java/Python)
([BEAM-X](https://issues.apache.org/jira/browse/BEAM-X)).
*
pabloem commented on a change in pull request #11086:
URL: https://github.com/apache/beam/pull/11086#discussion_r439592201
##
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##
@@ -78,6 +72,12 @@
or a table. Pipeline construction will fail with a validation error if
ibzib commented on pull request #12002:
URL: https://github.com/apache/beam/pull/12002#issuecomment-643426877
Run Python Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #12000:
URL: https://github.com/apache/beam/pull/12000#issuecomment-643424085
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11998:
URL: https://github.com/apache/beam/pull/11998#issuecomment-643423576
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pabloem opened a new pull request #12004:
URL: https://github.com/apache/beam/pull/12004
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
InigoSJ commented on a change in pull request #11943:
URL: https://github.com/apache/beam/pull/11943#discussion_r439507508
##
File path: sdks/python/apache_beam/transforms/combiners.py
##
@@ -66,8 +66,21 @@ class Mean(object):
"""Combiners for computing arithmetic means of
pskevin commented on pull request #11999:
URL: https://github.com/apache/beam/pull/11999#issuecomment-643419296
Thanks! My first PR ever actually.
This is an automated message from the Apache Git Service.
To respond to the
lostluck edited a comment on pull request #11999:
URL: https://github.com/apache/beam/pull/11999#issuecomment-643415498
Congratulations, you've contributed your first Go SDK PR :D
Don't forget to mark the JIRA issue as Resolved.
lostluck merged pull request #11999:
URL: https://github.com/apache/beam/pull/11999
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lostluck commented on pull request #11999:
URL: https://github.com/apache/beam/pull/11999#issuecomment-643415498
Congratulations, you've contributed your first Go SDK PR :D
This is an automated message from the Apache Git
ibzib commented on pull request #12002:
URL: https://github.com/apache/beam/pull/12002#issuecomment-643412087
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r439566281
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the Apache
aromanenko-dev commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r439565391
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the
aromanenko-dev commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r439565391
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the
acrites opened a new pull request #12003:
URL: https://github.com/apache/beam/pull/12003
This is done for the Dataflow runner for both Python and Java. We need the
transform id so we can look up relevant info (like environment) in the pipeline
proto.
@lukecwik
boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r439562951
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the Apache
annaqin418 commented on pull request #12002:
URL: https://github.com/apache/beam/pull/12002#issuecomment-643406436
Run Python Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the
annaqin418 opened a new pull request #12002:
URL: https://github.com/apache/beam/pull/12002
R: @ibzib @robertwb
Moved Spark Python validates tests to shared file to support all versions of
Python.
(Only tested build with py37 locally. There also may be duplicate code that
can
pskevin commented on a change in pull request #11999:
URL: https://github.com/apache/beam/pull/11999#discussion_r439556128
##
File path: sdks/go/pkg/beam/testing/passert/sum.go
##
@@ -22,9 +22,9 @@ import (
"github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
)
aromanenko-dev commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r439547427
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the
lostluck merged pull request #11989:
URL: https://github.com/apache/beam/pull/11989
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lostluck commented on a change in pull request #11989:
URL: https://github.com/apache/beam/pull/11989#discussion_r439546660
##
File path: sdks/go/pkg/beam/core/runtime/coderx/string.go
##
@@ -23,6 +23,8 @@ import (
// NewString returns a coder for the string type. It uses
lostluck commented on a change in pull request #11999:
URL: https://github.com/apache/beam/pull/11999#discussion_r439544557
##
File path: sdks/go/pkg/beam/testing/passert/sum.go
##
@@ -22,9 +22,9 @@ import (
"github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
)
pabloem commented on pull request #11998:
URL: https://github.com/apache/beam/pull/11998#issuecomment-643384507
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
tvalentyn commented on pull request #11996:
URL: https://github.com/apache/beam/pull/11996#issuecomment-643382060
I don't know why Jenkins lags. Tests are not triggered:
https://builds.apache.org/job/beam_PostCommit_Python37_PR/.
PR LGTM but we need to test before merge.
tvalentyn commented on pull request #11996:
URL: https://github.com/apache/beam/pull/11996#issuecomment-643381750
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r439531254
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the Apache
tvalentyn commented on pull request #11970:
URL: https://github.com/apache/beam/pull/11970#issuecomment-643375238
Run Python Dataflow ValidatesContainer
This is an automated message from the Apache Git Service.
To respond to
tvalentyn commented on pull request #11970:
URL: https://github.com/apache/beam/pull/11970#issuecomment-643374850
Run Python Dataflow ValidatesContainer
This is an automated message from the Apache Git Service.
To respond to
tvalentyn commented on pull request #11970:
URL: https://github.com/apache/beam/pull/11970#issuecomment-643374545
LGTM. This improves the situation, however, as I mentioned it would be more
reliable to check the python version.
perkss commented on pull request #12000:
URL: https://github.com/apache/beam/pull/12000#issuecomment-643373391
@pabloem could you please take a look?
This is an automated message from the Apache Git Service.
To respond to
1 - 100 of 140 matches
Mail list logo
