MartinSahlen commented on code in PR #1657:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1657#discussion_r1917906505
##
tests/sqlparser_bigquery.rs:
##
@@ -2244,3 +2244,15 @@ fn test_any_type() {
fn test_any_type_dont_break_custom_type() {
bigquery_and_gene
MartinSahlen commented on code in PR #1657:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1657#discussion_r1917904556
##
src/parser/mod.rs:
##
@@ -7341,6 +7341,10 @@ impl<'a> Parser<'a> {
pub fn parse_options(&mut self, keyword: Keyword) ->
Result, ParserErr
MartinSahlen commented on code in PR #1657:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1657#discussion_r1917893541
##
src/parser/mod.rs:
##
@@ -7341,6 +7341,10 @@ impl<'a> Parser<'a> {
pub fn parse_options(&mut self, keyword: Keyword) ->
Result, ParserErr
MartinSahlen commented on code in PR #1657:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1657#discussion_r1917882700
##
src/parser/mod.rs:
##
@@ -7341,6 +7341,10 @@ impl<'a> Parser<'a> {
pub fn parse_options(&mut self, keyword: Keyword) ->
Result, ParserErr
berkaysynnada commented on PR #14074:
URL: https://github.com/apache/datafusion/pull/14074#issuecomment-2594728046
> Looks like I got hit by some new ColumnStatistics tests on main. Should be
fixed now 🤞
>
> @berkaysynnada can you expand on the rationale for the V2 stats? I
understan
chenkovsky commented on issue #14147:
URL: https://github.com/apache/datafusion/issues/14147#issuecomment-2594725070
```
x1.write_csv("df1.csv", with_header=True)
x2.write_csv("df2.csv", with_header=True)
```
--
This is an automated message from the Apache Git Service.
To respond
MartinSahlen commented on code in PR #1657:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1657#discussion_r1917876805
##
src/parser/mod.rs:
##
@@ -7341,6 +7341,10 @@ impl<'a> Parser<'a> {
pub fn parse_options(&mut self, keyword: Keyword) ->
Result, ParserErr
jonahgao merged PR #14145:
URL: https://github.com/apache/datafusion/pull/14145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
Chen-Yuan-Lai commented on issue #14115:
URL: https://github.com/apache/datafusion/issues/14115#issuecomment-2594710273
Thanks @alamb for pointing out the detail. I will take it into
consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
lewiszlw commented on code in PR #14145:
URL: https://github.com/apache/datafusion/pull/14145#discussion_r1917842401
##
datafusion/physical-plan/src/joins/utils.rs:
##
@@ -1112,6 +1113,14 @@ pub(crate) fn need_produce_result_in_final(join_type:
JoinType) -> bool {
)
}
+
jonahgao commented on code in PR #14145:
URL: https://github.com/apache/datafusion/pull/14145#discussion_r1917839619
##
datafusion/physical-plan/src/joins/utils.rs:
##
@@ -1112,6 +1113,14 @@ pub(crate) fn need_produce_result_in_final(join_type:
JoinType) -> bool {
)
}
+
lewiszlw commented on PR #14148:
URL: https://github.com/apache/datafusion/pull/14148#issuecomment-2594664241
Emm... we have tests that create and run HashJoinExec directly, not
optimized by PhysicalOptimizer.
Closing.
--
This is an automated message from the Apache Git Service.
To re
lewiszlw closed pull request #14148: Simplify `collect_left_input` function in
hash join
URL: https://github.com/apache/datafusion/pull/14148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Lordworms commented on PR #14149:
URL: https://github.com/apache/datafusion/pull/14149#issuecomment-2594663505
I got two following PR for implement SortPreservingMergeStream in Row format
and change the logics in SortExec
--
This is an automated message from the Apache Git Service.
To res
Lordworms opened a new pull request, #14149:
URL: https://github.com/apache/datafusion/pull/14149
## Which issue does this PR close?
part of #7053
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these c
lewiszlw opened a new pull request, #14148:
URL: https://github.com/apache/datafusion/pull/14148
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested?
fullstart opened a new issue, #14147:
URL: https://github.com/apache/datafusion/issues/14147
### Describe the bug
Encountered an issue joining dataframes with duplicate column names if they
generated from file read (I tried csv and parquet).
Dataframes produced from python dict do
shencangsheng opened a new issue, #14146:
URL: https://github.com/apache/datafusion/issues/14146
### Is your feature request related to a problem or challenge?
I hope to directly use standard JSON, as most developers prefer this data
format.
```json
[
{
"use
lewiszlw opened a new pull request, #14145:
URL: https://github.com/apache/datafusion/pull/14145
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
We have two same functions `get_
cj-zhukov commented on issue #14144:
URL: https://github.com/apache/datafusion/issues/14144#issuecomment-2594596672
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
cj-zhukov opened a new issue, #14144:
URL: https://github.com/apache/datafusion/issues/14144
### Describe the bug
When attempting to register an existing file with different format using the
register_csv, register_json, register_parquet, instead of receiving an error,
the operation s
korowa commented on issue #13821:
URL: https://github.com/apache/datafusion/issues/13821#issuecomment-2594590175
@kosiew the root cause of the issue is how arrow writer handles data for
`Dictionary(Decimal)`, and I suppose it'll mostly be fixed by
https://github.com/apache/arrow-rs/pull/698
gsvgit commented on issue #13545:
URL: https://github.com/apache/datafusion/issues/13545#issuecomment-2594583174
My presentation on the topic for DataFusion community meeting:
[SemyonGrigorev_DataFusion_PGQ.pdf](https://github.com/user-attachments/files/18433964/SemyonGrigorev_DataFusion_PGQ
2010YOUY01 opened a new issue, #14143:
URL: https://github.com/apache/datafusion/issues/14143
### Describe the bug
Compile and run datafusion-cli
```
cargo run -- --mem-pool-type fair -m 80M -c 'select c1, c1 as c2 from
generate_series(1,1000) as t1(c1) order by c2 DESC, c1
2010YOUY01 commented on code in PR #14142:
URL: https://github.com/apache/datafusion/pull/14142#discussion_r1917754162
##
datafusion/core/tests/memory_limit/memory_limit_validation/utils.rs:
##
@@ -0,0 +1,192 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+//
2010YOUY01 commented on issue #14143:
URL: https://github.com/apache/datafusion/issues/14143#issuecomment-2594537073
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
2010YOUY01 opened a new pull request, #14142:
URL: https://github.com/apache/datafusion/pull/14142
## Which issue does this PR close?
Part of https://github.com/apache/datafusion/issues/13431
## Rationale for this change
Datafusion supports memory-limited queries: it's im
haohuaijin opened a new issue, #14141:
URL: https://github.com/apache/datafusion/issues/14141
### Describe the bug
```
DataFusion CLI v44.0.0
> create table t(a int, b int, user text) as values (1,2,'test'), (2,3,null);
0 row(s) fetched.
Elapsed 0.051 seconds.
> sele
jonahgao closed issue #14132: create view with multi union use the first union
schema as the final view schema
URL: https://github.com/apache/datafusion/issues/14132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jonahgao commented on PR #14133:
URL: https://github.com/apache/datafusion/pull/14133#issuecomment-2594345585
@Curricane Filed a todo issue #14140 for adding tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
jonahgao opened a new issue, #14140:
URL: https://github.com/apache/datafusion/issues/14140
We add some tests for PR #14133
> Hi @Curricane -- thank you for the fix 🙏
>
> Can you please add some tests, ideally in sqllogicteset format to ensure
this behavior is not broken in th
jonahgao merged PR #14133:
URL: https://github.com/apache/datafusion/pull/14133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
jonahgao commented on PR #14127:
URL: https://github.com/apache/datafusion/pull/14127#issuecomment-2594318289
Thanks @comphead @alamb for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
github-actions[bot] commented on PR #13455:
URL: https://github.com/apache/datafusion/pull/13455#issuecomment-2594306893
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
Curricane commented on PR #14133:
URL: https://github.com/apache/datafusion/pull/14133#issuecomment-2594286581
> Hi @Curricane -- thank you for the fix 🙏
>
> Can you please add some tests, ideally in sqllogicteset format to ensure
this behavior is not broken in the future.
>
>
comphead merged PR #13919:
URL: https://github.com/apache/datafusion/pull/13919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
Chen-Yuan-Lai commented on PR #13919:
URL: https://github.com/apache/datafusion/pull/13919#issuecomment-2594262550
@alamb @comphead I think this PR is ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
andygrove merged PR #1163:
URL: https://github.com/apache/datafusion-ballista/pull/1163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
jayzhan211 merged PR #14138:
URL: https://github.com/apache/datafusion/pull/14138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
jayzhan211 merged PR #14139:
URL: https://github.com/apache/datafusion/pull/14139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
jayzhan211 commented on issue #12644:
URL: https://github.com/apache/datafusion/issues/12644#issuecomment-2594225106
The current status is that we have several changes in branch `logical-types`
for #12622. Where the `Scalar` is introduced and the next step is to complete
the tasks left in #
jayzhan-synnada commented on issue #12644:
URL: https://github.com/apache/datafusion/issues/12644#issuecomment-2594223771
The current status is that we have several changes in branch `logical-types`
for #12622. Where the `Scalar` is introduced and the next step is to complete
the tasks left
andygrove merged PR #1162:
URL: https://github.com/apache/datafusion-ballista/pull/1162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
andygrove opened a new pull request, #1163:
URL: https://github.com/apache/datafusion-ballista/pull/1163
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing cha
xudong963 merged PR #14130:
URL: https://github.com/apache/datafusion/pull/14130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
xudong963 commented on PR #14130:
URL: https://github.com/apache/datafusion/pull/14130#issuecomment-2594170021
thanks @alamb @jonahgao —ill merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
andygrove commented on PR #1293:
URL:
https://github.com/apache/datafusion-comet/pull/1293#issuecomment-2594155855
TPC-H times:
comet_native 327.14
comet_datafusion 341.61
comet_iceberg_compat 297.71 :fire: (first sub-300 timing I have seen)
Our published time for 0.5.0 i
ctsk commented on issue #13729:
URL: https://github.com/apache/datafusion/issues/13729#issuecomment-2594124886
I checked out your second point and was able to replicate the difference in
speed between the two queries. I don't yet see how a TopK operator would help
the non-ordered query.
andygrove closed pull request #1291: [DO NOT MERGE] Merge latest from main into
comet-parquet-exec branch
URL: https://github.com/apache/datafusion-comet/pull/1291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
parthchandra opened a new pull request, #1293:
URL: https://github.com/apache/datafusion-comet/pull/1293
Brings comet-parquet-exec almost up to date with main
There are three new test failures which will be addressed in subsequent PRs
-
```
- Broadcast HashJoin without join filter
andygrove merged PR #1161:
URL: https://github.com/apache/datafusion-ballista/pull/1161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
andygrove merged PR #1159:
URL: https://github.com/apache/datafusion-ballista/pull/1159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
andygrove opened a new pull request, #1292:
URL: https://github.com/apache/datafusion-comet/pull/1292
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes
milenkovicm opened a new pull request, #1162:
URL: https://github.com/apache/datafusion-ballista/pull/1162
# Which issue does this PR close?
Closes none.
# Rationale for this change
in all cases we use logger instead of print, removing print with log
# What change
milenkovicm opened a new pull request, #1161:
URL: https://github.com/apache/datafusion-ballista/pull/1161
# Which issue does this PR close?
Closes none.
# Rationale for this change
adding new logo to readme, to be consistent with comet and datafusion
# What chan
milenkovicm opened a new pull request, #1160:
URL: https://github.com/apache/datafusion-ballista/pull/1160
# Which issue does this PR close?
Closes none.
# Rationale for this change
move `BallistaPlanner` to its own module from utils module.
# What changes are inc
milenkovicm opened a new pull request, #1159:
URL: https://github.com/apache/datafusion-ballista/pull/1159
# Which issue does this PR close?
Closes none.
# Rationale for this change
graph-viz deps have been removed so it broke rest-api, putting dependancy
back
#
andygrove opened a new pull request, #1291:
URL: https://github.com/apache/datafusion-comet/pull/1291
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes
iffyio commented on code in PR #1656:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1656#discussion_r1917322346
##
src/parser/mod.rs:
##
@@ -13150,6 +13151,40 @@ impl<'a> Parser<'a> {
}
}
+pub fn parse_raiserror(&mut self) -> Result {
+
XiangpengHao opened a new pull request, #14139:
URL: https://github.com/apache/datafusion/pull/14139
## Which issue does this PR close?
Closes #.
## Rationale for this change
Current `default_from_session_config` take no effect, this pr fix it. It
also added a `#[mus
alamb commented on code in PR #14138:
URL: https://github.com/apache/datafusion/pull/14138#discussion_r1917264140
##
datafusion/physical-expr/src/equivalence/ordering.rs:
##
@@ -156,6 +156,26 @@ impl OrderingEquivalenceClass {
}
}
+/// Trims `orderings[idx]`
alamb opened a new pull request, #14138:
URL: https://github.com/apache/datafusion/pull/14138
## Which issue does this PR close?
- Part of https://github.com/apache/datafusion/issues/13748
## Rationale for this change
I am testing out a change to the internal representati
Omega359 opened a new pull request, #14137:
URL: https://github.com/apache/datafusion/pull/14137
## Which issue does this PR close?
Closes #.
## Rationale for this change
Update datafusion-testing to latest hash to fix test issues with extended
github action work
alamb opened a new pull request, #14136:
URL: https://github.com/apache/datafusion/pull/14136
WIP as I am still in the process of
- [ ] I need to fix `resolve_overlap`
- [ ] Test timing
## Which issue does this PR close?
- Part of https://github.com/apache/datafusion/issu
alamb commented on PR #14083:
URL: https://github.com/apache/datafusion/pull/14083#issuecomment-2593638218
> Thanks @alamb for proactively reviewing and adding the fix commits. Much
appreciated 🙏
Thank you for helping push this along ❤️
--
This is an automated message from the Apa
gokselk commented on code in PR #14111:
URL: https://github.com/apache/datafusion/pull/14111#discussion_r1917134631
##
datafusion/core/src/datasource/physical_plan/file_scan_config.rs:
##
@@ -210,30 +221,25 @@ impl FileScanConfig {
self
}
-/// Project the sch
ion-elgreco commented on issue #14098:
URL: https://github.com/apache/datafusion/issues/14098#issuecomment-2593609621
@Spaarsh go ahead! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
alamb commented on issue #14008:
URL: https://github.com/apache/datafusion/issues/14008#issuecomment-2593564670
I plan to start assembing the release candidate and test on the week of Jan
27 (in about 2 weeks time()
--
This is an automated message from the Apache Git Service.
To respond t
Spaarsh commented on issue #14098:
URL: https://github.com/apache/datafusion/issues/14098#issuecomment-2593547003
@ion-elgreco @alamb if it is fine by you, can I work on this? I am just
getting familiar with the codebase with a few commits here and there :D
--
This is an automated message
alamb commented on issue #14115:
URL: https://github.com/apache/datafusion/issues/14115#issuecomment-2593524823
I looked a little at this usage:
https://github.com/apache/datafusion/blob/63b94c8f9e128b938e81b7e867ce6256a94d67e6/datafusion/physical-plan/src/aggregates/group_values/null_builde
mnpw commented on PR #14083:
URL: https://github.com/apache/datafusion/pull/14083#issuecomment-2593522924
Thanks @alamb for proactively reviewing and adding the fix commits. Much
appreciated 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please
iffyio commented on code in PR #1657:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1657#discussion_r1917060943
##
tests/sqlparser_bigquery.rs:
##
@@ -2244,3 +2244,15 @@ fn test_any_type() {
fn test_any_type_dont_break_custom_type() {
bigquery_and_generic().
erenavsarogullari commented on code in PR #1290:
URL: https://github.com/apache/datafusion-comet/pull/1290#discussion_r1917053881
##
native/proto/src/proto/expr.proto:
##
@@ -86,6 +86,7 @@ message Expr {
ArrayInsert array_insert = 59;
BinaryExpr array_contains = 60;
erenavsarogullari commented on code in PR #1290:
URL: https://github.com/apache/datafusion-comet/pull/1290#discussion_r1917053881
##
native/proto/src/proto/expr.proto:
##
@@ -86,6 +86,7 @@ message Expr {
ArrayInsert array_insert = 59;
BinaryExpr array_contains = 60;
alamb commented on PR #14130:
URL: https://github.com/apache/datafusion/pull/14130#issuecomment-2593495598
I merged this PR up from main and merged a clippy fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
alamb commented on code in PR #14071:
URL: https://github.com/apache/datafusion/pull/14071#discussion_r1917019302
##
README.md:
##
@@ -146,3 +146,27 @@ stable API, we also improve the API over time. As a
result, we typically
deprecate methods before removing them, according to
alamb opened a new issue, #14135:
URL: https://github.com/apache/datafusion/issues/14135
### Is your feature request related to a problem or challenge?
Broken out of a discussion on a PR here:
- https://github.com/apache/datafusion/pull/14071#discussion_r1910286465
As describ
seve-martinez closed pull request #1566: feat: Supporting `SAMPLE` parsing
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
seve-martinez commented on PR #1566:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1566#issuecomment-2593395062
> I did not notice this PR when I started working on parsing the SAMPLE
option, but since then it was merged: #1580
>
> I can share that we used to parse the
alamb commented on PR #14083:
URL: https://github.com/apache/datafusion/pull/14083#issuecomment-2593391114
I will update the datafusion-cli cargo file as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
comphead merged PR #14071:
URL: https://github.com/apache/datafusion/pull/14071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead closed issue #14001: Doc attribution: make `user_doc` to work with
predefined consts.
URL: https://github.com/apache/datafusion/issues/14001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
comphead merged PR #14086:
URL: https://github.com/apache/datafusion/pull/14086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead closed issue #14112: Can no longer easily join duplicate schemas as of
version 43
URL: https://github.com/apache/datafusion/issues/14112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
comphead merged PR #14127:
URL: https://github.com/apache/datafusion/pull/14127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
alamb commented on code in PR #14083:
URL: https://github.com/apache/datafusion/pull/14083#discussion_r1916965668
##
datafusion/physical-optimizer/Cargo.toml:
##
@@ -36,10 +36,14 @@ recursive_protection = ["dep:recursive"]
[dependencies]
arrow = { workspace = true }
+arrow-s
alamb opened a new pull request, #14134:
URL: https://github.com/apache/datafusion/pull/14134
Draft it is based on https://github.com/apache/datafusion/pull/14083 from
@mnpw
## Which issue does this PR close?
This is a follow up to
- https://github.com/apache/datafusion/pul
adriangb commented on issue #6518:
URL: https://github.com/apache/datafusion/issues/6518#issuecomment-2593297771
I just came across this use case today and am very interested, it would be
amazing if DataFusion just had
https://github.com/apache/datafusion/issues/6518#issuecomment-2585270509
alamb commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1916864288
##
datafusion/expr-common/src/interval_arithmetic.rs:
##
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDayNa
matthewmturner commented on issue #14132:
URL: https://github.com/apache/datafusion/issues/14132#issuecomment-2593195210
@xudong963 this sounds similar to the issue we saw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
alamb commented on code in PR #14119:
URL: https://github.com/apache/datafusion/pull/14119#discussion_r1916850331
##
datafusion/functions/src/string/starts_with.rs:
##
@@ -98,6 +99,27 @@ impl ScalarUDFImpl for StartsWithFunc {
}
}
+fn simplify(
+&self
alamb commented on PR #14122:
URL: https://github.com/apache/datafusion/pull/14122#issuecomment-2593146891
Thanks @jonahgao and @lewiszlw ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb closed issue #13967: Automatically run sqlitetests regularly (but not
with all PRs) to DataFusion
URL: https://github.com/apache/datafusion/issues/13967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alamb merged PR #14122:
URL: https://github.com/apache/datafusion/pull/14122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb merged PR #14101:
URL: https://github.com/apache/datafusion/pull/14101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #14101:
URL: https://github.com/apache/datafusion/pull/14101#issuecomment-2593141596
Let's merge this in and get some experience with running the extended suite
on main. Thank you @Omega359 and @comphead
--
This is an automated message from the Apache Git Service.
mnpw commented on PR #14083:
URL: https://github.com/apache/datafusion/pull/14083#issuecomment-2593062436
@alamb
Here's my understanding of the issue:
- `datafusion` crate already depends on `datafusion-physical-optimizer`.
- SanityChecker's tests depend on `datafusion::dat
alamb commented on PR #14057:
URL: https://github.com/apache/datafusion/pull/14057#issuecomment-2593033656
> Can these metadata columns utilize normal column properties, like ordering
equivalences, constantness, distinctness etc.? For example, AFAIU rowid is an
ordered column, and if I sort
rluvaton commented on PR #1219:
URL:
https://github.com/apache/datafusion-comet/pull/1219#issuecomment-2593045630
@andygrove Yes, would you mind first merging
https://github.com/apache/datafusion-comet/pull/1223 so if I have more
conflicts I can resolve them all at once
--
This is an au
gokselk commented on code in PR #14111:
URL: https://github.com/apache/datafusion/pull/14111#discussion_r1916731975
##
datafusion/core/src/datasource/physical_plan/file_scan_config.rs:
##
@@ -210,30 +221,25 @@ impl FileScanConfig {
self
}
-/// Project the sch
1 - 100 of 124 matches
Mail list logo
