iffyio merged PR #1576:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1874399142
##
tests/sqlparser_redshift.rs:
##
@@ -353,3 +380,23 @@ fn test_parse_json_path_from() {
_ => panic!(),
}
}
+
+#[test]
+fn test_parse_selec
iffyio commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1874372151
##
tests/sqlparser_redshift.rs:
##
@@ -353,3 +380,23 @@ fn test_parse_json_path_from() {
_ => panic!(),
}
}
+
+#[test]
+fn test_parse_sel
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1873845800
##
tests/sqlparser_redshift.rs:
##
@@ -353,3 +380,23 @@ fn test_parse_json_path_from() {
_ => panic!(),
}
}
+
+#[test]
+fn test_parse_selec
iffyio commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1873688579
##
tests/sqlparser_redshift.rs:
##
@@ -353,3 +380,23 @@ fn test_parse_json_path_from() {
_ => panic!(),
}
}
+
+#[test]
+fn test_parse_sel
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1873653672
##
src/dialect/mod.rs:
##
@@ -128,14 +128,38 @@ pub trait Dialect: Debug + Any {
ch == '"' || ch == '`'
}
-/// Return the character us
bombsimon commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1873553041
##
src/dialect/mod.rs:
##
@@ -128,14 +128,38 @@ pub trait Dialect: Debug + Any {
ch == '"' || ch == '`'
}
-/// Return the charact
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1873381493
##
tests/sqlparser_redshift.rs:
##
@@ -279,6 +279,31 @@ fn test_redshift_json_path() {
},
expr_from_projection(only(&select.projection))
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1873382034
##
tests/sqlparser_redshift.rs:
##
@@ -353,3 +378,20 @@ fn test_parse_json_path_from() {
_ => panic!(),
}
}
+
+#[test]
+fn test_parse_selec
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1873381184
##
src/tokenizer.rs:
##
@@ -1075,25 +1075,56 @@ impl<'a> Tokenizer<'a> {
Ok(Some(Token::DoubleQuotedString(s)))
}
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1873380547
##
tests/sqlparser_redshift.rs:
##
@@ -353,3 +378,20 @@ fn test_parse_json_path_from() {
_ => panic!(),
}
}
+
+#[test]
+fn test_parse_selec
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1873380142
##
src/dialect/mod.rs:
##
@@ -128,14 +128,23 @@ pub trait Dialect: Debug + Any {
ch == '"' || ch == '`'
}
-/// Return the character us
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1873379618
##
src/dialect/mod.rs:
##
@@ -128,14 +128,23 @@ pub trait Dialect: Debug + Any {
ch == '"' || ch == '`'
}
-/// Return the character us
iffyio commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1873272299
##
src/tokenizer.rs:
##
@@ -1075,25 +1075,56 @@ impl<'a> Tokenizer<'a> {
Ok(Some(Token::DoubleQuotedString(s)))
}
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1872019394
##
src/dialect/redshift.rs:
##
@@ -41,14 +41,48 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1872019394
##
src/dialect/redshift.rs:
##
@@ -41,14 +41,48 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1871857040
##
src/dialect/redshift.rs:
##
@@ -41,14 +41,48 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then
iffyio commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1871749957
##
src/dialect/redshift.rs:
##
@@ -41,14 +41,48 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier the
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1870464718
##
src/tokenizer.rs:
##
@@ -1081,19 +1081,34 @@ impl<'a> Tokenizer<'a> {
.dialect
.is_proper_id
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1870465243
##
src/dialect/redshift.rs:
##
@@ -41,10 +41,24 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1870464718
##
src/tokenizer.rs:
##
@@ -1081,19 +1081,34 @@ impl<'a> Tokenizer<'a> {
.dialect
.is_proper_id
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1870413689
##
src/dialect/redshift.rs:
##
@@ -41,10 +41,24 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1870413689
##
src/dialect/redshift.rs:
##
@@ -41,10 +41,24 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then
bombsimon commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1870388122
##
src/dialect/redshift.rs:
##
@@ -41,10 +41,24 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1868012113
##
src/dialect/redshift.rs:
##
@@ -41,10 +41,19 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1867993041
##
src/dialect/redshift.rs:
##
@@ -41,10 +41,19 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1867993041
##
src/dialect/redshift.rs:
##
@@ -41,10 +41,19 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1867993041
##
src/dialect/redshift.rs:
##
@@ -41,10 +41,19 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then
bombsimon commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1867939109
##
src/dialect/redshift.rs:
##
@@ -41,10 +41,19 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier
7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1867798790
##
src/dialect/redshift.rs:
##
@@ -41,10 +41,19 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then
bombsimon commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1867724836
##
src/dialect/redshift.rs:
##
@@ -41,10 +41,19 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier
7phs opened a new pull request, #1576:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1576
Quoted identifiers allow the use of any characters and can start with any
character, including digits. For example:
```sql
SELECT 1 AS "1" FROM a
```
However, the token
32 matches
Mail list logo
