I just thought, for colouring we can always simply turn off the Scintilla lexer
(set NULL) and pass the
[messages](https://www.scintilla.org/ScintillaDoc.html#SCN_STYLENEEDED) to the
LSP.
--
Reply to this email directly or view it on GitHub:
BTW although I was joking
[here](https://github.com/geany/geany/issues/3550#issuecomment-1704453258) its
almost there, see
[this](https://code.visualstudio.com/docs/editor/intellisense#_enhance-completions-with-ai).
--
Reply to this email directly or view it on GitHub:
I guess Neil added this because somebody wanted it. I can see that there are
times when knowing what was changed in a session is useful. Since last save is
maybe less useful since most IDEs have autosave and lots of people seem to like
it.
But as @b4n points out there are operations that can
> Just a shameless promotion - with my LSP plugin the clangd server seems to
> always return the "right" symbol based on its true visibility from the given
> position so no popup like that seems to be necessary.
You took the words right out my mouth, thats what happens with Vscode using LSP
@techee @b4n do we still want this in 2.0?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#issuecomment-1751845522
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- requested changes on this pull request.
> @@ -841,8 +827,8 @@ on_font_dialog_response(GtkDialog *dialog, gint response,
> gpointer user_data)
{
gchar *fontname;
- fontname = gtk_font_selection_dialog_get_font_name(
-
This touches strings (doesn't it?) and we're in string freeze so I'm afraid
it's too late now.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1751834172
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #2082.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2082#event-10582679011
You are receiving this because you are subscribed to this thread.
Message ID:
> There is a LSP plugin for Geany? Nice, I should give that a try :)
See https://github.com/techee/geany-lsp
and https://github.com/geany/geany/pull/3571
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#issuecomment-1751821714
You are receiving
> The disadvantage of your version is that the popup could get much bigger in
> some extreme cases but I think it's acceptable.
Yeah, if we want we can also limit the symbol side under 80 if it's a concern
-- although again, if there isn't enough info it can stop being useful.
> (Just a
> PS: this has string changes, not sure how bad that is for release… but I
> think this PR might be worth sorting out anyway.
Yes, I am aware of that and I actually talked with @frlan about it today in
person at Prague Linux Days. And he wasn't too serious about the string freeze
in this case.
> I really dislike italics, I think it makes things a lot harder to read, and I
> don't see the need (esp. as the symbol part has a different font). We had
> them before but only for the non-best match, which is IMO better. If you
> wanna keep them, let's only do so for those, not for the bold
> The problem seems to an extreme edge case
Not saying it's common, but AFAIR bulk search & replace will do that
(potentially massively change lines from the end to the start)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3551#issuecomment-1751810201
> I added a commit to enable the change history since it was trivial. Seems
> like a nice, user-visible change to take along (gives a bit of a modern
> feeling).
I'm a tad late to the party (as usual), but I don't think it should be enabled
by default. Here's a few reasons:
* I've seen it do
PS: this has string changes, not sure how bad that is for release… but I think
this PR might be worth sorting out anyway.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#issuecomment-1751803793
You are receiving this because you are subscribed to
First thoughts:
* I really dislike italics, I think it makes things a lot harder to read, and I
don't see the need (esp. as the symbol part has a different font). We had them
before but only for the non-best match, which is IMO better. If you wanna keep
them, let's only do so for those, not
I've just re-pushed: I removed one more use of GTK_CHECK_VERSION from this
patch which is already removed by #3316 to avoid merge conflicts.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3580#issuecomment-1751782225
You are receiving this because you
@techee pushed 1 commit.
31dfef5e12bc5adfe9ca7ed3baf6192dab24b2eb Bump GTK version requirement to 3.24
--
View it on GitHub:
https://github.com/geany/geany/pull/3580/files/9240847efcac459b8e2c19239e721d81832ad53d..31dfef5e12bc5adfe9ca7ed3baf6192dab24b2eb
You are receiving this because you are
I've been running the ever so slightly different implementation of this for a
long while and it worked nicely for me. Just tested this PR again, and it
seems to indeed actually behave the same, so I'm merging it.
--
Reply to this email directly or view it on GitHub:
Merged #3490 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3490#event-10582215719
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3454 as completed via #3490.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3454#event-10582215751
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3573 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3573#event-10582062068
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #1274 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1274#event-10582056563
You are receiving this because you are subscribed to this thread.
Message ID:
@ntrel pushed 1 commit.
2cb19afa7bcc1b4612338bf5d0cb645034793bce Update filter docs
--
View it on GitHub:
https://github.com/geany/geany/pull/2356/files/04b4ba508a43239a36223d8574a9239ad4d5d3cd..2cb19afa7bcc1b4612338bf5d0cb645034793bce
You are receiving this because you are subscribed to this
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3581
-- Commit Summary --
* Update of Slovak translation
-- File Changes --
M po/sk.po (160)
-- Patch Links --
https://github.com/geany/geany/pull/3581.patch
@ntrel commented on this pull request.
> -if git.found()
+if git.found() and fs.is_dir('.git')
ret = run_command(git, 'rev-parse', '--short', '--revs-only', 'HEAD',
check: true)
cdata.set_quoted('REVISION', ret.stdout().strip())
else
Looks OK.
--
Reply to this email
@b4n commented on this pull request.
> -if git.found()
+if git.found() and fs.is_dir('.git')
ret = run_command(git, 'rev-parse', '--short', '--revs-only', 'HEAD',
check: true)
cdata.set_quoted('REVISION', ret.stdout().strip())
else
So what about something like this (untested
> I don't really want to support meson from the tarball. It's still too
> experimental. If it seems to work from the tarball some guy or distro is
> going to rely on it.
We should definitely clearly mark this as experimental then.
But ATM it'll work from a tarball given `git` is not installed
I don't really want to support meson from the tarball. It's still too
experimental. If it seems to work from the tarball some guy or distro is going
to rely on it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#issuecomment-1751683826
You are
> given I see check: true maybe it'd be easy to change that…
Yeah, `check:false` does not fail, but returns `ret.return_code()` that can be
tested for success.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#issuecomment-1751680768
You are
Can't we simply not error-out if the `git` command fails, and assume
`REVISION=-1` as well then? given I see `check: true` maybe it'd be easy to
change that…
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#issuecomment-1751677602
You are
31 matches
Mail list logo
