[Github-comments] Re: [geany/geany] Other warnings hidden inside all the ELEMENT ones. (Issue #3689)

2023-11-20 Thread Colomban Wendling via Github-comments
I dare you try it 藍 Seriously though it might even work. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3689#issuecomment-1818477352 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Correction of issue #3678 (PR #3681)

2023-11-19 Thread Colomban Wendling via Github-comments
@b4n requested changes on this pull request. LGTM (obviously) but for the tiny style issue. > @@ -1649,8 +1649,7 @@ void sidebar_focus_symbols_tab(void) if (ui_prefs.sidebar_visible && interface_prefs.sidebar_symbol_visible) { GtkNotebook *notebook =

[Github-comments] Re: [geany/geany] Support writing plugins in Vala (Discussion #3696)

2023-11-19 Thread Colomban Wendling via Github-comments
Note that IIRC the reason Geany doesn't actually install the GIR file is that there (was) not enough testing regarding its quality. And also that the only *direct* consumer would be Vala, as other languages would still require a loader ([Peasy](https://github.com/kugel-/peasy) being the obvious

[Github-comments] Re: [geany/geany] How it is implemented disabling GIO unsafe file saving in Geany? (Discussion #3697)

2023-11-19 Thread Colomban Wendling via Github-comments
> I do not want any swap file, backup file ... be created, because […] those > unnecessary writes means use of energy and hardware wear Did you measure that they are? I mean, in either case the *whole* file is re-written, the only question is *where* it is. The additional operation is the

[Github-comments] Re: [geany/geany] How to force Geany to open unknown files as plain text/ASCII? (Discussion #3687)

2023-11-19 Thread Colomban Wendling via Github-comments
I should also add that it'd be quite easy to allow *opening* files with embedded NULs, I actually think it's just a matter of removing the check. However, it's likely a *lot* of features won't work right with the NULs, truncating some parts (and then, as @eht16 said it's totally fixable, but a

[Github-comments] Re: [geany/geany] Other warnings hidden inside all the ELEMENT ones. (Issue #3689)

2023-11-19 Thread Colomban Wendling via Github-comments
> > Does anybody actually cares about warnings from a non-GNUC compiler? > > Neat, we can remove 90% of the autotools test crap :-) Note that I'm saying "*about warnings* form a non-GNUC compiler", not that we shouldn't *build* fine with any random compliant compiler -- which we definitely

[Github-comments] Re: [geany/geany] How it is implemented disabling GIO unsafe file saving in Geany? (Discussion #3697)

2023-11-19 Thread Colomban Wendling via Github-comments
Why would you disable this on the first place? The issue you linked has a fairly complete explanation on why it exists, and unless save actually fails (e.g. no free space, failure to rename to the source or other errors). If really Caja is showing those file for a longer time, I see two

[Github-comments] Re: [geany/geany] Other warnings hidden inside all the ELEMENT ones. (Issue #3689)

2023-11-17 Thread Colomban Wendling via Github-comments
> Well, thats GUNC only IIUC, unlike G_NORETURN which supports multiple > compilers. Does anybody *actually* cares about warnings from a non-GNUC compiler? I mean, it's supported by GCC and clang, and I don't think any of us is using anything else? > Of course C++ indicates it with no name

[Github-comments] Re: [geany/geany] Correction of issue #3678 (PR #3681)

2023-11-17 Thread Colomban Wendling via Github-comments
@b4n requested changes on this pull request. This is way too specific and fragile. Do this instead: ```diff diff --git a/src/sidebar.c b/src/sidebar.c index 9d004f392..435e31394 100644 --- a/src/sidebar.c +++ b/src/sidebar.c @@ -1649,7 +1649,7 @@ void sidebar_focus_symbols_tab(void) if

[Github-comments] Re: [geany/geany] Correction of issue #3678 (PR #3681)

2023-11-17 Thread Colomban Wendling via Github-comments
I don't really care either for which it is; but maybe restoring this to the previous state is the safer solution. FWIW, I don't use that shortcut (didn't even know it existed :smile:) so I don't mind. > works for me, and I too really don't understand why the same call on > `treeview2` (the

[Github-comments] Re: [geany/geany] Symbol list does not get the focus when access through key binding (Issue #3678)

2023-11-17 Thread Colomban Wendling via Github-comments
> especially as it works if focus is switched to the document list first. Well, not really surprising if you don't actually check it *does* work per se: if the notebook is already focused, the code will switch active page and that'll be enough to bring focus to whatever make sense there. --

[Github-comments] Re: [geany/geany] Other warnings hidden inside all the ELEMENT ones. (Issue #3689)

2023-11-17 Thread Colomban Wendling via Github-comments
> How are you gonna get rid of the unused parameter warnings on all the GTK > callbacks? `-Wno-unused-parameter` :smile: If we really want that one, we could also sprinkle the code with `G_GNUC_UNUSED` all over the place; but is it worth it? -- Reply to this email directly or view it on

[Github-comments] Re: [geany/geany] [RFC] API for LSP plugins (PR #3571)

2023-11-17 Thread Colomban Wendling via Github-comments
:warning: **Disclaimer**: Big chunk ahead! I started this taking notes reading the above discussion, and more, and I might not have re-written it that nicely, so bear with me -- but I think I should reply before the decade is over :) First of all: I was thrilled by seeing this, LSP support

[Github-comments] Re: [geany/geany] Other warnings hidden inside all the ELEMENT ones. (Issue #3689)

2023-11-16 Thread Colomban Wendling via Github-comments
/me just learned that Meson had a built-in flag to enable some [random compiler warnings](https://mesonbuild.com/Builtin-options.html#details-for-warning_level). Half-neat, half-silly, but well. But yes, with `-Wextra` you're *gotta* want `-Wno-unused-parameter` at *least*. -- Reply to this

[Github-comments] Re: [geany/geany] Less warnings (PR #3665)

2023-11-16 Thread Colomban Wendling via Github-comments
Merged #3665 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3665#event-10980256453 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Less warnings (PR #3665)

2023-11-16 Thread Colomban Wendling via Github-comments
@b4n pushed 12 commits. ffad343f21be323b55b3ca44c6f2d0d4d9a008fb Fix harmless GCC warning 7f630aaf917b733c76640574610017fc3a7c15ab Fix fairly nasty implicit integer conversion 30a4200bfe48fa6fd09ec66c0b1b16d0d62451ed "Fix" passing const arguments to spawn functions

[Github-comments] Re: [geany/geany] Other warnings hidden inside all the ELEMENT ones. (Issue #3689)

2023-11-16 Thread Colomban Wendling via Github-comments
What are the "ELEMENT" warnings? For the Geany one(s), see #3665. For CTags, see https://github.com/universal-ctags/ctags/pull/3840 for fixing some of them; but CTags has *many* warnings (at least with my wonderful flags :slightly_smiling_face: ) that are not trivial to fix; but please, get a

[Github-comments] Re: [geany/geany] Cannot open uncompressed PDF file (Issue #3677)

2023-11-07 Thread Colomban Wendling via Github-comments
Sure, it won't be a convenient experience, and if the non-binary data is not single-byte encoded it's unlikely to be really usable as even stripping/replacing the NULs will not allow to convert to that multi-byte encoding if it has stricter rules than "any byte goes anywhere" (like UTF-8).

[Github-comments] Re: [geany/geany] Cannot open uncompressed PDF file (Issue #3677)

2023-11-07 Thread Colomban Wendling via Github-comments
Yes, any ISO-8859-* stream with no NULs is convertible to UTF-8 with no NULs. Or am I missing something? I don't think any of ISO-8859-* has things Unicode cannot represent :) -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Cannot open uncompressed PDF file (Issue #3677)

2023-11-07 Thread Colomban Wendling via Github-comments
> Still the image data may not be convertible to UTF-8, its just a sequence of > bytes, not any encoding. UTF-8 no, but many encodings are actually "a sequence of bytes", which is the reason why choosing the right one when opening is so hard (basically, it's a guessing game if you don't know

[Github-comments] Re: [geany/geany] Cannot open uncompressed PDF file (Issue #3677)

2023-11-06 Thread Colomban Wendling via Github-comments
> Any viable workaround ? Viable I don't know, but I heard some people working around NUL bytes by replacing those with a placeholder and back after edition. Something like `sed -i 's/\0/%%NUL%%/g' file && geany file && sed -i 's/%%NUL%%/\x00/g/'` or along the idea. Something like that should

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-03 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > SSM(sci, SCI_SETILEXER, 0, (uintptr_t) lexer); - if (old != (gint)lexer_id) + if (old != sci_get_lexer(sci)) OK. I can easily use this here (seems to work), but porting every use in Geany is gonna be more tricky, especially for cases

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-03 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > SSM(sci, SCI_SETILEXER, 0, (uintptr_t) lexer); - if (old != (gint)lexer_id) + if (old != sci_get_lexer(sci)) I'm not sure what is the recommendation on this: the [documentation](https://scintilla.org/ScintillaDoc.html#SCI_SETILEXER)

[Github-comments] Re: [geany/geany] Prefs: move "virtual spaces" to the "Features" tab (Issue #3605)

2023-11-02 Thread Colomban Wendling via Github-comments
Closed #3605 as completed via 4b54306424918c2e4a3f3d3a553463065420cf7c. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3605#event-10849945054 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Move "Virtual Spaces" preference to "Editor -> Features" (PR #3643)

2023-11-02 Thread Colomban Wendling via Github-comments
Merged #3643 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3643#event-10849945064 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] 2.0.0: meson fails on Linux with ` Dependency "gtk-mac-integration" not found` (Issue #3649)

2023-11-02 Thread Colomban Wendling via Github-comments
@techee thanks for the test! Committed, as well as 2 additional small improvements, that nobody else tested, so I have a chance to have introduced a big stupid error :smile: -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] 2.0.0: meson fails on Linux with ` Dependency "gtk-mac-integration" not found` (Issue #3649)

2023-11-02 Thread Colomban Wendling via Github-comments
Closed #3649 as completed via fb202dc583a9deefa3c17046fd7d5ad23c21e180. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3649#event-10849911654 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-11-02 Thread Colomban Wendling via Github-comments
Merged #3642 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3642#event-10849888473 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson error: meson.build:446:32: ERROR: The `==` operator of bool does not accept objects of type int (1) (Issue #3618)

2023-11-02 Thread Colomban Wendling via Github-comments
Closed #3618 as completed via 215271b02dbfa13e54bee77b6d3a8a76ec1fad68. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3618#event-10849888462 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Less warnings (PR #3665)

2023-11-02 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > - * { 0, 19, "geany-3.0.css" }, -*/ - }; - - guint gtk_version = gtk_get_minor_version(); - for (guint i = 0; i < G_N_ELEMENTS(css_files); i++) - { - if (gtk_version >=

[Github-comments] Re: [geany/geany] Less warnings (PR #3665)

2023-11-02 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -906,7 +906,12 @@ static gint sort_found_tags(gconstpointer a, > gconstpointer b, gpointer user_data * followed by workspace tags, * followed by global tags */ if (t1->type & tm_tag_local_var_t && t2->type &

[Github-comments] Re: [geany/geany] Less warnings (PR #3665)

2023-11-02 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 974fb802a897333b003ebea568bdfb8a7194d2a2 fixup! Fix fairly nasty implicit integer conversion -- View it on GitHub: https://github.com/geany/geany/pull/3665/files/12b30c5950eeccad2fed885745ff6cd0888d1d3a..974fb802a897333b003ebea568bdfb8a7194d2a2 You are receiving this

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-02 Thread Colomban Wendling via Github-comments
…and you could check this patch using this: ```bash #!/bin/bash diff -u \ <( git show | grep -P '#define highlighting_lexer_' | awk '{print $3}' | \ while read -r lexer_id; do read -r lexer_name test "${lexer_name%_*}" = highlighting_lexer && continue echo "$lexer_id $lexer_name" done |

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-02 Thread Colomban Wendling via Github-comments
> Looks good _but_ I didn't check if the actual lexer names are correct - but > see the related comment in the review. Yeah that's the tricky/boring part. What I did was based on the results from `git grep -h 'LexerModule.*SCLEX_' | sed -r 's/^.*(SCLEX_\w*)\W[^"]*("[^"]*").*$/\1: \2/' | sort

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-02 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 1009e021c39bb116e77f007ec4e59d7fb64fc8a6 Use Scintilla lexer names rather than deprecated IDs -- View it on GitHub: https://github.com/geany/geany/pull/3668/files/28fb2d044defbfe62bb29464f3e96700d2f7b663..1009e021c39bb116e77f007ec4e59d7fb64fc8a6 You are receiving this

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-02 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -696,23 +696,24 @@ gint sci_get_lexer(ScintillaObject *sci) } -void sci_set_lexer(ScintillaObject *sci, guint lexer_id) +void sci_set_lexer_name(ScintillaObject *sci, const gchar *lexer_name) Fair enough, as indeed I ended up removing the old one.

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-02 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > { - g_warning("Failed to find lexer for ID %u", lexer_id); + g_warning("Failed to find lexer for name %s", lexer_name); I don't know how expansive it'd be indeed, so whether or not it's reasonable to do it, but we could

[Github-comments] Re: [geany/geany] Installed 2.0, but 1.38 still loads (Discussion #3671)

2023-11-02 Thread Colomban Wendling via Github-comments
You install in `/usr/local`, while having an installation in `/usr` as well (I guess). I think it's a Ubuntu-specific problem, but anyway the issue is (very likely) that your `/usr/local/bin/geany` uses the library from `/usr/lib/libgeany.so` rather than `/usr/local/lib/geany`. You can verify

[Github-comments] [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-10-31 Thread Colomban Wendling via Github-comments
Title says it all: instead of fetching the name from the deprecated ID, directly use the lexer name. This removes a deprecation warning, and probably aligns us for the future. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3668 -- Commit

[Github-comments] Re: [geany/geany] Most recent directory is not remembered (Discussion #3664)

2023-10-31 Thread Colomban Wendling via Github-comments
> Although the OP has "no reasons for me to start Geany from the command line" > clearly others do, or the locking problem would not have been noticed and the > SF bug would not have been raised. I don't know how Windows does it, but the same problem would happen if the default working

[Github-comments] Re: [geany/geany] Less warnings (PR #3665)

2023-10-31 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > if (main_status.main_window_realized) - dialogs_show_msgbox(GTK_MESSAGE_WARNING, warn_msg, display_filename); + dialogs_show_msgbox(GTK_MESSAGE_WARNING, "%s", warn_msg); + +

[Github-comments] Re: [geany/geany] 2.0.0: meson fails on Linux with ` Dependency "gtk-mac-integration" not found` (Issue #3649)

2023-10-30 Thread Colomban Wendling via Github-comments
> Even with `--auto-features=enabled` MAC related things should be only checked > on MAC. Sounds reasonable to me; and `--auto-features=enabled` seems useful to make sure a (potentially new) dependency is not missed. Would something like this work? ```diff diff --git a/meson.build

[Github-comments] Re: [geany/geany] wrong functions showed in symbols (Issue #3661)

2023-10-30 Thread Colomban Wendling via Github-comments
Current universal-ctags still suffers from the issue. > Detecting command start might not be simple since they can be embedded. It is not trivial indeed. And the other solution of being stricter parsing `function …` is tricky as well because the syntax is actually fairly complex (e.g.

[Github-comments] Re: [geany/geany] Less warnings (PR #3665)

2023-10-30 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > if (main_status.main_window_realized) - dialogs_show_msgbox(GTK_MESSAGE_WARNING, warn_msg, display_filename); + dialogs_show_msgbox(GTK_MESSAGE_WARNING, "%s", warn_msg); + +

[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

2023-10-29 Thread Colomban Wendling via Github-comments
> An alternative would be to replace all checks for WIN32 in the code with > _WIN32, but there are lots of places.. And they are in ctags code, so this would have to be fixed upstream. Not tested, but looks OK. -- Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany] Less warnings (PR #3665)

2023-10-29 Thread Colomban Wendling via Github-comments
With this, you should be able to build *src/* and *plugins/* warning-free with `CFLAGS=-Wall -Wextra -g -Og -Wno-unused-parameter -Wunreachable-code -Wformat=2 -Wundef -Wshadow -Wpointer-arith -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs

[Github-comments] Re: [geany/geany] Replace utils_make_human_readable_str() with g_format_size() (PR #3657)

2023-10-29 Thread Colomban Wendling via Github-comments
Merged #3657 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3657#event-10800492414 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Pasting via middle-click clears X selection (Issue #3658)

2023-10-26 Thread Colomban Wendling via Github-comments
I don't see the same behavior, although kinda similar: I cannot paste multiple times from the editor to itself. On the first paste it clears the initial selection, and that clears the PRIMARY X selection. I believe that used to work, which was a lot more convenient I think. However, with

[Github-comments] Re: [geany/geany] Replace utils_make_human_readable_str() with g_format_size() (PR #3657)

2023-10-26 Thread Colomban Wendling via Github-comments
> Edit: are you _sure_ you want to use a functions that was only introduced in > Glib 2.30 12 years ago, 2011, thats the same year as C11, surely thats way > too new ;-P Hehe :) Hold tight though, I'm kind of planning to see what our minimal GTK dependency brings as of minimal GLib dependency

[Github-comments] Re: [geany/geany] New feature requests? (Issue #3659)

2023-10-26 Thread Colomban Wendling via Github-comments
> select and write out a particular chunk of code outside to be used elsewhere. You could use the [context action](https://geany.org/manual/#context-actions) with a custom script, but note that this can be set per-filetype as well, in which case it's less convenient for this. You could use a

[Github-comments] [geany/geany] Replace utils_make_human_readable_str() with g_format_size() (PR #3657)

2023-10-25 Thread Colomban Wendling via Github-comments
This allows removing a needlessly complex and tricky function (I dare you understanding what it actually does the first time around) in which we even introduced subtle (but luckily invisible for now) bugs over time as it was probably not understood properly, and more sensitive to breakage than

[Github-comments] Re: [geany/geany] Clang warnings: sizeof ((((void *)0)))' will return the size of the pointer (#2906)

2023-10-25 Thread Colomban Wendling via Github-comments
Closed #2906 as completed via #2398. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2906#event-10771516561 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Rewrite HL_N_ENTRIES macro to avoid a GCC8 false positive warning (#2398)

2023-10-25 Thread Colomban Wendling via Github-comments
Merged #2398 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2398#event-10771516299 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] indentation: curly braces difference js x php (review all languages that use them?) (Issue #3655)

2023-10-25 Thread Colomban Wendling via Github-comments
Closed #3655 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3655#event-10768517618 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] indentation: curly braces difference js x php (review all languages that use them?) (Issue #3655)

2023-10-25 Thread Colomban Wendling via Github-comments
Works for me, be it with *current characters* or *matching brace* indentation methods. Note however that auto-indentation here will not happen if you have something on the right of the cursor when typing the closing brace. What is you version of Geany? Does disabling plugins help? (`geany

[Github-comments] Re: [geany/geany] Question: When is the next release coming? (Discussion #3404)

2023-10-24 Thread Colomban Wendling via Github-comments
Closed #3404 as resolved. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3404 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Question: When is the next release coming? (Discussion #3404)

2023-10-24 Thread Colomban Wendling via Github-comments
So, definite answer is "last Thursday" :wink: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3404#discussioncomment-7374811 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Is it possible to increase the menu font size in the Windows version of Geany 2.0 WITHOUT recompiling the program? (Issue #3652)

2023-10-24 Thread Colomban Wendling via Github-comments
@b4n converted this issue into discussion #3653. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3652#event-10759585164 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Is it possible to increase the menu font size in the Windows version of Geany 2.0 WITHOUT recompiling the program? (Issue #3652)

2023-10-24 Thread Colomban Wendling via Github-comments
Yes, you can adjust this with custom [GTK CSS](https://docs.gtk.org/gtk3/css-overview.html). Go to [*Tools → Configuration Files → geany.css*](https://geany.org/manual/#customizing-geany-s-appearance-using-gtk-css), and insert something like `menu { font-size: 15pt; }` or `* { -gtk-dpi: 120;

[Github-comments] Re: [geany/geany] Increase the default width for the sidebar (PR #3637)

2023-10-24 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. Just squash when ready -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3637#pullrequestreview-1695676632 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Increase the default width for the sidebar (PR #3637)

2023-10-24 Thread Colomban Wendling via Github-comments
BTW, if setting this to `-1`, it'll use the minimum size so things fit, which is a bit wider than current master with the entry (I think I was right earlier). It'll however happily hide tabs as we allow this. Anyway, 220 or 230 look indeed better to me, and work as well if I use Adwaita on my

[Github-comments] Re: [geany/geany] Autotools: regenerate gmo files when po files are updated (PR #3650)

2023-10-24 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 35043402562a8ba8566f0cd4d7be6a1c94f006ba Autotools: regenerate gmo files when po files are updated -- View it on GitHub: https://github.com/geany/geany/pull/3650/files/6ed2d48a0b32b6a93501e0a49819fa64f06a50b6..35043402562a8ba8566f0cd4d7be6a1c94f006ba You are receiving

[Github-comments] Re: [geany/geany] Increase the default width for the sidebar (PR #3637)

2023-10-24 Thread Colomban Wendling via Github-comments
> > And when it doesn't fit why doesn't it do as I said, hide Documents and > > show the scroll arrows? Is that controlled by Adwaita too? > > I don't know. I had guessed it's rather GTK than the theme but I really don't > know. My guess would land on the search entry that has a minimum with

[Github-comments] Re: [geany/geany] Move "Virtual Spaces" preference to "Editor -> Features" (PR #3643)

2023-10-23 Thread Colomban Wendling via Github-comments
>Looks good - I just tested this PR and it works as described (no way for a >human being to review the XML diff itself). Use Git's own diff to see it, and enable highlighting of moved lines. Almost all of it is just moved, minus a few lines holding indices and such (and maybe uselessly

[Github-comments] Re: [geany/geany] 2.0.0: inconsistency in versioning (Issue #3644)

2023-10-23 Thread Colomban Wendling via Github-comments
OK, got it. Well, it's kind of a special case as IIUC you're using Geany-Plugins' version to depend on Geany; but I get it. Well in the end if it simplifies things I'm fine using `major.minor.micro` everywhere (only `2.0.0` will look kinda ugly (objectively :wink:), `2.1.0` will be fine), I

[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-23 Thread Colomban Wendling via Github-comments
> Ok, I made a script to grep all the `#define` and `#undef` symbols in > `config.h` and Geany appears to be fairly careful using `ifdef` `ifndef` or > `defined()`, Good :) > Scintilla has at least one place where it compares a symbol to 0, but I think > its its own internal one so fine.

[Github-comments] Re: [geany/geany] Update some paths in HACKING (PR #3641)

2023-10-23 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGBI -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3641#pullrequestreview-1692419285 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-23 Thread Colomban Wendling via Github-comments
Yeah, but it means not only the set of defines is different between meson and autotools, but also their value. We could be careful (and we probably are), but that sound like a great receipt for weird differences -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-23 Thread Colomban Wendling via Github-comments
Yeah well, meson has its own complicated handling depending on whether the value is a boolean or not…we probably could just use a boolean as IIRC it would just make for a define without a value, but that'd be different from what we have currently, so theoretically it could impact the C code

[Github-comments] Re: [geany/geany] 2.0.0: inconsistency in versioning (Issue #3644)

2023-10-22 Thread Colomban Wendling via Github-comments
This sounds like a continuation of https://github.com/geany/geany/commit/13bc05d80f456d8ed745e4fbfbf4286a49d1acaf#commitcomment-130441271, but I still don't understand what's the actual problem. Yes, it's not the same version string, but what harm does it do? For me, the rationale here is: *

[Github-comments] [geany/geany] Move "Virtual Spaces" preference to "Editor -> Features" (PR #3643)

2023-10-22 Thread Colomban Wendling via Github-comments
Editor - Display is very crowded already, and virtual spaces are not merely a display feature, but rather a tool for editing. Close #3605. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3643 -- Commit Summary -- * Move Virtual Spaces

[Github-comments] Re: [geany/geany] Feature request: Split Norwegian into `nb_NO` and `nn_NO` (Issue #3638)

2023-10-22 Thread Colomban Wendling via Github-comments
> Probably would be good if "somebody" provided a preliminary `nb.po` file > rather than rushing the whole translation at string freeze. Yes, and it's unlikely a large amount of the translation would be invalidated anyway, so most of it would still be usable by then. -- Reply to this email

[Github-comments] Re: [geany/geany] Feature request: Split Norwegian into `nb_NO` and `nn_NO` (Issue #3638)

2023-10-22 Thread Colomban Wendling via Github-comments
I'm not sure I entirely get this. We have `nn` translation indeed. We don't have `nb`. I am not sure how the locale selection is made for Norwegian (I guess when the configured language is either `no_NO` or `nb_NO`) as we rely on the system/on the gettext library to perform this step; but

[Github-comments] Re: [geany/geany] "Name" and "Value" is not translatable in Preferences dialog (Issue #3628)

2023-10-22 Thread Colomban Wendling via Github-comments
Closed #3628 as completed via 656b03bc00fe3a17b6b369f41b436c1473fa953d. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3628#event-10733916371 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Enable translations in the "Various" tab in preferences dialog (PR #3634)

2023-10-22 Thread Colomban Wendling via Github-comments
Merged #3634 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3634#event-10733916374 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-22 Thread Colomban Wendling via Github-comments
When a value could either be defined or not, we used to call either `set(varname, 1)` or `set(varname, false)` respectively. This however leads to the value type of `varname` to be conditional, making it virtually unusable for testing its value. Instead, just do not emit anything when we used

[Github-comments] Re: [geany/geany] Update some paths in HACKING (PR #3641)

2023-10-22 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -658,7 +658,7 @@ https://github.com/universal-ctags/ctags Method `` -* Add foo.c to SRCS in Makefile.am and meson.build. +* Add foo.c to SRCS in ctags/Makefile.am and meson.build. It's in `parsers` inside `ctags/Makefile.am` ```suggestion * Add

[Github-comments] Re: [geany/geany] Add meson.build to release howto and replace IRC by Matrix (PR #3633)

2023-10-22 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3633#pullrequestreview-1691455022 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson error: meson.build:446:32: ERROR: The `==` operator of bool does not accept objects of type int (1) (Issue #3618)

2023-10-22 Thread Colomban Wendling via Github-comments
Actually, its has nothing to do with the Meson version I think, it's just that `fnmatch` isn't found on the OP system, and the code uses either [`cfg_data.set(varname, 1)`](https://mesonbuild.com/Reference-manual_returned_cfg_data.html#cfg_dataset) or [`cfg_data.set(name,

[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)

2023-10-21 Thread Colomban Wendling via Github-comments
@scootergrisen did you use a fresh configuration? C.f. > It works for me, but note that this is the default value for a preference, so > it won't ever be updated on an existing installation. Try with `geany -c > /tmp/nonexistant`, you should see the translation. You should also be able to

[Github-comments] Re: [geany/geany] symbols panels dont update list after switching files (Issue #3622)

2023-10-20 Thread Colomban Wendling via Github-comments
Just as puzzled here, but given 2.0 will not load older plugins, it's unlikely it's the issue… Do you see the same thing using a fresh configuration, e.g. with `geany -c /tmp/tmpconf`? If not, save your conf and see if you can share it. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Feature request (Issue #3530)

2023-10-20 Thread Colomban Wendling via Github-comments
IIUC what the goal is, for one keyword you can already use *Search → More → Mark All* (or Ctrl+Shift+M). For more keywords, it kind of depends on the use case; but if you cant to highlight a specific set of keywords, always the same, you can probably make a custom file type based on some

[Github-comments] Re: [geany/geany] Emoji flag section is empty (Issue #3619)

2023-10-20 Thread Colomban Wendling via Github-comments
FWIW I have this on Debian GNU/Linux. Normally this is plain GTK (we don't do anything about this on our end), so either there's something missing in our GTK bundle, or there's something that prevents GTK from showing those (missing font or something?). > Maybe remove/hide sections that have

[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)

2023-10-20 Thread Colomban Wendling via Github-comments
OK no, it works fine here, I just had a stale `da.gmo` in my local directory, but the content of the tarball is OK. @eht16 is it possible you didn't build the Windows binaries from a fresh clone, and had a stale thing as well? -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)

2023-10-20 Thread Colomban Wendling via Github-comments
Hum, scratch that, doesn't seem to work for Danish… -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3620#issuecomment-1772764720 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)

2023-10-20 Thread Colomban Wendling via Github-comments
It works for me, but note that this is the default value for a preference, so it won't ever be updated on an existing installation. Try with `geany -c /tmp/nonexistant`, you should see the translation. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Replace never released version 1.39 by 2.0 (13bc05d)

2023-10-19 Thread Colomban Wendling via Github-comments
@kloczek Sorry I don't get it, they both use the same scheme: `major.minor.micro` as the tag, and `major.minor[.micro if micro > 0]` or however I can describe that for the asset names. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Replace never released version 1.39 by 2.0 (13bc05d)

2023-10-19 Thread Colomban Wendling via Github-comments
@kloczek not sure I get it, it's always been like that -- check e.g. the previous release https://github.com/geany/geany/releases/tag/1.38.0: tag is 1.38.0 but tarballs use 1.38. I guess if there's a compelling reason to do otherwise we could, but up until now we used the full version in tags,

[Github-comments] [geany/geany] Release 2.0.0 - Geany 2.0

2023-10-19 Thread Colomban Wendling via Github-comments
## General * Split "session data" into session.conf, preferences are written to and read from geany.conf ([PR#2776](https://github.com/geany/geany/pull/2776), [PR#2779](https://github.com/geany/geany/pull/2779), [PR#3014](https://github.com/geany/geany/pull/3014),

[Github-comments] Re: [geany/geany-plugins] Set release date (d50d5b3)

2023-10-19 Thread Colomban Wendling via Github-comments
I'm disappointed, when I saw @dmaphy's message I expected at *least* 2024… :disappointed: :laughing: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/commit/d50d5b31977db01fe6e63af7e6dedf0601402594#commitcomment-130432943 You are receiving this

[Github-comments] Re: [geany/geany] Replace never released version 1.39 by 2.0 (PR #3617)

2023-10-19 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM if you want, and the `@since` makes sense to update :+1: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3617#pullrequestreview-1688098429 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] `AddGeanyLexers()` omits the AsciiDoc module since 19336d2 (Issue #3615)

2023-10-19 Thread Colomban Wendling via Github-comments
@kugel- no problem, it happens, even if it's kinda stressful right now. And as @techee says, better see this now than in 24 hours… :laughing: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3615#issuecomment-1771120466 You are receiving this because

[Github-comments] Re: [geany/geany] `AddGeanyLexers()` omits the AsciiDoc module since 19336d2 (Issue #3615)

2023-10-19 Thread Colomban Wendling via Github-comments
Closed #3615 as completed via bc9f6e4dccea09b746510c0f262c2e3bf0ce11c9. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3615#event-10712974328 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix crash opening an AsciiDoc document (PR #3616)

2023-10-19 Thread Colomban Wendling via Github-comments
Merged #3616 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3616#event-10712974495 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] `AddGeanyLexers()` omits the AsciiDoc module since 19336d2 (Issue #3615)

2023-10-19 Thread Colomban Wendling via Github-comments
@rdipardo big kudos for the detailed and investigated report, hugely appreciated! See #3616 which should fix the crash and bring AsciiDoc back. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3615#issuecomment-1770882492 You are receiving this because

[Github-comments] [geany/geany] Fix crash opening an AsciiDoc document (PR #3616)

2023-10-19 Thread Colomban Wendling via Github-comments
@elextr one for you: not only is it AsciiDoc, but its also a candidate for very-last-minute fix :smile: @elextr @techee @eht16 I think we ought to do something for 2.0 here, because indeed hitting this crash is as easy as trying to open e.g. `foo.asciidoc`… You can view, comment on, or merge

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-19 Thread Colomban Wendling via Github-comments
@elextr what you're describing is hinting ;) The trade-off between faithful glyph shape rendering versus blurry render because pixels are big. And I agree that better hinting is better, but it's tricky. I admittedly got used to bad one because some upgrade lead to poorer hinting everywhere on

[Github-comments] Re: [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-19 Thread Colomban Wendling via Github-comments
@techee yeah, but here just using the icon name won't solve it, you also need to use the symbolic version for the problematic icons. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3614#issuecomment-1770418473 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] lineoperations: Fix translation of some strings (PR #1286)

2023-10-18 Thread Colomban Wendling via Github-comments
@frlan Ideally this could make it to 2.0 as it would extend translation and is fairly trivial, but if it doesn't because it's way too late for this nothing new breaks. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1286#issuecomment-1769587343

[Github-comments] [geany/geany-plugins] Small update of the French translation (PR #1287)

2023-10-18 Thread Colomban Wendling via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1287 -- Commit Summary -- * Small update of the French translation -- File Changes -- M po/fr.po (232) -- Patch Links --

<    1   2   3   4   5   6   7   8   9   10   >