@b4n commented on this pull request.
> @@ -658,7 +658,7 @@ https://github.com/universal-ctags/ctags
Method
``
-* Add foo.c to SRCS in Makefile.am and meson.build.
+* Add foo.c to SRCS in ctags/Makefile.am and meson.build.
It's in `parsers` inside `ctags/Makefile.am`
```suggestion
* Add
@b4n approved this pull request.
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3633#pullrequestreview-1691455022
You are receiving this because you are subscribed to this thread.
Message ID:
Actually, its has nothing to do with the Meson version I think, it's just that
`fnmatch` isn't found on the OP system, and the code uses either
[`cfg_data.set(varname,
1)`](https://mesonbuild.com/Reference-manual_returned_cfg_data.html#cfg_dataset)
or [`cfg_data.set(name,
@scootergrisen did you use a fresh configuration? C.f.
> It works for me, but note that this is the default value for a preference, so
> it won't ever be updated on an existing installation. Try with `geany -c
> /tmp/nonexistant`, you should see the translation.
You should also be able to
Just as puzzled here, but given 2.0 will not load older plugins, it's unlikely
it's the issue…
Do you see the same thing using a fresh configuration, e.g. with `geany -c
/tmp/tmpconf`? If not, save your conf and see if you can share it.
--
Reply to this email directly or view it on GitHub:
IIUC what the goal is, for one keyword you can already use *Search → More →
Mark All* (or Ctrl+Shift+M).
For more keywords, it kind of depends on the use case; but if you cant to
highlight a specific set of keywords, always the same, you can probably make a
custom file type based on some
FWIW I have this on Debian GNU/Linux. Normally this is plain GTK (we don't do
anything about this on our end), so either there's something missing in our GTK
bundle, or there's something that prevents GTK from showing those (missing font
or something?).
> Maybe remove/hide sections that have
OK no, it works fine here, I just had a stale `da.gmo` in my local directory,
but the content of the tarball is OK. @eht16 is it possible you didn't build
the Windows binaries from a fresh clone, and had a stale thing as well?
--
Reply to this email directly or view it on GitHub:
Hum, scratch that, doesn't seem to work for Danish…
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3620#issuecomment-1772764720
You are receiving this because you are subscribed to this thread.
Message ID:
It works for me, but note that this is the default value for a preference, so
it won't ever be updated on an existing installation. Try with `geany -c
/tmp/nonexistant`, you should see the translation.
--
Reply to this email directly or view it on GitHub:
@kloczek Sorry I don't get it, they both use the same scheme:
`major.minor.micro` as the tag, and `major.minor[.micro if micro > 0]` or
however I can describe that for the asset names.
--
Reply to this email directly or view it on GitHub:
@kloczek not sure I get it, it's always been like that -- check e.g. the
previous release https://github.com/geany/geany/releases/tag/1.38.0: tag is
1.38.0 but tarballs use 1.38.
I guess if there's a compelling reason to do otherwise we could, but up until
now we used the full version in tags,
## General
* Split "session data" into session.conf, preferences are written to and read
from geany.conf ([PR#2776](https://github.com/geany/geany/pull/2776),
[PR#2779](https://github.com/geany/geany/pull/2779),
[PR#3014](https://github.com/geany/geany/pull/3014),
I'm disappointed, when I saw @dmaphy's message I expected at *least* 2024…
:disappointed: :laughing:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/commit/d50d5b31977db01fe6e63af7e6dedf0601402594#commitcomment-130432943
You are receiving this
@b4n approved this pull request.
LGTM if you want, and the `@since` makes sense to update :+1:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3617#pullrequestreview-1688098429
You are receiving this because you are subscribed to this thread.
@kugel- no problem, it happens, even if it's kinda stressful right now. And as
@techee says, better see this now than in 24 hours… :laughing:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3615#issuecomment-1771120466
You are receiving this because
Closed #3615 as completed via bc9f6e4dccea09b746510c0f262c2e3bf0ce11c9.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3615#event-10712974328
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3616 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3616#event-10712974495
You are receiving this because you are subscribed to this thread.
Message ID:
@rdipardo big kudos for the detailed and investigated report, hugely
appreciated!
See #3616 which should fix the crash and bring AsciiDoc back.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3615#issuecomment-1770882492
You are receiving this because
@elextr one for you: not only is it AsciiDoc, but its also a candidate for
very-last-minute fix :smile:
@elextr @techee @eht16 I think we ought to do something for 2.0 here, because
indeed hitting this crash is as easy as trying to open e.g. `foo.asciidoc`…
You can view, comment on, or merge
@elextr what you're describing is hinting ;) The trade-off between faithful
glyph shape rendering versus blurry render because pixels are big.
And I agree that better hinting is better, but it's tricky. I admittedly got
used to bad one because some upgrade lead to poorer hinting everywhere on
@techee yeah, but here just using the icon name won't solve it, you also need
to use the symbolic version for the problematic icons.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3614#issuecomment-1770418473
You are receiving this because you are
@frlan Ideally this could make it to 2.0 as it would extend translation and is
fairly trivial, but if it doesn't because it's way too late for this nothing
new breaks.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1286#issuecomment-1769587343
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1287
-- Commit Summary --
* Small update of the French translation
-- File Changes --
M po/fr.po (232)
-- Patch Links --
@smostertdev @frlan This makes translations actually work in several places
(prefs dialog, keybindings list, Nth line dialog)
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1286
-- Commit Summary --
* lineoperations: Fix
@b4n approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#pullrequestreview-1686329485
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
On doc/images/edit_change_history.png:
@eht16 I took the liberty to push to this PR with the fix above.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#discussion_r1364648967
You are receiving this because
@b4n pushed 1 commit.
37647e32ca6861f7d06000d8acf8f8f8e079a405 Distribute new documentation image
--
View it on GitHub:
https://github.com/geany/geany/pull/3593/files/d2186cccddf8a885eae0ccb7c894564f1ac669a0..37647e32ca6861f7d06000d8acf8f8f8e079a405
You are receiving this because you are
@b4n requested changes on this pull request.
New image is missing from the build system. Otherwise I didn't check all PR
and issue references, but looks good! :+1:
On doc/images/edit_change_history.png:
This is not installed!
```diff
diff --git a/doc/Makefile.am b/doc/Makefile.am
index
Postponing as it's a bit late now. Should probably be merged soon after
release though.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1769503371
You are receiving this because you are subscribed to this thread.
Message ID:
I'm gonna postpone that as discussed in #3614, although it might come back to
bite us.
Or we mention it somewhere in the announcement email? @eht16 :laughing:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3613#issuecomment-1769501953
You are
Agreed, it grew way too out of hand to be merged less than 24 hours before the
deadline.
And I agree with @elextr that it likely requires more testing than just hoping
every other distro is shipping a well-behaving theme (better behaving than
Debian's Adwaita 43) by default, although @techee
@elextr regarding the CI it was merely a squash (no diff from the base
verified) + a rebase… and yes, I let my build and meson finish :P And it's all
green now, ain't it :]
(though, I start to think it's becoming late indeed… I'll only plan to make one
more PR for 2.0 GP :])
--
Reply to
@techee Ah yeah those names are common indeed. And cool, if they are required
by GTK itself, it's indeed very likely to be present, or at least work fine if
not (e.g. falling back on the non-symbolic version) :+1:
--
Reply to this email directly or view it on GitHub:
@eht16 looks like there has been a rebase mishap, and you grabbed some
unrelated things in there :confused:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#issuecomment-1769322566
You are receiving this because you are subscribed to this thread.
You can add #3611 now ;)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#issuecomment-1769320562
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3609 as completed via 4246298dd8b3c70528cdad0554000f5d54f39765.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3609#event-10699097436
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3611 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#event-10699097461
You are receiving this because you are subscribed to this thread.
Message ID:
(I just squashed the commits and rebased on master, will now merge)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#issuecomment-1769315976
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 1 commit.
4246298dd8b3c70528cdad0554000f5d54f39765 Fix startup files order when placing
tabs next to the current one
--
View it on GitHub:
https://github.com/geany/geany/pull/3611/files/0e0b33b5b8f2e858c06ea91128331f7d2252c15b..4246298dd8b3c70528cdad0554000f5d54f39765
You are
See #3614
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3613#issuecomment-1769309119
You are receiving this because you are subscribed to this thread.
Message ID:
See #3613.
Some of the changes here make sense, some dont really but are still needed
not to look terrible with Adwaita 43. See each commit for details.
@techee @eht16 thats kind of how it looks to dodge the Adwaita 43 issues I
could see.
You can view, comment on, or merge this pull request
@techee symbolic icons has nothing to do with using icon names rather than
stock items, apart that stock items don't use symbolic icons.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3613#issuecomment-1769305818
You are receiving this because you
> Might there be any risk that other themes may not work well with the changed
> icon references? I guess this is hard to answer; the icon loading mechanism
> are big mystique to me and so I'm just wondering how much we could break with
> this change.
Well, I'm not 100% sure, but I think yes,
@b4n commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
+
@b4n commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
+
@b4n pushed 1 commit.
0e0b33b5b8f2e858c06ea91128331f7d2252c15b fixup! Fix startup files order when
placing tabs next to the current one
--
View it on GitHub:
https://github.com/geany/geany/pull/3611/files/7ff00f56af24fe1ea9013c9d3b64e14d6dce5f76..0e0b33b5b8f2e858c06ea91128331f7d2252c15b
You
@kugel-
> It's not even clear to me if this is even a bug (as in "not working as
> intended"). I surely never used that pref.
Well, to me it's definitely a bug as the session is *not* restored as it was
saved. Both documents order and current document are lost (well, current
document is OK
@b4n commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
+
> otherwise we might get flooded with bug reports regarding this problem and we
> might have to make a new release because of it anyway.
Yeah that's kind of my point, whomever fault it is, some of it will land on us.
And it still might, as if you install Geany from Debian under GNOME in
Subset of a possible fix:
```diff
diff --git a/src/build.c b/src/build.c
index 56ec9d613..3d94a683f 100644
--- a/src/build.c
+++ b/src/build.c
@@ -1898,7 +1898,7 @@ static RowWidgets *build_add_dialog_row(GeanyDocument
*doc, GtkTable *table, gui
GTK_FILL | GTK_EXPAND,
Following up https://github.com/geany/geany/pull/3593#issuecomment-1757592993,
should we do something about it on our end? Basically the solution is to use
`edit-clear-symbolic` icon-name instead of `GTK_STOCK_CLEAR`, which is for most
of it easy, for some a bit more involved.
* is it our
@b4n commented on this pull request.
On doc/images/main_window.png:
@eht16 yeah… is it a problem in the generated file?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#discussion_r1363823645
You are receiving this because you are subscribed to
@b4n commented on this pull request.
> +Screenshots in the document are the default GTK Adwaita theme,
+but Geany will adapt to the desktop GTK theme that is set.
```suggestion
Screenshots in this document are taken with the default GTK Adwaita
theme, but Geany will adapt to
@eht16 @techee @elextr I added that to %2.0, but if it's not new since 1.38 and
you don't feel it's simple enough, we can postpone. It's actually not a
problem with the default settings, so it's less bad -- although any sane person
would have enabled the problematic option :grin:
--
Reply
@b4n approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3612#pullrequestreview-1684973051
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- @techee looks like it's code points if cursory reading is to be trusted
(looks like it's based on `g_utf8_strlen()`).
Anyway, LGBI and agree that it's not pretty in the prefs dialog as is.
--
Reply to this email directly or view it on GitHub:
@b4n commented on this pull request.
On doc/images/main_window.png:
Agreed it could be bit improved having more room for the editor, event with
Adwaita. And having it a bit taller is probably no problem. Something like
this (though beware! it's a Git build and you can see it)
hum… it's bad, but I'm wondering for how long this existed. I didn't bisect,
but quickly going through this code seems to suggest it's nothing recent (yet,
I might be wrong).
--
Reply to this email directly or view it on GitHub:
When the `tab_order_beside` option is enabled, tabs are opened on either side
of the active tab, depending on `tab_order_ltr`, rather than at either end.
However, when loading startup files we dont switch to the last opened
document right away, but postpone this to the very end. This affects
Merged #3599 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3599#event-10684019579
You are receiving this because you are subscribed to this thread.
Message ID:
Should we postpone? Review the comments and merge?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1767210063
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
On doc/images/pref_dialog_various.png:
> This is also theme-dependent, isn't it?
It is, unless we're explicitly asking for the theme to do something like that
(there's an option I don't remember, but you're only supposed to use that if
things would be
@b4n commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
> The Gnome default screenshot tool adds a think transparent border around the
> images. I could remove it but actually I think it's nice because it gives the
> images some margin when embedded in the HTML
@b4n commented on this pull request.
On doc/images/replace_dialog.png:
That one still needs updating, sorry
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#pullrequestreview-1683207407
You are receiving this because you are subscribed to this
@b4n commented on this pull request.
On doc/images/pref_dialog_templ.png:
Haha I didn't remember I was there :D
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#pullrequestreview-1683202948
You are receiving this because you are subscribed to
Same as @eht16, it looks good if I believe the docs that a value of `[]` make
it use the default behavior.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3608#issuecomment-1767017197
You are receiving this because you are subscribed to this thread.
@b4n commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
@eht16 do you want me to take care of the screenshots, or can you do it with
what I mentioned?
--
Reply to this email directly or view it on GitHub:
@b4n commented on this pull request.
> +* Improved support of ctags file format, this is also the
+ recommended format for generating tags files (PR#3049).
```suggestion
* Improved support for the ctags file format, which is now the
recommended format for tags files
Yeah, it happens if `next to current` is checked.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3609#issuecomment-1766878125
You are receiving this because you are subscribed to this thread.
Message ID:
Ah right, it was notifying when *either* `major` or `minor` was higher. So
yeah, only false positives if the local version is newer than the release.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1284#issuecomment-1766870584
You are receiving
Restoring the session (from my upgraded ~/.config, which has seen all versions
since the dawn of time^W^W^W^W I started using Geany) restores the files, but
not:
* the order
* the current file
It kinda looks like the first element is right, but the reset is sort of loaded
in reverse… Might
> Here you'll be saved by the copy-paste error of the current code where the
> last digit is ignored ;-).
Ah indeed, missed that typo :)
> The current code won't behave as bad as I thought originally because for
> releases the value on the server is the highest number. It would be just in
>
Closed #865 via 38a138f8c0df31787a3f579c5a606c6a71bb1fd9.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/865#event-10680086514
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #952 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/952#event-10680086535
You are receiving this because you are subscribed to this thread.
Message ID:
Yeah let's get it in not to have other people waste time trying to "fix" it.
This won't remove all deprecation warnings (the plugin still uses
`gtk_vbox_new()`) though. I can very easily fix that now we depend on GTK3
anyway though, but that can be for later.
--
Reply to this email directly
@b4n approved this pull request.
LGTM (not tested)
Indeed the check is wrong in many aspects -- event 0.0.2 would be < then 1.38.1
Also, it uses `GEANY_VERSION`, which is a compile-time thing, so better update
your update checker! It could benefit from Geany exposing
@b4n approved this pull request.
WFM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3599#pullrequestreview-1682534844
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/
' -i geany_private.rc
sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac
+sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build
@b4n commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
@eht16 if you move those out of the way:
* */usr/share/icons/Adwaita/48x48/legacy/edit-clear-all.png*
* */usr/share/icons/Adwaita/48x48/legacy/edit-clear.png*
*
@b4n commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
FWIW I just tried in Bookworm VM as well, and was shocked that @eht16 is not
crazy and it *does* look like this, be it on Wayland or X11… playing a tad with
it, it's due to the Adwaita icons, if I use that on
See #2398
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2906#issuecomment-1765889149
You are receiving this because you are subscribed to this thread.
Message ID:
> Yeah, will happily add it once it is merged 爛
It just got in :wink:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#issuecomment-1765856443
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
I'll try and grab my girlfriend's Bullseye (yeah, not updated yet…) which has
whatever version of GNOME shell that came with it, and see if it looks more
"normal". If it does, I'll take the screenshots later
Merged #3049 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#event-10674470211
You are receiving this because you are subscribed to this thread.
Message ID:
As @techee (IIRC) mentioned somewhere, the *Editor→Display* tab is getting
crowded to the point it makes the prefs window grow. I suggest moving the
*Virtual spaces* section to the *Editor→Features* tab that not only has room,
but also seems more fitting to me – it's not a display thing, it's
@b4n approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#pullrequestreview-1681065041
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
Looks fairly useful and simple enough :+1:
Apart from my inline comments, LGTM and WFM.
> + gtk_container_add(GTK_CONTAINER(menu), item);
+ gtk_menu_reorder_child(GTK_MENU(menu), item, 0);
```suggestion
188038a06a1050308fd7621f11147883d7e5b8fc extended the formatting options, but a
blooper made it effectively ignore the language-specific rules, always using
the default one. This affects formatting for Go, Pascal and Python, as well as
introducing memory leaks for those.
You can view, comment
@b4n commented on this pull request.
> {
- if ((NULL == fgets(buf, BUFSIZ, fp)) || ('\0' == *buf))
- return FALSE;
- }
- while (strncmp(buf, "!_TAG_", 6) == 0); /* skip !_TAG_ lines */
+ TMTagType type;
+ TMTag
@b4n approved this pull request.
Apart the small doc changes, LGTM. Limited testing shows it works nicely,
including mixed languages in a tags file. Older tags files I had laying around
using either Pipe or Tagmanager format still seemed to work as usual. I didn't
have any older ctags tags
@b4n requested changes on this pull request.
First pass only based on *code* review, no actual testing yet.
> + TMParserType lang =
> tm_ctags_get_named_lang(value);
+ if (lang >= 0)
+ tag->lang =
Merged #3316 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#event-10658414985
You are receiving this because you are subscribed to this thread.
Message ID:
I added a few minor changes, including a small behavioral one: the goto popup
is again positioned at the mouse if triggered with it, which makes it slightly
better for that use case.
--
Reply to this email directly or view it on GitHub:
@b4n approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#pullrequestreview-1678848601
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 3 commits.
869606ee1427b3611d01ee37c4811942241bb320 Pass the event to
gtk_menu_popup_at_pointer() when possible
705dc3c8eb39c43e54daf171811b412d6eaa5032 Use gtk_menu_popup_at_pointer() in
filebrowser as well
d10cfb503d30ee9bb7848f171dc857e2e90f0de5 Position goto popup at the
@b4n commented on this pull request.
> @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/
' -i geany_private.rc
sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac
+sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build
What about simply adding a `q` command after the first replacement so only that
one is handled?
Le 15 octobre 2023 10:05:04 GMT+02:00, "Enrico Tröger" ***@***.***> a écrit :
>@eht16 commented on this pull request.
>
>
>
>> @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^
@b4n approved this pull request.
You gotta do what you gotta do I guess
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3600#pullrequestreview-1678012613
You are receiving this because you are subscribed to this thread.
Message ID:
Closing in favor to #3597.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#issuecomment-1762816343
You are receiving this because you are subscribed to this thread.
Message ID:
501 - 600 of 793 matches
Mail list logo
