[Github-comments] Re: [geany/geany-plugins] Update pt_BR.po (PR #1260)

2023-08-07 Thread Enrico Tröger via Github-comments
Closed #1260. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1260#event-10028761519 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Update pt_BR.po (PR #1260)

2023-08-07 Thread Enrico Tröger via Github-comments
I suggest to simply close this PR and focus on #1242 which has the same changes. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1260#issuecomment-1668582270 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Rectangular selection mode initialization inserts garbage characters (Issue #3539)

2023-08-07 Thread Enrico Tröger via Github-comments
Can you reproduce this with Scite? I'm not sure but it could be a Scintilla issue (if this is an issue at all?). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3539#issuecomment-1668578154 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany-plugins] Update pt_BR.po (PR #1260)

2023-08-06 Thread Enrico Tröger via Github-comments
I don't get it. Currently, there is no Devhelp in GIT master. So, strictly the *.po files should be updated to remove the previous translations. But since you are already about to re-add the plugin, updating the translation files would be done best after your changes from #1242 have been

[Github-comments] Re: [geany/geany-plugins] Update POTFILES.in (PR #1263)

2023-08-06 Thread Enrico Tröger via Github-comments
Closed #1263. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1263#event-10018007397 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Update pt_BR.po (PR #1260)

2023-08-05 Thread Enrico Tröger via Github-comments
Are these changes intended? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1260#issuecomment-113325 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-08-05 Thread Enrico Tröger via Github-comments
I'd like to merge this in a few days if there are no objections or further remarks. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1257#issuecomment-113074 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Update POTFILES.in (PR #1263)

2023-08-05 Thread Enrico Tröger via Github-comments
Do we need this PR at all? It seems the requested changes are also handled in #1242. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1263#issuecomment-112679 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update use of Python to default to and/or use Python 3 (#2615)

2023-08-05 Thread Enrico Tröger via Github-comments
Not even three later, we finally managed to finish all open tasks. Python 2 R.I.P. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2615#issuecomment-108173 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update use of Python to default to and/or use Python 3 (#2615)

2023-08-05 Thread Enrico Tröger via Github-comments
Closed #2615 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2615#event-10016090976 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Generate PHP global tags in ctags format (PR #3512)

2023-08-05 Thread Enrico Tröger via Github-comments
Merged #3512 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3512#event-10016084237 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update NSIS filetype keywords (PR #3487)

2023-08-05 Thread Enrico Tröger via Github-comments
Merged #3487 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3487#event-10016081995 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Remove obsolete helper scripts (PR #3486)

2023-08-05 Thread Enrico Tröger via Github-comments
Merged #3486 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3486#event-10016081263 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Markdown: "matching" underscores have priority over code block (#1439)

2023-08-05 Thread Enrico Tröger via Github-comments
Since we already use Scintilla 5.1.5 where this bug is fixed, I'll close this issue. Just re-open if you disagree. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1439#issuecomment-104481 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany] Markdown: "matching" underscores have priority over code block (#1439)

2023-08-05 Thread Enrico Tröger via Github-comments
Closed #1439 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1439#event-10016077696 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Markdown syntax highlighting confused by indented code block (#2797)

2023-08-05 Thread Enrico Tröger via Github-comments
Closed #2797 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2797#event-10015656361 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Markdown syntax highlighting confused by indented code block (#2797)

2023-08-05 Thread Enrico Tröger via Github-comments
Since we already use Scintilla 5.1.5 where this bug is fixed, I'll close this issue. Just re-open if you disagree. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2797#issuecomment-1666549586 You are receiving this because you are subscribed to this

[Github-comments] [geany/geany-plugins] Scope: Define GETTEXT_PACKAGE macro for recent cppcheck versions (PR #1264)

2023-08-01 Thread Enrico Tröger via Github-comments
Without this, cppcheck will throw errors like ``` store/scptreestore.c:1990:37: warning: syntax error [syntaxError] g_param_spec_boolean(sublevels, P_(Sublevels), ``` This is probably caused by the P_() macro if GETTEXT_PACKAGE is not set. Admittedly, this is the easy way to fix or better

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-08-01 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > { + AoTasksUpdateTasksForDocArguments *arguments = data; + AoTasks *t = arguments->t; + GeanyDocument *doc = arguments->doc; Alright, done and also in a few more places in the Addons plugin. -- Reply to this email directly or view

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-08-01 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. b1ba03c3edc70677df578ee7282456e38f965af5 Use DOC_VALID macro across the Addons plugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1257/files/d975ce3f6c1a8e03d94ceb73bfc635b84bf2a1cc..b1ba03c3edc70677df578ee7282456e38f965af5 You are receiving this

[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)

2023-07-31 Thread Enrico Tröger via Github-comments
> I made the modifications. What is the next step? Be a bit more patient until someone does a full review. I would like to but cannot say when I find time to do it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1659157748 You

[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)

2023-07-31 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -0,0 +1,10 @@ +include $(top_srcdir)/build/vars.docs.mk + +plugin = devhelp + +dist_plugindata_DATA = \ + devhelp-plugin.svg \ + devhelp-plugin-48.png \ + geany-devhelp-plugin.png \ The file is still not referenced here or am I

[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)

2023-07-31 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -0,0 +1,367 @@ +/* Included directly into dhp-object.c just to keep this whole mess out What is this comment about? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#pullrequestreview-1555760609

[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)

2023-07-31 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -0,0 +1,365 @@ +Installation Instructions This file is always not very useful, these are just generic install instructions which mainly don't fit for this plugin. I'd say better remove it than just keeping it around. -- Reply to this email

[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)

2023-07-31 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -0,0 +1,10 @@ +include $(top_srcdir)/build/vars.auxfiles.mk + +if GP_GTK3 Well, I meant that both branches of the switch seem to do the same and so the switch is not necessary at all. Additionally, Geany-Plugins are always using GTK3, we do not

[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)

2023-07-31 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -0,0 +1,1630 @@ +# Doxyfile 1.7.1 Just delete it. This is the configuration for Doxygen, a tool to generate API documentation for code. But it is unlikely to be necessary or useful in this context. If you at some point in the future want to use

[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)

2023-07-30 Thread Enrico Tröger via Github-comments
> there were 23 commits, so I ran git reset --soft HEAD~22 and deleted 96 > files. Was that the procedure? This removed the commits only for you locally, they are still here in the repository. Just the delete (`git rm` as @elextr said) the files mentioned in one of my comments above. > hello,

[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)

2023-07-30 Thread Enrico Tröger via Github-comments
@eht16 requested changes on this pull request. I had a quick look and left a few comments. Though this was no proper review, just a first look. > @@ -0,0 +1 @@ +Matthew Brush Maybe add yourself here? > +} + + +/* Load module */ +G_MODULE_EXPORT +void geany_load_module(GeanyPlugin *plugin) +{

[Github-comments] Re: [geany/geany] Change the color of the menu and symbol bar ... (Discussion #3529)

2023-07-16 Thread Enrico Tröger via Github-comments
@elextr thanks for the reminder. I merged and deployed the PR and it is now available at https://www.geany.org/documentation/faq/#how-to-change-the-gtk-theme. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3529#discussioncomment-6461487 You are

[Github-comments] Re: [geany/www.geany.org] Explain changing GTK theme in FAQ (PR #40)

2023-07-16 Thread Enrico Tröger via Github-comments
Merged #40 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/40#event-9831492335 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Create file.md (PR #3517)

2023-07-16 Thread Enrico Tröger via Github-comments
Merged #3517 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3517#event-9831472307 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Compiling geangy-plugins appeared errors (Issue #1255)

2023-07-09 Thread Enrico Tröger via Github-comments
@Novak-Zhao you can use the changes from https://github.com/geany/geany-plugins/pull/1259 to fix the build. E.g. by downloading the changes as patch from https://github.com/geany/geany-plugins/pull/1259.patch and then apply it locally, should work with the 1.38 sources as well. -- Reply to

[Github-comments] Re: [geany/geany-plugins] vimode: Don't build the viw binary on Windows (PR #1259)

2023-07-09 Thread Enrico Tröger via Github-comments
Thank you @techee. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1259#issuecomment-1627827244 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)

2023-07-09 Thread Enrico Tröger via Github-comments
> @eht16 I did the rebase, verified it compiles/works as expected on my rhel 8 > workstation. Shall we give the CI another shot? The CI is fine. Though you added quite some new code in the last commit which should be reviewed. Btw, what is the "#5" referring to you mentioned in the commit

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-07-09 Thread Enrico Tröger via Github-comments
@elextr fine by you now? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1257#issuecomment-1627749597 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Create file.md (PR #3517)

2023-07-09 Thread Enrico Tröger via Github-comments
Nice idea. If there are no objections, I'll merge this in a few days. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3517#issuecomment-1627748936 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] vimode: Don't build the viw binary on Windows (PR #1259)

2023-07-09 Thread Enrico Tröger via Github-comments
> end of summer holidays so he can check. Unfortunately no holidays but I was unable to find enough time anyway :). > > CI passes! > > Was the original problem reproducible with our CI (and the version of msys2 > our CI uses)? Let's just celebrate the CI passes, even without any reason!

[Github-comments] Re: [geany/geany] CSS nesting syntax coloring (Issue #3523)

2023-07-09 Thread Enrico Tröger via Github-comments
Just to be sure, @bobWinner did you mean to use CSS nesting on the gtk.css / theming? Or did you refer to the syntax highlighting of CSS files within Geany? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3523#issuecomment-1627724948 You are receiving

[Github-comments] Re: [geany/geany-plugins] Copmiling geangy-plugins appeared errors (Issue #1255)

2023-06-10 Thread Enrico Tröger via Github-comments
@Novak-Zhao contacted me via mail additionally and after updating my MSYS2 environment to the latest packages, I can reproduce the problem. So I assume something has changed which triggers the build errors. I'm not completely sure whether I have read the log correctly, to me it seems it fails

[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)

2023-06-10 Thread Enrico Tröger via Github-comments
> Hmmm, the other CI builds seem to work without a problem. For some reason > this one isn't getting picked up: > > ``` > This request was automatically failed because there were no enabled runners > online to process the request for more than 1 days. > ``` Maybe this is related to the

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-06-10 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > { + AoTasksUpdateTasksForDocArguments *arguments = data; + AoTasks *t = arguments->t; I think so. The `AoTasks` object exists as long as the Addons plugin is loaded, independently of opened documents and independent of whether the Tasks

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-06-10 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > { + AoTasksUpdateTasksForDocArguments *arguments = data; + AoTasks *t = arguments->t; + GeanyDocument *doc = arguments->doc; I don't know if there is more than checking `data` for `NULL`. BUt at least I've added this. -- Reply to

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-06-10 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. d975ce3f6c1a8e03d94ceb73bfc635b84bf2a1cc Add more sanity checks -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1257/files/d6cb2c252b314088dd1ae99bacb1a55794098c79..d975ce3f6c1a8e03d94ceb73bfc635b84bf2a1cc You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-06-10 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. d6cb2c252b314088dd1ae99bacb1a55794098c79 Add more sanity checks -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1257/files/e06dced5ccd9aba9af257fb3fca68c3ab13157dd..d6cb2c252b314088dd1ae99bacb1a55794098c79 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)

2023-06-10 Thread Enrico Tröger via Github-comments
>The Windows build doesn't fail (it uses a docker image with >pre-installed deps), but devhelp does not configure, possibly because >that image doesn't have the requisite dependencies. The Docker image is not really relevant here, it only has some dependencies as some sort of cache. The workflow

[Github-comments] Re: [geany/geany-plugins] TODO tasks need the autorefresh button when opening a file to be visible 1.38 kubuntu 22.04, plasma 5.24 (Issue #1254)

2023-06-04 Thread Enrico Tröger via Github-comments
Thank you @elextr for the detailed analysis and for finding that it's us in Geany itself and not (yet) Scintilla. Apart from the upcoming Scintilla change, #1257 should improve the current situation for the Addons task updating by delaying it. In my tests, this worked reliably. -- Reply to

[Github-comments] [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-06-04 Thread Enrico Tröger via Github-comments
Closes #1254. This is not completely perfect but will do the trick to delay the parsing of tasks in the current document until the main loop has triggered the also delayed colourising of the current document which is necessary for parsing the tasks. You can view, comment on, or merge this pull

[Github-comments] [geany/geany] Generate PHP global tags in ctags format (PR #3512)

2023-06-04 Thread Enrico Tröger via Github-comments
This is the follow-up PR for #3488 and #3039 to seperate the code for generating the ctags format into a commonly used helper module and to use the ctags format also for the global PHP tags. Works fine so far. I noticed the return type (`typeref` in ctags speak) for symbols is not parsed

[Github-comments] Re: [geany/geany-plugins] TODO tasks need the autorefresh button when opening a file to be visible 1.38 kubuntu 22.04, plasma 5.24 (Issue #1254)

2023-05-27 Thread Enrico Tröger via Github-comments
I debugged this and the plugin works. But for some reason, when the plugin checks the newly opened file for comments and to look for keywords, there is no styling set yet in the Scintilla object. And since there is no styling set, the plugin finds no comments at all

[Github-comments] Re: [geany/geany-plugins] ProjectOrganizer: Initialise "is_header" variable (PR #1252)

2023-05-23 Thread Enrico Tröger via Github-comments
Yeah, I think too it was safe before. The intention was just to silence cppcheck. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1252#issuecomment-1560087410 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] ProjectOrganizer: Initialise "is_header" variable (PR #1252)

2023-05-22 Thread Enrico Tröger via Github-comments
Older cppcheck versions (e.g. 1.90) complain about this while newer versions (e.g. 2.10) do not. @techee is `FALSE` a proper default here? You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1252 -- Commit Summary -- *

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-05-21 Thread Enrico Tröger via Github-comments
Closed #1239. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#event-9296330950 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-05-21 Thread Enrico Tröger via Github-comments
Done in #1201. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#issuecomment-1556234319 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-05-21 Thread Enrico Tröger via Github-comments
Merged #1201 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1201#event-9296327438 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Refs #2615 - Convert create_py_tags.py to Python 3 (#2630)

2023-05-21 Thread Enrico Tröger via Github-comments
Closed #2630. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2630#event-9296320401 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Refs #2615 - Convert create_py_tags.py to Python 3 (#2630)

2023-05-21 Thread Enrico Tröger via Github-comments
Done in #3039 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2630#issuecomment-1556231313 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2023-05-21 Thread Enrico Tröger via Github-comments
Merged #3039 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3039#event-9296319491 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-21 Thread Enrico Tröger via Github-comments
Merged #3488 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3488#event-9296317872 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] TASKS not showing from.txt files geany 1.38 kubuntu 22.04, plasma 5.24.7 (Issue #1251)

2023-05-21 Thread Enrico Tröger via Github-comments
Closed #1251 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1251#event-9296314224 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] TASKS not showing from.txt files geany 1.38 kubuntu 22.04, plasma 5.24.7 (Issue #1251)

2023-05-21 Thread Enrico Tröger via Github-comments
The plugin only considers TODO keywords which are part of a comment. Thus you also need a document with a filetype which supports comments. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1251#issuecomment-1556229940 You are receiving this

[Github-comments] Re: [geany/geany] Why not add a "build and run" button to the toolbar (Issue #3477)

2023-05-21 Thread Enrico Tröger via Github-comments
Oh, sorry. This was a left over from a previous "Build" command result. Unfortunately in this case very misleading, so I recreated the screenshot in the above post. Sorry for the confusion. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Restore startup behavior to focus files from the command line after session files (PR #3267)

2023-05-20 Thread Enrico Tröger via Github-comments
Fine by me to merge. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3267#issuecomment-1555906663 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Why not add a "build and run" button to the toolbar (Issue #3477)

2023-05-20 Thread Enrico Tröger via Github-comments
@elextr is right for a proper implementation and I agree this might be of little use for more than simple single file programs. If needed, you can configure Geany to build your code in the run command. Just tested and works pretty good if you can live to have the compiler output in the

[Github-comments] Re: [geany/geany] Geany 1.33 AutoSave FilesOpenList, using Debian Buster 10 in Oracle VirtualBox inside Windows 10 PC (Issue #3502)

2023-05-15 Thread Enrico Tröger via Github-comments
> 1a) Linux Terminal commands sudo apt update and sudo apt full-upgrade never > update Geany 1.33 to its current version of 1.38. Thus Geany 1.33 remains > apparently the "latest available" version of Geany within a Windows PC > running Oracle Virtual Box Debian Buster 10; and thus a 32-bits OS

[Github-comments] Re: [geany/geany] Geany 1.38 - Opening Large Log Files Appear Empty (Issue #3498)

2023-05-14 Thread Enrico Tröger via Github-comments
Maybe it should. Here, the file is opened without an error if I force "Without encoding". This is probably because the encoding detection code is not used then and so won't fail on NULL bytes. But the file is *not* opened without errors because in Geany, it is loaded until the first NULL byte

[Github-comments] Re: [geany/geany-themes] Fixed markup colors. Final fix. (PR #60)

2023-05-14 Thread Enrico Tröger via Github-comments
Merged #60 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/60#event-9239685299 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Geany 1.38 - Opening Large Log Files Appear Empty (Issue #3498)

2023-05-14 Thread Enrico Tröger via Github-comments
Regarding the file open issue: it's not about encodings in this case but the file contains NULL bytes and Geany does not support that. See also https://github.com/geany/geany/issues/1508 which has even more references to issues like this. To answer the probably upcoming question when it will

[Github-comments] Re: [geany/geany] Remove obsolete helper scripts (PR #3486)

2023-05-12 Thread Enrico Tröger via Github-comments
I removed the others as well. If we need them again, they still can be restored from GIT. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3486#issuecomment-1546324520 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Remove obsolete helper scripts (PR #3486)

2023-05-12 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 6fd7e7eff9ba453c915847757a5d67e4ac02db53 Remove obsolete helper scripts -- View it on GitHub: https://github.com/geany/geany/pull/3486/files/c8718048810da953d2aad32188b9e4e385aa33ce..6fd7e7eff9ba453c915847757a5d67e4ac02db53 You are receiving this because you are

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-12 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > # write tags script_dir = dirname(__file__) tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags') -with open(tags_file_path, 'w') as tags_file: +with open(tags_file_path, 'w', encoding='iso-8859-1') as

[Github-comments] Re: [geany/geany] Port "main.py" template to Python3 (PR #3485)

2023-05-12 Thread Enrico Tröger via Github-comments
Merged #3485 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3485#event-9236621018 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-themes] Fixed mark-up colors in theme evg-ega-dark, reverted a change in mkin… (PR #59)

2023-05-12 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -8,7 +8,7 @@ import os import sys import json -from configparser import ConfigParser +import ConfigParser See #58 where the script is roughly ported to Python3 though there is still way more to do (linting, modernising the code, ...) but it works

[Github-comments] Re: [geany/geany-themes] Fixed mark-up colors in theme evg-ega-dark, reverted a change in mkin… (PR #59)

2023-05-12 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. On index/index.json: Not necessary, master has already an updated index (see #58). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/59#pullrequestreview-1425148898 You are receiving this because you are

[Github-comments] Re: [geany/geany-themes] Fixed mark-up colors in theme evg-ega-dark, reverted a change in mkin… (PR #59)

2023-05-12 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -156,6 +156,67 @@ of the tree. If you don't have GNU make (ex. on Windows), don't worry about doing this step, it's entirely trivial for me to do it. +IMPORTANT NOTE 2023-05-11 by Evgueni Antonov (github: StrayFeral): This file is meant as

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2023-05-10 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -8,296 +7,368 @@ # # This script should be run in the top source directory. # -# Parses all files given on command line for Python classes or functions and write -# them into data/tags/std.py.tags (internal tagmanager format). +# Parses all files

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2023-05-10 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > # If called without command line arguments, a preset of common Python libs > is used. # # WARNING -# Be aware that running this script will actually *import* modules in the specified directory +# Be aware that running this script will actually

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2023-05-10 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 706ee56f0f0b2c09744c380b033b2ff44682a95e Fix doc typos -- View it on GitHub: https://github.com/geany/geany/pull/3039/files/d350dad27a45656cd9c84a0ac9dfb3a0412d6604..706ee56f0f0b2c09744c380b033b2ff44682a95e You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-10 Thread Enrico Tröger via Github-comments
> Is there a reason that Python tags are in ctags format and php tags in > tagmanager? Before #3039, Python tags were also in tagmanager format and so are the PHP tags. As said in https://github.com/geany/geany/pull/3488#issuecomment-1537369732, I would switch the format to ctags for the PHP

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-10 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > # write tags script_dir = dirname(__file__) tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags') -with open(tags_file_path, 'w') as tags_file: +with open(tags_file_path, 'w', encoding='iso-8859-1') as

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-10 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > (arg_list, TA_ARGLIST), (return_type, TA_VARTYPE), (scope, TA_SCOPE)]: if attr is not None: -tag_line +=

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-10 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 721550ca76caa155dc3ea2c7e0edb4710ef6c7e9 Port create_php_tags to Python3 and generate new PHP tags file -- View it on GitHub: https://github.com/geany/geany/pull/3488/files/36ccb38776e6c1439900b39c79b5a20a535c0969..721550ca76caa155dc3ea2c7e0edb4710ef6c7e9 You are

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-05-10 Thread Enrico Tröger via Github-comments
I'm close to give up on this. It's more like that @nrikonomov's comment kills our efforts to find a better solution for most users. Aprt from that, I completely with what @elextr said in https://github.com/geany/geany/issues/3063#issuecomment-1539252949. -- Reply to this email directly or

[Github-comments] [geany/geany-themes] Fix broken theme index (PR #58)

2023-05-10 Thread Enrico Tröger via Github-comments
The first commit roughly ports the `mkindex.py` to work with Python3 and regenerate the broken `index.json` (it got broken in #57 0c0a8c28bcd3479e472f6125f3362c679cfc895b). The broken `index.json` caused an error on the theme index page on the Geany website

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-05-08 Thread Enrico Tröger via Github-comments
> Seriously though, this is the stuff that kills projects. I am already eyeing > out another open source project. What exactly is this referring to? What should kill the project and why? -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Restore startup behavior to focus files from the command line after session files (PR #3267)

2023-05-07 Thread Enrico Tröger via Github-comments
> Haven't looked at this, but it may be affected by #3395. I just tested the latest changes and it seems fine for me now. Had only a minor remark but it is not critical at all. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3267#issuecomment-1537441161

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-05-07 Thread Enrico Tröger via Github-comments
Incorporated the changes from https://github.com/geany/geany/pull/3465 and builds are fine now. I would like to merge this finally in a few days if there are no objections. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Restore startup behavior to focus files from the command line after session files (PR #3267)

2023-05-07 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -4746,8 +4746,12 @@ gboolean editor_goto_pos(GeanyEditor *editor, gint > pos, gboolean mark) sci_goto_pos(editor->sci, pos, TRUE); editor->scroll_percent = 0.25F; - /* finally switch to the page */ -

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-05-07 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. ccce45fba7bcd956edf5e087e8cc34b292fb18f7 CI: Add Windows build -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1201/files/a9be6d6ee8c5d59fbd68e1c85e121a756d086347..ccce45fba7bcd956edf5e087e8cc34b292fb18f7 You are receiving this because you are

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-05-07 Thread Enrico Tröger via Github-comments
> We do? I just looked and couldn't find anything? I was referring to the not yet merged addition to the FAQs in https://github.com/geany/www.geany.org/pull/40. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3063#issuecomment-1537432650 You are

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2023-05-07 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. a9be6d6ee8c5d59fbd68e1c85e121a756d086347 CI: Add Windows build -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1201/files/43f1b202b637c81cb5af6a6bf2f1e4728a8fc6c6..a9be6d6ee8c5d59fbd68e1c85e121a756d086347 You are receiving this because you are

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-05-07 Thread Enrico Tröger via Github-comments
Another year later...luckily we got some more feedback even though it doesn't make the decision for a suitable default theme not easier. The new master plan (suggestion): - merge https://github.com/geany/geany-osx/pull/35 to use it in Windows builds - integrate the Prof-Gnome theme from the

[Github-comments] Re: [geany/geany] Python usage in build (#2896)

2023-05-07 Thread Enrico Tröger via Github-comments
@elextr all of the parts mentioned in the OP are already resolved. Can we close this one? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2896#issuecomment-1537374170 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-07 Thread Enrico Tröger via Github-comments
When #3039 is merged, I would adjust the script to generate ctags file format and share the code with the Python tags script. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3488#issuecomment-1537369732 You are receiving this because you are subscribed

[Github-comments] [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-07 Thread Enrico Tröger via Github-comments
Related to #2615. I dont know how good the newly generated tags are, my PHP knowledge is basically non-existent anymore :). At least, the diff looks like some were added, removed and changed, some keep even unchanged. You can view, comment on, or merge this pull request online at:

[Github-comments] [geany/geany] Update NSIS filetype keywords (PR #3487)

2023-05-07 Thread Enrico Tröger via Github-comments
Created by scripts/update-nsis-functions.sh. Changed keywords: ```diff Changed functions: +!assert +!uninstfinalize +getknownfolderpath +getregview +getshellvarcontext +getwinver +ifaltregview +ifrtllanguage +ifshellvarcontextall +manifestappendcustomstring +manifestlongpathaware +readmemory

[Github-comments] [geany/geany] Remove obsolete helper scripts (PR #3486)

2023-05-07 Thread Enrico Tröger via Github-comments
`scripts/changelist.pl`: process ChangeLog which we do not use anymore `scripts/cross-build-mingw.sh`: old cross build script, replaced by #3315 `scripts/rstrip-whitespace.py`: probably unused (as assumed in #2615) There are more candidates: `scripts/fix-alignment.pl`

[Github-comments] [geany/geany] Port "main.py" template to Python3 (PR #3485)

2023-05-07 Thread Enrico Tröger via Github-comments
Related to #2615. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3485 -- Commit Summary -- * Port main.py template to Python3 -- File Changes -- M data/templates/files/main.py (10) -- Patch Links --

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2023-05-07 Thread Enrico Tröger via Github-comments
I just cleaned the commit history and would like to merge this in a few days if there are no objections. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3039#issuecomment-1537346113 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)

2023-05-06 Thread Enrico Tröger via Github-comments
One thing to note: with the new workflow based on the `msys2/setup-msys2` action, we now depend on a proprietary Windows runner in the CI. I didn't make up my mind about this yet. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Fix building with meson in mingw (PR #3466)

2023-05-06 Thread Enrico Tröger via Github-comments
I guess we are waiting for @kugel- to review. Maybe @eli-schwartz could have a look, for me this would suffice. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3466#issuecomment-1537152304 You are receiving this because you are subscribed to this thread.

<    1   2   3   4   5   6   7   8   9   10   >