Merged #3488 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3488#event-9296317872
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
>
# write tags
script_dir = dirname(__file__)
tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags')
-with open(tags_file_path, 'w') as tags_file:
+with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file:
@elextr commented on this pull request.
>
# write tags
script_dir = dirname(__file__)
tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags')
-with open(tags_file_path, 'w') as tags_file:
+with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file
@eht16 commented on this pull request.
>
# write tags
script_dir = dirname(__file__)
tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags')
-with open(tags_file_path, 'w') as tags_file:
+with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file:
@b4n commented on this pull request.
>
# write tags
script_dir = dirname(__file__)
tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags')
-with open(tags_file_path, 'w') as tags_file:
+with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file:
> Is there a reason that Python tags are in ctags format and php tags in
> tagmanager?
Before #3039, Python tags were also in tagmanager format and so are the PHP
tags.
As said in https://github.com/geany/geany/pull/3488#issuecomment-1537369732, I
would switch the format to ctags for the PHP t
@eht16 commented on this pull request.
>
# write tags
script_dir = dirname(__file__)
tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags')
-with open(tags_file_path, 'w') as tags_file:
+with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file:
@eht16 commented on this pull request.
> (arg_list, TA_ARGLIST),
(return_type, TA_VARTYPE),
(scope, TA_SCOPE)]:
if attr is not None:
-tag_line += '{type:c}{attr}'.
@eht16 pushed 1 commit.
721550ca76caa155dc3ea2c7e0edb4710ef6c7e9 Port create_php_tags to Python3 and
generate new PHP tags file
--
View it on GitHub:
https://github.com/geany/geany/pull/3488/files/36ccb38776e6c1439900b39c79b5a20a535c0969..721550ca76caa155dc3ea2c7e0edb4710ef6c7e9
You are receiv
Is there a reason that Python tags are in ctags format and php tags in
tagmanager?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3488#issuecomment-1539717673
You are receiving this because you are subscribed to this thread.
Message ID:
@elextr commented on this pull request.
>
# write tags
script_dir = dirname(__file__)
tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags')
-with open(tags_file_path, 'w') as tags_file:
+with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file
@cwendling commented on this pull request.
I don't know much PHP anymore either, but at least the script seems to still
work, the difference seem to be in the JSON itself (I only checked a couple
things, but they match).
Sadly the JSON seems to have a few flaws with the types in signatures (no
When #3039 is merged, I would adjust the script to generate ctags file format
and share the code with the Python tags script.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3488#issuecomment-1537369732
You are receiving this because you are subscribed t
13 matches
Mail list logo
