github-actions[bot] commented on pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#issuecomment-697601870
Revision: ecf974670e78e86a47511e3293d192b9f9dfbf2f
Submitted crossbow builds: [ursa-labs/crossbow @
jorisvandenbossche commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r493532800
##
File path: python/pyarrow/array.pxi
##
@@ -21,28 +21,28 @@ import warnings
cdef _sequence_to_array(object sequence, object mask, object
MAHESH-HASBI opened a new issue #8247:
URL: https://github.com/apache/arrow/issues/8247
STOP! Are you reporting a bug, a possible bug, or requesting a
feature? If so, please report under the ARROW project on the ASF JIRA
server https://issues.apache.org/jira/browse/ARROW. This JIRA
bkietz commented on pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#issuecomment-697425261
https://github.com/apache/arrow/pull/8248
This is an automated message from the Apache Git Service.
To respond to
nealrichardson commented on a change in pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#discussion_r493703796
##
File path: r/R/parquet.R
##
@@ -432,19 +453,45 @@ ParquetFileReader <- R6Class("ParquetFileReader",
active = list(
num_rows = function()
pitrou commented on a change in pull request #8249:
URL: https://github.com/apache/arrow/pull/8249#discussion_r493666535
##
File path: python/pyarrow/tests/test_fs.py
##
@@ -1321,6 +1321,8 @@ def test_s3_real_aws():
from pyarrow.fs import S3FileSystem
fs =
github-actions[bot] commented on pull request #8249:
URL: https://github.com/apache/arrow/pull/8249#issuecomment-697520410
https://issues.apache.org/jira/browse/ARROW-10066
This is an automated message from the Apache Git
pitrou commented on pull request #8249:
URL: https://github.com/apache/arrow/pull/8249#issuecomment-697498088
I tested with PR with versions 1.7.164 and 1.8.52 of the AWS SDK.
This is an automated message from the Apache Git
kszucs commented on pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#issuecomment-697524354
The `Ursabot / AMD64 Debian 9 NodeJS 11` builder is no longer enabled in
favor of `Ursabot / AMD64 Debian 9 NodeJS 14`, so it should be good to go from
the buildbot side.
praveenbingo closed pull request #8095:
URL: https://github.com/apache/arrow/pull/8095
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kszucs commented on pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#issuecomment-697573383
@github-actions crossbow submit -g wheel -g integration
This is an automated message from the Apache Git Service.
nealrichardson commented on pull request #8112:
URL: https://github.com/apache/arrow/pull/8112#issuecomment-697620964
It would be nice to have a CI job that would catch issues like this. It
looks like Go tests are only running on 1.12 on GHA. Could you add 1.15 (or is
there a way to say
bkietz opened a new pull request #8248:
URL: https://github.com/apache/arrow/pull/8248
Instead, refer to fields by name
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
bkietz commented on pull request #8240:
URL: https://github.com/apache/arrow/pull/8240#issuecomment-697424423
https://github.com/apache/arrow/pull/8248
This is an automated message from the Apache Git Service.
To respond to
kszucs commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r493697862
##
File path: python/pyarrow/scalar.pxi
##
@@ -615,7 +614,6 @@ cdef class StructScalar(Scalar, collections.abc.Mapping):
--
index
pitrou commented on a change in pull request #8249:
URL: https://github.com/apache/arrow/pull/8249#discussion_r493717801
##
File path: cpp/src/arrow/filesystem/s3fs.cc
##
@@ -99,7 +99,7 @@ using internal::OutcomeToStatus;
using internal::ToAwsString;
using
github-actions[bot] commented on pull request #8248:
URL: https://github.com/apache/arrow/pull/8248#issuecomment-697452887
https://issues.apache.org/jira/browse/ARROW-10073
This is an automated message from the Apache Git
nealrichardson commented on a change in pull request #8246:
URL: https://github.com/apache/arrow/pull/8246#discussion_r493663218
##
File path: r/src/arrow_cpp11.h
##
@@ -157,8 +157,15 @@ struct ns {
template
Pointer r6_to_pointer(SEXP self) {
- return reinterpret_cast(
-
pitrou commented on pull request #8243:
URL: https://github.com/apache/arrow/pull/8243#issuecomment-697352808
> OpenSSL is a security related product. I'm not sure we can release a new
version ASAP when bundled OpenSSL has a vulnerability.
I agree, but I think we already do that
bkietz commented on pull request #8240:
URL: https://github.com/apache/arrow/pull/8240#issuecomment-697387129
@pitrou looks like an ordering-of-dict-fields problem in
test_parquet_nested_storage
https://github.com/apache/arrow/pull/8240/checks?check_run_id=1154644456#step:8:2885
pitrou commented on pull request #8240:
URL: https://github.com/apache/arrow/pull/8240#issuecomment-697401323
@bkietz Yes, this probably needs a quick fixup PR.
This is an automated message from the Apache Git Service.
To
xhochy commented on a change in pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#discussion_r493663621
##
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##
@@ -2360,6 +2361,39 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) {
3);
}
emkornfield commented on a change in pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#discussion_r493685095
##
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##
@@ -2360,6 +2361,39 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) {
3);
nealrichardson commented on a change in pull request #8249:
URL: https://github.com/apache/arrow/pull/8249#discussion_r493696292
##
File path: python/pyarrow/tests/test_fs.py
##
@@ -1321,6 +1321,8 @@ def test_s3_real_aws():
from pyarrow.fs import S3FileSystem
fs =
kszucs closed pull request #8248:
URL: https://github.com/apache/arrow/pull/8248
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on a change in pull request #8249:
URL: https://github.com/apache/arrow/pull/8249#discussion_r493696828
##
File path: python/pyarrow/tests/test_fs.py
##
@@ -1321,6 +1321,8 @@ def test_s3_real_aws():
from pyarrow.fs import S3FileSystem
fs =
pitrou opened a new pull request #8249:
URL: https://github.com/apache/arrow/pull/8249
When the user doesn't set an explicit region, the default algorithm from the
AWS C++ SDK should be used.
With SDK versions >= 1.8, this involves reading environment variables and
potentially
stuartcarnie commented on pull request #8112:
URL: https://github.com/apache/arrow/pull/8112#issuecomment-697519043
@wesm could we get this merged please, which resolves compatibility issues
with versions of Go ≥ 1.14
This
nealrichardson commented on a change in pull request #8249:
URL: https://github.com/apache/arrow/pull/8249#discussion_r493713616
##
File path: cpp/src/arrow/filesystem/s3fs.cc
##
@@ -99,7 +99,7 @@ using internal::OutcomeToStatus;
using internal::ToAwsString;
using
xhochy closed issue #8247:
URL: https://github.com/apache/arrow/issues/8247
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitrou commented on pull request #8249:
URL: https://github.com/apache/arrow/pull/8249#issuecomment-697881452
Successful Travis-CI build here:
https://travis-ci.org/github/pitrou/arrow/builds/729705592
This is an automated
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r492263370
##
File path: js/src/interfaces.ts
##
@@ -356,48 +356,48 @@ type TypeToBuilder = {
/** @ignore */
type DataTypeToBuilder = {
-[key: number
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r493767917
##
File path: js/package.json
##
@@ -100,11 +100,11 @@
"source-map-loader": "0.2.4",
"terser-webpack-plugin": "1.2.1",
"trash": "4.3.0",
-
bkietz commented on pull request #8187:
URL: https://github.com/apache/arrow/pull/8187#issuecomment-697926431
@pitrou CI failure seems unrelated, PTAL
This is an automated message from the Apache Git Service.
To respond to
mark-rushakoff commented on pull request #8112:
URL: https://github.com/apache/arrow/pull/8112#issuecomment-697819493
`go test -race` with go1.15.2 passes the entire Arrow suite. I don't
understand enough about Arrow, or how influxdata/flux uses Arrow, to write a
new test in the Arrow
bkietz commented on a change in pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#discussion_r493791622
##
File path: cpp/src/parquet/arrow/reader.cc
##
@@ -174,10 +174,10 @@ class FileReaderImpl : public FileReader {
Status BoundsCheck(const std::vector&
nealrichardson closed pull request #8249:
URL: https://github.com/apache/arrow/pull/8249
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
wesm closed pull request #8112:
URL: https://github.com/apache/arrow/pull/8112
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
josiahyan commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-698085225
I've updated the PR to cache the capacities, and recompute it whenever it is
changed; please take a look again.
Here are the benchmarks that seemed to have shown some
emkornfield opened a new pull request #8252:
URL: https://github.com/apache/arrow/pull/8252
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
emkornfield opened a new pull request #8251:
URL: https://github.com/apache/arrow/pull/8251
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
emkornfield opened a new pull request #8250:
URL: https://github.com/apache/arrow/pull/8250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kou commented on pull request #8243:
URL: https://github.com/apache/arrow/pull/8243#issuecomment-697989129
Ah, wheel...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
emkornfield opened a new pull request #8253:
URL: https://github.com/apache/arrow/pull/8253
using a literal implies 32-bit integers for some compilers so this could
overflow potentially.
This is an automated message from
github-actions[bot] commented on pull request #8251:
URL: https://github.com/apache/arrow/pull/8251#issuecomment-698083388
https://issues.apache.org/jira/browse/ARROW-10075
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8250:
URL: https://github.com/apache/arrow/pull/8250#issuecomment-698083389
https://issues.apache.org/jira/browse/ARROW-10074
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8252:
URL: https://github.com/apache/arrow/pull/8252#issuecomment-698083386
https://issues.apache.org/jira/browse/ARROW-10076
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8253:
URL: https://github.com/apache/arrow/pull/8253#issuecomment-698083387
https://issues.apache.org/jira/browse/ARROW-10077
This is an automated message from the Apache Git
nevi-me closed pull request #8204:
URL: https://github.com/apache/arrow/pull/8204
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nevi-me closed pull request #8224:
URL: https://github.com/apache/arrow/pull/8224
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jhorstmann commented on pull request #8204:
URL: https://github.com/apache/arrow/pull/8204#issuecomment-697172063
@andygrove format issue is solved
This is an automated message from the Apache Git Service.
To respond to the
liyafan82 commented on pull request #8245:
URL: https://github.com/apache/arrow/pull/8245#issuecomment-697173842
The straightforward way of running a Java benchmark is through the following
command:
```
java -jar ./performance/target/benchmarks.jar
```
However, it is like to
liyafan82 opened a new pull request #8245:
URL: https://github.com/apache/arrow/pull/8245
See https://issues.apache.org/jira/browse/ARROW-10069
This is an automated message from the Apache Git Service.
To respond to the
kou commented on pull request #8243:
URL: https://github.com/apache/arrow/pull/8243#issuecomment-697151804
Right.
It seems that we need to specify `-DBUILD_SHARED_LIBS=off`.
This is an automated message from the
github-actions[bot] commented on pull request #8245:
URL: https://github.com/apache/arrow/pull/8245#issuecomment-697177304
https://issues.apache.org/jira/browse/ARROW-10069
This is an automated message from the Apache Git
romainfrancois commented on pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#issuecomment-697227723
I added some tests for `ReadRowGroup(s)()` and clarified about 0-based.
I'm getting a weird error in some cases with `ReadRowGroups()`:
``` r
naman1996 commented on pull request #8231:
URL: https://github.com/apache/arrow/pull/8231#issuecomment-697189413
Functionality - Takes in 3 arguments. String, split_string, and index. Will
split the given string by using split_string as delimitersand return the string
at index position.
romainfrancois commented on pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#issuecomment-697232130
This returns too early, I believe this needs to be `RETURN_NOT_OK` instead
of `return`:
github-actions[bot] commented on pull request #8231:
URL: https://github.com/apache/arrow/pull/8231#issuecomment-697188782
https://issues.apache.org/jira/browse/ARROW-10023
This is an automated message from the Apache Git
romainfrancois commented on a change in pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#discussion_r493346352
##
File path: cpp/src/parquet/arrow/reader.cc
##
@@ -174,10 +174,10 @@ class FileReaderImpl : public FileReader {
Status BoundsCheck(const
kszucs commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r493355315
##
File path: python/pyarrow/array.pxi
##
@@ -158,24 +158,44 @@ def array(object obj, type=None, mask=None, size=None,
from_pandas=None,
Notes
kszucs commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r493354685
##
File path: cpp/src/arrow/util/converter.h
##
@@ -0,0 +1,353 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
romainfrancois opened a new pull request #8246:
URL: https://github.com/apache/arrow/pull/8246
``` r
library(arrow, warn.conflicts = FALSE)
a <- Array$create(1:10)
tf <- tempfile()
saveRDS(a, tf)
b <- readRDS(tf)
b$length()
#> Error in Array__length(self):
ggershinsky commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r493402883
##
File path: cpp/src/parquet/encryption/remote_kms_client.h
##
@@ -0,0 +1,111 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
kszucs commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r493382407
##
File path: cpp/src/arrow/array/array_list_test.cc
##
@@ -508,6 +534,8 @@ TYPED_TEST(TestListArray, ValidateOffsets) {
this->TestValidateOffsets(); }
github-actions[bot] commented on pull request #8246:
URL: https://github.com/apache/arrow/pull/8246#issuecomment-697259565
https://issues.apache.org/jira/browse/ARROW-10071
This is an automated message from the Apache Git
kszucs commented on pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#issuecomment-697273398
@ursabot build
This is an automated message from the Apache Git Service.
To respond to the message, please log on
67 matches
Mail list logo
