[GitHub] [arrow] jonkeane commented on a change in pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
jonkeane commented on a change in pull request #10476: URL: https://github.com/apache/arrow/pull/10476#discussion_r647622152 ## File path: r/tests/testthat/test-compute-aggregate.R ## @@ -383,33 +383,30 @@ test_that("value_counts", { }) test_that("any.Array and

[GitHub] [arrow-datafusion] Dandandan opened a new issue #525: Add delta tableprovider

2021-06-08 Thread GitBox
Dandandan opened a new issue #525: URL: https://github.com/apache/arrow-datafusion/issues/525 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Delta is used more and more as a storage format, and has some nice features like ACID

[GitHub] [arrow-rs] jorgecarleitao commented on pull request #425: Derive Eq and PartialEq for SortOptions

2021-06-08 Thread GitBox
jorgecarleitao commented on pull request #425: URL: https://github.com/apache/arrow-rs/pull/425#issuecomment-856942081 Thanks! I agree. Could you open an issue for this, so that this ends up in our changelog? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow-datafusion] jorgecarleitao commented on issue #525: Add Delta Lake TableProvider

2021-06-08 Thread GitBox
jorgecarleitao commented on issue #525: URL: https://github.com/apache/arrow-datafusion/issues/525#issuecomment-856941493 fwiw, imo this should be discussed over the mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] jeroen edited a comment on pull request #10414: [C++]: C++17 test PR

2021-06-08 Thread GitBox
/arrow_dataset_objlib.dir/file_ipc.cc.o cd /tmp/apache-arrow-20210608-10068-17s4hhj/build/src/arrow/dataset && /Users/builder/Desktop/brew/Library/Homebrew/shims/mac/super/clang++ -DARROW_DS_EXPORTING -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNT

[GitHub] [arrow-rs] alamb opened a new issue #427: Implement sort by float lists

2021-06-08 Thread GitBox
alamb opened a new issue #427: URL: https://github.com/apache/arrow-rs/issues/427 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** there is no reason not to support sorting lists of floats **Describe the solution you'd

[GitHub] [arrow-rs] alamb closed issue #427: Implement sort by float lists

2021-06-08 Thread GitBox
alamb closed issue #427: URL: https://github.com/apache/arrow-rs/issues/427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow-rs] alamb merged pull request #420: Sort by float lists

2021-06-08 Thread GitBox
alamb merged pull request #420: URL: https://github.com/apache/arrow-rs/pull/420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow-rs] alamb opened a new pull request #432: Cherry pick Fix out of bounds read in bit chunk iterator to active_release

2021-06-08 Thread GitBox
alamb opened a new pull request #432: URL: https://github.com/apache/arrow-rs/pull/432 Automatic cherry-pick of e8d9ef5 * Originally appeared in https://github.com/apache/arrow-rs/pull/416: Fix out of bounds read in bit chunk iterator -- This is an automated message from the

[GitHub] [arrow-rs] alamb opened a new pull request #431: Cherry pick Add set_bit to BooleanBufferBuilder to allow mutating bit in index to active_release

2021-06-08 Thread GitBox
alamb opened a new pull request #431: URL: https://github.com/apache/arrow-rs/pull/431 Automatic cherry-pick of 18c804a * Originally appeared in https://github.com/apache/arrow-rs/pull/383: Add set_bit to BooleanBufferBuilder to allow mutating bit in index -- This is an automated

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #411: Cherry pick Reduce memory usage of concat (large)utf8 to active_release

2021-06-08 Thread GitBox
codecov-commenter edited a comment on pull request #411: URL: https://github.com/apache/arrow-rs/pull/411#issuecomment-854993481 #

[GitHub] [arrow-datafusion] alamb merged pull request #505: Wrong aggregation arguments error.

2021-06-08 Thread GitBox
alamb merged pull request #505: URL: https://github.com/apache/arrow-datafusion/pull/505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow-datafusion] alamb closed issue #496: panic! 'index out of bounds: the len is 0 but the index is 0 with bad sql query

2021-06-08 Thread GitBox
alamb closed issue #496: URL: https://github.com/apache/arrow-datafusion/issues/496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #501: Add `partition by` constructs in window functions and modify logical planning

2021-06-08 Thread GitBox
alamb commented on a change in pull request #501: URL: https://github.com/apache/arrow-datafusion/pull/501#discussion_r647810344 ## File path: datafusion/src/optimizer/utils.rs ## @@ -340,7 +348,19 @@ pub fn rewrite_expression(expr: , expressions: &[Expr]) -> Result {

[GitHub] [arrow-rs] alamb commented on pull request #421: Reenable MIRI check on PRs

2021-06-08 Thread GitBox
alamb commented on pull request #421: URL: https://github.com/apache/arrow-rs/pull/421#issuecomment-857187992 third success: https://github.com/apache/arrow-rs/pull/421/checks?check_run_id=2777893632 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] rok commented on pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
rok commented on pull request #10476: URL: https://github.com/apache/arrow/pull/10476#issuecomment-856925764 Hey @thisisnic, @jonkeane, could you take a look at the [R

[GitHub] [arrow-rs] jorgecarleitao commented on a change in pull request #424: add lexicographically partition points and ranges

2021-06-08 Thread GitBox
jorgecarleitao commented on a change in pull request #424: URL: https://github.com/apache/arrow-rs/pull/424#discussion_r647625641 ## File path: arrow/src/compute/kernels/partition.rs ## @@ -0,0 +1,314 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] nealrichardson commented on pull request #10445: ARROW-9140: [R] Zero-copy Arrow to R where possible

2021-06-08 Thread GitBox
nealrichardson commented on pull request #10445: URL: https://github.com/apache/arrow/pull/10445#issuecomment-856934564 Cool, so that would just be `if(GetBoolOption("arrow.altrep", true) && array->null_count() == 0)` -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow] jeroen commented on pull request #10414: [C++]: C++17 test PR

2021-06-08 Thread GitBox
/tmp/apache-arrow-20210608-10068-17s4hhj/build/src/arrow/dataset && /Users/builder/Desktop/brew/Library/Homebrew/shims/mac/super/clang++ -DARROW_DS_EXPORTING -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAV

[GitHub] [arrow] github-actions[bot] commented on pull request #10484: ARROW-12891: [C++] Move subtree pruning to compute

2021-06-08 Thread GitBox
github-actions[bot] commented on pull request #10484: URL: https://github.com/apache/arrow/pull/10484#issuecomment-857031758 https://issues.apache.org/jira/browse/ARROW-12891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] kou commented on pull request #10478: ARROW-12991: [CI] Migrate Travis-CI ARM job to "arm64-graviton2" arch

2021-06-08 Thread GitBox
kou commented on pull request #10478: URL: https://github.com/apache/arrow/pull/10478#issuecomment-857086677 I forgot that we need to `group: edge` for `arm64-graviton2`. https://docs.travis-ci.com/user/multi-cpu-architectures/#example-multi-architecture-build-matrix > Note

[GitHub] [arrow] jeroen commented on pull request #10414: [C++]: C++17 test PR

2021-06-08 Thread GitBox
jeroen commented on pull request #10414: URL: https://github.com/apache/arrow/pull/10414#issuecomment-857158724 How exactly do I do that? I tried literally substituting that line and that errors with: ``` file_base.cc:77:26: error: 'compression' is not a class, namespace, or

[GitHub] [arrow-rs] alamb merged pull request #382: make sure that only concat preallocates buffers

2021-06-08 Thread GitBox
alamb merged pull request #382: URL: https://github.com/apache/arrow-rs/pull/382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow-rs] alamb opened a new pull request #436: Update release Readme.md

2021-06-08 Thread GitBox
alamb opened a new pull request #436: URL: https://github.com/apache/arrow-rs/pull/436 Don't start search on page 2, make link nicer looking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #435: Cherry pick Sort by float lists to active_release

2021-06-08 Thread GitBox
codecov-commenter edited a comment on pull request #435: URL: https://github.com/apache/arrow-rs/pull/435#issuecomment-857191716 #

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #434: Cherry pick Fix bug with null buffer offset in boolean not kernel to active_release

2021-06-08 Thread GitBox
codecov-commenter edited a comment on pull request #434: URL: https://github.com/apache/arrow-rs/pull/434#issuecomment-857190636 #

[GitHub] [arrow-rs] codecov-commenter commented on pull request #435: Cherry pick Sort by float lists to active_release

2021-06-08 Thread GitBox
codecov-commenter commented on pull request #435: URL: https://github.com/apache/arrow-rs/pull/435#issuecomment-857191716 #

[GitHub] [arrow-rs] codecov-commenter commented on pull request #436: Update release Readme.md

2021-06-08 Thread GitBox
codecov-commenter commented on pull request #436: URL: https://github.com/apache/arrow-rs/pull/436#issuecomment-857192429 #

[GitHub] [arrow] rok commented on a change in pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
rok commented on a change in pull request #10476: URL: https://github.com/apache/arrow/pull/10476#discussion_r647629868 ## File path: r/tests/testthat/test-compute-aggregate.R ## @@ -383,33 +383,30 @@ test_that("value_counts", { }) test_that("any.Array and

[GitHub] [arrow] lidavidm opened a new pull request #10484: ARROW-12891: [C++] Move subtree pruning to compute

2021-06-08 Thread GitBox
lidavidm opened a new pull request #10484: URL: https://github.com/apache/arrow/pull/10484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [arrow] bkietz commented on pull request #10414: [C++]: C++17 test PR

2021-06-08 Thread GitBox
bkietz commented on pull request #10414: URL: https://github.com/apache/arrow/pull/10414#issuecomment-857042761 @jeroen does it work if we replace calls to `optional::value()` with `optional::operator*`? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow-rs] alamb commented on pull request #411: Cherry pick Reduce memory usage of concat (large)utf8 to active_release

2021-06-08 Thread GitBox
alamb commented on pull request #411: URL: https://github.com/apache/arrow-rs/pull/411#issuecomment-857160274 I cherry picked https://github.com/apache/arrow-rs/commit/0cbf85a01f15ab8fc8db654fcdc8fc9b85fc76fb from https://github.com/apache/arrow-rs/pull/382 as well -- This is an

[GitHub] [arrow-rs] alamb opened a new pull request #433: Cherry pick Derive Eq and PartialEq for SortOptions to active_release

2021-06-08 Thread GitBox
alamb opened a new pull request #433: URL: https://github.com/apache/arrow-rs/pull/433 Automatic cherry-pick of 5adfd3d * Originally appeared in https://github.com/apache/arrow-rs/pull/425: Derive Eq and PartialEq for SortOptions -- This is an automated message from the Apache

[GitHub] [arrow-rs] alamb opened a new pull request #435: Cherry pick Sort by float lists to active_release

2021-06-08 Thread GitBox
alamb opened a new pull request #435: URL: https://github.com/apache/arrow-rs/pull/435 Automatic cherry-pick of b440642 * Originally appeared in https://github.com/apache/arrow-rs/pull/420: Sort by float lists -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow-rs] alamb opened a new pull request #434: Cherry pick Fix bug with null buffer offset in boolean not kernel to active_release

2021-06-08 Thread GitBox
alamb opened a new pull request #434: URL: https://github.com/apache/arrow-rs/pull/434 Automatic cherry-pick of 015ee75 * Originally appeared in https://github.com/apache/arrow-rs/pull/418: Fix bug with null buffer offset in boolean not kernel -- This is an automated message from

[GitHub] [arrow-rs] alamb edited a comment on pull request #382: make sure that only concat preallocates buffers

2021-06-08 Thread GitBox
alamb edited a comment on pull request #382: URL: https://github.com/apache/arrow-rs/pull/382#issuecomment-857165876 Included in #411 cherry pick -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow-rs] codecov-commenter commented on pull request #433: Cherry pick Derive Eq and PartialEq for SortOptions to active_release

2021-06-08 Thread GitBox
codecov-commenter commented on pull request #433: URL: https://github.com/apache/arrow-rs/pull/433#issuecomment-857189194 #

[GitHub] [arrow-rs] codecov-commenter commented on pull request #432: Cherry pick Fix out of bounds read in bit chunk iterator to active_release

2021-06-08 Thread GitBox
codecov-commenter commented on pull request #432: URL: https://github.com/apache/arrow-rs/pull/432#issuecomment-857188817 #

[GitHub] [arrow-rs] alamb closed issue #392: window::shift can work for more than just primitive array type

2021-06-08 Thread GitBox
alamb closed issue #392: URL: https://github.com/apache/arrow-rs/issues/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow-rs] alamb merged pull request #388: window::shift to work for all array types

2021-06-08 Thread GitBox
alamb merged pull request #388: URL: https://github.com/apache/arrow-rs/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] rok commented on a change in pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
rok commented on a change in pull request #10476: URL: https://github.com/apache/arrow/pull/10476#discussion_r647625730 ## File path: r/tests/testthat/test-compute-aggregate.R ## @@ -383,33 +383,30 @@ test_that("value_counts", { }) test_that("any.Array and

[GitHub] [arrow] nealrichardson commented on pull request #10414: [C++]: C++17 test PR

2021-06-08 Thread GitBox
nealrichardson commented on pull request #10414: URL: https://github.com/apache/arrow/pull/10414#issuecomment-856940085 @jeroen there are a number of packages on CRAN that use C++17 already, aren't there? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] jeroen commented on pull request #10414: [C++]: C++17 test PR

2021-06-08 Thread GitBox
jeroen commented on pull request #10414: URL: https://github.com/apache/arrow/pull/10414#issuecomment-856945434 Yes I think so, but that does not guarantee that the given compilers support the full c++17 feature set. Perhaps it would be good to add a travis build with: ``` os:

[GitHub] [arrow] jonkeane commented on a change in pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
jonkeane commented on a change in pull request #10476: URL: https://github.com/apache/arrow/pull/10476#discussion_r647637941 ## File path: r/tests/testthat/test-compute-aggregate.R ## @@ -383,33 +383,30 @@ test_that("value_counts", { }) test_that("any.Array and

[GitHub] [arrow-datafusion] houqp commented on issue #525: Add Delta Lake TableProvider

2021-06-08 Thread GitBox
houqp commented on issue #525: URL: https://github.com/apache/arrow-datafusion/issues/525#issuecomment-857006465 I am all for this. I think this is a good move, especially for ballista. I am happy to help maintain the deltalake support in datafusion going forward as well. If we go with

[GitHub] [arrow-rs] alamb commented on pull request #418: Fix bug with null buffer offset in boolean not kernel

2021-06-08 Thread GitBox
alamb commented on pull request #418: URL: https://github.com/apache/arrow-rs/pull/418#issuecomment-857130937 FYI @jorgecarleitao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow-rs] alamb closed issue #417: Boolean `not` kernel does not take offset of null buffer into account

2021-06-08 Thread GitBox
alamb closed issue #417: URL: https://github.com/apache/arrow-rs/issues/417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow-rs] alamb merged pull request #418: Fix bug with null buffer offset in boolean not kernel

2021-06-08 Thread GitBox
alamb merged pull request #418: URL: https://github.com/apache/arrow-rs/pull/418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow-rs] alamb commented on pull request #423: refactor lexico sort for future code reuse

2021-06-08 Thread GitBox
alamb commented on pull request #423: URL: https://github.com/apache/arrow-rs/pull/423#issuecomment-857148980 > seems like rebasing just solved this issue I think that causes the tests to get re-run and thus if the error was due to some network glitch or something it will be solved

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #411: Cherry pick Reduce memory usage of concat (large)utf8 to active_release

2021-06-08 Thread GitBox
codecov-commenter edited a comment on pull request #411: URL: https://github.com/apache/arrow-rs/pull/411#issuecomment-854993481 #

[GitHub] [arrow] jonkeane commented on a change in pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
jonkeane commented on a change in pull request #10476: URL: https://github.com/apache/arrow/pull/10476#discussion_r647637242 ## File path: r/tests/testthat/test-compute-aggregate.R ## @@ -383,33 +383,30 @@ test_that("value_counts", { }) test_that("any.Array and

[GitHub] [arrow-rs] jorgecarleitao merged pull request #425: Derive Eq and PartialEq for SortOptions

2021-06-08 Thread GitBox
jorgecarleitao merged pull request #425: URL: https://github.com/apache/arrow-rs/pull/425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow-rs] jorgecarleitao closed issue #426: Derive Eq and PartialEq for SortOptions

2021-06-08 Thread GitBox
jorgecarleitao closed issue #426: URL: https://github.com/apache/arrow-rs/issues/426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [arrow-rs] alamb commented on pull request #422: disable lexsort bound check

2021-06-08 Thread GitBox
alamb commented on pull request #422: URL: https://github.com/apache/arrow-rs/pull/422#issuecomment-857139303 Thank you @Jimexist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow-rs] alamb commented on pull request #424: add lexicographically partition points and ranges

2021-06-08 Thread GitBox
alamb commented on pull request #424: URL: https://github.com/apache/arrow-rs/pull/424#issuecomment-857150318 BTW I hope to get this into Arrow 4.3 -- I plan to build a release candidate for that on Thursday or Friday this week and release early next week. Once it gets released it will

[GitHub] [arrow-rs] alamb commented on pull request #382: make sure that only concat preallocates buffers

2021-06-08 Thread GitBox
alamb commented on pull request #382: URL: https://github.com/apache/arrow-rs/pull/382#issuecomment-857165876 Included in #411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] lidavidm commented on a change in pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
lidavidm commented on a change in pull request #10476: URL: https://github.com/apache/arrow/pull/10476#discussion_r647616702 ## File path: python/pyarrow/tests/test_compute.py ## @@ -494,30 +494,40 @@ def test_min_max(): def test_any(): # ARROW-1846 + +options =

[GitHub] [arrow] jonkeane commented on a change in pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
jonkeane commented on a change in pull request #10476: URL: https://github.com/apache/arrow/pull/10476#discussion_r647622562 ## File path: r/tests/testthat/test-compute-aggregate.R ## @@ -383,33 +383,30 @@ test_that("value_counts", { }) test_that("any.Array and

[GitHub] [arrow-datafusion] Dandandan commented on issue #525: Add Delta Lake TableProvider

2021-06-08 Thread GitBox
Dandandan commented on issue #525: URL: https://github.com/apache/arrow-datafusion/issues/525#issuecomment-856936027 FYI @houqp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow-rs] alamb commented on pull request #425: Derive Eq and PartialEq for SortOptions

2021-06-08 Thread GitBox
alamb commented on pull request #425: URL: https://github.com/apache/arrow-rs/pull/425#issuecomment-856994059  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [arrow-rs] alamb opened a new issue #428: Add partitioning kernel for sorted arrays

2021-06-08 Thread GitBox
alamb opened a new issue #428: URL: https://github.com/apache/arrow-rs/issues/428 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** in order to support order by and partition by within window functions in DataFusion, we'll need to

[GitHub] [arrow-rs] alamb commented on pull request #424: add lexicographically partition points and ranges

2021-06-08 Thread GitBox
alamb commented on pull request #424: URL: https://github.com/apache/arrow-rs/pull/424#issuecomment-857145786 I filed https://github.com/apache/arrow-rs/issues/428 to track this. Thanks @Jimexist -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow-rs] alamb opened a new pull request #429: Cherry pick add more tests for window::shift and handle boundary cases to active_release

2021-06-08 Thread GitBox
alamb opened a new pull request #429: URL: https://github.com/apache/arrow-rs/pull/429 Automatic cherry-pick of 45acc62 * Originally appeared in https://github.com/apache/arrow-rs/pull/386: add more tests for window::shift and handle boundary cases -- This is an automated message

[GitHub] [arrow-rs] alamb commented on pull request #386: add more tests for window::shift and handle boundary cases

2021-06-08 Thread GitBox
alamb commented on pull request #386: URL: https://github.com/apache/arrow-rs/pull/386#issuecomment-857164336 Second chance back porting has worked https://github.com/apache/arrow-rs/pull/429  -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #436: Update release Readme.md

2021-06-08 Thread GitBox
codecov-commenter edited a comment on pull request #436: URL: https://github.com/apache/arrow-rs/pull/436#issuecomment-857192429 #

[GitHub] [arrow-rs] alamb commented on a change in pull request #384: Implement faster arrow array reader

2021-06-08 Thread GitBox
alamb commented on a change in pull request #384: URL: https://github.com/apache/arrow-rs/pull/384#discussion_r647819077 ## File path: parquet/src/util/mod.rs ## @@ -22,6 +22,4 @@ pub mod bit_util; mod bit_packing; pub mod cursor; pub mod hash_util; - -#[cfg(test)] Review

[GitHub] [arrow-datafusion] Dandandan commented on issue #525: Add Delta Lake TableProvider

2021-06-08 Thread GitBox
Dandandan commented on issue #525: URL: https://github.com/apache/arrow-datafusion/issues/525#issuecomment-856943253 > fwiw, imo this should be discussed over the mailing list. I agree, if we have some positive reactions I will send something over the mailing list. -- This is an

[GitHub] [arrow-rs] alamb commented on pull request #420: Sort by float lists

2021-06-08 Thread GitBox
alamb commented on pull request #420: URL: https://github.com/apache/arrow-rs/pull/420#issuecomment-857135763 Thank you for the contribution @medwards  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-rs] alamb commented on pull request #382: make sure that only concat preallocates buffers

2021-06-08 Thread GitBox
alamb commented on pull request #382: URL: https://github.com/apache/arrow-rs/pull/382#issuecomment-857137179 @jorgecarleitao what is the status of this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow-rs] alamb merged pull request #423: refactor lexico sort for future code reuse

2021-06-08 Thread GitBox
alamb merged pull request #423: URL: https://github.com/apache/arrow-rs/pull/423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow-rs] alamb opened a new pull request #430: Cherry pick Respect max rowgroup size in Arrow writer to active_release

2021-06-08 Thread GitBox
alamb opened a new pull request #430: URL: https://github.com/apache/arrow-rs/pull/430 Automatic cherry-pick of 7ec3158 * Originally appeared in https://github.com/apache/arrow-rs/pull/381: Respect max rowgroup size in Arrow writer -- This is an automated message from the Apache

[GitHub] [arrow-rs] alamb commented on pull request #381: Respect max rowgroup size in Arrow writer

2021-06-08 Thread GitBox
alamb commented on pull request #381: URL: https://github.com/apache/arrow-rs/pull/381#issuecomment-857167215 Back ported in https://github.com/apache/arrow-rs/pull/430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow-rs] codecov-commenter commented on pull request #434: Cherry pick Fix bug with null buffer offset in boolean not kernel to active_release

2021-06-08 Thread GitBox
codecov-commenter commented on pull request #434: URL: https://github.com/apache/arrow-rs/pull/434#issuecomment-857190636 #

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #433: Cherry pick Derive Eq and PartialEq for SortOptions to active_release

2021-06-08 Thread GitBox
codecov-commenter edited a comment on pull request #433: URL: https://github.com/apache/arrow-rs/pull/433#issuecomment-857189194 #

[GitHub] [arrow] ianmcook commented on a change in pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
ianmcook commented on a change in pull request #10476: URL: https://github.com/apache/arrow/pull/10476#discussion_r647630733 ## File path: r/tests/testthat/test-compute-aggregate.R ## @@ -383,33 +383,30 @@ test_that("value_counts", { }) test_that("any.Array and

[GitHub] [arrow-rs] tustvold opened a new pull request #425: Derive Eq and PartialEq for SortOptions

2021-06-08 Thread GitBox
tustvold opened a new pull request #425: URL: https://github.com/apache/arrow-rs/pull/425 Being able to compare SortOptions settings is very useful, especially when writing tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow-datafusion] Dandandan edited a comment on issue #525: Add Delta Lake TableProvider

2021-06-08 Thread GitBox
Dandandan edited a comment on issue #525: URL: https://github.com/apache/arrow-datafusion/issues/525#issuecomment-856936027 FYI @houqp what do you think of integrating this into DataFusion? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] jeroen commented on pull request #10414: [C++]: C++17 test PR

2021-06-08 Thread GitBox
jeroen commented on pull request #10414: URL: https://github.com/apache/arrow/pull/10414#issuecomment-856938274 CRAN targets MacOS 10.13 (xcode10.1). Did anyone test if this version of xcode supports C++17? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow-rs] alamb opened a new issue #426: Derive Eq and PartialEq for SortOptions

2021-06-08 Thread GitBox
alamb opened a new issue #426: URL: https://github.com/apache/arrow-rs/issues/426 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Being able to compare SortOptions settings is very useful, especially when writing tests

[GitHub] [arrow-rs] alamb commented on pull request #425: Derive Eq and PartialEq for SortOptions

2021-06-08 Thread GitBox
alamb commented on pull request #425: URL: https://github.com/apache/arrow-rs/pull/425#issuecomment-856954147 I filed this issue: https://github.com/apache/arrow-rs/issues/426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow-rs] alamb commented on pull request #419: Remove DictionaryArray::keys_array method

2021-06-08 Thread GitBox
alamb commented on pull request #419: URL: https://github.com/apache/arrow-rs/pull/419#issuecomment-857132369 @andygrove @Dandandan @jorgecarleitao @paddyhoran @tustvold @nevi-me any thoughts on this proposal? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow-rs] alamb commented on pull request #384: Implement faster arrow array reader

2021-06-08 Thread GitBox
alamb commented on pull request #384: URL: https://github.com/apache/arrow-rs/pull/384#issuecomment-857153406 FYI I plan to make a release candidate for Arrow 4.3 on Thursday or Friday this week and release early next week. So if we want to try and get this PR into 4.3 that is the

[GitHub] [arrow] ianmcook commented on a change in pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
ianmcook commented on a change in pull request #10476: URL: https://github.com/apache/arrow/pull/10476#discussion_r647632845 ## File path: r/tests/testthat/test-compute-aggregate.R ## @@ -383,33 +383,30 @@ test_that("value_counts", { }) test_that("any.Array and

[GitHub] [arrow] ianmcook commented on a change in pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
ianmcook commented on a change in pull request #10476: URL: https://github.com/apache/arrow/pull/10476#discussion_r647632845 ## File path: r/tests/testthat/test-compute-aggregate.R ## @@ -383,33 +383,30 @@ test_that("value_counts", { }) test_that("any.Array and

[GitHub] [arrow] nealrichardson commented on pull request #10414: [C++]: C++17 test PR

2021-06-08 Thread GitBox
nealrichardson commented on pull request #10414: URL: https://github.com/apache/arrow/pull/10414#issuecomment-856941324 hmm, fewer than I thought: ``` > table(grepl("C++17", tools::CRAN_package_db()$SystemRequirements, fixed = TRUE)) FALSE TRUE 17691 3 ```

[GitHub] [arrow-rs] codecov-commenter commented on pull request #425: Derive Eq and PartialEq for SortOptions

2021-06-08 Thread GitBox
codecov-commenter commented on pull request #425: URL: https://github.com/apache/arrow-rs/pull/425#issuecomment-856953848 #

[GitHub] [arrow-rs] alamb commented on pull request #421: Reenable MIRI check on PRs

2021-06-08 Thread GitBox
alamb commented on pull request #421: URL: https://github.com/apache/arrow-rs/pull/421#issuecomment-857128952 Second successful run: https://github.com/apache/arrow-rs/pull/421/checks?check_run_id=2766161179 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] github-actions[bot] commented on pull request #10487: ARROW-13010: [C++][Compute] Support outputting to slices from kleene kernels

2021-06-08 Thread GitBox
github-actions[bot] commented on pull request #10487: URL: https://github.com/apache/arrow/pull/10487#issuecomment-857361898 https://issues.apache.org/jira/browse/ARROW-13010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] kou commented on pull request #10478: ARROW-12991: [CI] Migrate Travis-CI ARM job to "arm64-graviton2" arch

2021-06-08 Thread GitBox
kou commented on pull request #10478: URL: https://github.com/apache/arrow/pull/10478#issuecomment-857286536 `virt` is also required. https://docs.travis-ci.com/user/multi-cpu-architectures/#testing-on-multiple-cpu-architectures > The arm64-graviton2 architecture builds can

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #501: Add `partition by` constructs in window functions and modify logical planning

2021-06-08 Thread GitBox
Jimexist commented on a change in pull request #501: URL: https://github.com/apache/arrow-datafusion/pull/501#discussion_r647894204 ## File path: datafusion/src/sql/planner.rs ## @@ -1121,52 +1121,53 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { // then,

[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #501: Add `partition by` constructs in window functions and modify logical planning

2021-06-08 Thread GitBox
codecov-commenter edited a comment on pull request #501: URL: https://github.com/apache/arrow-datafusion/pull/501#issuecomment-854535739 #

[GitHub] [arrow-datafusion] msathis commented on issue #488: Map `IN` to semi join

2021-06-08 Thread GitBox
msathis commented on issue #488: URL: https://github.com/apache/arrow-datafusion/issues/488#issuecomment-857393540 @Dandandan I would like to work on this ticket. Some pointers would be great, so i will be in the right direction.  -- This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #10486: ARROW-13016: [C++][Compute] Support Null type in Sum/Mean/MinMax aggregation

2021-06-08 Thread GitBox
github-actions[bot] commented on pull request #10486: URL: https://github.com/apache/arrow/pull/10486#issuecomment-857344568 https://issues.apache.org/jira/browse/ARROW-13016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] Crystrix opened a new pull request #10486: ARROW-13016: [C++][Compute] Support Null type in Sum/Mean/MinMax aggregation

2021-06-08 Thread GitBox
Crystrix opened a new pull request #10486: URL: https://github.com/apache/arrow/pull/10486 The Sum/Mean/MinMax of a Null type array is a Null type scalar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-rs] Jimexist opened a new issue #437: migrate partition kernel to use IntoIter trait

2021-06-08 Thread GitBox
Jimexist opened a new issue #437: URL: https://github.com/apache/arrow-rs/issues/437 It should be possible to write the below as an iterator, thereby avoiding the allocation of the vector. The general idea: create a struct with a method `try_new`. That method initializes the

[GitHub] [arrow-rs] Jimexist commented on a change in pull request #424: add lexicographically partition points and ranges

2021-06-08 Thread GitBox
Jimexist commented on a change in pull request #424: URL: https://github.com/apache/arrow-rs/pull/424#discussion_r647891165 ## File path: arrow/src/compute/kernels/partition.rs ## @@ -0,0 +1,314 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] frmnboi opened a new issue #10488: Passing back and forth from Python and C++ with Pyarrow C++ extension and pybind11.

2021-06-08 Thread GitBox
frmnboi opened a new issue #10488: URL: https://github.com/apache/arrow/issues/10488 I'm trying to write a C++ extension to add a new column to a table I have. I create the table with pyarrow in python, but I want to call a function in C++ to operate on the data, in-place if possible.

[GitHub] [arrow] nealrichardson commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

2021-06-08 Thread GitBox
nealrichardson commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r647851002 ## File path: r/R/util.R ## @@ -139,3 +139,42 @@ attr(is_writable_table, "fail") <- function(call, env){ ) } +#' Take an object of length 1

[GitHub] [arrow] rok commented on a change in pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
rok commented on a change in pull request #10476: URL: https://github.com/apache/arrow/pull/10476#discussion_r647881835 ## File path: r/tests/testthat/test-compute-aggregate.R ## @@ -383,33 +383,30 @@ test_that("value_counts", { }) test_that("any.Array and

[GitHub] [arrow] rok commented on pull request #10476: ARROW-12499: [C++][Compute] Add ScalarAggregateOptions to Any and All kernels

2021-06-08 Thread GitBox
rok commented on pull request #10476: URL: https://github.com/apache/arrow/pull/10476#issuecomment-857293373 @lidavidm - I've introduced some small changes to c++ to enable desired behaviour so perhaps re-review is in order. Changes are all in [this

  1   2   3   >