[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2021-02-19 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r579596186 ## File path: cpp/src/parquet/encryption/test_encryption_util.cc ## @@ -0,0 +1,481 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2021-02-19 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r579596103 ## File path: cpp/src/parquet/encryption/test_encryption_util.cc ## @@ -0,0 +1,481 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2021-02-19 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r579596080 ## File path: cpp/src/parquet/encryption/test_encryption_util.cc ## @@ -0,0 +1,481 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2021-02-19 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r579595188 ## File path: cpp/src/parquet/encryption/test_encryption_util.cc ## @@ -0,0 +1,481 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2021-02-19 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r579594227 ## File path: cpp/src/parquet/encryption/properties_driven_crypto_factory.h ## @@ -0,0 +1,210 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-02 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498709142 ## File path: cpp/src/parquet/encryption/remote_kms_client.cc ## @@ -0,0 +1,127 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-02 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498685819 ## File path: cpp/src/parquet/encryption/remote_kms_client.cc ## @@ -0,0 +1,127 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-02 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498676039 ## File path: cpp/src/parquet/encryption/test_encryption_util.h ## @@ -0,0 +1,152 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-01 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498334175 ## File path: cpp/src/parquet/encryption/remote_kms_client.cc ## @@ -0,0 +1,127 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-01 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498326446 ## File path: cpp/src/arrow/util/concurrent_map.h ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-01 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498154775 ## File path: cpp/src/parquet/encryption/properties_driven_crypto_factory.h ## @@ -0,0 +1,210 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-01 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498153010 ## File path: cpp/src/parquet/encryption/key_metadata.h ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-01 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498151648 ## File path: cpp/src/parquet/encryption/key_toolkit_internal.h ## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-01 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498147171 ## File path: cpp/src/parquet/encryption/kms_client.h ## @@ -0,0 +1,84 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-01 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498141296 ## File path: cpp/src/parquet/encryption/kms_client.h ## @@ -0,0 +1,84 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-01 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498102558 ## File path: cpp/src/parquet/encryption/properties_driven_crypto_factory.h ## @@ -0,0 +1,210 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-01 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498008512 ## File path: cpp/src/parquet/encryption/test_encryption_util.cc ## @@ -0,0 +1,481 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-10-01 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r498005234 ## File path: cpp/src/parquet/encryption/properties_driven_crypto_factory.h ## @@ -0,0 +1,210 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497999593 ## File path: cpp/src/parquet/encryption/key_metadata.h ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497997865 ## File path: cpp/src/arrow/util/concurrent_map.h ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497996333 ## File path: cpp/src/arrow/json/object_parser.h ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497994581 ## File path: cpp/src/parquet/encryption/file_key_unwrapper.h ## @@ -0,0 +1,66 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497982290 ## File path: cpp/src/parquet/encryption/file_key_unwrapper.h ## @@ -0,0 +1,66 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497981750 ## File path: cpp/src/parquet/encryption/file_key_unwrapper.h ## @@ -0,0 +1,66 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497981549 ## File path: cpp/src/parquet/encryption/file_key_wrapper.h ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497980986 ## File path: cpp/src/parquet/encryption/key_encryption_key.h ## @@ -0,0 +1,62 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497980844 ## File path: cpp/src/parquet/encryption/key_material.h ## @@ -0,0 +1,125 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497980169 ## File path: cpp/src/parquet/encryption/key_toolkit_internal.h ## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497978500 ## File path: cpp/src/parquet/encryption/kms_client.h ## @@ -0,0 +1,84 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497977436 ## File path: cpp/src/parquet/encryption/properties_driven_crypto_factory.h ## @@ -0,0 +1,210 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497974822 ## File path: cpp/src/parquet/encryption/properties_driven_crypto_factory.h ## @@ -0,0 +1,210 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497973635 ## File path: cpp/src/parquet/encryption/properties_driven_crypto_factory.h ## @@ -0,0 +1,210 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497973376 ## File path: cpp/src/parquet/encryption/remote_kms_client.cc ## @@ -0,0 +1,127 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497971996 ## File path: cpp/src/parquet/encryption/two_level_cache_with_expiration.h ## @@ -0,0 +1,167 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497971688 ## File path: cpp/src/parquet/encryption/two_level_cache_with_expiration.h ## @@ -0,0 +1,167 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497970716 ## File path: cpp/src/parquet/encryption/two_level_cache_with_expiration.h ## @@ -0,0 +1,167 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497970111 ## File path: cpp/src/parquet/encryption/two_level_cache_with_expiration.h ## @@ -0,0 +1,167 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-30 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r497969857 ## File path: cpp/src/parquet/encryption/two_level_cache_with_expiration_test.cc ## @@ -0,0 +1,207 @@ +// Licensed to the Apache Software Foundation

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486434226 ## File path: cpp/src/parquet/key_toolkit.h ## @@ -0,0 +1,123 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486434226 ## File path: cpp/src/parquet/key_toolkit.h ## @@ -0,0 +1,123 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486420973 ## File path: cpp/src/parquet/key_toolkit.h ## @@ -0,0 +1,123 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486400053 ## File path: cpp/src/parquet/key_toolkit.h ## @@ -0,0 +1,123 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486397802 ## File path: cpp/src/parquet/key_toolkit.h ## @@ -0,0 +1,123 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486382968 ## File path: cpp/src/parquet/key_material.h ## @@ -0,0 +1,120 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486382035 ## File path: cpp/src/parquet/file_key_wrapper.h ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486380916 ## File path: cpp/src/parquet/key_metadata.h ## @@ -0,0 +1,91 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486372095 ## File path: cpp/src/parquet/file_key_wrapper.h ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486371291 ## File path: cpp/src/parquet/kms_client_factory.h ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486370626 ## File path: cpp/src/parquet/kms_client_factory.h ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486370626 ## File path: cpp/src/parquet/kms_client_factory.h ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-10 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486367648 ## File path: cpp/src/parquet/key_toolkit.h ## @@ -0,0 +1,123 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-03 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r483013904 ## File path: cpp/src/parquet/file_key_wrapper.h ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-03 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r482995943 ## File path: cpp/src/parquet/key_toolkit.h ## @@ -0,0 +1,123 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-09-03 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r482993016 ## File path: cpp/src/parquet/file_key_wrapper.h ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-29 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r479634599 ## File path: cpp/src/parquet/key_material.cc ## @@ -0,0 +1,161 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-29 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r479633600 ## File path: cpp/src/parquet/key_toolkit.h ## @@ -0,0 +1,123 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-29 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r479633145 ## File path: cpp/src/parquet/kms_client.h ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-29 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r479632794 ## File path: cpp/src/parquet/key_material.cc ## @@ -0,0 +1,161 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-29 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r479632859 ## File path: cpp/src/parquet/key_metadata.h ## @@ -0,0 +1,91 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-29 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r479626558 ## File path: cpp/src/parquet/key_material.cc ## @@ -0,0 +1,161 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-29 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r479625144 ## File path: cpp/src/parquet/file_key_wrapper.h ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-29 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r479625018 ## File path: cpp/src/parquet/file_key_unwrapper.h ## @@ -0,0 +1,65 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-29 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r479624632 ## File path: cpp/src/parquet/file_key_unwrapper.h ## @@ -0,0 +1,65 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-29 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r479624053 ## File path: cpp/src/parquet/key_encryption_key.h ## @@ -0,0 +1,57 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-26 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r477067068 ## File path: cpp/src/parquet/encryption_internal.h ## @@ -45,6 +45,9 @@ constexpr int8_t kOffsetIndex = 7; /// Performs AES encryption operations with

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-24 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r475668043 ## File path: cpp/src/parquet/encryption.h ## @@ -47,15 +47,15 @@ using ColumnPathToEncryptionPropertiesMap = class PARQUET_EXPORT

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-24 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r475446337 ## File path: cpp/src/parquet/file_key_material_store.h ## @@ -0,0 +1,51 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-24 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r475442393 ## File path: cpp/src/parquet/kms_client_factory.h ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-24 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r475440024 ## File path: cpp/src/parquet/key_toolkit.h ## @@ -0,0 +1,123 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] thamht4190 commented on a change in pull request #8023: ARROW-9318: [C++] Parquet encryption key management

2020-08-24 Thread GitBox
thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r475368729 ## File path: cpp/src/parquet/encryption.h ## @@ -47,15 +47,15 @@ using ColumnPathToEncryptionPropertiesMap = class PARQUET_EXPORT